Hi Joe,
Sorry, I replied to this mailing list message but realised afterwards that
you're not a list subscriber ...
Regards,
Robert
On Thursday, 31 July 2014, 14:54, Robert Gibson wrote:
On Mon Jun 30 16:20:50 UTC 2014, Joe Darcy wrote:
> It was not immediately clear how javax.swing.tree.Tre
Should the @SuppressWarnings("serial") annotation be also removed?
Thanks,
Alexandr.
On 8/4/2014 4:00 PM, Sergey Bylokhov wrote:
Hello.
Please review a small fix for jdk9.
Bug: https://bugs.openjdk.java.net/browse/JDK-6521727
Webrev can be found at:
http://cr.openjdk.java.net/~serb/6521727/w
Hi, Alexander.
No, it covers some warnings inside inner classes.
On 05.08.2014 12:54, Alexander Scherbatiy wrote:
Should the @SuppressWarnings("serial") annotation be also removed?
Thanks,
Alexandr.
On 8/4/2014 4:00 PM, Sergey Bylokhov wrote:
Hello.
Please review a small fix for jdk9.
Bug:
On 8/5/2014 1:00 PM, Sergey Bylokhov wrote:
Hi, Alexander.
No, it covers some warnings inside inner classes.
Could the annotation be moved to the inner classes?
Thanks,
Alexandr.
On 05.08.2014 12:54, Alexander Scherbatiy wrote:
Should the @SuppressWarnings("serial") annotation be als
On 05.08.2014 13:06, Alexander Scherbatiy wrote:
On 8/5/2014 1:00 PM, Sergey Bylokhov wrote:
Hi, Alexander.
No, it covers some warnings inside inner classes.
Could the annotation be moved to the inner classes?
Yes, we can.
New version:
http://cr.openjdk.java.net/~serb/6521727/webrev.01
The fix looks good to me.
Thanks,
Alexandr.
On 8/5/2014 1:24 PM, Sergey Bylokhov wrote:
On 05.08.2014 13:06, Alexander Scherbatiy wrote:
On 8/5/2014 1:00 PM, Sergey Bylokhov wrote:
Hi, Alexander.
No, it covers some warnings inside inner classes.
Could the annotation be moved to the i
The fix still looks good for me.
Thanks,
Alexander.
On 08/05/2014 01:40 PM, Alexander Scherbatiy wrote:
The fix looks good to me.
Thanks,
Alexandr.
On 8/5/2014 1:24 PM, Sergey Bylokhov wrote:
On 05.08.2014 13:06, Alexander Scherbatiy wrote:
On 8/5/2014 1:00 PM, Sergey Bylokhov wrote:
Hello.
Please review a small fix for a warning from the another tool, which is
simpler to fix than to close.
Commented method was removed, since it was commented from the beginning,
when it was added in 1997.
Bug: https://bugs.openjdk.java.net/browse/JDK-6521706
Webrev can be found at: http://
Hi Sergey,
the fix looks fine for me.
Thanks,
Alexander.
On 08/05/2014 05:57 PM, Sergey Bylokhov wrote:
Hello.
Please review a small fix for a warning from the another tool, which
is simpler to fix than to close.
Commented method was removed, since it was commented from the
beginning, when