Re: [systemd-devel] [PATCH] Fix systemd crash (on assert) during shutdown/reboot in unprivileged container

2015-01-20 Thread Martin Pitt
Andrei Borzenkov [2015-01-16 19:32 +0300]: > If I as user do "systemctl stop /dev/pts" I expect it to > unmount /dev/pts not fake "dead" state. Well, not all such commands can be expected to do something useful. Stopping mounts which the system depends on is going to break it, so trying to "system

[systemd-devel] [PATCH v2] sysv-generator: Handle .sh suffixes when translating Provides:

2015-01-20 Thread Martin Pitt
Martin Pitt [2015-01-20 17:44 +0100]: > the recent fix for sysv-generator's Provides: handling [1] caused, or > rather uncovered, another bug which now creates symlinks to itself > "foo.service -> foo.service" for any /etc/init.d/foo.sh. > > The generator would output an error message like > >

Re: [systemd-devel] [PATCH] initial sysv-generator test suite

2015-01-20 Thread Martin Pitt
Martin Pitt [2015-01-20 16:19 +0100]: > Thus I think it's high time to write some integration tests for that. > The attached patch provides the necessary framework and an initial set > of tests; e. g. test_multiple_provides() covers Michael's recent > commit b7e71846. Zbigniew and Thomas generally

Re: [systemd-devel] networkd link file not setting MTU

2015-01-20 Thread Cameron Norman
On Tue, Jan 20, 2015 at 4:40 PM, Tom Gundersen wrote: > Hi Ian, > > Did you try to reboot? Note that .link files are applied by udev (so > usually during early boot). You can override their settings from > .network files in some cases (at least with current git you can). > Out of curiosity and fo

Re: [systemd-devel] networkd link file not setting MTU

2015-01-20 Thread Tom Gundersen
Hi Ian, Did you try to reboot? Note that .link files are applied by udev (so usually during early boot). You can override their settings from .network files in some cases (at least with current git you can). I was not able to reproduce here (with git). "journalctl -b -u systemd-udevd" may contain

[systemd-devel] networkd link file not setting MTU

2015-01-20 Thread Ian Pilcher
I am trying to use systemd-networkd on Fedora 21, and I haven't been able to get it to set the MTU of an interface correctly: [root@localhost network]# cat eth0.link [Match] MACAddress=52:54:00:d8:3d:3e [Link] MTUBytes=8996 [root@localhost network]# [root@localhost network]# cat eth0.network [Ma

Re: [systemd-devel] [PATCH] initial sysv-generator test suite

2015-01-20 Thread Thomas H.P. Andersen
On Tue, Jan 20, 2015 at 8:08 PM, Martin Pitt wrote: > Hey Jóhann, > > "Jóhann B. Guðmundsson" [2015-01-20 17:55 +]: >> We only provide backwards compatibility with initscript which are lsb >> compliance and I dont think . ending on a script confirms to >> that standard hence that test should

Re: [systemd-devel] [PATCH] initial sysv-generator test suite

2015-01-20 Thread Martin Pitt
Hey Dimitri, Dimitri John Ledkov [2015-01-20 18:23 +]: > With parallel test harness in automake (everyone should have it by > now) you can set custom "runner" of your test, based on extensions, > e.g. from automake manual: > > TESTS = foo.pl bar.py baz > TEST_EXTENSIONS = .pl .py > PL_LOG_COM

Re: [systemd-devel] [PATCH] initial sysv-generator test suite

2015-01-20 Thread Martin Pitt
Hey Jóhann, "Jóhann B. Guðmundsson" [2015-01-20 17:55 +]: > We only provide backwards compatibility with initscript which are lsb > compliance and I dont think . ending on a script confirms to > that standard hence that test should be unnecessary and that initscript be > fixed upstream as in

Re: [systemd-devel] [PATCH] initial sysv-generator test suite

2015-01-20 Thread Dimitri John Ledkov
On 20 January 2015 at 16:49, Martin Pitt wrote: > Zbigniew Jędrzejewski-Szmek [2015-01-20 16:48 +0100]: >> Maybe we could do this check in configure.ac/Makefile.am (add the test >> to the list conditinally)? > > Yes, that's a good idea. > >> We already test for python presence and extract the vers

Re: [systemd-devel] [PATCH] initial sysv-generator test suite

2015-01-20 Thread Jóhann B. Guðmundsson
On 01/20/2015 03:19 PM, Martin Pitt wrote: initial generic feedback We only provide backwards compatibility with initscript which are lsb compliance and I dont think . ending on a script confirms to that standard hence that test should be unnecessary and that initscript be fixed upstream a

[systemd-devel] [PATCH v2 8/9] sd-icmp6-nd: Add support for fetching the latest expired prefix

2015-01-20 Thread Patrik Flykt
Keep the expired prefix for the duration of the prefix expiration event and remove it afterwards. --- src/libsystemd-network/sd-icmp6-nd.c | 20 src/systemd/sd-icmp6-nd.h| 2 ++ 2 files changed, 22 insertions(+) diff --git a/src/libsystemd-network/sd-icmp6-nd.c

[systemd-devel] [PATCH v2 5/9] test-icmp6-rs: Add trivial test case for an MTU that is not present

2015-01-20 Thread Patrik Flykt
--- src/libsystemd-network/test-icmp6-rs.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/libsystemd-network/test-icmp6-rs.c b/src/libsystemd-network/test-icmp6-rs.c index be64d33..9d50c57 100644 --- a/src/libsystemd-network/test-icmp6-rs.c +++ b/src/libsyste

[systemd-devel] [PATCH v2 0/9] DHCPv6 address assignment

2015-01-20 Thread Patrik Flykt
Hi, Here is version 2 updated according to comments. The trivial debug printout removal being too trivial is no longer part of this set. NTP and DNS information I also left off, I think there might have been a few bugs so there should be some initial test cases done first. And the values

[systemd-devel] [PATCH v2 1/9] sd-dhcp6-lease: Revise address iteration functions

2015-01-20 Thread Patrik Flykt
Revise the address iteration functions so that one helper function resets the iterator to the start of the address list while the second one fetches addresses one by one. The test case is also updated. --- src/libsystemd-network/sd-dhcp6-lease.c| 26 - src/libsystemd-network/t

[systemd-devel] [PATCH v2 3/9] sd-icmp6-nd: Add link and prefix structures for ICMPv6

2015-01-20 Thread Patrik Flykt
Each ICMPv6 structure has an interface index and will therefore be associated with an IPv6 link containing a list of of prefixes. --- v2: Keep the check that 'len' is not equal to zero as the option header points to the next option that might not exist One struct CamelCapsed, the other merg

[systemd-devel] [PATCH v2 7/9] test-icmp6-nd: Add test cases for prefixes

2015-01-20 Thread Patrik Flykt
Add test cases that feeds an Router Advertisement to the ICMPv6 code and verify that the correct prefix lengths are returned given an IPv6 address. Enhance the prefix verification test by adding a shorter prefix and check that the intended prefix lengths are now updated. --- src/libsystemd-networ

[systemd-devel] [PATCH v2 2/9] sd-icmp6-nd: Update Router Advertisement handling

2015-01-20 Thread Patrik Flykt
As the IPv6 prefixes are needed, update the ICMPv6 Router Advertisement code to dynamically allocate a suitably sized buffer. Iterate through the ICMPv6 options one by one returning error if the option length is too big to fit the buffer. --- v2: Address iteration fixed accordign to comments in v1,

[systemd-devel] [PATCH v2 6/9] sd-icmp6-nd: Parse ICMPv6 prefix information

2015-01-20 Thread Patrik Flykt
Save each new onlink IPv6 prefix and attach an expiry timer to it. If the prefixes overlap, take the shorter prefix and write a debug message about the event. Once the prefix is resent in a Router Advertisement, update the timer. Add a new event for the expiring prefix. Add two helper functions, o

[systemd-devel] [PATCH v2 4/9] sd-icmp6-nd: Add helper function to get the IPv6 link MTU

2015-01-20 Thread Patrik Flykt
Update MTU according to the latest value received. --- src/libsystemd-network/sd-icmp6-nd.c | 27 +++ src/systemd/sd-icmp6-nd.h| 2 ++ 2 files changed, 29 insertions(+) diff --git a/src/libsystemd-network/sd-icmp6-nd.c b/src/libsystemd-network/sd-icmp6-nd.c i

[systemd-devel] [PATCH v2 9/9] networkd-dhcp6: Assign DHCPv6 addresses and prefix lengths

2015-01-20 Thread Patrik Flykt
Once IPv6 addresses have been acquired, assign these to the interface with the prefix lengths taken from the ICMPv6 Router Advertisement handling code. The preferred and valid IPv6 address lifetimes are handed to the kernel which will clean up them if not renewed in time. When a prefix announced v

Re: [systemd-devel] [PATCH] initial sysv-generator test suite

2015-01-20 Thread Martin Pitt
Zbigniew Jędrzejewski-Szmek [2015-01-20 16:48 +0100]: > Maybe we could do this check in configure.ac/Makefile.am (add the test > to the list conditinally)? Yes, that's a good idea. > We already test for python presence and extract the version, so we > shouldn't duplicate the tests here and have a

[systemd-devel] [PATCH] sysv-generator: Handle .sh suffixes when translating Provides:

2015-01-20 Thread Martin Pitt
Hey all, the recent fix for sysv-generator's Provides: handling [1] caused, or rather uncovered, another bug which now creates symlinks to itself "foo.service -> foo.service" for any /etc/init.d/foo.sh. The generator would output an error message like Failed to create unit file /foo.service: F

Re: [systemd-devel] [PATCH] initial sysv-generator test suite

2015-01-20 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jan 20, 2015 at 04:19:24PM +0100, Martin Pitt wrote: > Hello all, > > We've had numerous problems with the SysV generator in the past, and > we just recently introduced another regression: init.d scripts which > end in ".sh" are now totally broken. > > Thus I think it's high time to write

[systemd-devel] [PATCH] initial sysv-generator test suite

2015-01-20 Thread Martin Pitt
Hello all, We've had numerous problems with the SysV generator in the past, and we just recently introduced another regression: init.d scripts which end in ".sh" are now totally broken. Thus I think it's high time to write some integration tests for that. The attached patch provides the necessary

[systemd-devel] systemd-216 breaks combined ReadOnlyDirectories / ReadWriteDirectories

2015-01-20 Thread Reindl Harald
after upgrade to Fedora 21 with new systemd namespaces like below no longer works which breaks *all my systemd-units* why? ReadOnlyDirectories=/var/lib ReadWriteDirectories=/var/lib/mysql 150120 13:44:01 [ERROR] Can't start server : Bind on unix socket: Read-only file system 150120 13:44:01 [

Re: [systemd-devel] failing boot start jobs delay reboot

2015-01-20 Thread Felix Miata
Andrei Borzenkov composed on 2015-01-20 11:24 (UTC+0300): > Felix Miata wrote: >> When they occur during init they repeat during shutdown. Even when I >> let init complete and succeed to fix the typo or oversight, the init failure >> gets remembered and repeated at shutdown. > Yes, that

Re: [systemd-devel] [PATCH] networkd: fix a typo in networkd-wait-online-manager.

2015-01-20 Thread Daniel Mack
On 01/20/2015 12:56 PM, Rami Rosen wrote: > subscibe->subscribe Applied, thanks! > > --- > src/network/networkd-wait-online-manager.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/network/networkd-wait-online-manager.c > b/src/network/networkd-wait-online-manage

Re: [systemd-devel] failing boot start jobs delay reboot

2015-01-20 Thread Andrei Borzenkov
On Tue, Jan 20, 2015 at 7:03 AM, Felix Miata wrote: > Andrei Borzenkov composed on 2015-01-20 06:35 (UTC+0300): > >> Mon, 19 Jan 2015 17:59:41 -0500 Felix Miata composed: > >>> Has anything been done in more recent releases about this? I do a lot of >>> cloning, and sometimes produce typos on grub

[systemd-devel] [PATCH] networkd: fix a typo in networkd-wait-online-manager.

2015-01-20 Thread Rami Rosen
subscibe->subscribe --- src/network/networkd-wait-online-manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/network/networkd-wait-online-manager.c b/src/network/networkd-wait-online-manager.c index 3f2b966..6f392fe 100644 --- a/src/network/networkd-wait-online-mana