Re: [systemd-devel] [PATCH] initial sysv-generator test suite

2015-01-21 Thread Martin Pitt
Hey Simon, Simon McVittie [2015-01-21 14:31 +]: systemd currently has AM_INIT_AUTOMAKE([foreign 1.11 -Wall -Wno-portability silent-rules tar-pax no-dist-gzip dist-xz subdir-objects]) but Automake 1.11 and 1.12 use the old serial test harness by default. That doesn't understand the

Re: [systemd-devel] [PATCH] initial sysv-generator test suite

2015-01-21 Thread Dimitri John Ledkov
On 21 January 2015 at 14:31, Simon McVittie simon.mcvit...@collabora.co.uk wrote: On 20/01/15 20:33, Martin Pitt wrote: Dimitri John Ledkov [2015-01-20 18:23 +]: With parallel test harness in automake (everyone should have it by now) Yay, thanks for pointing this out! That makes the

Re: [systemd-devel] [PATCH] initial sysv-generator test suite

2015-01-21 Thread Simon McVittie
On 20/01/15 20:33, Martin Pitt wrote: Dimitri John Ledkov [2015-01-20 18:23 +]: With parallel test harness in automake (everyone should have it by now) Yay, thanks for pointing this out! That makes the whole thing indeed much friendlier. systemd currently has AM_INIT_AUTOMAKE([foreign

Re: [systemd-devel] [PATCH] initial sysv-generator test suite

2015-01-20 Thread Martin Pitt
Zbigniew Jędrzejewski-Szmek [2015-01-20 16:48 +0100]: Maybe we could do this check in configure.ac/Makefile.am (add the test to the list conditinally)? Yes, that's a good idea. We already test for python presence and extract the version, so we shouldn't duplicate the tests here and have an

Re: [systemd-devel] [PATCH] initial sysv-generator test suite

2015-01-20 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jan 20, 2015 at 04:19:24PM +0100, Martin Pitt wrote: Hello all, We've had numerous problems with the SysV generator in the past, and we just recently introduced another regression: init.d scripts which end in .sh are now totally broken. Thus I think it's high time to write some

[systemd-devel] [PATCH] initial sysv-generator test suite

2015-01-20 Thread Martin Pitt
Hello all, We've had numerous problems with the SysV generator in the past, and we just recently introduced another regression: init.d scripts which end in .sh are now totally broken. Thus I think it's high time to write some integration tests for that. The attached patch provides the necessary

Re: [systemd-devel] [PATCH] initial sysv-generator test suite

2015-01-20 Thread Dimitri John Ledkov
On 20 January 2015 at 16:49, Martin Pitt martin.p...@ubuntu.com wrote: Zbigniew Jędrzejewski-Szmek [2015-01-20 16:48 +0100]: Maybe we could do this check in configure.ac/Makefile.am (add the test to the list conditinally)? Yes, that's a good idea. We already test for python presence and

Re: [systemd-devel] [PATCH] initial sysv-generator test suite

2015-01-20 Thread Jóhann B. Guðmundsson
On 01/20/2015 03:19 PM, Martin Pitt wrote: initial generic feedback We only provide backwards compatibility with initscript which are lsb compliance and I dont think .something ending on a script confirms to that standard hence that test should be unnecessary and that initscript be fixed

Re: [systemd-devel] [PATCH] initial sysv-generator test suite

2015-01-20 Thread Thomas H.P. Andersen
On Tue, Jan 20, 2015 at 8:08 PM, Martin Pitt martin.p...@ubuntu.com wrote: Hey Jóhann, Jóhann B. Guðmundsson [2015-01-20 17:55 +]: We only provide backwards compatibility with initscript which are lsb compliance and I dont think .something ending on a script confirms to that standard

Re: [systemd-devel] [PATCH] initial sysv-generator test suite

2015-01-20 Thread Martin Pitt
Martin Pitt [2015-01-20 16:19 +0100]: Thus I think it's high time to write some integration tests for that. The attached patch provides the necessary framework and an initial set of tests; e. g. test_multiple_provides() covers Michael's recent commit b7e71846. Zbigniew and Thomas generally

Re: [systemd-devel] [PATCH] initial sysv-generator test suite

2015-01-20 Thread Martin Pitt
Hey Dimitri, Dimitri John Ledkov [2015-01-20 18:23 +]: With parallel test harness in automake (everyone should have it by now) you can set custom runner of your test, based on extensions, e.g. from automake manual: TESTS = foo.pl bar.py baz TEST_EXTENSIONS = .pl .py PL_LOG_COMPILER =

Re: [systemd-devel] [PATCH] initial sysv-generator test suite

2015-01-20 Thread Martin Pitt
Hey Jóhann, Jóhann B. Guðmundsson [2015-01-20 17:55 +]: We only provide backwards compatibility with initscript which are lsb compliance and I dont think .something ending on a script confirms to that standard hence that test should be unnecessary and that initscript be fixed upstream as