[systemd-devel] [PATCH 1/2] dhcp-network: add check for DHCP.chaddr

2014-06-19 Thread Michal Sekletar
Check that received DHCP packets actually include our MAC address in chaddr field. BPF interpreter has 32 bit wide registers but MAC address is 48 bits long so we have to do check in two steps. --- src/libsystemd-network/dhcp-internal.h| 3 ++- src/libsystemd-network/dhcp-network.c | 15 +

Re: [systemd-devel] [PATCH 1/2] dhcp-network: add check for DHCP.chaddr

2014-06-19 Thread Dan Williams
On Thu, 2014-06-19 at 18:59 +0200, Michal Sekletar wrote: > Check that received DHCP packets actually include our MAC address in > chaddr field. BPF interpreter has 32 bit wide registers but MAC address > is 48 bits long so we have to do check in two steps. And if the MAC address is not 48 bits (I

Re: [systemd-devel] [PATCH 1/2] dhcp-network: add check for DHCP.chaddr

2014-06-19 Thread Michal Sekletar
On Thu, Jun 19, 2014 at 12:02:39PM -0500, Dan Williams wrote: > On Thu, 2014-06-19 at 18:59 +0200, Michal Sekletar wrote: > > Check that received DHCP packets actually include our MAC address in > > chaddr field. BPF interpreter has 32 bit wide registers but MAC address > > is 48 bits long so we ha

Re: [systemd-devel] [PATCH 1/2] dhcp-network: add check for DHCP.chaddr

2014-06-24 Thread Michal Sekletar
On Thu, Jun 19, 2014 at 12:02:39PM -0500, Dan Williams wrote: > On Thu, 2014-06-19 at 18:59 +0200, Michal Sekletar wrote: > > Check that received DHCP packets actually include our MAC address in > > chaddr field. BPF interpreter has 32 bit wide registers but MAC address > > is 48 bits long so we ha

Re: [systemd-devel] [PATCH 1/2] dhcp-network: add check for DHCP.chaddr

2014-06-24 Thread Tom Gundersen
On Tue, Jun 24, 2014 at 12:58 PM, Michal Sekletar wrote: > On Thu, Jun 19, 2014 at 12:02:39PM -0500, Dan Williams wrote: >> On Thu, 2014-06-19 at 18:59 +0200, Michal Sekletar wrote: >> > Check that received DHCP packets actually include our MAC address in >> > chaddr field. BPF interpreter has 32

Re: [systemd-devel] [PATCH 1/2] dhcp-network: add check for DHCP.chaddr

2014-07-07 Thread Michal Sekletar
On Tue, Jun 24, 2014 at 03:54:54PM +0200, Tom Gundersen wrote: > On Tue, Jun 24, 2014 at 12:58 PM, Michal Sekletar wrote: > > On Thu, Jun 19, 2014 at 12:02:39PM -0500, Dan Williams wrote: > >> On Thu, 2014-06-19 at 18:59 +0200, Michal Sekletar wrote: > >> > Check that received DHCP packets actuall