Re: [systemd-devel] [PATCH] rules: Fix by-path of mmc RPMB partitions and don't blkid them

2015-03-12 Thread Kay Sievers
On Fri, Feb 13, 2015 at 10:35 AM, Martin Pitt wrote: > Kay Sievers [2015-02-13 10:12 +0100]: >> This looks awful. We should not litter generic rules with exotic niche >> use cases like this. It will end up in a mess. > > Fully agreed :/ It is a rather small whitelist for now, which should not cat

Re: [systemd-devel] [PATCH] rules: Fix by-path of mmc RPMB partitions and don't blkid them

2015-02-13 Thread Martin Pitt
Hey Kay, Kay Sievers [2015-02-13 10:47 +0100]: > Let's remove it. There was never a reason for by-path/ to cover all > exotic device types. disk/by-path/ is for slots, chassis, ports where > swappable disks can be connected and disconnected without the > identifier to change. I doubt that applies

Re: [systemd-devel] [PATCH] rules: Fix by-path of mmc RPMB partitions and don't blkid them

2015-02-13 Thread Kay Sievers
On Fri, Feb 13, 2015 at 10:35 AM, Martin Pitt wrote: > Kay Sievers [2015-02-13 10:12 +0100]: >> This looks awful. We should not litter generic rules with exotic niche >> use cases like this. It will end up in a mess. > > Fully agreed :/ > >> First, what is the use-case for by-path for mmc devices?

Re: [systemd-devel] [PATCH] rules: Fix by-path of mmc RPMB partitions and don't blkid them

2015-02-13 Thread Martin Pitt
Kay Sievers [2015-02-13 10:12 +0100]: > This looks awful. We should not litter generic rules with exotic niche > use cases like this. It will end up in a mess. Fully agreed :/ > First, what is the use-case for by-path for mmc devices? If there is > no strong one, which I suspect, please just remo

Re: [systemd-devel] [PATCH] rules: Fix by-path of mmc RPMB partitions and don't blkid them

2015-02-13 Thread Kay Sievers
On Fri, Feb 13, 2015 at 8:51 AM, Martin Pitt wrote: > Martin Pitt [2015-02-12 19:52 +0100]: >> Lennart Poettering [2015-02-12 18:50 +0100]: >> > > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=090d25fe224c0 >> > >> > Looks simple enough. This looks awful. We should not

Re: [systemd-devel] [PATCH] rules: Fix by-path of mmc RPMB partitions and don't blkid them

2015-02-12 Thread Martin Pitt
Martin Pitt [2015-02-12 19:52 +0100]: > Lennart Poettering [2015-02-12 18:50 +0100]: > > > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=090d25fe224c0 > > > > Looks simple enough. Though I wonder if [0-9] is the right match, > > shouldn't it also cover multiple numbers

Re: [systemd-devel] [PATCH] rules: Fix by-path of mmc RPMB partitions and don't blkid them

2015-02-12 Thread Martin Pitt
Lennart Poettering [2015-02-12 18:50 +0100]: > > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=090d25fe224c0 > > Looks simple enough. Though I wonder if [0-9] is the right match, > shouldn't it also cover multiple numbers there? Hm, yes. fnmatch() doesn't support a reg

Re: [systemd-devel] [PATCH] rules: Fix by-path of mmc RPMB partitions and don't blkid them

2015-02-12 Thread Lennart Poettering
On Thu, 12.02.15 18:11, Martin Pitt (martin.p...@ubuntu.com) wrote: > Linux 3.10+ exposes RPMB (Replay Protected Memory Block) partitions of MMC > devices [1] ; trying to read them with blkid or other unspecific means will > cause kernel buffer I/O errors and timeouts. So don't run blkid on these.

[systemd-devel] [PATCH] rules: Fix by-path of mmc RPMB partitions and don't blkid them

2015-02-12 Thread Martin Pitt
Linux 3.10+ exposes RPMB (Replay Protected Memory Block) partitions of MMC devices [1] ; trying to read them with blkid or other unspecific means will cause kernel buffer I/O errors and timeouts. So don't run blkid on these. Also ensure that /dev/disk/by-path creates proper symlinks and exposes th