Re: Fix: tcp_output window calculation error

2021-09-05 Thread Martin Pieuchot
On 22/07/21(Thu) 15:03, Jan Klemkow wrote: > Hi, > > This calculation of the receive window has a logic error: > > If win is 0 it will be overwritten by (rcv_adv - rcv_nxt). Thus, win > will be (rcv_adv - rcv_nxt) even if its below (sb_hiwat / 4). Why is this a problem? > We could just remove

Fix: tcp_output window calculation error

2021-07-22 Thread Jan Klemkow
Hi, This calculation of the receive window has a logic error: If win is 0 it will be overwritten by (rcv_adv - rcv_nxt). Thus, win will be (rcv_adv - rcv_nxt) even if its below (sb_hiwat / 4). We could just remove the dead (sb_hiwat / 4) code, or reorder the conditions to keep the original