Re: LibreSSL memory leak fix

2014-06-04 Thread Miod Vallat
> Hi All, > > >From OpenSSL RT: > http://rt.openssl.org/Ticket/Display.html?id=3278&user=guest&pass=guest > > len can be 0 as well, and in which case, memory isn't freed. Correct. If successful, data is actually a malloc(len + 1), thus if len == 0, we leak a \0 byte... > Patch from Frantisek B

LibreSSL memory leak fix

2014-06-04 Thread Loganaden Velvindron
Hi All, >From OpenSSL RT: http://rt.openssl.org/Ticket/Display.html?id=3278&user=guest&pass=guest len can be 0 as well, and in which case, memory isn't freed. Patch from Frantisek Boranek: Index: lib/libssl/src/crypto/pkcs12/p12_kiss.c =

Re: LibreSSL memory leak fix

2014-06-03 Thread Philip Guenther
On Tue, Jun 3, 2014 at 2:56 PM, deoxyt2 wrote: > I think that is: > > #include > > and not > > #include "cryptlib.h" > No. cryptlib.h isn't installed under /usr/include Philip Guenther

Re: LibreSSL memory leak fix

2014-06-03 Thread deoxyt2
I think that is: #include and not #include "cryptlib.h" --- bss_dgram.c-bk Tue Jun 3 13:11:18 2014 +++ bss_dgram.c Tue Jun 3 17:32:09 2014 @@ -61,7 +61,7 @@ #include #include #include -#include "cryptlib.h" +#include #include #include #include

Re: LibreSSL memory leak fix

2014-06-02 Thread Miod Vallat
ok. Note this codepath is not compiled under OpenBSD. > Index: src/lib/libssl/src/crypto/bio/bss_dgram.c > === > RCS file: /cvs/src/lib/libssl/src/crypto/bio/bss_dgram.c,v > retrieving revision 1.25 > diff -u -p -u -p -r1.25 bss_dgram

LibreSSL memory leak fix

2014-06-02 Thread Loganaden Velvindron
Hi All, >From Martin Brejcha: Index: src/lib/libssl/src/crypto/bio/bss_dgram.c === RCS file: /cvs/src/lib/libssl/src/crypto/bio/bss_dgram.c,v retrieving revision 1.25 diff -u -p -u -p -r1.25 bss_dgram.c --- src/lib/libssl/src/crypt