Re: chown: Remove SUPPORT_DOT ifdef - it's on by default for 22 years

2017-05-27 Thread Adam Wolk
On Sat, May 27, 2017 at 10:58:40PM +0100, Jason McIntyre wrote: > On Sat, May 27, 2017 at 11:45:43PM +0200, Adam Wolk wrote: > > Index: chown.8 > > === > > RCS file: /cvs/src/bin/chmod/chown.8,v > > retrieving revision 1.20 > > diff

Re: chown: Remove SUPPORT_DOT ifdef - it's on by default for 22 years

2017-05-27 Thread Jason McIntyre
On Sat, May 27, 2017 at 11:45:43PM +0200, Adam Wolk wrote: > Index: chown.8 > === > RCS file: /cvs/src/bin/chmod/chown.8,v > retrieving revision 1.20 > diff -u -p -r1.20 chown.8 > --- chown.8 31 Dec 2015 23:38:16 - 1.20 >

Re: chown: Remove SUPPORT_DOT ifdef - it's on by default for 22 years

2017-05-27 Thread Adam Wolk
On Sat, May 27, 2017 at 11:01:29PM +0200, Adam Wolk wrote: > On Sat, May 27, 2017 at 01:42:45PM -0600, Theo de Raadt wrote: > > I agree with you. Maybe change the comment > > > > /* UID and GID are separated by a dot and UID exists. */ > > > > to say a bit more on the matter, to

Re: chown: Remove SUPPORT_DOT ifdef - it's on by default for 22 years

2017-05-27 Thread Adam Wolk
On Sat, May 27, 2017 at 01:42:45PM -0600, Theo de Raadt wrote: > I agree with you. Maybe change the comment > > /* UID and GID are separated by a dot and UID exists. */ > > to say a bit more on the matter, to prevent a zealot from arriving 2-3 > years from now and proposing

Re: chown: Remove SUPPORT_DOT ifdef - it's on by default for 22 years

2017-05-27 Thread Theo de Raadt
I agree with you. Maybe change the comment /* UID and GID are separated by a dot and UID exists. */ to say a bit more on the matter, to prevent a zealot from arriving 2-3 years from now and proposing removal. Just a few words to hint . support will stay forever. It seems the

chown: Remove SUPPORT_DOT ifdef - it's on by default for 22 years

2017-05-27 Thread Adam Wolk
Hi tech@, I stumbled on SUPPORT_DOT while reading /usr/src/bin/chmod.c, got curious and started doing some research. POSIX changed the separator from . to : to make the utility properly work with usernames containing a dot. The standard doesn't forbid keeping the dot handling for backwards