Re: recent sysctl changes

2014-03-07 Thread Matt Thomas
On Mar 7, 2014, at 8:32 AM, Andreas Gustafsson wrote: > Thor Lancelot Simon wrote: >>> An application could, for example, maintain a single, shared, >>> malloc'ed buffer that is reused for multiple sysctl() calls and only >>> resized on ENOMEM returns. IMO, this is allowed by the API, but with

Re: recent sysctl changes

2014-03-07 Thread Andreas Gustafsson
Thor Lancelot Simon wrote: > > An application could, for example, maintain a single, shared, > > malloc'ed buffer that is reused for multiple sysctl() calls and only > > resized on ENOMEM returns. IMO, this is allowed by the API, but with > > your change, a read of a CTLTYPE_QUAD variable will ret

Re: recent sysctl changes

2014-03-07 Thread Thor Lancelot Simon
On Fri, Mar 07, 2014 at 10:49:54AM +0200, Andreas Gustafsson wrote: > > An application could, for example, maintain a single, shared, > malloc'ed buffer that is reused for multiple sysctl() calls and only > resized on ENOMEM returns. IMO, this is allowed by the API, but with > your change, a read

Re: recent sysctl changes

2014-03-07 Thread Andreas Gustafsson
David Laight wrote: > > Both of these aspects of the API are now broken: reading a 4-byte > > CTLTYPE_INT variable now works for any buffer size >= 4 *except* 8, > > That wasn't the intent of the change. > The intent was that if the size was 8 then the code would return > a numeric value of size 8

Re: Recent sysctl changes

2014-03-05 Thread Manuel Bouyer
On Thu, Mar 06, 2014 at 09:19:00AM +0200, Andreas Gustafsson wrote: > Thor Lancelot Simon wrote: > > I don't actually know of any code that hands over a "wrong-size" > > buffer and will therefore break, though. Do you? > > No, but I think we should aim for correctness, not just "works for me". S

Re: Recent sysctl changes

2014-03-05 Thread Andreas Gustafsson
Thor Lancelot Simon wrote: > I don't actually know of any code that hands over a "wrong-size" > buffer and will therefore break, though. Do you? No, but I think we should aim for correctness, not just "works for me". -- Andreas Gustafsson, g...@netbsd.org

Re: Recent sysctl changes

2014-03-05 Thread Paul Goyette
On Wed, 5 Mar 2014, Andreas Gustafsson wrote: I posted this on source-changes-d earlier today, but Jeff Rizzo asked me to take it to tech-kern. On Feb 27, David Laight said: Module Name: src Committed By: dsl Date: Thu Feb 27 22:50:52 UTC 2014 Modified Files: src/sys/kern: kern

Re: Recent sysctl changes

2014-03-05 Thread David Laight
On Wed, Mar 05, 2014 at 03:56:54PM -0500, Thor Lancelot Simon wrote: > On Wed, Mar 05, 2014 at 08:55:50PM +0200, Andreas Gustafsson wrote: > > > > 2. I also object to the change of kern_sysctl.c 1.247. > > > > This change attempts to work around the problems caused by the changes > > to the varia

Re: Recent sysctl changes

2014-03-05 Thread Thor Lancelot Simon
On Wed, Mar 05, 2014 at 08:55:50PM +0200, Andreas Gustafsson wrote: > > 2. I also object to the change of kern_sysctl.c 1.247. > > This change attempts to work around the problems caused by the changes > to the variable types by making sysctl() return different types > depending on the value of t

Recent sysctl changes

2014-03-05 Thread Andreas Gustafsson
I posted this on source-changes-d earlier today, but Jeff Rizzo asked me to take it to tech-kern. On Feb 27, David Laight said: > Module Name: src > Committed By: dsl > Date: Thu Feb 27 22:50:52 UTC 2014 > > Modified Files: > src/sys/kern: kern_sysctl.c > > Log Message: > Allow CT