Thanks to all who provided feedback. I plan to go with approach 3
for all the provider SPI additions. So there will be new interfaces
ReferenceBindingProvider2 and ServiceBindingProvider2 that extend
ReferenceBindingProvider and ServiceBindingProvider respectively,
and all the new methods that
I am reconsidering the changes made in stage 2 of this patch, which
added two new methods to the Binding SPI interface.
I made these changes for the reasons stated in
http://www.mail-archive.com/tuscany-dev@ws.apache.org/msg19305.html
and
On 7/2/07, Simon Nash [EMAIL PROTECTED] wrote:
I am reconsidering the changes made in stage 2 of this patch, which
added two new methods to the Binding SPI interface.
I made these changes for the reasons stated in
http://www.mail-archive.com/tuscany-dev@ws.apache.org/msg19305.html
and
I'd like to get some other views on this before I spend a lot of
time reworking this patch. Please see my comments inline below.
Simon
ant elder wrote:
On 7/2/07, Simon Nash [EMAIL PROTECTED] wrote:
I am reconsidering the changes made in stage 2 of this patch, which
added two new
On 7/2/07, Simon Nash [EMAIL PROTECTED] wrote:
snip
1. Not including the change to remove the redundant isCallback parameter
from ReferenceBindingProvider.createInvoker() doesn't cause any
significant problems in the core. The core can always pass the
meaningless extra parameter,
Folks,
I tend to favour this more conservative approach. There may be a
problem longer term in explaining the interfaces to writers of new
binding types and implementation types, but the mess caused to existing
implementation types and existing binding types by breaking changes in
the SPI
Hi,
I really like the approach mentioned under '3'. While the SPIs might
undergo changes sometime, this is probably too early, especially now that we
have promised for its stability from Release 0.90. Thats just about my
opinion. Thanks
- Venkat
On 7/2/07, Simon Nash [EMAIL PROTECTED]
Please review and apply the patch for TUSCANY-1341 which I have
attached to the JIRA in 7 parts as follows.
Stages 1, 2 and 3 contain new SPIs and bug fixes that are needed
to support callbacks across bindings. They do not have cross-
dependencies and can be applied in any order.
Stage 4
