On Wed, Jul 06, 2011 at 05:27:55PM -0400, Glyph Lefkowitz wrote:
> Looking at http://twistedmatrix.com/trac/ticket/3420 now, I see
> reviews with lots of functional issues and spec-compliance/correctness
> issues raised. There are a few notes on the API as well, but without
> addressing the re
On Jul 6, 2011, at 8:04 AM, Itamar Turner-Trauring wrote:
> On Wed, 2011-07-06 at 13:10 +0200, Johan Rydberg wrote:
>
>> I was mostly thinking about the persistent connection functionality
>> for twisted.web.client.Agent.
>
> We definitely want this to get in, this was a large part of the
> mot
On Wed, 2011-07-06 at 13:10 +0200, Johan Rydberg wrote:
> I was mostly thinking about the persistent connection functionality
> for twisted.web.client.Agent.
We definitely want this to get in, this was a large part of the
motivation for Agent in the first place.
> Maybe Twisted would benefit mor
On 7/5/11 10:36 PM, Glyph Lefkowitz wrote:
>
> Can you point to a specific ticket where you think this was the case? I have
> this same general feeling, but pretty much all of the reviews I found when I
> went looking for specific examples included at least some significant
> coding-standard, d
On Jul 5, 2011, at 1:36 AM, Johan Rydberg wrote:
> On 7/1/11 6:08 PM, Itamar Turner-Trauring wrote:
>> In order to have at least some anecdotal evidence --
> I've had some patched rejected, probably on sound basis. But the
> experience always leave you with a feeling that you got stabbed.
We're
On Tue, Jul 5, 2011 at 7:36 AM, Johan Rydberg wrote:
> On 7/1/11 6:08 PM, Itamar Turner-Trauring wrote:
> > In order to have at least some anecdotal evidence --
> I've had some patched rejected, probably on sound basis. But the
> experience always leave you with a feeling that you got stabbed.
>
On 7/1/11 6:08 PM, Itamar Turner-Trauring wrote:
> In order to have at least some anecdotal evidence --
I've had some patched rejected, probably on sound basis. But the
experience always leave you with a feeling that you got stabbed.
Sometimes it _is_ be better to get some basic functionality in
On Fri, Jul 1, 2011 at 6:01 PM, Jason J. W. Williams <
jasonjwwilli...@gmail.com> wrote:
> Because they don't always seem to track the ticket branch folders in a
> timely manner. Especially, when JP (he seems to usually be my reviewer :) )
> pushes a modification of my patch to the ticket branch.
On Sat, Jul 2, 2011 at 02:23, Tim Allen wrote:
> On Fri, Jul 01, 2011 at 09:11:34PM +0200, Laurens Van Houtven wrote:
>> Only if there's a decent Github mirror to fork from, otherwise you're asking
>> people to do a multi-hour operation (I know, because I'm doing it right now)
>> to get a decent g
On Jul 1, 2011, at 9:06 PM, exar...@twistedmatrix.com wrote:
> On 1 Jul, 11:27 pm, gl...@twistedmatrix.com wrote:
>>
>> On Jul 1, 2011, at 6:57 PM, David Ripton wrote:
>>> Working with patches because you don't have svn commit rights is
>>> annoying, but this annoyance is a relatively minor fix
On Fri, Jul 01, 2011 at 09:11:34PM +0200, Laurens Van Houtven wrote:
> On Fri, Jul 1, 2011 at 8:59 PM, Itamar Turner-Trauring
> wrote:
> > Or for that matter, you can include e.g. an github URL in the ticket
> > instead of attaching the patch.
>
> Only if there's a decent Github mirror to fork fro
On 1 Jul, 11:27 pm, gl...@twistedmatrix.com wrote:
>
>On Jul 1, 2011, at 6:57 PM, David Ripton wrote:
>>Working with patches because you don't have svn commit rights is
>>annoying, but this annoyance is a relatively minor fixed cost.
>
>It's still important for us to reduce this cost; even if it's
On Sat, Jul 2, 2011 at 1:27 AM, Glyph Lefkowitz wrote:
>
> When you do a review, try to be as thorough as possible. Don't *ever* do
> a review that says "update @since markers" or "2 blank lines between
> methods" and nothing else
>
With Github's edit-this-file-on-the-web feature, it will effecti
On Jul 1, 2011, at 6:57 PM, David Ripton wrote:
> Working with patches because you don't have svn commit rights is annoying,
> but this annoyance is a relatively minor fixed cost.
It's still important for us to reduce this cost; even if it's not the
bottleneck, we have to optimize first where
On 07/01/11 12:08, Itamar Turner-Trauring wrote:
> In order to have at least some anecdotal evidence --
>
> If you've submitted a patch to Twisted (or started a branch) and it never
> made it in, how did that happen? I imagine reasons might include a review
> request to write tests, redesign reques
On Fri, Jul 1, 2011 at 12:59 PM, Itamar Turner-Trauring wrote:
> > It would be far simpler to setup my DVCS to track JP's remote copy of my
> > ticket's branch...then simply pull from that remote...make my changes and
> > request he pull from me when he's ready to review. Automates the whole
> >
On Jul 1, 2011, at 2:06 PM, Tom Davis wrote:
> On Jul 1, 2011, at 1:41 PM, Glyph Lefkowitz wrote:
>
>>
>> On Jul 1, 2011, at 1:08 PM, chris wrote:
>>
>>> doing continuous development based on tools like
>>> svn and trac is really painful and it's really difficult to motivate
>>> yourself to
On Fri, Jul 1, 2011 at 8:59 PM, Itamar Turner-Trauring
wrote:
> > It would be far simpler to setup my DVCS to track JP's remote copy of my
> > ticket's branch...then simply pull from that remote...make my changes and
> > request he pull from me when he's ready to review. Automates the whole
> > pr
> It would be far simpler to setup my DVCS to track JP's remote copy of my
> ticket's branch...then simply pull from that remote...make my changes and
> request he pull from me when he's ready to review. Automates the whole
> process quite a bit and reduces the round trip yak shaving.
Any reason y
On Fri, Jul 1, 2011 at 12:41 PM, Glyph Lefkowitz wrote:
>
> On Jul 1, 2011, at 1:08 PM, chris wrote:
>
> doing continuous development based on tools like
> svn and trac is really painful and it's really difficult to motivate
> yourself to work on a once rejected ticket
>
>
> Can you be more specif
On Fri, Jul 1, 2011 at 11:08 AM, Itamar Turner-Trauring wrote:
> In order to have at least some anecdotal evidence --
>
> If you've submitted a patch to Twisted (or started a branch) and it never
> made it in, how did that happen? I imagine reasons might include a review
> request to write tests,
Sent via iPhone
Is your email Premiere?
On Jul 1, 2011, at 11:41, Glyph Lefkowitz wrote:
>
> Can you be more specific, please? What's painful?
Re-syncing whatever changes JP (just as an example of a reviewer) has made back
into your local repo from SVN...which due to SVN's weakness on bra
On Jul 1, 2011, at 1:41 PM, Glyph Lefkowitz wrote:
>
> On Jul 1, 2011, at 1:08 PM, chris wrote:
>
>> doing continuous development based on tools like
>> svn and trac is really painful and it's really difficult to motivate
>> yourself to work on a once rejected ticket
>
> Can you be more spec
On Jul 1, 2011, at 1:08 PM, chris wrote:
> doing continuous development based on tools like
> svn and trac is really painful and it's really difficult to motivate
> yourself to work on a once rejected ticket
Can you be more specific, please? What's painful?
Procedurally, it's almost the same
Hi all,
On 01.07.2011 18:36, Phil Mayers wrote:
> However, more constructively (less whiney!) some tickets languished in
> "make these tiny cleanups" and that's just incredibly painful in the
> current setup, with SVN and Trac mediating things.
>
> I've got absolutely no interest in pulling SVN he
On 01/07/11 17:08, Itamar Turner-Trauring wrote:
> In order to have at least some anecdotal evidence --
>
> If you've submitted a patch to Twisted (or started a branch) and it never
> made it in, how did that happen? I imagine reasons might include a review
> request to write tests, redesign reques
twisted.positioning never got in because I never finish anyth
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
27 matches
Mail list logo
