Hi!
> > > + case (USB_REQ_GET_DESCRIPTOR << 8) | USB_DIR_IN | USB_TYPE_CLASS:
> > > + {
> > > + __u32 temp = 0x0001;
> >
> > temp is never writtenn to. Can you just write 1 instead of it?
>
> I added a comment. This is the root port config, so it should be tweakable
> in case there i
On Friday, September 26, 2014 at 05:01:22 PM, Dinh Nguyen wrote:
[...]
> >>> +#define DWC2_GUSBCFG_TX_END_DELAY(1 << 28)
> >>> +#define DWC2_GUSBCFG_TX_END_DELAY_OFFSET 28
> >>
> >> bits 29 and 30 of GUSBCFG are to Force Host and Device mode,
> >> respectively. Thes
On 09/26/2014 02:29 AM, Marek Vasut wrote:
> On Tuesday, September 23, 2014 at 11:59:28 PM, Dinh Nguyen wrote:
>
>
> btw. please try to trim down the content of the patch when replying only to
> the
> relevant part, so others don't have to look up the relevant bits among
> billions
> of lines
On Tuesday, September 23, 2014 at 11:59:28 PM, Dinh Nguyen wrote:
[...]
> > +static int wait_for_bit(void *reg, const uint32_t mask, bool set)
> > +{
> > + unsigned int timeout = 100;
> > + uint32_t val;
> > +
> > + while (--timeout) {
> > + val = readl(reg);
> > + i
On Wednesday, September 24, 2014 at 05:37:16 PM, Stephen Warren wrote:
> On 09/23/2014 09:31 PM, Stephen Warren wrote:
> > On 09/21/2014 07:13 AM, Marek Vasut wrote:
> >> From: Oleksandr Tymoshenko
> >>
> >> This is the USB host controller used on the Altera SoCFPGA and Raspbery
> >> Pi.
> >>
>
On 09/23/2014 09:31 PM, Stephen Warren wrote:
On 09/21/2014 07:13 AM, Marek Vasut wrote:
From: Oleksandr Tymoshenko
This is the USB host controller used on the Altera SoCFPGA and Raspbery Pi.
This code has three checkpatch warnings, but to make sure it stays at least
readable and clear, these
On Wednesday, September 24, 2014 at 05:31:26 AM, Stephen Warren wrote:
> On 09/21/2014 07:13 AM, Marek Vasut wrote:
> > From: Oleksandr Tymoshenko
> >
> > This is the USB host controller used on the Altera SoCFPGA and Raspbery
> > Pi.
> >
> > This code has three checkpatch warnings, but to make
On 09/21/2014 07:13 AM, Marek Vasut wrote:
> From: Oleksandr Tymoshenko
>
> This is the USB host controller used on the Altera SoCFPGA and Raspbery Pi.
>
> This code has three checkpatch warnings, but to make sure it stays at least
> readable and clear, these are not fixed. These bugs are in the
On Sun, 21 Sep 2014, Marek Vasut wrote:
> From: Oleksandr Tymoshenko
>
> This is the USB host controller used on the Altera SoCFPGA and Raspbery Pi.
>
> This code has three checkpatch warnings, but to make sure it stays at least
> readable and clear, these are not fixed. These bugs are in the U
On Monday, September 22, 2014 at 11:40:36 AM, Pavel Machek wrote:
[...]
> > index c4f5157..c9d2ed5 100644
> > --- a/drivers/usb/host/Makefile
> > +++ b/drivers/usb/host/Makefile
> > @@ -45,3 +45,6 @@ obj-$(CONFIG_USB_EHCI_ZYNQ) += ehci-zynq.o
> >
> > obj-$(CONFIG_USB_XHCI) += xhci.o xhci-mem.o
Hi!
> This is the USB host controller used on the Altera SoCFPGA and Raspbery Pi.
>
> This code has three checkpatch warnings, but to make sure it stays at least
> readable and clear, these are not fixed. These bugs are in the USB request
> handling combinatorial logic, so any abstracting of thos
From: Oleksandr Tymoshenko
This is the USB host controller used on the Altera SoCFPGA and Raspbery Pi.
This code has three checkpatch warnings, but to make sure it stays at least
readable and clear, these are not fixed. These bugs are in the USB request
handling combinatorial logic, so any abstr
12 matches
Mail list logo