Re: [U-Boot] [PATCH 3/5] arm: tegra30: video: integrate display driver for t30

2015-08-26 Thread Simon Glass
Hi Thierry, On 26 August 2015 at 00:29, Thierry Reding wrote: > On Tue, Aug 25, 2015 at 10:03:13AM -0600, Simon Glass wrote: >> On 25 August 2015 at 05:02, Thierry Reding wrote: >> > On Mon, Aug 24, 2015 at 10:58:48AM -0600, Simon Glass wrote: >> >> On 24 August 2015 at 04:12, Thierry Reding wr

Re: [U-Boot] [PATCH 3/5] arm: tegra30: video: integrate display driver for t30

2015-08-26 Thread Simon Glass
Hi, On 26 August 2015 at 00:39, Thierry Reding wrote: > On Mon, Aug 24, 2015 at 10:03:35PM +, Marcel Ziswiler wrote: >> On 21 Aug 2015 11:29, Thierry Reding wrote: >> > Perhaps a good idea would be to simply copy what we have in the kernel >> > and see where (if at all) U-Boot breaks down an

Re: [U-Boot] [PATCH 3/5] arm: tegra30: video: integrate display driver for t30

2015-08-26 Thread Thierry Reding
On Mon, Aug 24, 2015 at 10:03:35PM +, Marcel Ziswiler wrote: > On 21 Aug 2015 11:29, Thierry Reding wrote: > > Perhaps a good idea would be to simply copy what we have in the kernel > > and see where (if at all) U-Boot breaks down and fix it to work properly > > with "upstream" DTBs. > > I ca

Re: [U-Boot] [PATCH 3/5] arm: tegra30: video: integrate display driver for t30

2015-08-26 Thread Thierry Reding
On Tue, Aug 25, 2015 at 10:03:13AM -0600, Simon Glass wrote: > On 25 August 2015 at 05:02, Thierry Reding wrote: > > On Mon, Aug 24, 2015 at 10:58:48AM -0600, Simon Glass wrote: > >> On 24 August 2015 at 04:12, Thierry Reding wrote: [...] > >> > SOR is an even worse abstraction because it's compl

Re: [U-Boot] [PATCH 3/5] arm: tegra30: video: integrate display driver for t30

2015-08-25 Thread Simon Glass
Hi Thierry, On 25 August 2015 at 05:02, Thierry Reding wrote: > On Mon, Aug 24, 2015 at 10:58:48AM -0600, Simon Glass wrote: >> +Nikita >> >> Hi Thierry, >> >> On 24 August 2015 at 04:12, Thierry Reding wrote: >> > On Fri, Aug 21, 2015 at 06:37:37PM -0600, Simon Glass wrote: >> > [...] >> >> I h

Re: [U-Boot] [PATCH 3/5] arm: tegra30: video: integrate display driver for t30

2015-08-25 Thread Thierry Reding
On Mon, Aug 24, 2015 at 10:58:48AM -0600, Simon Glass wrote: > +Nikita > > Hi Thierry, > > On 24 August 2015 at 04:12, Thierry Reding wrote: > > On Fri, Aug 21, 2015 at 06:37:37PM -0600, Simon Glass wrote: > > [...] > >> I have serious doubts about the wisdom of requiring a contributor to > >> c

Re: [U-Boot] [PATCH 3/5] arm: tegra30: video: integrate display driver for t30

2015-08-24 Thread Marcel Ziswiler
On 22 Aug 2015 02:38, Simon Glass wrote: > Please take a look at tegra124's display driver for an > example. You mean that second copy of the existing Tegra stuff I find myself now certainly in the middle of having to clean up? Thank you! ___ U-Boot m

Re: [U-Boot] [PATCH 3/5] arm: tegra30: video: integrate display driver for t30

2015-08-24 Thread Marcel Ziswiler
On 21 Aug 2015 11:29, Thierry Reding wrote: > I agree with Stephen that U-Boot should use an exact copy of the DTS > files in the kernel. The bits in the kernel get much more review and > have been known to work well for a number of years. I do not oppose however I doubt this has ever been the c

Re: [U-Boot] [PATCH 3/5] arm: tegra30: video: integrate display driver for t30

2015-08-24 Thread Simon Glass
+Nikita Hi Thierry, On 24 August 2015 at 04:12, Thierry Reding wrote: > On Fri, Aug 21, 2015 at 06:37:37PM -0600, Simon Glass wrote: > [...] >> I have serious doubts about the wisdom of requiring a contributor to >> completely re-architect the existing display system in U-Boot. It's a >> big job

Re: [U-Boot] [PATCH 3/5] arm: tegra30: video: integrate display driver for t30

2015-08-24 Thread Thierry Reding
On Fri, Aug 21, 2015 at 06:37:37PM -0600, Simon Glass wrote: [...] > I have serious doubts about the wisdom of requiring a contributor to > completely re-architect the existing display system in U-Boot. It's a > big job. Perhaps we can settle for following along the same lines and > not making thin

Re: [U-Boot] [PATCH 3/5] arm: tegra30: video: integrate display driver for t30

2015-08-21 Thread Simon Glass
Hi, On 21 August 2015 at 03:27, Thierry Reding wrote: > On Thu, Aug 20, 2015 at 11:46:41PM +, Marcel Ziswiler wrote: >> On 20 Aug 2015 22:09, Stephen Warren wrote: >> >> > Hopefully the process was to copy the Linux Tegra30 DT verbatim? >> >> No, the T20 one is far from verbatim neither. So

Re: [U-Boot] [PATCH 3/5] arm: tegra30: video: integrate display driver for t30

2015-08-21 Thread Thierry Reding
On Thu, Aug 20, 2015 at 11:46:41PM +, Marcel Ziswiler wrote: > On 20 Aug 2015 22:09, Stephen Warren wrote: > > > Hopefully the process was to copy the Linux Tegra30 DT verbatim? > > No, the T20 one is far from verbatim neither. So I just did the > adjustments analogous by comparing the T20 a

Re: [U-Boot] [PATCH 3/5] arm: tegra30: video: integrate display driver for t30

2015-08-20 Thread Marcel Ziswiler
On 20 Aug 2015 22:09, Stephen Warren wrote: > Hopefully the process was to copy the Linux Tegra30 DT verbatim? No, the T20 one is far from verbatim neither. So I just did the adjustments analogous by comparing the T20 and T30 Linux DTs. > That's > far more likely to yield a correct DT than cop

Re: [U-Boot] [PATCH 3/5] arm: tegra30: video: integrate display driver for t30

2015-08-20 Thread Stephen Warren
On 08/20/2015 05:29 AM, Marcel Ziswiler wrote: On popular request make the display driver from T20 work on T30 as well. Turned out to be quite straight forward. However a few notes about some things encountered during porting: Of course the T30 device tree was completely missing host1x as well as

[U-Boot] [PATCH 3/5] arm: tegra30: video: integrate display driver for t30

2015-08-20 Thread Marcel Ziswiler
On popular request make the display driver from T20 work on T30 as well. Turned out to be quite straight forward. However a few notes about some things encountered during porting: Of course the T30 device tree was completely missing host1x as well as PWM support but it turns out this can simply be