Re: [U-Boot] [net/eth.c:64]: (error) Uninitialized variable: skip_state

2014-11-06 Thread Tom Rini
On Thu, Nov 06, 2014 at 07:12:55PM +0100, Wolfgang Denk wrote: > Dear Tom Rini, > > In message <20141106164628.GR24724@bill-the-cat> you wrote: > > > > > [net/eth.c:64]: (error) Uninitialized variable: skip_state > > > > Dense code, like cmd_ini.c my cppcheck is OK and looking at the code > > ma

Re: [U-Boot] [net/eth.c:64]: (error) Uninitialized variable: skip_state

2014-11-06 Thread Wolfgang Denk
Dear Tom Rini, In message <20141106164628.GR24724@bill-the-cat> you wrote: > > > [net/eth.c:64]: (error) Uninitialized variable: skip_state > > Dense code, like cmd_ini.c my cppcheck is OK and looking at the code > manually I think it's fine too: > return ((skip_state = getenv(enetvar))

Re: [U-Boot] [net/eth.c:64]: (error) Uninitialized variable: skip_state

2014-11-06 Thread Tom Rini
On Thu, Nov 06, 2014 at 01:37:23PM +0100, Wolfgang Denk wrote: > Hello, > > cppcheck reports: > > [net/eth.c:64]: (error) Uninitialized variable: skip_state > > can you please have a look? Thanks! Dense code, like cmd_ini.c my cppcheck is OK and looking at the code manually I think it's fine

[U-Boot] [net/eth.c:64]: (error) Uninitialized variable: skip_state

2014-11-06 Thread Wolfgang Denk
Hello, cppcheck reports: [net/eth.c:64]: (error) Uninitialized variable: skip_state can you please have a look? Thanks! Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany