[U-Boot] weak functions versus conditional compile

2008-11-17 Thread Graeme Russ
I have a quick question I would like the groups opinion on: What is the rule-of-thumb for defining a function as weak versus using conditional compilation (or #defines)? For example, I am doing some work on cleaning up the structure and design of the i386 / sc520 code. Specifically, some function

Re: [U-Boot] weak functions versus conditional compile

2008-11-17 Thread Mike Frysinger
On Monday 17 November 2008 16:17:54 Graeme Russ wrote: > I have a quick question I would like the groups opinion on: > > What is the rule-of-thumb for defining a function as weak versus using > conditional compilation (or #defines)? > > For example, I am doing some work on cleaning up the structure

Re: [U-Boot] weak functions versus conditional compile

2008-11-19 Thread Haavard Skinnemoen
Mike Frysinger <[EMAIL PROTECTED]> wrote: > On Monday 17 November 2008 16:17:54 Graeme Russ wrote: > > Should I declare these functions as weak in the core i386 code and use a > > config #define to override or should I seperate the functions out into > > seperate source files and use conditional co

Re: [U-Boot] weak functions versus conditional compile

2008-11-19 Thread Joakim Tjernlund
On Wed, 2008-11-19 at 14:54 +0100, Haavard Skinnemoen wrote: > Mike Frysinger <[EMAIL PROTECTED]> wrote: > > On Monday 17 November 2008 16:17:54 Graeme Russ wrote: > > > Should I declare these functions as weak in the core i386 code and use a > > > config #define to override or should I seperate th