[Bug 913336] Re: grub-common recreates /etc/grub/grubenv

2012-01-07 Thread Richard Laager
** Patch added: "grubenv.diff" https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/913336/+attachment/2662333/+files/grubenv.diff ** Description changed: /etc/init.d/grub-common and /etc/pm/sleep.d/10_grub-common call grub- editenv to clear the recordfail setting to indicate that the sys

[Bug 913336] Re: grub-common recreates /etc/grub/grubenv

2012-01-08 Thread Ubuntu Foundation's Bug Bot
The attachment "grubenv.diff" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from t

[Bug 913336] Re: grub-common recreates /etc/grub/grubenv

2012-01-08 Thread Launchpad Bug Tracker
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: grub2 (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/913336 Title: grub-

[Bug 913336] Re: grub-common recreates /etc/grub/grubenv

2012-01-09 Thread Richard Laager
This patch is not sufficient, as grub-install calls grub-editenv /boot/grub/grubenv create unconditionally. I've attached another patch which stops grub-install from creating grubenv when /boot/grub is on ZFS. If we care about the possible use case of an admin who doesn't want grubenv, further wor

[Bug 913336] Re: grub-common recreates /etc/grub/grubenv

2012-01-10 Thread Richard Laager
Jordan_U in #grub suggested that GRUB should just not fail on boot when grubenv is read-only. That would sidestep the need for these changes. I'll pursue that option a bit. Ignore the patches for now. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscrib

[Bug 913336] Re: grub-common recreates /etc/grub/grubenv

2013-09-11 Thread Launchpad Bug Tracker
** Branch linked: lp:~ubuntu-core-dev/ubuntu/saucy/grub2/saucy -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/913336 Title: grub-common recreates /etc/grub/grubenv To manage notifications about this

[Bug 913336] Re: grub-common recreates /etc/grub/grubenv

2013-09-11 Thread Colin Watson
Applied, thanks; apologies for the long delay. ** Changed in: grub2 (Ubuntu) Importance: Undecided => Medium ** Changed in: grub2 (Ubuntu) Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. h

[Bug 913336] Re: grub-common recreates /etc/grub/grubenv

2013-09-11 Thread Dmitriy "Simplehuman" Fedorov
After this update grub-pc failed to install -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/913336 Title: grub-common recreates /etc/grub/grubenv To manage notifications about this bug go to: https:/

[Bug 913336] Re: grub-common recreates /etc/grub/grubenv

2013-09-11 Thread Launchpad Bug Tracker
This bug was fixed in the package grub2 - 2.00-18ubuntu3 --- grub2 (2.00-18ubuntu3) saucy; urgency=low * Fix recordfail-disabling patch to take account of the GRUB_PREFIX variable no longer existing. -- Colin WatsonWed, 11 Sep 2013 17:41:22 +0100 ** Changed in: grub2 (Ubun

[Bug 913336] Re: grub-common recreates /etc/grub/grubenv

2013-02-11 Thread Richard Laager
Can I get a review on the most recent patch? It's been a year with no comment. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/913336 Title: grub-common recreates /etc/grub/grubenv To manage notifica

[Bug 913336] Re: grub-common recreates /etc/grub/grubenv

2012-01-17 Thread Richard Laager
My original description was wrong. This does not stop the boot. GRUB does timeout and continue. After more thought, I believe my two patches are the correct solution to this problem. If we were to simply suppress the error on boot, then an admin who wants the features provided by the grubenv file

[Bug 913336] Re: grub-common recreates /etc/grub/grubenv

2012-02-04 Thread Richard Laager
I've attached "zfs-ubuntu-disable-recordfail.patch". This supersedes my previous patches and takes a different approach. It disables the recordfail feature for filesystems to which GRUB cannot write (btrfs, zfs, etc.). The changes from this patch are on top of (and should be folded into) debian/p