Review: Approve
That is OK.
--
https://code.launchpad.net/~renatofilho/ubuntu-filemanager-app/snap-mir-libs/+merge/320882
Your team Ubuntu File Manager Developers is subscribed to branch
lp:ubuntu-filemanager-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to
Review: Approve
That is OK, thank you.
--
https://code.launchpad.net/~renatofilho/ubuntu-filemanager-app/snap-mir/+merge/316877
Your team Ubuntu File Manager Developers is subscribed to branch
lp:ubuntu-filemanager-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Carlos Jose Mazieri has proposed merging
lp:~carlos-mazieri/ubuntu-filemanager-app/fix-network-crash-1609051 into
lp:ubuntu-filemanager-app.
Commit message:
FIX the netwotk crash when Localtion::m_info is deleted in the main thread
Requested reviews:
Ubuntu File Manager Developers (ubuntu
Carlos Jose Mazieri has proposed merging
lp:~carlos-mazieri/ubuntu-filemanager-app/fix-network-crash-1609051 into
lp:ubuntu-filemanager-app.
Commit message:
It fixes a network crash bug #1609051 when Localtion::m_info is deleted in the
main thread.
Requested reviews:
Ubuntu File Manager
Renato,
The check in line 61 is necessary.
The 'parentItemInfo' keeps the information from the parent, which can be:
directory/share/host/workgroup.
When the 'mainItemInfo' is root like "smb://" there is no 'parentItemInfo', it
can be null.
Another reason it might be used in my regression
Renato,
Can you please test that proposal of that NetworkListWorker creating its own
instance of the parent item?
There is a proposal
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app//fix-network-crash-1609051
Also renamed "parent" to "parentItemInfo".
--
I would remove all the Qt metaprogramming as it is not necessary,
Only a small change in the NetworkListWorker as exposed above should solve the
problem, NetworkListWorker class can create its own instance by doing a copy.
--
Another and easy approach would be if the class NetworkListWorker receive again
a const DirItemInfo *parent, but sets m_parent as its own instance using the
operator '=', in this case it never gets deleted outside the worker thread.
Suppose the code changed:
Renato,
by temporary objects I mean a temporary DirItemInfo created in Location??
classes, example:
void Location::refreshInfo()
{
if (m_info)
{
DirItemInfo *item = newItemInfo(m_info->absoluteFilePath());
delete m_info;
m_info = item;
}
}
Would be changed
Review: Needs Information
OK, Let's have a review on it,
1. perhaps the slot onParentDestroyed() on location.h lines 94-96 is not being
used.
2. on line 38 from networklistworker.cpp we should check if m_parent != 0,
the default value for 'parent' is 0 on networklistworker.h
38:
Review: Needs Information
Does it crash on both phone and desktop or just phone?
--
https://code.launchpad.net/~renatofilho/ubuntu-filemanager-app/fix-network-crash/+merge/314870
Your team Ubuntu File Manager Developers is subscribed to branch
lp:ubuntu-filemanager-app.
--
Mailing list:
Review: Needs Information
Renato,
The bug description appears to say that it always crashes.
Can you confirm that it always crashes or it happens under some special
condition?
If it happens under special condition can you describe that scenario?
--
Review: Needs Information
Hello Renato,
I am sorry for my lack of knowledge about this,
Can you explain what is it for?
What does it improve the app?
Is it required for others/all core apps?
What is/does ubuntu-app-plataform plugin?
--
Review: Approve
I am OK with this. Thanks.
--
https://code.launchpad.net/~ken-vandine/ubuntu-filemanager-app/deb_content-hub_peer_registration/+merge/307223
Your team Ubuntu File Manager Developers is subscribed to branch
lp:ubuntu-filemanager-app.
--
Mailing list:
Hello Arto and Sam,
The "apt-get install libsmbclient-dev" used to fail on any armf kit, so it was
impossible to generate the click package in the qtcreator.
The build on device used to work because "apt-get install libsmbclient-dev" on
device used to work.
That is the reason why Alan Pope
Review: Needs Information
Hello Sam,
It is OK to me, just a question:
Have you tested building for armf on device and building for armf on
qtcreator using a sdk like click-ubuntu-sdk-13.10-armhf?
This build was done by Alan Pope and Stefano Verzegnassi to prevent a bug that
did not allow
Review: Approve
Nice, Thanks.
--
https://code.launchpad.net/~mzanetti/ubuntu-filemanager-app/share-files/+merge/299821
Your team Ubuntu File Manager Developers is subscribed to branch
lp:ubuntu-filemanager-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to
Review: Approve
The code looks OK to me. Thanks.
--
https://code.launchpad.net/~renatofilho/ubuntu-filemanager-app/import-contact/+merge/300087
Your team Ubuntu File Manager Developers is subscribed to branch
lp:ubuntu-filemanager-app.
--
Mailing list:
The proposal to merge
lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-02 into
lp:ubuntu-filemanager-app has been updated.
Status: Needs review => Approved
For more details, see:
The proposal to merge
lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 into
lp:ubuntu-filemanager-app has been updated.
Status: Needs review => Approved
For more details, see:
I will fix that, thanks.
--
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-02/+merge/280388
Your team Ubuntu File Manager Developers is subscribed to branch
lp:ubuntu-filemanager-app.
--
Mailing list:
Carlos Jose Mazieri has proposed merging
lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-04 into
lp:ubuntu-filemanager-app with
lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-03 as a
prerequisite.
Commit message:
* Created new and generic classes
Carlos Jose Mazieri has proposed merging
lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 into
lp:ubuntu-filemanager-app.
Commit message:
Improved DirItemInfo and descendant classes:
* added DirItemInfo::setFile(const QString& newUrl) to change the current Item
informa
Carlos Jose Mazieri has proposed merging
lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-02 into
lp:ubuntu-filemanager-app with
lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 as a
prerequisite.
Commit message:
LocationItemDirIterator descendants classes now
Carlos Jose Mazieri has proposed merging
lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-03 into
lp:ubuntu-filemanager-app with
lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-02 as a
prerequisite.
Commit message:
ust fixed a typo in some files
Hello,
if you copy a text using another app to the clipboard the filemanager
will recognize it as non file url and then understands the clipboard is
empty even it is not. Does it help?
--
You received this bug notification because you are a member of Ubuntu
File Manager Developers, which is
Hi Tony,
The new version will be available soon, when you get that, please test
it without your work around.
Thank you very much.
--
You received this bug notification because you are a member of Ubuntu
File Manager Developers, which is subscribed to Ubuntu File Manager App.
Matching
Carlos Jose Mazieri has proposed merging
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-hostname-bug into
lp:ubuntu-filemanager-app.
Commit message:
Fixed a bug #1508504 related to get the Samba hostname.
It used to get the description instead of the name.
For some cases the name is the first
Carlos Jose Mazieri has proposed merging
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-09 into
lp:ubuntu-filemanager-app.
Commit message:
Removed unnecessary variable pathExists from DiskLocation::isThereDiskSpace()
Improved log for authenticateCallBacks.
Requested reviews
** Changed in: ubuntu-filemanager-app
Status: New => In Progress
** Changed in: ubuntu-filemanager-app
Importance: Undecided => Medium
--
You received this bug notification because you are a member of Ubuntu
File Manager Developers, which is subscribed to Ubuntu File Manager App.
Tony,
I will work next weekend to fix the problem related to the "name" of the
servers.
Regarding to private folders, it should show all folders if you "unlock
full access", then when you try to access private folders it should ask
for user/password, this behavior was a design decision.
Many
Hello Tony,
I am looking for "console ouput" not for screen shots. Are you able to
get it? (maybe using logcat)
Do you need password to access those servers content?
Thanks,
Carlos
--
You received this bug notification because you are a member of Ubuntu
File Manager Developers, which is
** Changed in: ubuntu-filemanager-app
Assignee: (unassigned) => Carlos Jose Mazieri (carlos-mazieri)
--
You received this bug notification because you are a member of Ubuntu
File Manager Developers, which is subscribed to Ubuntu File Manager App.
Matching subscriptions: File Manager
Hello,
Regarding to "Devices are listed by 'description'" it can be easily
fixed.
Regarding to it does not show the content of "nasbox", have you first
checked "unlock full access" option first?
if not, please try do it and try it again.
if so or if it does not work after doing it, can you
Public bug reported:
In order to open remote files, they are first downloaded into a
temporary file in "/tmp" directory.
They should be removed when the user closes the file in order to save
space.
** Affects: ubuntu-filemanager-app
Importance: Undecided
Status: New
--
You
Carlos Jose Mazieri has proposed merging
lp:~carlos-mazieri/ubuntu-filemanager-app/open-remote-files-03 into
lp:ubuntu-filemanager-app with
lp:~carlos-mazieri/ubuntu-filemanager-app/open-remote-files-02 as a
prerequisite.
Commit message:
implemented a set of high level download functions
Carlos Jose Mazieri has proposed merging
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-08 into
lp:ubuntu-filemanager-app.
Commit message:
Removed static_cast from SmbLocationItemFile::size()
Fixed SmbUtil::getStatInfo() to set "Not exist" for items su
Carlos Jose Mazieri has proposed merging
lp:~carlos-mazieri/ubuntu-filemanager-app/open-remote-files-05 into
lp:ubuntu-filemanager-app with
lp:~carlos-mazieri/ubuntu-filemanager-app/open-remote-files-04 as a
prerequisite.
Commit message:
UI changed to open remote files
Requested reviews
Carlos Jose Mazieri has proposed merging
lp:~carlos-mazieri/ubuntu-filemanager-app/open-remote-files-04 into
lp:ubuntu-filemanager-app with
lp:~carlos-mazieri/ubuntu-filemanager-app/open-remote-files-03 as a
prerequisite.
Commit message:
implemented tests for downloading files
Requested
Carlos Jose Mazieri has proposed merging
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-07 into
lp:ubuntu-filemanager-app with
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-06 as a
prerequisite.
Commit message:
improved SmbUtil::findSmBServer()
Requested reviews
Carlos Jose Mazieri has proposed merging
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into
lp:ubuntu-filemanager-app.
Commit message:
changed SmbUtil::getStat() and SmbUtil::getFstat() to return int as they do not
handle items from SmbUtil::StatReturn, they are just
Carlos Jose Mazieri has proposed merging
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-06 into
lp:ubuntu-filemanager-app with
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 as a
prerequisite.
Commit message:
some cleanup in SmbItemInfo::setInfo(), work around
Review: Approve
Nice, Thanks.
--
https://code.launchpad.net/~popey/ubuntu-filemanager-app/set-bzr-revno/+merge/274957
Your team Ubuntu File Manager Developers is subscribed to branch
lp:ubuntu-filemanager-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to
Review: Approve
OK, Thanks.
--
https://code.launchpad.net/~popey/ubuntu-filemanager-app/suppress-predictive-text/+merge/274995
Your team Ubuntu File Manager Developers is subscribed to branch
lp:ubuntu-filemanager-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
It has been released.
** Changed in: ubuntu-filemanager-app
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Ubuntu
File Manager Developers, which is subscribed to Ubuntu File Manager App.
Matching subscriptions: File Manager App
The proposal to merge lp:~popey/ubuntu-filemanager-app/suppress-predictive-text
into lp:ubuntu-filemanager-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~popey/ubuntu-filemanager-app/suppress-predictive-text/+merge/274995
--
Your
There was related bug that was fixed some time ago, all items used show
the time of the current folder.
I think that it is OK now, can you check it again?
--
You received this bug notification because you are a member of Ubuntu
File Manager Developers, which is subscribed to Ubuntu File
The proposal to merge
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-04 into
lp:ubuntu-filemanager-app has been updated.
Status: Needs review => Superseded
For more details, see:
Carlos Jose Mazieri has proposed merging
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-04 into
lp:ubuntu-filemanager-app with
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-03 as a
prerequisite.
Commit message:
ixed SmbUtil::changePermissions()
improved SmbUtil
The proposal to merge lp:~popey/ubuntu-filemanager-app/set-bzr-revno into
lp:ubuntu-filemanager-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~popey/ubuntu-filemanager-app/set-bzr-revno/+merge/274957
--
Your team Ubuntu File
The proposal to merge
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-04 into
lp:ubuntu-filemanager-app has been updated.
Status: Needs review => Superseded
For more details, see:
Review: Approve
Thanks,
I am looking forward to getting the entire Samba stuff in the next release.
--
https://code.launchpad.net/~popey/ubuntu-filemanager-app/add-click-deps/+merge/270287
Your team Ubuntu File Manager Developers is subscribed to branch
lp:ubuntu-filemanager-app.
--
Review: Approve
That is OK
Thanks.
--
https://code.launchpad.net/~popey/ubuntu-filemanager-app/fix-1507566/+merge/274884
Your team Ubuntu File Manager Developers is subscribed to branch
lp:ubuntu-filemanager-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to
Carlos Jose Mazieri has proposed merging
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into
lp:ubuntu-filemanager-app with
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-04 as a
prerequisite.
Commit message:
changed SmbUtil::getStat() and SmbUtil::getFstat
Hello Alan,
My attempt was done using the SDK armhf 15-04.
I see that you did install 'libsmbclient-dev' (it installs all the samba
libraries) which I thought it was going to be downloaded by the proposed
solution.
I thought that solution would bring all the necessary resources to compile and
Carlos Jose Mazieri has proposed merging
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-02 into
lp:ubuntu-filemanager-app with
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-01 as a
prerequisite.
Commit message:
After using a such user/password
Carlos Jose Mazieri has proposed merging
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-03 into
lp:ubuntu-filemanager-app with
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-02 as a
prerequisite.
Commit message:
Improved SmbUtil::getStatInfo() to not always open
Carlos Jose Mazieri has proposed merging
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into
lp:ubuntu-filemanager-app with
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-04 as a
prerequisite.
Commit message:
changed SmbUtil::getStat() and SmbUtil::getFstat
Carlos Jose Mazieri has proposed merging
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-04 into
lp:ubuntu-filemanager-app with
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-03 as a
prerequisite.
Commit message:
ixed SmbUtil::changePermissions()
improved SmbUtil
Carlos Jose Mazieri has proposed merging
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-01 into
lp:ubuntu-filemanager-app.
Commit message:
Improved Authentication saving/using by trying the host only when there is no
user/password for a such URL which has path
Requested reviews
Carlos Jose Mazieri has proposed merging
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into
lp:ubuntu-filemanager-app with
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-04 as a
prerequisite.
Commit message:
changed SmbUtil::getStat() and SmbUtil::getFstat
Carlos Jose Mazieri has proposed merging
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into
lp:ubuntu-filemanager-app with
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-04 as a
prerequisite.
Commit message:
changed SmbUtil::getStat() and SmbUtil::getFstat
Carlos Jose Mazieri has proposed merging
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-04 into
lp:ubuntu-filemanager-app with
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-03 as a
prerequisite.
Commit message:
fixed SmbUtil::changePermissions()
improved SmbUtil
Carlos Jose Mazieri has proposed merging
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-06 into
lp:ubuntu-filemanager-app with
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 as a
prerequisite.
Commit message:
some cleanup in SmbItemInfo::setInfo(), work around
Carlos Jose Mazieri has proposed merging
lp:~carlos-mazieri/ubuntu-filemanager-app/directory-browsing-info into
lp:ubuntu-filemanager-app with
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-crash-fix as a prerequisite.
Commit message:
Show the size of directories: (it is the number of items
Review: Needs Information
Hello,
I did a first test without removing my Samba libraries.
On desktop it downloaded the libraries but on armhf it did not.
See some output:
-- Setting BZR_SOURCE to lp:ubuntu-filemanager-app
Grabbing upstream libs to
Carlos Jose Mazieri has proposed merging
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-ui-06 into
lp:ubuntu-filemanager-app with
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-ui-05 as a prerequisite.
Commit message:
Fixed problems in the Authentication and using saved Password
Requested
> It is hard to say something about the crash, if you have the
> 'libsmbclient' installed in your phone you can try this click package
> which contains 'Network' in Places to start navigating in Samba.
> https://www.dropbox.com/s/f6gxiqbav3th8bx/com.ubuntu.filemanager_0.4.latest_ar
>
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/samba-ui-05
into lp:ubuntu-filemanager-app has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-ui-05/+merge/270339
--
Your team
Looking at the log you posted, it looks like there is an extra space
after "smb":
void DirModel::setPath(const QString&, const QString&, const QString&,
bool) DirModel_QML_137(0x12ff010) path or url may not exist or cannot
be read: "smb ://192.168.1.3/"
The correct url must be
I agree with your comments and I will modify that according to that.
Thanks.
--
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-ui-02/+merge/270335
Your team Ubuntu File Manager Developers is subscribed to branch
lp:ubuntu-filemanager-app.
--
Mailing list:
It is hard to say something about the crash, if you have the
'libsmbclient' installed in your phone you can try this click package
which contains 'Network' in Places to start navigating in Samba.
https://www.dropbox.com/s/f6gxiqbav3th8bx/com.ubuntu.filemanager_0.4.latest_armhf.click?dl=0
Have you
Carlos Jose Mazieri has proposed merging
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-ui-01 into
lp:ubuntu-filemanager-app.
Commit message:
Improved "unlock full access" regarding remote locations
Requested reviews:
Ubuntu File Manager Developers (ubuntu-filemanager-dev)
For mo
Carlos Jose Mazieri has proposed merging
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-ui-02 into
lp:ubuntu-filemanager-app with
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-ui-01 as a prerequisite.
Commit message:
1. Added Samba Location as Network
2. Removed default locations
Carlos Jose Mazieri has proposed merging
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-ui-03 into
lp:ubuntu-filemanager-app with
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-ui-02 as a prerequisite.
Commit message:
mproved icon chooser based on the model data
added icon for remote places
Carlos Jose Mazieri has proposed merging
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-ui-04 into
lp:ubuntu-filemanager-app with
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-ui-03 as a prerequisite.
Commit message:
forcing Executable/Readable for hosts, it will make them act as folder
Carlos Jose Mazieri has proposed merging
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-ui-05 into
lp:ubuntu-filemanager-app with
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-ui-04 as a prerequisite.
Commit message:
Implemented a dialog for Authentication when remote locations requires
The proposal to merge
lp:~verzegnassi-stefano/ubuntu-filemanager-app/fix-1490146-chdoctypes into
lp:ubuntu-filemanager-app has been updated.
Status: Needs review => Approved
For more details, see:
The proposal to merge lp:~mterry/ubuntu-filemanager-app/ok into
lp:ubuntu-filemanager-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~mterry/ubuntu-filemanager-app/ok/+merge/269578
--
Your team Ubuntu File Manager Developers is
** Changed in: ubuntu-filemanager-app
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Ubuntu
File Manager Developers, which is subscribed to Ubuntu File Manager App.
Matching subscriptions: File Manager App Bugmail
Review: Approve
This is OK to me.
Thanks.
--
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-filemanager-app/fix-1490146-chdoctypes/+merge/269565
Your team Ubuntu File Manager Developers is subscribed to branch
lp:ubuntu-filemanager-app.
--
Mailing list:
Review: Needs Information
Have you looked at the entire repository code?
It may have any .cpp or .h code using the same, some messages come from c++
code.
--
https://code.launchpad.net/~mterry/ubuntu-filemanager-app/ok/+merge/269578
Your team Ubuntu File Manager Developers is subscribed to
Have you tried to check "unlock full content" ?
if not please give it a try.
--
You received this bug notification because you are a member of Ubuntu
File Manager Developers, which is subscribed to Ubuntu File Manager App.
Matching subscriptions: File Manager App Bugmail
The proposal to merge
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-14 into
lp:ubuntu-filemanager-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-actions-14/+merge/265213
--
Your
Review: Approve
I did a top approve myself as Arto had already done it.
--
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-actions-14/+merge/265213
Your team Ubuntu File Manager Developers is subscribed to branch
lp:ubuntu-filemanager-app.
--
Mailing list:
Hello,
Maybe you are talking about SD card only.
Can you confirm that it is not a file manager bug?
--
You received this bug notification because you are a member of Ubuntu
File Manager Developers, which is subscribed to Ubuntu File Manager App.
Matching subscriptions: File Manager App Bugmail
Yes, it is a memory leak.
I will fix that.
--
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-actions-14/+merge/265213
Your team Ubuntu File Manager Developers is subscribed to branch
lp:ubuntu-filemanager-app.
--
Mailing list:
About the comment:
But it's not clear to me when existing context should be closed and new
created etc.
It is not clear to me either, I could not find good documentation of
libsmbclient, this source code is based on libsmbclient examples and some
own tests, all operations require a context,
About the comment:
166 if (fd == 0)
167 {
168 - fd = openFile(context, smb_path);
169 + openFile(context,smb_path);
It is really a mistake, the function still works most of the times due to next
if that still tries to get a valid descriptor from the parent directory.
That will
Answer from comment on line 35:
Yes, we can compare instances here because there will be just one instance for
each type: one for DiskLocation, one for TrashLocation and another for
SmbLocation. Locations are created by LocationsFactory creator class. See
Thanks for looking at this, for sure I agree, I just was not paying attention
on this.
I will change that in the samba-actions-04 as it changes again
DirModel::canReadDir(), I think that is possible to generate a merge conflict
changing it here.
--
Review: Approve
That is OK for me.
--
https://code.launchpad.net/~snwh/ubuntu-filemanager-app/new-icon/+merge/264632
Your team Ubuntu File Manager Developers is subscribed to branch
lp:ubuntu-filemanager-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to
Carlos Jose Mazieri has proposed merging
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-13 into
lp:ubuntu-filemanager-app with
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-12 as a prerequisite.
Commit message:
Some DirItemInfo objects created by targetLocation in Actions
No it is not, it was my mistake.
If you do no mind as it does not cause any problem, I will remove that later
when this big MP finishes.
Thanks.
--
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-actions-01/+merge/265192
Your team Ubuntu File Manager Developers is
Carlos Jose Mazieri has proposed merging
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-15 into
lp:ubuntu-filemanager-app with
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-14 as a prerequisite.
Commit message:
Qt QDir object is no longer used in Actions nor in DirModel
Carlos Jose Mazieri has proposed merging
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-10 into
lp:ubuntu-filemanager-app with
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-09 as a prerequisite.
Commit message:
provided TrashLocation::urlBelongsToLocation()
Requested
Carlos Jose Mazieri has proposed merging
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-12 into
lp:ubuntu-filemanager-app with
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-11 as a prerequisite.
Commit message:
nherited Location classes now provide inherited LocationItemFile
Carlos Jose Mazieri has proposed merging
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-14 into
lp:ubuntu-filemanager-app with
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-13 as a prerequisite.
Commit message:
Inherited Location classes now provide inherited LocationItemDir
Carlos Jose Mazieri has proposed merging
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-04 into
lp:ubuntu-filemanager-app with
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-03 as a prerequisite.
Commit message:
FileSystemAction needs to interact with Locations, it now
Carlos Jose Mazieri has proposed merging
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-08 into
lp:ubuntu-filemanager-app with
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-07 as a prerequisite.
Commit message:
Object LocationItemDirIterator is created by Location classes
1 - 100 of 133 matches
Mail list logo
