[v8-dev] improve allocation accounting for incremental mark (issue 1252053003 by ofrob...@google.com)

2015-07-22 Thread ofrob...@google.com via codereview.chromium.org
Reviewers: Hannes Payer, Description: improve allocation accounting for incremental mark Add an assertion that allocated_bytes >=0 in IncrementalMark::Step and then make it pass. We were not being diligent in maintaining top_on_previous_step_ and as a result inaccurate, and even negative values

[v8-dev] remove recursion from NewSpace::AllocateRaw* (issue 1265443003 by ofrob...@google.com)

2015-07-29 Thread ofrob...@google.com via codereview.chromium.org
Reviewers: Hannes Payer, Description: remove recursion from NewSpace::AllocateRaw* The recursion between AllocateRaw* and SlowAllocateRaw makes incremental stepping very complicated. This patch removes the recursion. Follow-on patches will improve accounting of allocations done by incremental ma

[v8-dev] Re: remove recursion from NewSpace::AllocateRaw* (issue 1265443003 by ofrob...@google.com)

2015-07-30 Thread ofrob...@google.com via codereview.chromium.org
Done. https://codereview.chromium.org/1265443003/diff/1/src/heap/spaces-inl.h File src/heap/spaces-inl.h (right): https://codereview.chromium.org/1265443003/diff/1/src/heap/spaces-inl.h#newcode348 src/heap/spaces-inl.h:348: int filler_size = Heap::GetFillToAlign(allocation_info_.top(), alignmen

[v8-dev] Re: remove recursion from NewSpace::AllocateRaw* (issue 1265443003 by ofrob...@google.com)

2015-07-31 Thread ofrob...@google.com via codereview.chromium.org
Thanks for the review. I have addressed your comments. PTAL. https://codereview.chromium.org/1265443003/diff/20001/src/heap/spaces-inl.h File src/heap/spaces-inl.h (right): https://codereview.chromium.org/1265443003/diff/20001/src/heap/spaces-inl.h#newcode358 src/heap/spaces-inl.h:358: top = al

[v8-dev] improve allocation accounting for incremental mark (issue 1274453002 by ofrob...@google.com)

2015-08-04 Thread ofrob...@google.com via codereview.chromium.org
Reviewers: Hannes Payer, Description: improve allocation accounting for incremental mark Add an assertion that allocated_bytes >= 0 in IncrementalMark::Step and then make it pass. We were not being diligent in maintaining top_on_previous_step_ and as a result inaccurate, and even negative val

[v8-dev] fix gen-postmortem-metadata.py for kInObjectPropertiesOffset (issue 1308113007 by ofrob...@google.com)

2015-09-01 Thread ofrob...@google.com via codereview.chromium.org
Reviewers: Benedikt Meurer, Description: fix gen-postmortem-metadata.py for kInObjectPropertiesOffset This is causing build breaks for Node.js w/ V8 4.6. Map::kInObjectPropertiesOffset was been replaced by kInObjectPropertiesOrConstructorFunctionIndexOffset in https://codereview.chromium.org/12

[v8-dev] Version 4.6.85.13 (cherry-pick) (issue 1308703013 by ofrob...@google.com)

2015-09-03 Thread ofrob...@google.com via codereview.chromium.org
Reviewers: Benedikt Meurer, Description: Version 4.6.85.13 (cherry-pick) Merged 5434d052f138adc0933c20ad24cc3d84555be53d fix gen-postmortem-metadata.py for kInObjectPropertiesOffset R=bmeu...@chromium.org BUG=v8:4411 Please review this at https://codereview.chromium.org/1308703013/ Base URL: