Reviewers: Hannes Payer,
Description:
improve allocation accounting for incremental mark
Add an assertion that allocated_bytes >=0 in IncrementalMark::Step and then
make it pass.
We were not being diligent in maintaining top_on_previous_step_ and as a
result inaccurate, and even negative values
Reviewers: Hannes Payer,
Description:
remove recursion from NewSpace::AllocateRaw*
The recursion between AllocateRaw* and SlowAllocateRaw makes incremental
stepping very complicated. This patch removes the recursion. Follow-on
patches will improve accounting of allocations done by incremental ma
Done.
https://codereview.chromium.org/1265443003/diff/1/src/heap/spaces-inl.h
File src/heap/spaces-inl.h (right):
https://codereview.chromium.org/1265443003/diff/1/src/heap/spaces-inl.h#newcode348
src/heap/spaces-inl.h:348: int filler_size =
Heap::GetFillToAlign(allocation_info_.top(), alignmen
Thanks for the review. I have addressed your comments. PTAL.
https://codereview.chromium.org/1265443003/diff/20001/src/heap/spaces-inl.h
File src/heap/spaces-inl.h (right):
https://codereview.chromium.org/1265443003/diff/20001/src/heap/spaces-inl.h#newcode358
src/heap/spaces-inl.h:358: top = al
Reviewers: Hannes Payer,
Description:
improve allocation accounting for incremental mark
Add an assertion that allocated_bytes >= 0 in IncrementalMark::Step and then
make it pass. We were not being diligent in maintaining
top_on_previous_step_
and as a result inaccurate, and even negative val
Reviewers: Benedikt Meurer,
Description:
fix gen-postmortem-metadata.py for kInObjectPropertiesOffset
This is causing build breaks for Node.js w/ V8 4.6.
Map::kInObjectPropertiesOffset was been replaced by
kInObjectPropertiesOrConstructorFunctionIndexOffset in
https://codereview.chromium.org/12
Reviewers: Benedikt Meurer,
Description:
Version 4.6.85.13 (cherry-pick)
Merged 5434d052f138adc0933c20ad24cc3d84555be53d
fix gen-postmortem-metadata.py for kInObjectPropertiesOffset
R=bmeu...@chromium.org
BUG=v8:4411
Please review this at https://codereview.chromium.org/1308703013/
Base URL: