Change in vdsm[master]: sampling: Handle numa nodes with zero memory assigned

2015-07-29 Thread rmohr
Roman Mohr has posted comments on this change. Change subject: sampling: Handle numa nodes with zero memory assigned .. Patch Set 2: -Verified -- To view, visit https://gerrit.ovirt.org/44121 To unsubscribe, visit https://gerr

Change in vdsm[master]: sampling: Handle numa nodes with zero memory assigned

2015-07-29 Thread rmohr
Roman Mohr has posted comments on this change. Change subject: sampling: Handle numa nodes with zero memory assigned .. Patch Set 2: Verified+1 Tried to verify this with the fake numa kernel option, but it is not possible to c

Change in vdsm[master]: sampling: Handle numa nodes with zero memory assigned

2015-07-29 Thread rgolan
Roy Golan has posted comments on this change. Change subject: sampling: Handle numa nodes with zero memory assigned .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/44121 To unsubscribe, visit https://g

Change in vdsm[master]: tests: Fix ipwrapper tests isolation

2015-07-29 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: tests: Fix ipwrapper tests isolation .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/44165 To unsubscribe, visit https://gerrit.ovirt.org/

Change in vdsm[master]: tests: Isolate tcTests test properly

2015-07-29 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: tests: Isolate tcTests test properly .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/44144 To unsubscribe, visit https://gerrit.ovirt.org/

Change in vdsm[master]: tests: Remove hack for devices with same names

2015-07-29 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: tests: Remove hack for devices with same names .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/44166 To unsubscribe, visit https://gerrit.

Change in vdsm[master]: tests: Remove hack for devices with same names

2015-07-29 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: tests: Remove hack for devices with same names .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make su

Change in vdsm[master]: tests: Fix ipwrapper tests isolation

2015-07-29 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: tests: Fix ipwrapper tests isolation .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: tests: Isolate tcTests test properly

2015-07-29 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: tests: Isolate tcTests test properly .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: tests: Remove hack for devices with same names

2015-07-29 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: tests: Remove hack for devices with same names .. tests: Remove hack for devices with same names After the test isolation issues in tcTests.py and ipwrapperTests.p

Change in vdsm[master]: tests: Fix ipwrapper tests isolation

2015-07-29 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: tests: Fix ipwrapper tests isolation .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: tests: Fix ipwrapper tests isolation

2015-07-29 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: tests: Fix ipwrapper tests isolation .. tests: Fix ipwrapper tests isolation Similar to tcTests, tests were sharing same devices, so failure to delete a device wou

Change in vdsm[master]: tests: Isolate tcTests test properly

2015-07-29 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: tests: Isolate tcTests test properly .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: tests: Use more random interface names

2015-07-29 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: tests: Use more random interface names .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/44111 To unsubscribe, visit https://gerrit.ovir

Change in vdsm[master]: virt: Add _getVolumeInfo helper

2015-07-29 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: virt: Add _getVolumeInfo helper .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/43560 To unsubscribe, visit https://gerrit.ovirt.org/s

Change in vdsm[master]: virt: Add _getVolumeInfo helper

2015-07-29 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: virt: Add _getVolumeInfo helper .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit h

Change in vdsm[master]: virt: Add _getVolumeInfo helper

2015-07-29 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Add _getVolumeInfo helper .. virt: Add _getVolumeInfo helper The next patch needs to call into to storage to get detailed volume size information

Change in vdsm[master]: tests: Fix expandPermutations use with Mixins

2015-07-29 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: Fix expandPermutations use with Mixins .. tests: Fix expandPermutations use with Mixins When using the expandPermutations decorator on Mixin cla

Change in vdsm[master]: tests: Fix expandPermutations use with Mixins

2015-07-29 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: tests: Fix expandPermutations use with Mixins .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/44151 To unsubscribe, visit https://gerr

Change in vdsm[master]: tests: Use more random interface names

2015-07-29 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: Use more random interface names .. tests: Use more random interface names Shorten the default prefix, allowing longer random suffix, and generat

Change in vdsm[master]: tests: Use more random interface names

2015-07-29 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: tests: Use more random interface names .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view,

Change in vdsm[master]: tests: Fix expandPermutations use with Mixins

2015-07-29 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: tests: Fix expandPermutations use with Mixins .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To

Change in vdsm[master]: tests: Isolate tcTests test properly

2015-07-29 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: tests: Isolate tcTests test properly .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: tests: Abusing permutations to run tests multiple times

2015-07-29 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: tests: Abusing permutations to run tests multiple times .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovir

Change in vdsm[master]: tests: Abusing permutations to run tests multiple times

2015-07-29 Thread nsoffer
Nir Soffer has abandoned this change. Change subject: tests: Abusing permutations to run tests multiple times .. Abandoned Need to get the basic test running first. -- To view, visit https://gerrit.ovirt.org/44109 To unsubscr

Change in vdsm[master]: tests: Wait until an interface is up

2015-07-29 Thread nsoffer
Nir Soffer has abandoned this change. Change subject: tests: Wait until an interface is up .. Abandoned Still does not work. We need to fix test isolation first. -- To view, visit https://gerrit.ovirt.org/44108 To unsubscribe

Change in vdsm[master]: tests: Wait until an interface is up

2015-07-29 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: tests: Wait until an interface is up .. Patch Set 12: * Update tracker::IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/44108 To uns

Change in vdsm[master]: tests: Fix expandPermutations use with Mixins

2015-07-29 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Fix expandPermutations use with Mixins .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/44151 To unsubscribe, visit https://gerrit.o

Change in vdsm[master]: tests: Wait until an interface is up

2015-07-29 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: tests: Wait until an interface is up .. Patch Set 12: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: tests: Abusing permutations to run tests multiple times

2015-07-29 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: tests: Abusing permutations to run tests multiple times .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found

Change in vdsm[master]: tests: Use more random interface names

2015-07-29 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: tests: Use more random interface names .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure heade

Change in vdsm[master]: tests: Isolate tcTests test properly

2015-07-29 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: tests: Isolate tcTests test properly .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: Live Merge: Prevent merge when base volume is too small

2015-07-29 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Live Merge: Prevent merge when base volume is too small .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/42836 To unsubscribe, visit https:

Change in vdsm[master]: spmprotect: Switch from fencing by pid to fencing using syst...

2015-07-29 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: spmprotect: Switch from fencing by pid to fencing using systemctl .. Patch Set 7: ping? -- To view, visit https://gerrit.ovirt.org/43211 To unsubscribe, visi

Change in vdsm[master]: Live Merge: Prevent merge when base volume is too small

2015-07-29 Thread alitke
Adam Litke has posted comments on this change. Change subject: Live Merge: Prevent merge when base volume is too small .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/42836 To unsubscribe, visit https://g

Change in vdsm[master]: virt: Add _getVolumeInfo helper

2015-07-29 Thread alitke
Adam Litke has posted comments on this change. Change subject: virt: Add _getVolumeInfo helper .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/43560 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: Live Merge: Allow extension of non-leaf raw volumes

2015-07-29 Thread alitke
Adam Litke has posted comments on this change. Change subject: Live Merge: Allow extension of non-leaf raw volumes .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/43407 To unsubscribe, visit https://gerri

Change in vdsm[master]: vm: remove unused 'output' value in response

2015-07-29 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: remove unused 'output' value in response .. Patch Set 3: moved on vdsm_driven_events5 branch to enforce patch order -- To view, visit https://gerrit.ovi

Change in vdsm[master]: vmstats: do not report empty ioTune

2015-07-29 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vmstats: do not report empty ioTune .. Patch Set 10: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: vmstats: report disks stats only if present

2015-07-29 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vmstats: report disks stats only if present .. Patch Set 10: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: vm: event: simplify send_status_event

2015-07-29 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vm: event: simplify send_status_event .. Patch Set 16: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure heade

Change in vdsm[master]: vmstats: do not report empty balloonInfo

2015-07-29 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vmstats: do not report empty balloonInfo .. Patch Set 12: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure he

Change in vdsm[master]: vm: event: send status event on pause and resume

2015-07-29 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vm: event: send status event on pause and resume .. Patch Set 19: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: vm: make up pauseCode if libvirt is omitting it

2015-07-29 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vm: make up pauseCode if libvirt is omitting it .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make s

Change in vdsm[master]: vm: event: send status event on IO Error

2015-07-29 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vm: event: send status event on IO Error .. Patch Set 22: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure he

Change in vdsm[master]: vm: remove unused 'output' value in response

2015-07-29 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vm: remove unused 'output' value in response .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: vmstats: avoid explicit string conversion

2015-07-29 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vmstats: avoid explicit string conversion .. Patch Set 10: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure h

Change in vdsm[master]: vm: make up pauseCode if libvirt is omitting it

2015-07-29 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: make up pauseCode if libvirt is omitting it .. Patch Set 2: Verified+1 HOji> 17:57:58 root [~]$ vdsClient -s 0 getAllVmStats b0f37f43-ff02-4dbf-ba8c-dfcc

Change in vdsm[master]: vm: event: simplify send_status_event

2015-07-29 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: event: simplify send_status_event .. Patch Set 15: -Verified wrong copy/paste, removing score -- To view, visit https://gerrit.ovirt.org/43414 To unsubs

Change in vdsm[master]: vm: event: simplify send_status_event

2015-07-29 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: event: simplify send_status_event .. Patch Set 15: Verified+1 Verification: started overwriting the disk inside the VM (dd ... oflag=direct ...), stopped

Change in vdsm[master]: vm: event: send status event on IO Error

2015-07-29 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: event: send status event on IO Error .. Patch Set 21: Verified+1 works: libvirtEventLoop::INFO::2015-07-29 17:56:07,654::vm::3608::virt.vm::(onIOError) v

Change in vdsm[master]: hyperv: enforce hypervclock presence

2015-07-29 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: hyperv: enforce hypervclock presence .. Patch Set 3: * Update tracker::#1083529::OK * Set MODIFIED::bug 1083529#1083529IGNORE, not oVirt prod but

Change in vdsm[master]: hyperv: enforce hypervclock presence

2015-07-29 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: hyperv: enforce hypervclock presence .. hyperv: enforce hypervclock presence It is not enough for libvirt to have the element in the domain XM

Change in vdsm[master]: hyperv: enforce hypervclock presence

2015-07-29 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: hyperv: enforce hypervclock presence .. Patch Set 2: * Update tracker::#1083529::OK * Check Bug-Url::OK * Check Public Bug::#1083529::OK, public bug * Che

Change in vdsm[master]: hyperv: enforce hypervclock presence

2015-07-29 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: hyperv: enforce hypervclock presence .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/44119 To unsubscribe, visit https://gerrit.ovirt.

Change in vdsm[master]: vm: make up pauseCode if libvirt is omitting it

2015-07-29 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vm: make up pauseCode if libvirt is omitting it .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/44115 To unsubscribe, visit https://ge

Change in vdsm[master]: vm: make up pauseCode if libvirt is omitting it

2015-07-29 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vm: make up pauseCode if libvirt is omitting it .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make s

Change in vdsm[master]: vm: remove unused 'output' value in response

2015-07-29 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vm: remove unused 'output' value in response .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: vm: remove unused 'output' value in response

2015-07-29 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vm: remove unused 'output' value in response .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/44116 To unsubscribe, visit https://gerri

Change in vdsm[master]: net/api: drop support for legacy mgmt networks

2015-07-29 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net/api: drop support for legacy mgmt networks .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.ovirt.org/43615 To unsubscribe, visit

Change in vdsm[master]: net/api: drop support for legacy mgmt networks

2015-07-29 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: net/api: drop support for legacy mgmt networks .. net/api: drop support for legacy mgmt networks Change-Id: I45d956b117f7a6cbfa97ce7e060a08307e62a883 S

Change in vdsm[master]: net/api: drop support for legacy mgmt networks

2015-07-29 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: net/api: drop support for legacy mgmt networks .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- T

Change in vdsm[master]: periodic: Use thread names that can be used as system thread...

2015-07-29 Thread fromani
Francesco Romani has posted comments on this change. Change subject: periodic: Use thread names that can be used as system thread names .. Patch Set 3: yep, I'm fine with periodic-sched. -- To view, visit https://gerrit.ovir

Change in vdsm[master]: tests: Fix expandPermutations use with Mixins

2015-07-29 Thread alitke
Adam Litke has posted comments on this change. Change subject: tests: Fix expandPermutations use with Mixins .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/44151 To unsubscribe, visit https://gerrit.ovir

Change in vdsm[master]: mount: Better and simpler __hash__

2015-07-29 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: mount: Better and simpler __hash__ .. Patch Set 5: Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/43978 To unsubscribe, visit https://gerr

Change in vdsm[master]: mount: Better and simpler __hash__

2015-07-29 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: mount: Better and simpler __hash__ .. mount: Better and simpler __hash__ The hash values were mixed in a poor way. There is no need to implement this w

Change in vdsm[master]: mount: Better and simpler __hash__

2015-07-29 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: mount: Better and simpler __hash__ .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visi

Change in vdsm[master]: tests: Fix expandPermutations use with Mixins

2015-07-29 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: tests: Fix expandPermutations use with Mixins .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sur

Change in vdsm[master]: periodic: Use thread names that can be used as system thread...

2015-07-29 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: periodic: Use thread names that can be used as system thread names .. Patch Set 3: Francesco, foo/\d is good notation for multiple threads running the same code.

Change in vdsm[master]: tests: Fix expandPermutations use with Mixins

2015-07-29 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Fix expandPermutations use with Mixins .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/44151/2/tests/testlibTests.py File tests/testlibTests.py: L

Change in vdsm[master]: tests: Fix expandPermutations use with Mixins

2015-07-29 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Fix expandPermutations use with Mixins .. Patch Set 2: Code-Review-1 -- To view, visit https://gerrit.ovirt.org/44151 To unsubscribe, visit https://gerrit.o

Change in vdsm[master]: tests: Fix expandPermutations use with Mixins

2015-07-29 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Fix expandPermutations use with Mixins .. Patch Set 2: (2 comments) Very nice, but should be updated to current master behavior, and could also be more cle

Change in vdsm[master]: tests: Isolate tcTests test properly

2015-07-29 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: tests: Isolate tcTests test properly .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/44144 To unsubscribe, visit https://gerrit.ovirt.org/

Change in vdsm[master]: tests: Fix expandPermutations use with Mixins

2015-07-29 Thread alitke
Adam Litke has posted comments on this change. Change subject: tests: Fix expandPermutations use with Mixins .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/44151 To unsubscribe, visit https://gerrit.ovir

Change in vdsm[master]: tests: Fix expandPermutations use with Mixins

2015-07-29 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: tests: Fix expandPermutations use with Mixins .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sur

Change in vdsm[master]: periodic: Use thread names that can be used as system thread...

2015-07-29 Thread fromani
Francesco Romani has posted comments on this change. Change subject: periodic: Use thread names that can be used as system thread names .. Patch Set 3: actually: periodic/sched ? -- To view, visit https://gerrit.ovirt.org/43

Change in vdsm[master]: tests: Fix expandPermutations use with Mixins

2015-07-29 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Fix expandPermutations use with Mixins .. Patch Set 1: Code-Review-1 (1 comment) The fix is fine, but the tests does not really test this issue. Without thi

Change in vdsm[master]: periodic: Use thread names that can be used as system thread...

2015-07-29 Thread fromani
Francesco Romani has posted comments on this change. Change subject: periodic: Use thread names that can be used as system thread names .. Patch Set 3: Code-Review+1 (1 comment) very nice idea, thanks! https://gerrit.ovirt.o

Change in vdsm[master]: virt: enable libgfapi

2015-07-29 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: virt: enable libgfapi .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/44061/7/vdsm/clientIF.py File vdsm/clientIF.py: Line 316 Line 317 Line 318 Line 319

Change in vdsm[master]: virt: enable libgfapi

2015-07-29 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: virt: enable libgfapi .. Patch Set 7: Please fix pep8 errors - see http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/22527/console -- To view, visit https://g

Change in vdsm[master]: virt: enable libgfapi with snapshot support

2015-07-29 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: virt: enable libgfapi with snapshot support .. Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/33768/4/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2937:

Change in vdsm[master]: virt: enable libgfapi

2015-07-29 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: virt: enable libgfapi .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/44061/4/vdsm/storage/glusterVolume.py File vdsm/storage/glusterVolume.py: Line 55:

Change in vdsm[ovirt-3.5]: net: ignore pass through ifcfg parameters for selective rest...

2015-07-29 Thread ibarkan
Ido Barkan has uploaded a new change for review. Change subject: net: ignore pass through ifcfg parameters for selective restoration .. net: ignore pass through ifcfg parameters for selective restoration Ignore keys in persiste

Change in vdsm[master]: virt: enable libgfapi

2015-07-29 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: virt: enable libgfapi .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/44061/6/vdsm/storage/glusterVolume.py File vdsm/storage/glusterVolume.py: Line 57:

Change in vdsm[master]: virt: enable libgfapi

2015-07-29 Thread ahino
Ala Hino has posted comments on this change. Change subject: virt: enable libgfapi .. Patch Set 6: (4 comments) https://gerrit.ovirt.org/#/c/44061/6//COMMIT_MSG Commit Message: Line 4: Commit: Ala Hino Line 5: CommitDate

Change in vdsm[ovirt-3.5]: net: ignore pass through ifcfg parameters for selective rest...

2015-07-29 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net: ignore pass through ifcfg parameters for selective restoration .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/44153 To unsubscr

Change in vdsm[master]: virt: enable libgfapi

2015-07-29 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: virt: enable libgfapi .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Ur

Change in vdsm[ovirt-3.5]: net: ignore pass through ifcfg parameters for selective rest...

2015-07-29 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: net: ignore pass through ifcfg parameters for selective restoration .. Patch Set 1: Verified-1 * Update tracker::#1203422::OK * Check Bug-Url::OK * Check

Change in vdsm[master]: net: ignore pass through ifcfg parameters for selective rest...

2015-07-29 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net: ignore pass through ifcfg parameters for selective restoration .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/44152 To unsubscr

Change in vdsm[master]: net: ignore pass through ifcfg parameters for selective rest...

2015-07-29 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: net: ignore pass through ifcfg parameters for selective restoration .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no

Change in vdsm[master]: net: ignore pass through ifcfg parameters for selective rest...

2015-07-29 Thread ibarkan
Ido Barkan has uploaded a new change for review. Change subject: net: ignore pass through ifcfg parameters for selective restoration .. net: ignore pass through ifcfg parameters for selective restoration Ignore keys in persiste

Change in vdsm[master]: tests: Fix expandPermutations use with Mixins

2015-07-29 Thread alitke
Adam Litke has posted comments on this change. Change subject: tests: Fix expandPermutations use with Mixins .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/44151 To unsubscribe, visit https://gerrit.ovir

Change in vdsm[master]: tests: Fix expandPermutations use with Mixins

2015-07-29 Thread alitke
Adam Litke has uploaded a new change for review. Change subject: tests: Fix expandPermutations use with Mixins .. tests: Fix expandPermutations use with Mixins When using the expandPermutations decorator on Mixin classes or in c

Change in vdsm[master]: tests: Fix expandPermutations use with Mixins

2015-07-29 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: tests: Fix expandPermutations use with Mixins .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sur

Change in vdsm[master]: executor: Set worker system name

2015-07-29 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: executor: Set worker system name .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matc

Change in vdsm[master]: periodic: Use thread names that can be used as system thread...

2015-07-29 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: periodic: Use thread names that can be used as system thread names .. Patch Set 3: * Update tracker::#1141422::OK * Check Bug-Url::OK * Check Public Bug:

Change in vdsm[master]: virt: enable libgfapi

2015-07-29 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: virt: enable libgfapi .. Patch Set 6: (4 comments) https://gerrit.ovirt.org/#/c/44061/6//COMMIT_MSG Commit Message: Line 4: Commit: Ala Hino Line 5: CommitDa

Change in vdsm[master]: virt: enable libgfapi

2015-07-29 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: virt: enable libgfapi .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Ur

Change in vdsm[master]: vm: event: send status event on IO Error

2015-07-29 Thread michal . skrivanek
Michal Skrivanek has posted comments on this change. Change subject: vm: event: send status event on IO Error .. Patch Set 21: (1 comment) https://gerrit.ovirt.org/#/c/43312/21/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3622:

Change in vdsm[master]: virt: enable libgfapi

2015-07-29 Thread ahino
Ala Hino has posted comments on this change. Change subject: virt: enable libgfapi .. Patch Set 5: (3 comments) https://gerrit.ovirt.org/#/c/44061/5/vdsm/clientIF.py File vdsm/clientIF.py: Line 322: if drive.g

  1   2   3   >