gerrit-hooks has posted comments on this change.
Change subject: storage: Organize imports in storage.iscsiadm
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has uploaded a new change for review.
Change subject: storage: Organize imports in storage.threadPool
..
storage: Organize imports in storage.threadPool
Change-Id: If7e96ac259029aa12ee548a8113c1fbcbf82d26c
Nir Soffer has uploaded a new change for review.
Change subject: storage: Oraganize imports in storage.sdc
..
storage: Oraganize imports in storage.sdc
Change-Id: Id949a69853e2c97a4f1177cd3e717b9c956d03c8
Signed-off-by: Nir
gerrit-hooks has posted comments on this change.
Change subject: storage: Organize imports in storage.threadPool
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: storage: Oraganize imports in storage.sdc
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has uploaded a new change for review.
Change subject: storage: Organize imports in storage.iscsiadm
..
storage: Organize imports in storage.iscsiadm
Change-Id: Ie6a356824572c14da5baa862cf20e872767fb52e
Signed-off-by:
gerrit-hooks has posted comments on this change.
Change subject: storage: Fix copyright years in storage.imagetickets
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: storage: Organize imports in storage.outOfProcess
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has uploaded a new change for review.
Change subject: storage: Fix copyright years in storage.imagetickets
..
storage: Fix copyright years in storage.imagetickets
This module does not cotain any code from 2009.
Nir Soffer has posted comments on this change.
Change subject: storage: Fix copyright years in storage.imagetickets
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/55257
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: storage: Organize imports in storage.imagetickets
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/55258
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: storage: Organize imports in storage.imagetickets
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has uploaded a new change for review.
Change subject: storage: Organize imports in storage.outOfProcess
..
storage: Organize imports in storage.outOfProcess
Change-Id: I723200491287229da72edf5179e1646df9f40195
Nir Soffer has uploaded a new change for review.
Change subject: storage: Organize imports in storage.imagetickets
..
storage: Organize imports in storage.imagetickets
3rd party libraries such as ovirt_image_daemon should
gerrit-hooks has posted comments on this change.
Change subject: storage: Move threadLocal module to vdsm storage lib
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Nir Soffer has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 27:
(8 comments)
https://gerrit.ovirt.org/#/c/52864/27/lib/api/schemaapi.py
File lib/api/schemaapi.py:
Line 37: from
gerrit-hooks has posted comments on this change.
Change subject: storage: Move threadLocal module to vdsm storage lib
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Nir Soffer has uploaded a new change for review.
Change subject: storage: Move threadLocal module to vdsm storage lib
..
storage: Move threadLocal module to vdsm storage lib
Move storage.threadLocal to
Nir Soffer has posted comments on this change.
Change subject: monitoring: Add process helpers
..
Patch Set 2: Verified+1
Verified using the tests.
--
To view, visit https://gerrit.ovirt.org/55254
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: monitoring: Introduce the check module
..
Patch Set 31: Verified+1
Verified using the tests.
--
To view, visit https://gerrit.ovirt.org/54757
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: monitoring: Introduce the asyncevent module
..
Patch Set 14: Verified+1
Verified using the tests.
--
To view, visit https://gerrit.ovirt.org/54849
To
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Introduce the check module
..
Patch Set 31:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Add process helpers
..
Patch Set 2:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Introduce the asyncevent module
..
Patch Set 14:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
*
Nir Soffer has posted comments on this change.
Change subject: monitoring: Introduce the asyncevent module
..
Patch Set 13:
This version rename the module using the same style as asyncore and asynchat.
The code is mostly take
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Make QCOW2_COMPAT configurable
..
Patch Set 2: Code-Review+1
Thanks Pavel! Waiting for another ack from storage.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Add process helpers
..
Patch Set 1:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Introduce the check module
..
Patch Set 30:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Introduce the asyncevent module
..
Patch Set 13:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
*
Nir Soffer has uploaded a new change for review.
Change subject: monitoring: Add process helpers
..
monitoring: Add process helpers
Add helpers for running processes using the event loop:
BufferedReader read data from file
Francesco Romani has posted comments on this change.
Change subject: spec: bump safelease version
..
Patch Set 6: Verified+1
the safelease package is available on CentOS 7:
[root@goji ~]# yum info safelease
Loaded plugins:
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpcvdscli: add storage verbs
..
Patch Set 1:
It looks like hsm makes them optional:
@public
def createStoragePool(self, poolType, spUUID,
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpcvdscli: add storage verbs
..
Patch Set 1:
It looks like xmlrpc was providing some default values:
def poolCreate(self, poolType, spUUID,
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Make QCOW2_COMPAT configurable
..
Patch Set 2:
* #1317850::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1317850::OK, public bug
* Check
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpcvdscli: add storage verbs
..
Patch Set 1:
Sandro checking API.py I can see following params needed by this call :
def __init__(self, UUID):
and
Dan Kenigsberg has submitted this change and it was merged.
Change subject: jsonrpcvdscli: getStorageDomainsList verb
..
jsonrpcvdscli: getStorageDomainsList verb
Add getStorageDomainsList used by ovirt-hoste-engine-setup.
gerrit-hooks has posted comments on this change.
Change subject: jsonrpcvdscli: getStorageDomainsList verb
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: jsonrpcvdscli: connectStorageServer verb
..
jsonrpcvdscli: connectStorageServer verb
Add connectStorageServer used by ovirt-hoste-engine-setup.
gerrit-hooks has posted comments on this change.
Change subject: jsonrpcvdscli: connectStorageServer verb
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: usage of yaml schema
..
Patch Set 10: Verified+1
Fixed issue with default types such as tuple and dict. Yaml parser assumed them
to be strings.
Piotr Kliczewski has posted comments on this change.
Change subject: json: removal of old schemas
..
Patch Set 10: Verified+1
Rebase only no code changes.
--
To view, visit https://gerrit.ovirt.org/54548
To unsubscribe,
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 27: Verified+1
Updated default types in schema file. No code changes.
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: el7: require newly available python34-nose
..
Patch Set 8:
When I run a build on el7 it fails with:
error: Failed build dependencies:
python34-nose
Sandro Bonazzola has posted comments on this change.
Change subject: jsonrpcvdscli: add storage verbs
..
Patch Set 1: Verified-1
[ ERROR ] Failed to execute stage 'Misc configuration': Attempt to call
function: > with
gerrit-hooks has posted comments on this change.
Change subject: bridge: usage of yaml schema
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: bridge: fix naming style
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: events: introduction of schema
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 27:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: bridge: data verification
..
Patch Set 15:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: json: removal of old schemas
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpcvdscli: add storage verbs
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55252
To unsubscribe, visit
Sandro Bonazzola has posted comments on this change.
Change subject: jsonrpcvdscli: add storage verbs
..
Patch Set 1:
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/otopi/context.py", line 131, in
Sandro Bonazzola has uploaded a new change for review.
Change subject: jsonrpcvdscli: add storage verbs
..
jsonrpcvdscli: add storage verbs
Add verbs used by ovirt-hosted-engine-setup for
handling the storage setup.
Change-Id:
gerrit-hooks has posted comments on this change.
Change subject: jsonrpcvdscli: add storage verbs
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Francesco Romani has posted comments on this change.
Change subject: vm: Move saveState() out of constructor
..
Patch Set 6:
(1 comment)
I'm thinking again about the error paths.
Francesco Romani has posted comments on this change.
Change subject: configurator: libvirt: do not jump on virtlogd
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55225
To unsubscribe, visit
Sandro Bonazzola has posted comments on this change.
Change subject: jsonrpcvdscli: disconnectStorageServer verb
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/55250
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: configurator: libvirt: do not jump on virtlogd
..
Patch Set 4:
* #1318902::Update tracker: OK
* Set MODIFIED::bug 1318902#1318902IGNORE, not oVirt
Francesco Romani has submitted this change and it was merged.
Change subject: configurator: libvirt: do not jump on virtlogd
..
configurator: libvirt: do not jump on virtlogd
Libvirt 1.3.0 adds and uses by default a new
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpcvdscli: getStorageDomainsList verb
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55249
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: configurator: libvirt: do not jump on virtlogd
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55225
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: jsonrpcvdscli: getStorageDomainsList verb
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: jsonrpcvdscli: connectStorageServer verb
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: jsonrpcvdscli: disconnectStorageServer verb
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Sandro Bonazzola has uploaded a new change for review.
Change subject: jsonrpcvdscli: disconnectStorageServer verb
..
jsonrpcvdscli: disconnectStorageServer verb
Add disconnectStorageServer used by ovirt-hoste-engine-setup.
Sandro Bonazzola has posted comments on this change.
Change subject: jsonrpcvdscli: getStorageDomainsList verb
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/55249
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: configurator: libvirt: do not jump on virtlogd
..
Patch Set 3: Verified+1
re-verified on branch:
HOji> 14:41:42 root [~]$ grep stdio /etc/libvirt/qemu.conf
Dan Kenigsberg has submitted this change and it was merged.
Change subject: el7: require newly available python34-nose
..
el7: require newly available python34-nose
Recently, (as of rhbz#1294865 and rhbz#1294862) six and nose
gerrit-hooks has posted comments on this change.
Change subject: el7: require newly available python34-nose
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Dan Kenigsberg has posted comments on this change.
Change subject: el7: require newly available python34-nose
..
Patch Set 7: Code-Review+2 Verified+1
build passes on el7 and f23.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: jsonrpcvdscli: getStorageDomainsList verb
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Sandro Bonazzola has uploaded a new change for review.
Change subject: jsonrpcvdscli: getStorageDomainsList verb
..
jsonrpcvdscli: getStorageDomainsList verb
Add getStorageDomainsList used by ovirt-hoste-engine-setup.
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpcvdscli: connectStorageServer verb
..
Patch Set 1: Code-Review+2
It looks like required params are provided in wrong order. The mapping looks OK.
--
Sandro Bonazzola has posted comments on this change.
Change subject: jsonrpcvdscli: connectStorageServer verb
..
Patch Set 1: Verified+1
Changed order between spUUID and type in the call and it worked.
Note that vdscli and
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: common handling of exceptions
..
virt: common handling of exceptions
Vm methods should not return responses directly.
Rather, they should raise
gerrit-hooks has posted comments on this change.
Change subject: virt: common handling of exceptions
..
Patch Set 15:
* #1316128::Update tracker: OK
* Set MODIFIED::bug 1316128#1316128FAILED, illegal change from NEW
Dan Kenigsberg has submitted this change and it was merged.
Change subject: jsonrpcvdscli: getConnectedStoragePoolsList verb
..
jsonrpcvdscli: getConnectedStoragePoolsList verb
Add getConnectedStoragePoolsList used by
gerrit-hooks has posted comments on this change.
Change subject: jsonrpcvdscli: getConnectedStoragePoolsList verb
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: jsonrpcvdscli: add getVdsHardwareInfo verb
..
jsonrpcvdscli: add getVdsHardwareInfo verb
Add getVdsHardwareInfo used by ovirt-hoste-engine-setup.
gerrit-hooks has posted comments on this change.
Change subject: jsonrpcvdscli: add getVdsHardwareInfo verb
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Sandro Bonazzola has posted comments on this change.
Change subject: jsonrpcvdscli: connectStorageServer verb
..
Patch Set 1: Verified-1
--
To view, visit https://gerrit.ovirt.org/55247
To unsubscribe, visit
Sandro Bonazzola has posted comments on this change.
Change subject: jsonrpcvdscli: connectStorageServer verb
..
Patch Set 1: Verified+1
Arguments as in xmlrpc call are: arguments: (1,
'----',
Sandro Bonazzola has uploaded a new change for review.
Change subject: jsonrpcvdscli: connectStorageServer verb
..
jsonrpcvdscli: connectStorageServer verb
Add connectStorageServer used by ovirt-hoste-engine-setup.
Change-Id:
gerrit-hooks has posted comments on this change.
Change subject: jsonrpcvdscli: connectStorageServer verb
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Sandro Bonazzola has posted comments on this change.
Change subject: jsonrpcvdscli: getConnectedStoragePoolsList verb
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/55246
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpcvdscli: getConnectedStoragePoolsList verb
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55246
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: jsonrpcvdscli: getConnectedStoragePoolsList verb
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Sandro Bonazzola has uploaded a new change for review.
Change subject: jsonrpcvdscli: getConnectedStoragePoolsList verb
..
jsonrpcvdscli: getConnectedStoragePoolsList verb
Add getConnectedStoragePoolsList used by
Francesco Romani has posted comments on this change.
Change subject: jsonrpcvdscli: add getVdsHardwareInfo verb
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55244
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpcvdscli: add getVdsHardwareInfo verb
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55244
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: spec: don't depend on ovirt-vmconsole on fedora
..
Patch Set 8: Verified+1
re-verified on FC23
--
To view, visit https://gerrit.ovirt.org/54999
To
Francesco Romani has posted comments on this change.
Change subject: spec: don't depend on ovirt-vmconsole on fedora
..
Patch Set 8:
re-verified on FC23
--
To view, visit https://gerrit.ovirt.org/54999
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: virt: common handling of exceptions
..
Patch Set 14: Verified+1
Verified using the tests.
--
To view, visit https://gerrit.ovirt.org/54664
To unsubscribe,
Sandro Bonazzola has uploaded a new change for review.
Change subject: jsonrpcvdscli: add getVdsHardwareInfo verb
..
jsonrpcvdscli: add getVdsHardwareInfo verb
Add getVdsHardwareInfo used by ovirt-hoste-engine-setup.
Sandro Bonazzola has posted comments on this change.
Change subject: jsonrpcvdscli: add getVdsHardwareInfo verb
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/55244
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: jsonrpcvdscli: add getVdsHardwareInfo verb
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has posted comments on this change.
Change subject: vm: use the new response handling
..
Patch Set 9:
(14 comments)
https://gerrit.ovirt.org/#/c/54799/9/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3937
Line 3938
gerrit-hooks has posted comments on this change.
Change subject: ifcfg: re-enable IPv6 before device configuration, or disable
afterwards
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no
Nir Soffer has posted comments on this change.
Change subject: vm: use the new response handling
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/54799/8//COMMIT_MSG
Commit Message:
Line 8:
Line 9: Let's start using
Ondřej Svoboda has posted comments on this change.
Change subject: ifcfg: re-enable IPv6 before device configuration, or disable
afterwards
..
Patch Set 12:
(4 comments)
1 - 100 of 118 matches
Mail list logo
