Piotr Kliczewski has posted comments on this change.
Change subject: supervdsm: Decorator for supervdsm proxied calls.
..
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/44598
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: coverage: Enable coverage using config value
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45261
To unsubscribe, visit https
Piotr Kliczewski has reverted this change.
Change subject: Revert "tests: functional - convert to run over jsonrpc"
..
Patch Set 12: Reverted
This patchset was reverted in change: Ib45fbaa84e25e3c72aa09bfa78c16d
Piotr Kliczewski has uploaded a new change for review.
Change subject: Revert "tests: functional - convert to run over jsonrpc"
..
Revert "tests: functional - convert to run over jsonrpc"
Due to regressi
Piotr Kliczewski has posted comments on this change.
Change subject: Revert "tests: functional - convert to run over jsonrpc"
..
Patch Set 1: Verified+1
It is revert patch so no need to special steps for verification
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 4: Code-Review-1
Need to update config.py.in.
--
To view, visit https://gerrit.ovirt.org/43759
To
Piotr Kliczewski has posted comments on this change.
Change subject: caps: More readable and maintainable packages list
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44731
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: Revert "tests: functional - convert to run over jsonrpc"
..
Patch Set 1:
What is the cure for the issue you saw?
--
To view, visit https://gerrit
Piotr Kliczewski has posted comments on this change.
Change subject: rpc.Bridge: support positional optional parameters, in addition
to kwargs
..
Patch Set 1: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/45274/1
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: Add feature to create dispersed volume
..
Patch Set 5: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/37474/5/vdsm/gluster/apiwrapper.py
Piotr Kliczewski has posted comments on this change.
Change subject: make: unbreak pyflakes test
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45254
To unsubscribe, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: scheduler: use single instance
..
Patch Set 3: Verified+1
Verified by host deploying vdsm and seeing that there are no issues with
communication.
--
To
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 6: Verified+1
Verified by host deploying vdsm and seeing that there are no issues with
communication
Piotr Kliczewski has posted comments on this change.
Change subject: make: unbreak pyflakes test
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45297
To unsubscribe, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: rpc.Bridge: sanitize optional, positional argument names
..
Patch Set 5: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/45274/5/tests
Piotr Kliczewski has posted comments on this change.
Change subject: rpc.Bridge: sanitize optional, positional argument names
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/45274/5/tests/bridgeTests.py
File tests
Piotr Kliczewski has posted comments on this change.
Change subject: rpc.Bridge: sanitize optional, positional argument names
..
Patch Set 5:
Please propose your solution. Jsonrpc client is only used for tests so far so
it
Piotr Kliczewski has posted comments on this change.
Change subject: rpc.Bridge: sanitize optional, positional argument names
..
Patch Set 5:
Please take a look at integration.jsonRpcTest#testMethodCallArgDict
I think this is
Piotr Kliczewski has posted comments on this change.
Change subject: tests: AsyncClient test suite
..
Patch Set 4: Verified+1
Verified by running vdsm build
--
To view, visit https://gerrit.ovirt.org/43393
To unsubscribe
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: ignore unknown message id
..
Patch Set 2: Verified+1
Verified by running vdsm build
--
To view, visit https://gerrit.ovirt.org/43746
To
Piotr Kliczewski has posted comments on this change.
Change subject: tests: AsyncDispatcher tests suite
..
Patch Set 4: Verified+1
Verified by running vdsm build
--
To view, visit https://gerrit.ovirt.org/43394
To
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: make sure to send error message when no subscription
..
Patch Set 3: Verified+1
Verified by running vdsm build
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: tests: StompAdapter test suite
..
Patch Set 6: Verified+1
Verified by running vdsm build
--
To view, visit https://gerrit.ovirt.org/43342
To unsubscribe
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: allow to mock monotonic_time method
..
Patch Set 2: Verified+1
Verified by running vdsm build
--
To view, visit https://gerrit.ovirt.org/43745
To
Piotr Kliczewski has posted comments on this change.
Change subject: scheduler: use single instance
..
Patch Set 5: Verified+1
Fixed pyflakes issue and the build was rerun. Copying verify flag from previous
patch set.
--
To
Piotr Kliczewski has posted comments on this change.
Change subject: scheduler: use single instance
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/43825/5/vdsm/virt/periodic.py
File vdsm/virt/periodic.py:
Line 58
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/43759/7/vdsm/rpc/bindingjsonrpc.py
File vdsm/rpc
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/43759/7/vdsm/rpc/bindingjsonrpc.py
File vdsm/rpc
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: Add feature to create dispersed volume
..
Patch Set 6: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/37474/6/vdsm/rpc/vdsmapi-gluster
Piotr Kliczewski has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/44857/7/vdsm/v2v.py
File vdsm/v2v.py:
Line 282: obj
Piotr Kliczewski has posted comments on this change.
Change subject: scheduler: use single instance
..
Patch Set 6: Verified+1
Verified by host deploying and seeing that communication works.
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 8: Verified+1
Verified by host deploying and seeing that communication works.
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: Revert "supervdsm: Decorator for supervdsm proxied calls."
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/45316
To u
Piotr Kliczewski has posted comments on this change.
Change subject: Revert "supervdsm: Decorator for supervdsm proxied calls."
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/45316
To u
Piotr Kliczewski has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/44857/7/vdsm/v2v.py
File vdsm/v2v.py:
Line 282: obj
Piotr Kliczewski has posted comments on this change.
Change subject: virtTests: add way to query full stats via jsonrpc
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45309
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: m2c: rename m2c modules
..
Patch Set 4: Verified+1
Maunual rebase, no code changes. Conflicting lib/vdsm/Makefile,
debian/vdsm-python.install and
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: configurable implementation
..
Patch Set 5: Verified+1
Maunual rebase, no code changes. Conflicting lib/vdsm/Makefile,
debian/vdsm-python.install and
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 4: Verified+1
Maunual rebase, no code changes. No conflicts.
Rebuilt to check packaging for both
Piotr Kliczewski has posted comments on this change.
Change subject: make v2v errors reusable
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45381
To unsubscribe, visit https://gerrit.ovirt.org
Piotr Kliczewski has uploaded a new change for review.
Change subject: vdscli: map invocation params to dictionary
..
vdscli: map invocation params to dictionary
We need to be more flexible with parameters provided during
Piotr Kliczewski has uploaded a new change for review.
Change subject: vdscli: host verification fails on client side
..
vdscli: host verification fails on client side
When we provide hostname or run functional tests and
Piotr Kliczewski has posted comments on this change.
Change subject: vdscli: host verification fails on client side
..
Patch Set 1: Verified+1
Run network functional test and there were no issues with ssl handshake
--
To
Piotr Kliczewski has posted comments on this change.
Change subject: vdscli: host verification fails on client side
..
Patch Set 1:
(1 comment)
I understand that this solution looks not great but this code is used when we
Piotr Kliczewski has posted comments on this change.
Change subject: vdscli: map invocation params to dictionary
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/45429/2/vdsm.spec.in
File vdsm.spec.in:
Line 260: An
Piotr Kliczewski has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44857
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: Update v2v to use new jobs infrastructure
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45382
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: tests: Introduce schema parsing tests
..
Patch Set 2: Code-Review-1
Agree with Nir
--
To view, visit https://gerrit.ovirt.org/45464
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: concurrent: Add support for target function kwargs
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45470
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: vdscli: map invocation params to dictionary
..
Patch Set 2: Verified-1
(3 comments)
https://gerrit.ovirt.org/#/c/45429/2/lib/vdsm/jsonrpcvdscli.py
File lib
Piotr Kliczewski has posted comments on this change.
Change subject: vdscli: host verification fails on client side
..
Patch Set 1:
We fail during check of the server cert (host stored in commonName) with
address/name
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: configurable implementation
..
Patch Set 5:
(5 comments)
https://gerrit.ovirt.org/#/c/44494/5/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 58: from
Piotr Kliczewski has posted comments on this change.
Change subject: lib: Use new concurrent.thread() utility
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44895
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: infra: Use new concurrent.thread() utility
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/45554
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: storage: Use new concurrent.thread() utility
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45552
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: tests: Introduce schema parsing tests
..
Patch Set 2: Code-Review+1
After talking to Adam we can have them as they are and refactor later if needed.
--
To
Piotr Kliczewski has uploaded a new change for review.
Change subject: jsonrpc: fd leak
..
jsonrpc: fd leak
We need to make sure that there is no reference to objects which holds
a socket because m2c closes socket when its
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: fd leak
..
Patch Set 1: Verified+1
Verified by running jsonrpc based vdscli wrapped by functional network tests.
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: fd leak
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/45615/1//COMMIT_MSG
Commit Message:
Line 6:
Line 7: jsonrpc: fd leak
Line 8
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: fd leak
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/45615/1//COMMIT_MSG
Commit Message:
Line 6:
Line 7: jsonrpc: fd leak
Line 8
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: fd leak
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/45615/2/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:
Line 244
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: fd leak
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/45615/2/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:
Line 244
Piotr Kliczewski has uploaded a new change for review.
Change subject: stomp: broken unsubscribe process
..
stomp: broken unsubscribe process
There is a logic common for incoming and outgoing connection which
cleans the
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: fd leak
..
Patch Set 3: Verified+1
No code changes. Patch split as Nir suggested. Copying verification flag from
previous patch set.
--
To view
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: broken unsubscribe process
..
Patch Set 1: Verified+1
Verified together with jsonrpc fd leak patch and split later from it.
Verification flag copied
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 4: -Code-Review
--
To view, visit https://gerrit.ovirt.org/44689
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 4: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/44689/4/lib/vdsm/config.py.in
File lib
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: configurable implementation
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/44494/5/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 1260
Piotr Kliczewski has posted comments on this change.
Change subject: json cli: use ssl when creating a socket
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/45611/1/lib/vdsm/utils.py
File lib/vdsm
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: fd leak
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/45615/3/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:
Line 266
Piotr Kliczewski has posted comments on this change.
Change subject: json cli: use ssl when creating a socket
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/45611/1/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: configurable implementation
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/44494/5/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 1255
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 5: Verified+1
Fixed comments and rebased. Verified by building with and without m2c and
tested
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: configurable implementation
..
Patch Set 7: Verified+1
Fixed comments and rebased. Verified by building with and without m2c and
tested communication
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: fd leak
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/45615/3/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:
Line 266
Piotr Kliczewski has posted comments on this change.
Change subject: vdscli: map invocation params to dictionary
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/45429/2/lib/vdsm/jsonrpcvdscli.py
File lib/vdsm
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: broken unsubscribe process
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/45617/1/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc
Piotr Kliczewski has posted comments on this change.
Change subject: json cli: use ssl when creating a socket
..
Patch Set 2:
The change looks good. Now we should ssl module for client side. Please verify
the patch.
--
To
Piotr Kliczewski has uploaded a new change for review.
Change subject: jsonrpc: fd leak
..
jsonrpc: fd leak
We need to make sure that there is no reference to objects which holds
a socket because m2c closes socket only when its
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: fd leak
..
Patch Set 1: Verified+1
This patch was cherry-picked from master. It was verified on master so copying
verify flag.
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: fd leak
..
Patch Set 1:
We need to check whether we do not need to backport it to 3.5.
--
To view, visit https://gerrit.ovirt.org/45714
To
Piotr Kliczewski has posted comments on this change.
Change subject: lib: daemon: cpu affinity support using taskset
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/45738/1/lib/vdsm/config.py.in
File lib/vdsm
Piotr Kliczewski has posted comments on this change.
Change subject: Add an empty metadata qos element to the created domain
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45664
To unsubscribe, visit
Piotr Kliczewski has uploaded a new change for review.
Change subject: schema: rpm for jsonrpc schema files
..
schema: rpm for jsonrpc schema files
We need to use schema files outside of vdsm for external clients and in
the
Piotr Kliczewski has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 1: Verified+1
Verified by updating existing vdsm with new rpm and seeing that communication
still works
Piotr Kliczewski has posted comments on this change.
Change subject: vdscli: host verification fails on client side
..
Patch Set 1:
After verification of https://gerrit.ovirt.org/#/c/45611/ we can abandon this
patch.
--
To
Piotr Kliczewski has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 1:
CI failure not related to this patch.
--
To view, visit https://gerrit.ovirt.org/45750
To unsubscribe
Piotr Kliczewski has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 2: Verified+1
Actually failure was related to this patch. I forgot to git add 2 files.
Verification flag
Piotr Kliczewski has posted comments on this change.
Change subject: vdscli: map invocation params to dictionary
..
Patch Set 4: Verified+1
Missing two files in parent commit so this commit had to be rebased. Copying
Piotr Kliczewski has posted comments on this change.
Change subject: scheduler: use single instance
..
Patch Set 6:
(4 comments)
https://gerrit.ovirt.org/#/c/43825/6/vdsm/virt/periodic.py
File vdsm/virt/periodic.py:
Line 53
Piotr Kliczewski has posted comments on this change.
Change subject: lib: daemon: cpu affinity support using taskset
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/45738/2/init/daemonAdapter
File init/daemonAdapter
Piotr Kliczewski has posted comments on this change.
Change subject: json cli: use ssl when creating a socket
..
Patch Set 2: Verified+1
I checked this patch by cherry-picking https://gerrit.ovirt.org/#/c/43237/ and
other ssl
Piotr Kliczewski has abandoned this change.
Change subject: vdscli: host verification fails on client side
..
Abandoned
Patch https://gerrit.ovirt.org/#/c/45611 provides fallback to standard ssl
implementation and is much
Piotr Kliczewski has posted comments on this change.
Change subject: scheduler: use single instance
..
Patch Set 7: Verified+1
Comments fixed and rebased. Verified by host deploying vdsm and seeing that
communication works
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/44689/5/lib/vdsm/config.py.in
File lib/vdsm
Piotr Kliczewski has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 2:
vdsm-api.html is generated during the build from schema file. From where do you
want me to remove it
Piotr Kliczewski has posted comments on this change.
Change subject: scheduler: use single instance
..
Patch Set 7:
(4 comments)
https://gerrit.ovirt.org/#/c/43825/7/vdsm/virt/periodic.py
File vdsm/virt/periodic.py:
Line 62
Piotr Kliczewski has posted comments on this change.
Change subject: multipath: Move all calls to multipath exe to a single method
..
Patch Set 10:
Do we still want to have this patch?
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: zombiereaper: Add ability to wait on process
..
Patch Set 1:
Do we still see a need for this patch?
--
To view, visit https://gerrit.ovirt.org/35055
To
Piotr Kliczewski has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 2:
Good catch will remove it.
--
To view, visit https://gerrit.ovirt.org/45750
To unsubscribe, visit
201 - 300 of 1223 matches
Mail list logo
