Re: [virt-tools-list] [libosinfo] API to query required user avatar format

2012-11-19 Thread Fabiano Fidêncio
On Mon, Nov 19, 2012 at 8:29 PM, Zeeshan Ali (Khattak) wrote: > On Thu, Nov 15, 2012 at 12:44 AM, Zeeshan Ali (Khattak) > wrote: >> From: "Zeeshan Ali (Khattak)" >> >> Add a new API for apps to be able to query in which format do the user >> avatar file need to be in. >> >> Based on a patch from

Re: [virt-tools-list] [libosinfo] API to query required user avatar format

2012-11-19 Thread Zeeshan Ali (Khattak)
On Thu, Nov 15, 2012 at 12:44 AM, Zeeshan Ali (Khattak) wrote: > From: "Zeeshan Ali (Khattak)" > > Add a new API for apps to be able to query in which format do the user > avatar file need to be in. > > Based on a patch from Fabiano Fidêncio . Anyone wants to review this patch? -- Regards, Ze

Re: [virt-tools-list] [libosinfo v5 06/12] Remove now redundant code in InstallConfigParam

2012-11-19 Thread Zeeshan Ali (Khattak)
On Mon, Nov 19, 2012 at 7:07 PM, Christophe Fergeau wrote: > On Mon, Nov 19, 2012 at 06:01:14PM +0100, Michal Privoznik wrote: >> On 14.11.2012 03:40, Zeeshan Ali (Khattak) wrote: >> > From: "Zeeshan Ali (Khattak)" >> > >> > Remove private structure and finalize implementation. This should have >

Re: [virt-tools-list] [libosinfo v5 06/12] Remove now redundant code in InstallConfigParam

2012-11-19 Thread Zeeshan Ali (Khattak)
On Mon, Nov 19, 2012 at 7:01 PM, Michal Privoznik wrote: > On 14.11.2012 03:40, Zeeshan Ali (Khattak) wrote: >> From: "Zeeshan Ali (Khattak)" >> >> Remove private structure and finalize implementation. This should have >> been part of commit ee9e797. >> --- >> osinfo/osinfo_install_config_param.

Re: [virt-tools-list] [libosinfo v5 02/12] Don't assume avatar location and disk

2012-11-19 Thread Zeeshan Ali (Khattak)
On Mon, Nov 19, 2012 at 7:02 PM, Michal Privoznik wrote: > On 14.11.2012 03:40, Zeeshan Ali (Khattak) wrote: >> From: "Zeeshan Ali (Khattak)" >> >> Instead of hardcoding avatar path and disk, lets get those from >> application. >> --- >> data/install-scripts/fedora.xml | 26 +---

Re: [virt-tools-list] Fwd: how to convert virtualbox vm instance to kvm instance, and then run kvm instance under virt-manager?

2012-11-19 Thread Richard W.M. Jones
On Tue, Nov 20, 2012 at 08:13:07AM +1300, Qiubo Su (David Su) wrote: > dear community, > > no matter the guest vm instance is raw or qcow2 format, when run "virsh > dumpxml ", the error are all the same, shown below: > > virsh dumpxml ttylinux.img > error: failed to get domain 'ttylinux.img' > er

[virt-tools-list] Fwd: how to convert virtualbox vm instance to kvm instance, and then run kvm instance under virt-manager?

2012-11-19 Thread Qiubo Su (David Su)
dear community, no matter the guest vm instance is raw or qcow2 format, when run "virsh dumpxml ", the error are all the same, shown below: virsh dumpxml ttylinux.img error: failed to get domain 'ttylinux.img' error: Domain not found: no domain with matching name 'ttylinux.img' virsh dumpxml clo

Re: [virt-tools-list] how to convert virtualbox vm instance to kvm instance, and then run kvm instance under virt-manager?

2012-11-19 Thread Richard W.M. Jones
On Sat, Nov 17, 2012 at 10:40:31PM +1300, Qiubo Su (David Su) wrote: > dear virt-manager team, > > i run "VBoxManage clonehd --format RAW image.vdi image.img" to convert the > virtualbox .vdi vm instance to raw format, and with virt-manager to create > new vm with the raw format, it works fine, i.

Re: [virt-tools-list] [libosinfo v5 06/12] Remove now redundant code in InstallConfigParam

2012-11-19 Thread Christophe Fergeau
On Mon, Nov 19, 2012 at 06:01:14PM +0100, Michal Privoznik wrote: > On 14.11.2012 03:40, Zeeshan Ali (Khattak) wrote: > > From: "Zeeshan Ali (Khattak)" > > > > Remove private structure and finalize implementation. This should have > > been part of commit ee9e797. > > --- > > osinfo/osinfo_instal

Re: [virt-tools-list] [libosinfo v5 06/12] Remove now redundant code in InstallConfigParam

2012-11-19 Thread Michal Privoznik
On 14.11.2012 03:40, Zeeshan Ali (Khattak) wrote: > From: "Zeeshan Ali (Khattak)" > > Remove private structure and finalize implementation. This should have > been part of commit ee9e797. > --- > osinfo/osinfo_install_config_param.c | 29 - > 1 file changed, 29 deleti

Re: [virt-tools-list] [libosinfo v5 11/12] Separate root & user passwd setup in fedora installer

2012-11-19 Thread Michal Privoznik
On 14.11.2012 03:40, Zeeshan Ali (Khattak) wrote: > From: "Zeeshan Ali (Khattak)" > > Separate out root and user password setup in fedora installer so that > root account is not made passwordless just because user password was > not specified. > --- > data/install-scripts/fedora.xml | 9 ++--

Re: [virt-tools-list] [libosinfo v5 01/12] Add InstallScript:path-format

2012-11-19 Thread Michal Privoznik
On 14.11.2012 03:40, Zeeshan Ali (Khattak) wrote: > From: "Zeeshan Ali (Khattak)" > > Inform the applications in which format the paths are expected by the > installer. > --- > data/install-scripts/windows-cmd.xml | 1 + > data/install-scripts/windows-reg.xml | 1 + > data/install-sc

Re: [virt-tools-list] [libosinfo v6] Make 'filename' more consistent w/ other restrictions

2012-11-19 Thread Michal Privoznik
On 14.11.2012 16:30, Zeeshan Ali (Khattak) wrote: > From: "Zeeshan Ali (Khattak)" > > 'filename' should be toplevel node under 'install-script' rather than > an attribute of its toplevel 'template' child. The reason this was > previously put in the incorrect place was that the first idea was to h

Re: [virt-tools-list] [libosinfo v5 04/12] Allow apps to specify install script disk

2012-11-19 Thread Michal Privoznik
On 14.11.2012 03:40, Zeeshan Ali (Khattak) wrote: > From: "Zeeshan Ali (Khattak)" > > --- > data/install-scripts/windows-cmd.xml | 14 +- > data/install-scripts/windows-sif.xml | 2 +- > osinfo/libosinfo.syms| 3 +++ > osinfo/osinfo_install_config.c | 28 +

Re: [virt-tools-list] [libosinfo v5 02/12] Don't assume avatar location and disk

2012-11-19 Thread Michal Privoznik
On 14.11.2012 03:40, Zeeshan Ali (Khattak) wrote: > From: "Zeeshan Ali (Khattak)" > > Instead of hardcoding avatar path and disk, lets get those from > application. > --- > data/install-scripts/fedora.xml | 26 +--- > data/install-scripts/windows-cmd.xml | 4 ++- > osinfo/libos

Re: [virt-tools-list] [libosinfo v5 07/12] Product key is optional for win7

2012-11-19 Thread Michal Privoznik
On 14.11.2012 03:40, Zeeshan Ali (Khattak) wrote: > From: "Zeeshan Ali (Khattak)" > > --- > data/install-scripts/windows-unattend.xml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/data/install-scripts/windows-unattend.xml > b/data/install-scripts/windows-unattend.xml

Re: [virt-tools-list] [libosinfo v5 03/12] Allow apps to specify target disk

2012-11-19 Thread Michal Privoznik
On 14.11.2012 03:40, Zeeshan Ali (Khattak) wrote: > From: "Zeeshan Ali (Khattak)" > > --- > data/install-scripts/fedora.xml | 84 > +-- > data/install-scripts/windows-cmd.xml | 14 +- > data/install-scripts/windows-unattend.xml | 32 ++-- >

Re: [virt-tools-list] [libosinfo v5 08/12] win7 desktop installer can also use product key

2012-11-19 Thread Michal Privoznik
On 14.11.2012 03:40, Zeeshan Ali (Khattak) wrote: > From: "Zeeshan Ali (Khattak)" > > --- > data/install-scripts/windows-unattend.xml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/data/install-scripts/windows-unattend.xml > b/data/install-scripts/windows-unattend.xml > index baa8059

Re: [virt-tools-list] [libosinfo v5 10/12] Specify product key format for windows installers

2012-11-19 Thread Michal Privoznik
On 14.11.2012 03:40, Zeeshan Ali (Khattak) wrote: > From: "Zeeshan Ali (Khattak)" > > --- > data/install-scripts/windows-sif.xml | 2 ++ > data/install-scripts/windows-unattend.xml | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/data/install-scripts/windows-sif.xml > b/data/in

Re: [virt-tools-list] [libosinfo v5 05/12] Add a NULL check

2012-11-19 Thread Michal Privoznik
On 14.11.2012 03:40, Zeeshan Ali (Khattak) wrote: > From: "Zeeshan Ali (Khattak)" > > --- > osinfo/osinfo_entity.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/osinfo/osinfo_entity.c b/osinfo/osinfo_entity.c > index 9fabc46..348981e 100644 > --- a/osinfo/osinfo_entity.c > +++ b/osin

Re: [virt-tools-list] [libosinfo v5 09/12] Document osinfo_install_script_get_product_key_format

2012-11-19 Thread Michal Privoznik
On 14.11.2012 03:40, Zeeshan Ali (Khattak) wrote: > From: "Zeeshan Ali (Khattak)" > > Document the format of the string returned by this function. > --- > osinfo/osinfo_install_script.c | 23 +++ > 1 file changed, 23 insertions(+) > > diff --git a/osinfo/osinfo_install_scrip

[virt-tools-list] [PATCH virt-viewer] Add virt-viewer-debug.exe NSIS installer

2012-11-19 Thread Marc-André Lureau
This installer will provide with the tools and configuration needed to debug virt-viewer & remote-viewer. It will install itself by default in virt-viewer directory. --- configure.ac | 1 + data/Makefile.am | 1 + data/virt-viewer-debug.nsis.in | 50 ++