[virt-tools-list] [virt-viewer][PATCH v3 1/2] virt-viewer-display-vnc: Set guest name when using VNC

2015-04-29 Thread Lukas Venhoda
If it's not already set, set guest name field in virt-viewer-app when using VNC. Wait for VNC to be initialized (virt_viewer_display_vnc_initialized()). In this callback get field guest name from app and check whether it was already set before (FE from libvirt). If not, set the guest name to name

[virt-tools-list] [virt-viewer][PATCH v3 2/2] virt-viewer-display-vnc: Set uuid when using VNC

2015-04-29 Thread Lukas Venhoda
Notify user, that VNC does not provide uuid. Set uuid to string "VNC does not provide guid". This is more informative then just plain "Unknown". User will now know WHY the GUID is unknown, when using remote-viewer. --- Changes since v2: - Changed char to gchar. - Added file src/virt-viewer-displ

Re: [virt-tools-list] [virt-viewer][PATCH v2 1/2] virt-viewer-display-vnc: Set guest name when using VNC

2015-04-29 Thread Fabiano Fidêncio
On Wed, Apr 29, 2015 at 10:35 AM, Lukas Venhoda wrote: > If it's not already set, set guest name field in virt-viewer-app when using > VNC. > > Wait for VNC to be initialized (virt_viewer_display_vnc_initialized()). > In this callback get field guest name from app and check whether it > was alrea

Re: [virt-tools-list] [virt-viewer][PATCH v2 2/2] virt-viewer-display-vnc: Set uuid when using VNC

2015-04-29 Thread Fabiano Fidêncio
On Wed, Apr 29, 2015 at 10:35 AM, Lukas Venhoda wrote: > Notify user, that VNC does not provide uuid. > > Set uuid to string "VNC does not provide guid". > This is more informative then just plain "Unknown". > User will now know WHY the GUID is unknown, when using remote-viewer. > --- > Changes si

Re: [virt-tools-list] [PATCH virt-viewer v2] session-spice: Disable extra displays in fullscreen mode

2015-04-29 Thread Pavel Grunt
self NACK, I am sending a better version Pavel On Wed, 2015-04-29 at 15:46 +0200, Pavel Grunt wrote: > When running in fullscreen it is possible to end up in a situation > where we have more displays enabled than monitors. This can happen > if displays that were enabled in the previous connection

Re: [virt-tools-list] Libvirt: problem with hidding that a VM is running

2015-04-29 Thread Antoine
> Date: Tue, 28 Apr 2015 20:20:18 -0400 > From: crobi...@redhat.com > To: abyssa...@hotmail.fr; virt-tools-list@redhat.com > Subject: Re: [virt-tools-list] Libvirt: problem with hidding that a VM is > running > > On 04/28/2015 04:31 AM, Antoine wrote: > > Hello everyone, > > > > > > I try to s

Re: [virt-tools-list] [PATCH virt-manager] connection: refresh domain XML on device hotplug

2015-04-29 Thread Cole Robinson
On 04/29/2015 05:00 AM, Ján Tomko wrote: > Listen to the VIR_DOMAIN_EVENT_ID_DEVICE_ADDED event > too, added by libvirt 1.2.15. > > https://bugzilla.redhat.com/show_bug.cgi?id=1179138 > > Signed-off-by: Ján Tomko > --- > Libvirt 1.2.15 is scheduled for release this weekend. While the API is > u

[virt-tools-list] [PATCH virt-viewer v2] session-spice: Disable extra displays in fullscreen mode

2015-04-29 Thread Pavel Grunt
When running in fullscreen it is possible to end up in a situation where we have more displays enabled than monitors. This can happen if displays that were enabled in the previous connection to the guest doesn't match displays requested when entering the fullscreen mode. This commit solves the pro

[virt-tools-list] [virt-viewer][PATCH v2 2/2] virt-viewer-display-vnc: Set uuid when using VNC

2015-04-29 Thread Lukas Venhoda
Notify user, that VNC does not provide uuid. Set uuid to string "VNC does not provide guid". This is more informative then just plain "Unknown". User will now know WHY the GUID is unknown, when using remote-viewer. --- Changes since v1: - No longer calling g_strdup() on _("VNC does not provide GU

[virt-tools-list] [virt-viewer][PATCH v2 1/2] virt-viewer-display-vnc: Set guest name when using VNC

2015-04-29 Thread Lukas Venhoda
If it's not already set, set guest name field in virt-viewer-app when using VNC. Wait for VNC to be initialized (virt_viewer_display_vnc_initialized()). In this callback get field guest name from app and check whether it was already set before (FE from libvirt). If not, set the guest name to name

Re: [virt-tools-list] [PATCH virt-manager] connection: refresh domain XML on device hotplug

2015-04-29 Thread Giuseppe Scrivano
Ján Tomko writes: > Listen to the VIR_DOMAIN_EVENT_ID_DEVICE_ADDED event > too, added by libvirt 1.2.15. > > https://bugzilla.redhat.com/show_bug.cgi?id=1179138 > > Signed-off-by: Ján Tomko > --- > Libvirt 1.2.15 is scheduled for release this weekend. While the API is > unlikely > to change, it

Re: [virt-tools-list] [virt-viewer][PATCH 2/2] virt-viewer-display-vnc: Set uuid when using VNC

2015-04-29 Thread Victor Toso
Hi, On Wed, Apr 29, 2015 at 02:39:51PM +0200, Lukas Venhoda wrote: > Notify user, that VNC does not provide uuid. > > Set uuid to string "VNC does not provide guid". > This is more informative then just plain "Unknown". > User will now know WHY the GUID is unknown, when using remote-viewer. > ---

[virt-tools-list] [virt-viewer][PATCH 2/2] virt-viewer-display-vnc: Set uuid when using VNC

2015-04-29 Thread Lukas Venhoda
Notify user, that VNC does not provide uuid. Set uuid to string "VNC does not provide guid". This is more informative then just plain "Unknown". User will now know WHY the GUID is unknown, when using remote-viewer. --- src/virt-viewer-display-vnc.c | 7 ++- 1 file changed, 6 insertions(+), 1

[virt-tools-list] [virt-viewer][PATCH 1/2] virt-viewer-display-vnc: Set guest name when using VNC

2015-04-29 Thread Lukas Venhoda
If it's not already set, set guest name field in virt-viewer-app when using VNC. Wait for VNC to be initialized (virt_viewer_display_vnc_initialized()). In this callback get field guest name from app and check whether it was already set before (FE from libvirt). If not, set the guest name to name

[virt-tools-list] [PATCH virt-manager] connection: refresh domain XML on device hotplug

2015-04-29 Thread Ján Tomko
Listen to the VIR_DOMAIN_EVENT_ID_DEVICE_ADDED event too, added by libvirt 1.2.15. https://bugzilla.redhat.com/show_bug.cgi?id=1179138 Signed-off-by: Ján Tomko --- Libvirt 1.2.15 is scheduled for release this weekend. While the API is unlikely to change, it is not final until then. virtManager

[virt-tools-list] [virt-viewer][PATCH] Fix syntax-check

2015-04-29 Thread Michal Privoznik
Commit c45a30e9 broke syntax-check: trailing_blank src/virt-viewer-window.c:1478: maint.mk: found trailing blank(s) maint.mk:700: recipe for target 'sc_trailing_blank' failed make: *** [sc_trailing_blank] Error 1 Signed-off-by: Michal Privoznik --- Pushed under trivial & build-breaker rules.