Re: [PATCH v2] virtio_console: allocate inbufs in add_port() only if it is needed

2019-11-13 Thread Michael S. Tsirkin
On Wed, Nov 13, 2019 at 05:37:34PM +0100, Laurent Vivier wrote: > On 13/11/2019 16:22, Michael S. Tsirkin wrote: > > On Wed, Nov 13, 2019 at 10:21:11AM -0500, Michael S. Tsirkin wrote: > >> On Wed, Nov 13, 2019 at 04:00:56PM +0100, Laurent Vivier wrote: > >>> When we hot unplug a virtserialport and

Re: [PATCH net-next 11/14] vsock: add multi-transports support

2019-11-13 Thread Stefano Garzarella
On Wed, Nov 13, 2019 at 02:30:24PM +, Jorgen Hansen wrote: > > From: Stefano Garzarella [mailto:sgarz...@redhat.com] > > Sent: Tuesday, November 12, 2019 11:37 AM > > > > > > You already mentioned that you are working on a fix for loopback > > > > > here for the guest, but presumably a host co

Re: [PATCH v2] virtio_console: allocate inbufs in add_port() only if it is needed

2019-11-13 Thread Laurent Vivier
On 13/11/2019 16:22, Michael S. Tsirkin wrote: > On Wed, Nov 13, 2019 at 10:21:11AM -0500, Michael S. Tsirkin wrote: >> On Wed, Nov 13, 2019 at 04:00:56PM +0100, Laurent Vivier wrote: >>> When we hot unplug a virtserialport and then try to hot plug again, >>> it fails: >>> >>> (qemu) chardev-add so

Re: [PATCH v2] virtio_console: allocate inbufs in add_port() only if it is needed

2019-11-13 Thread Michael S. Tsirkin
On Wed, Nov 13, 2019 at 10:21:11AM -0500, Michael S. Tsirkin wrote: > On Wed, Nov 13, 2019 at 04:00:56PM +0100, Laurent Vivier wrote: > > When we hot unplug a virtserialport and then try to hot plug again, > > it fails: > > > > (qemu) chardev-add socket,id=serial0,path=/tmp/serial0,server,nowait >

Re: [PATCH v2] virtio_console: allocate inbufs in add_port() only if it is needed

2019-11-13 Thread Michael S. Tsirkin
On Wed, Nov 13, 2019 at 04:00:56PM +0100, Laurent Vivier wrote: > When we hot unplug a virtserialport and then try to hot plug again, > it fails: > > (qemu) chardev-add socket,id=serial0,path=/tmp/serial0,server,nowait > (qemu) device_add virtserialport,bus=virtio-serial0.0,nr=2,\ >

[PATCH v2] virtio_console: allocate inbufs in add_port() only if it is needed

2019-11-13 Thread Laurent Vivier
When we hot unplug a virtserialport and then try to hot plug again, it fails: (qemu) chardev-add socket,id=serial0,path=/tmp/serial0,server,nowait (qemu) device_add virtserialport,bus=virtio-serial0.0,nr=2,\ chardev=serial0,id=serial0,name=serial0 (qemu) device_del serial0 (qemu)

Re: [PATCH 3/3] virtiofs: Use completions while waiting for queue to be drained

2019-11-13 Thread Stefan Hajnoczi
On Wed, Oct 30, 2019 at 11:07:19AM -0400, Vivek Goyal wrote: > While we wait for queue to finish draining, use completions instead of > uslee_range(). This is better way of waiting for event. s/uslee_range()/usleep_range()/ signature.asc Description: PGP signature ___

Re: [PATCH 0/3] virtiofs: Small Cleanups for 5.5

2019-11-13 Thread Stefan Hajnoczi
On Wed, Oct 30, 2019 at 11:07:16AM -0400, Vivek Goyal wrote: > Hi Miklos, > > Here are few small cleanups for virtiofs for 5.5. I had received some > comments from Michael Tsirkin on original virtiofs patches and these > cleanups are result of these comments. > > Thanks > Vivek > > Vivek Goyal (

Re: [PATCH 2/3] virtiofs: Do not send forget request "struct list_head" element

2019-11-13 Thread Stefan Hajnoczi
On Wed, Oct 30, 2019 at 11:07:18AM -0400, Vivek Goyal wrote: > We are sending whole of virtio_fs_foreget struct to the other end over s/foreget/forget/ signature.asc Description: PGP signature ___ Virtualization mailing list Virtualization@lists.linux-

RE: [PATCH net-next 11/14] vsock: add multi-transports support

2019-11-13 Thread Jorgen Hansen via Virtualization
> From: Stefano Garzarella [mailto:sgarz...@redhat.com] > Sent: Tuesday, November 12, 2019 11:37 AM > > > > You already mentioned that you are working on a fix for loopback > > > > here for the guest, but presumably a host could also do loopback. > > > > > > IIUC we don't support loopback in the h