Hi Jason,
We agree that the same can be done also using the old way, i.e. try to
set specific offload - if failed, probably it is not supported.
We think this is a little not scalable and we suggest adding the ioctl
that will allow us to query allo the supported features in a single
call.
We think
On Wed, Jan 26, 2022 at 9:54 AM Xuan Zhuo wrote:
>
> On Tue, 25 Jan 2022 10:46:57 +0200, Andrew Melnychenko
> wrote:
> > Added new offloads for TUN devices TUN_F_USO4 and TUN_F_USO6.
> > Technically they enable NETIF_F_GSO_UDP_L4
> > (and only if USO4 & USO6 are set simultaneously).
> > It
On Fri, May 14, 2021 at 10:16 AM Jason Wang wrote:
>
> On Fri, May 14, 2021 at 4:35 AM Willem de Bruijn
> wrote:
> >
> > > > But surprisingly when TUN receives TUN_F_UFO it does not propagate it
> > > > anywhere, there is no corresponding NETIF flag.
> > >
> > > (It looks like I drop the
On Thu, May 13, 2021 at 11:43 PM Willem de Bruijn
wrote:
>
> > > > > > So the question is what to do now:
> > > > > > A)
> > > > > > Finalize patches for guest TX and respective QEMU patches
> > > > > > Prepare RFC patches for guest RX, get ack on them
> > > > > > Change the spec
> > > > > >
On Thu, May 13, 2021 at 10:05 AM Jason Wang wrote:
>
> On Thu, May 13, 2021 at 12:36 PM Yuri Benditovich
> wrote:
> >
> > On Thu, May 13, 2021 at 5:07 AM Jason Wang wrote:
> > >
> > > On Wed, May 12, 2021 at 6:37 PM Yuri Benditovich
> > > wrote:
On Tue, May 11, 2021 at 8:48 PM Willem de Bruijn
wrote:
>
> On Tue, May 11, 2021 at 12:43 AM Yuri Benditovich
> wrote:
> >
> > Large UDP packet provided by the guest with GSO type set to
> > VIRTIO_NET_HDR_GSO_UDP_L4 will be divided to several UDP
> > packet
On Wed, May 12, 2021 at 4:33 AM Jason Wang wrote:
>
>
> 在 2021/5/11 下午4:33, Yuri Benditovich 写道:
> > On Tue, May 11, 2021 at 9:50 AM Jason Wang wrote:
> >>
> >> 在 2021/5/11 下午12:42, Yuri Benditovich 写道:
> >>> Signed-off-by: Yuri Benditovich
> >
On Tue, May 11, 2021 at 11:33 AM Yuri Benditovich
wrote:
>
> On Tue, May 11, 2021 at 9:50 AM Jason Wang wrote:
> >
> >
> > 在 2021/5/11 下午12:42, Yuri Benditovich 写道:
> > > Signed-off-by: Yuri Benditovich
> > > ---
> > > drivers/net/tun
On Tue, May 11, 2021 at 11:24 AM Jason Wang wrote:
>
> On Tue, May 11, 2021 at 4:12 PM Yuri Benditovich
> wrote:
> >
> > On Tue, May 11, 2021 at 9:47 AM Jason Wang wrote:
> > >
> > >
> > > 在 2021/5/11 下午12:42, Yuri Benditovich 写道:
> > >
On Tue, May 11, 2021 at 9:50 AM Jason Wang wrote:
>
>
> 在 2021/5/11 下午12:42, Yuri Benditovich 写道:
> > Signed-off-by: Yuri Benditovich
> > ---
> > drivers/net/tun.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/dr
On Tue, May 11, 2021 at 9:47 AM Jason Wang wrote:
>
>
> 在 2021/5/11 下午12:42, Yuri Benditovich 写道:
> > Large UDP packet provided by the guest with GSO type set to
> > VIRTIO_NET_HDR_GSO_UDP_L4 will be divided to several UDP
> > packets according to the gso_size field.
On Tue, May 11, 2021 at 9:47 AM Jason Wang wrote:
>
>
> 在 2021/5/11 下午12:42, Yuri Benditovich 写道:
> > Define feature bit and GSO type according to the VIRTIO
> > specification.
> >
> > Signed-off-by: Yuri Benditovich
> > ---
> > include/uapi/linu
Signed-off-by: Yuri Benditovich
---
drivers/net/tun.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index 84f832806313..a35054f9d941 100644
--- a/drivers/net/tun.c
+++ b/drivers/net/tun.c
@@ -2812,7 +2812,7 @@ static int set_offload
Define feature bit and GSO type according to the VIRTIO
specification.
Signed-off-by: Yuri Benditovich
---
include/uapi/linux/virtio_net.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/uapi/linux/virtio_net.h b/include/uapi/linux/virtio_net.h
index 3f55a4215f11..a556ac735d7f
User mode software can probe this bit to check whether the
USO feature is supported by TUN/TAP device.
Signed-off-by: Yuri Benditovich
---
include/uapi/linux/if_tun.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/uapi/linux/if_tun.h b/include/uapi/linux/if_tun.h
index 454ae31b93c7
This series adds support for UDP segmentation offload feature
in TUN device according to the VIRTIO specification
Yuri Benditovich (4):
virtio-net: add definitions for host USO feature
virtio-net: add support of UDP segmentation (USO) on the host
tun: define feature bit for USO support
On Wed, Jan 20, 2021 at 8:45 PM Alexei Starovoitov
wrote:
>
> On Tue, Jan 12, 2021 at 12:55 PM Yuri Benditovich
> wrote:
> >
> > On Tue, Jan 12, 2021 at 10:40 PM Yuri Benditovich
> > wrote:
> > >
> > > On Tue, Jan 12, 2021 at 9:42 PM Yuri Benditovi
Hello Alexei,
Can you please answer the questions in the last email of this thread?
Your comment will be extremely helpful.
Thanks
On Tue, Jan 12, 2021 at 10:55 PM Yuri Benditovich
wrote:
>
> On Tue, Jan 12, 2021 at 10:40 PM Yuri Benditovich
> wrote:
> >
> > On Tue, Ja
On Mon, Jan 18, 2021 at 4:46 AM Jason Wang wrote:
>
>
> On 2021/1/17 下午3:57, Yuri Benditovich wrote:
> > On Thu, Jan 14, 2021 at 5:39 AM Jason Wang wrote:
> >>
> >> On 2021/1/13 下午10:33, Willem de Bruijn wrote:
> >>> On Tue, Jan 12, 2021 at 11:11 PM
On Thu, Jan 14, 2021 at 5:39 AM Jason Wang wrote:
>
>
> On 2021/1/13 下午10:33, Willem de Bruijn wrote:
> > On Tue, Jan 12, 2021 at 11:11 PM Jason Wang wrote:
> >>
> >> On 2021/1/13 上午7:47, Willem de Bruijn wrote:
> >>> On Tue, Jan 12, 2021 at 3:29 PM
On Tue, Jan 12, 2021 at 10:40 PM Yuri Benditovich
wrote:
>
> On Tue, Jan 12, 2021 at 9:42 PM Yuri Benditovich
> wrote:
> >
> > This program type can set skb hash value. It will be useful
> > when the tun will support hash reporting feature if virtio-net.
> >
&g
On Tue, Jan 12, 2021 at 9:42 PM Yuri Benditovich
wrote:
>
> This program type can set skb hash value. It will be useful
> when the tun will support hash reporting feature if virtio-net.
>
> Signed-off-by: Yuri Benditovich
> ---
> drivers/net/tun.c | 2 ++
> 1 fi
On Tue, Jan 12, 2021 at 9:49 PM Yuri Benditovich
wrote:
>
> On Tue, Jan 12, 2021 at 9:41 PM Yuri Benditovich
> wrote:
> >
> > Existing TUN module is able to use provided "steering eBPF" to
> > calculate per-packet hash and derive the destination queue to
&
On Tue, Jan 12, 2021 at 9:46 PM Alexei Starovoitov
wrote:
>
> On Tue, Jan 12, 2021 at 11:42 AM Yuri Benditovich
> wrote:
> >
> > This program type can set skb hash value. It will be useful
> > when the tun will support hash reporting feature if virtio-net.
> >
&g
IFF_HASH feature indicates that the tun supports
TUNSETHASHPOPULATION ioctl and can propagate the hash
data to the virtio-net packet.
Signed-off-by: Yuri Benditovich
---
drivers/net/tun.c | 2 +-
include/uapi/linux/if_tun.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff
On Tue, Jan 12, 2021 at 9:41 PM Yuri Benditovich
wrote:
>
> Existing TUN module is able to use provided "steering eBPF" to
> calculate per-packet hash and derive the destination queue to
> place the packet to. The eBPF uses mapped configuration data
> containing a
-by: Yuri Benditovich
---
drivers/net/tun.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index 455f7afc1f36..18c1baf1a6c1 100644
--- a/drivers/net/tun.c
+++ b/drivers/net/tun.c
@@ -2218,7 +2218,7 @@ static void tun_prog_free(struct rcu_head
According to the virtio specification if VIRTIO_NET_F_HASH_REPORT
feature acked the virtio-net header is extended to hold the hash
value and hash report type.
Signed-off-by: Yuri Benditovich
---
drivers/vhost/net.c | 37 +
1 file changed, 29 insertions(+), 8
This program type can set skb hash value. It will be useful
when the tun will support hash reporting feature if virtio-net.
Signed-off-by: Yuri Benditovich
---
drivers/net/tun.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index 7959b5c2d11f
If the BPF program populated the hash in the skb the tun
propagates the hash value and hash report type to the
respective fields of virtio-net header.
Signed-off-by: Yuri Benditovich
---
drivers/net/tun.c | 25 ++---
1 file changed, 22 insertions(+), 3 deletions(-)
diff
User mode program calls this ioctl before loading of
BPF program to inform the tun that the BPF program has
extended functionality, i.e. sets hash value and returns
the virtqueue number in the lower 16 bits and the type
of the hash report in the upper 16 bits.
Signed-off-by: Yuri Benditovich
Used by virtio-net receive side scaling
Signed-off-by: Yuri Benditovich
---
include/linux/skbuff.h | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 416bf95cd5f2..36cf40ec0259 100644
--- a/include/linux/skbuff.h
+++ b
the hash
and the hash type into virtio-net header.
VHOST driver is made aware of respective virtio-net feature that
extends the virtio-net header to report the hash value and hash report
type.
Yuri Benditovich (7):
skbuff: define field for hash report type
vhost: support for hash report virtio-ne
According to the virtio specification if VIRTIO_NET_F_HASH_REPORT
feature acked the virtio-net header is extended to hold the hash
value and hash report type.
Signed-off-by: Yuri Benditovich
---
drivers/vhost/net.c | 37 +
1 file changed, 29 insertions(+), 8
This series introduce virtio-net features VIRTIO_NET_F_RSC_EXT,
VIRTIO_NET_F_RSS and VIRTIO_NET_F_HASH_REPORT.
Changes from v3: reformatted structure in patch 1
Yuri Benditovich (3):
virtio-net: Introduce extended RSC feature
virtio-net: Introduce RSS receive steering feature
virtio-net
in 'csum_offset'
field and sets VIRTIO_NET_HDR_F_RSC_INFO in 'flags' field.
Signed-off-by: Yuri Benditovich
---
include/uapi/linux/virtio_net.h | 24 ++--
1 file changed, 22 insertions(+), 2 deletions(-)
diff --git a/include/uapi/linux/virtio_net.h b/include/uapi/linux/virtio_net.h
parameters
for receive steering.
Signed-off-by: Yuri Benditovich
---
include/uapi/linux/virtio_net.h | 42 +++--
1 file changed, 40 insertions(+), 2 deletions(-)
diff --git a/include/uapi/linux/virtio_net.h b/include/uapi/linux/virtio_net.h
index 6466c5979a93..aec6fac3666a
The feature VIRTIO_NET_F_HASH_REPORT extends the
layout of the packet and requests the device to
calculate hash on incoming packets and report it
in the packet header.
Signed-off-by: Yuri Benditovich
---
include/uapi/linux/virtio_net.h | 36 +
1 file changed, 36
On Mon, Mar 02, 2020 at 10:53:14AM +0200, Yuri Benditovich wrote:
> > On Sun, Mar 1, 2020 at 9:58 PM Michael S. Tsirkin wrote:
> > >
> > > On Sun, Mar 01, 2020 at 04:33:01PM +0200, Yuri Benditovich wrote:
> > > > RSS (Receive-side scaling) defines hash calcula
On Sun, Mar 1, 2020 at 9:58 PM Michael S. Tsirkin wrote:
>
> On Sun, Mar 01, 2020 at 04:33:01PM +0200, Yuri Benditovich wrote:
> > RSS (Receive-side scaling) defines hash calculation
> > rules and decision on receive virtqueue according to
> > the calculated hash
The feature VIRTIO_NET_F_HASH_REPORT extends the
layout of the packet and requests the device to
calculate hash on incoming packets and report it
in the packet header.
Signed-off-by: Yuri Benditovich
---
include/uapi/linux/virtio_net.h | 36 +
1 file changed, 36
This series introduce virtio-net features VIRTIO_NET_F_RSC_EXT,
VIRTIO_NET_F_RSS and VIRTIO_NET_F_HASH_REPORT.
Changes from v2: reformatted structure in patch 1
Yuri Benditovich (3):
virtio-net: Introduce extended RSC feature
virtio-net: Introduce RSS receive steering feature
virtio-net
in 'csum_offset'
field and sets VIRTIO_NET_HDR_F_RSC_INFO in 'flags' field.
Signed-off-by: Yuri Benditovich
---
include/uapi/linux/virtio_net.h | 22 --
1 file changed, 20 insertions(+), 2 deletions(-)
diff --git a/include/uapi/linux/virtio_net.h b/include/uapi/linux/virtio_net.h
parameters
for receive steering.
Signed-off-by: Yuri Benditovich
---
include/uapi/linux/virtio_net.h | 42 +++--
1 file changed, 40 insertions(+), 2 deletions(-)
diff --git a/include/uapi/linux/virtio_net.h b/include/uapi/linux/virtio_net.h
index 19e76b3e3a64..188ad3eecdc8
No problem, I'll send an update
On Sun, Mar 1, 2020 at 1:31 PM Michael S. Tsirkin wrote:
>
> On Sun, Mar 01, 2020 at 01:07:31PM +0200, Yuri Benditovich wrote:
> > VIRTIO_NET_F_RSC_EXT feature bit indicates that the device
> > is able to provide extended RSC information
On Sun, Mar 1, 2020 at 1:32 PM Michael S. Tsirkin wrote:
>
> On Sun, Mar 01, 2020 at 01:07:30PM +0200, Yuri Benditovich wrote:
> > This series introduce virtio-net features VIRTIO_NET_F_RSC_EXT,
> > VIRTIO_NET_F_RSS and VIRTIO_NET_F_HASH_REPORT.
> >
> > Changes
This series introduce virtio-net features VIRTIO_NET_F_RSC_EXT,
VIRTIO_NET_F_RSS and VIRTIO_NET_F_HASH_REPORT.
Changes from v1:
__virtio -> __le
maximal -> maximum
minor style fixes
Yuri Benditovich (3):
virtio-net: Introduce extended RSC feature
virtio-net: Introduce RSS receive st
The feature VIRTIO_NET_F_HASH_REPORT extends the
layout of the packet and requests the device to
calculate hash on incoming packets and report it
in the packet header.
Signed-off-by: Yuri Benditovich
---
include/uapi/linux/virtio_net.h | 36 +
1 file changed, 36
parameters
for receive steering.
Signed-off-by: Yuri Benditovich
---
include/uapi/linux/virtio_net.h | 42 +++--
1 file changed, 40 insertions(+), 2 deletions(-)
diff --git a/include/uapi/linux/virtio_net.h b/include/uapi/linux/virtio_net.h
index 536152fad3c4..6b309fe23671
in 'csum_offset'
field and sets VIRTIO_NET_HDR_F_RSC_INFO in 'flags' field.
Signed-off-by: Yuri Benditovich
---
include/uapi/linux/virtio_net.h | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/include/uapi/linux/virtio_net.h b/include/uapi/linux/virtio_net.h
index
in 'csum_offset'
field and sets VIRTIO_NET_HDR_F_RSC_INFO in 'flags' field.
Signed-off-by: Yuri Benditovich
---
include/uapi/linux/virtio_net.h | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/include/uapi/linux/virtio_net.h b/include/uapi/linux/virtio_net.h
index
The feature VIRTIO_NET_F_HASH_REPORT extends the
layout of the packet and requests the device to
calculate hash on incoming packets and report it
in the packet header.
Signed-off-by: Yuri Benditovich
---
include/uapi/linux/virtio_net.h | 36 +
1 file changed, 36
parameters
for receive steering.
Signed-off-by: Yuri Benditovich
---
include/uapi/linux/virtio_net.h | 42 +++--
1 file changed, 40 insertions(+), 2 deletions(-)
diff --git a/include/uapi/linux/virtio_net.h b/include/uapi/linux/virtio_net.h
index 6e26a2cc6ad0..7a342657fb6c
This series introduce virtio-net features VIRTIO_NET_F_RSC_EXT,
VIRTIO_NET_F_RSS and VIRTIO_NET_F_HASH_REPORT.
Yuri Benditovich (3):
virtio-net: Introduce extended RSC feature
virtio-net: Introduce RSS receive steering feature
virtio-net: Introduce hash report feature
include/uapi/linux
On Mon, Jan 13, 2020 at 1:08 PM Jason Wang wrote:
>
>
> On 2020/1/13 下午4:17, Yuri Benditovich wrote:
> > VIRTIO_NET_F_RSC_EXT feature bit indicates that the device
> > is able to provide extended RSC information. When the feature
> > is negotiatede and 'gso_typ
in 'csum_offset'
field and sets VIRTIO_NET_HDR_F_RSC_INFO in 'flags' field.
Signed-off-by: Yuri Benditovich
---
include/uapi/linux/virtio_net.h | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/include/uapi/linux/virtio_net.h b/include/uapi/linux/virtio_net.h
index
56 matches
Mail list logo
