[PATCH 2/3] fbdev: Make deferred I/O work as advertized

2008-02-25 Thread Markus Armbruster
Deferred I/O was utterly broken. Reading the mmap()ed framebuffer worked, but writing it made the VM endlessly invoke vm_ops.page_mkwrite(). That happened because we failed to set page->mapping and page->index. The fix is to set them, and clean up properly before the framebuffer gets released.

Re: [PATCH 2/3] fbdev: Make deferred I/O work as advertized

2008-02-26 Thread Jaya Kumar
On Mon, Feb 25, 2008 at 8:03 AM, Markus Armbruster <[EMAIL PROTECTED]> wrote: > > Subject: [PATCH 1/1 2.6.24] fbdev: defio and Metronomefb > From: Jaya Kumar <[EMAIL PROTECTED]> > Date: 2008-02-18 13:41:26 Hi Markus, Andrew pointed out that there may be race conditions associated with

Re: [PATCH 2/3] fbdev: Make deferred I/O work as advertized

2008-02-26 Thread Markus Armbruster
"Jaya Kumar" <[EMAIL PROTECTED]> writes: > On Mon, Feb 25, 2008 at 8:03 AM, Markus Armbruster <[EMAIL PROTECTED]> wrote: >> >> Subject: [PATCH 1/1 2.6.24] fbdev: defio and Metronomefb >> From: Jaya Kumar <[EMAIL PROTECTED]> >> Date: 2008-02-18 13:41:26 > > Hi Markus, > > Andrew pointed

Re: [PATCH 2/3] fbdev: Make deferred I/O work as advertized

2008-02-26 Thread Jaya Kumar
On Tue, Feb 26, 2008 at 9:45 AM, Markus Armbruster <[EMAIL PROTECTED]> wrote: > > What about pushing the fb_defio fixes independently of any new > fb_defio users? If fb_defio was worth merging into Linus's tree, it > should be worth fixing there, whether new users are in shape already > or not

Re: [PATCH 2/3] fbdev: Make deferred I/O work as advertized

2008-03-19 Thread Markus Armbruster
"Jaya Kumar" <[EMAIL PROTECTED]> writes: > On Tue, Feb 26, 2008 at 9:45 AM, Markus Armbruster <[EMAIL PROTECTED]> wrote: >> >> What about pushing the fb_defio fixes independently of any new >> fb_defio users? If fb_defio was worth merging into Linus's tree, it >> should be worth fixing there,

Re: [PATCH 2/3] fbdev: Make deferred I/O work as advertized

2008-03-19 Thread Jaya Kumar
On Wed, Mar 19, 2008 at 6:45 PM, Markus Armbruster <[EMAIL PROTECTED]> wrote: > > Any progress on this? > > Considering that fb_defio is utterly broken without the fix (writing > the frame buffer makes the VM endlessly invoke vm_ops.page_mkwrite()), > wouldn't it make sense to merge the fix eve

Re: [PATCH 2/3] fbdev: Make deferred I/O work as advertized

2008-03-19 Thread Andrew Morton
On Wed, 19 Mar 2008 19:24:25 +0800 "Jaya Kumar" <[EMAIL PROTECTED]> wrote: > On Wed, Mar 19, 2008 at 6:45 PM, Markus Armbruster <[EMAIL PROTECTED]> wrote: > > > > Any progress on this? > > > > Considering that fb_defio is utterly broken without the fix (writing > > the frame buffer makes the VM

Re: [PATCH 2/3] fbdev: Make deferred I/O work as advertized

2008-03-19 Thread Jaya Kumar
On Thu, Mar 20, 2008 at 2:37 AM, Andrew Morton <[EMAIL PROTECTED]> wrote: > > Do we need some of all of that patch in 2.6.25? I wasn't aware of such a > need. > > If the drivers/video/fb_defio.c hunk of that patch fixes something then I'd > be inclined to merge the whole thing - adding a new d

Re: [PATCH 2/3] fbdev: Make deferred I/O work as advertized

2008-03-19 Thread Andrew Morton
On Thu, 20 Mar 2008 06:30:37 +0800 "Jaya Kumar" <[EMAIL PROTECTED]> wrote: > On Thu, Mar 20, 2008 at 2:37 AM, Andrew Morton > <[EMAIL PROTECTED]> wrote: > > > > Do we need some of all of that patch in 2.6.25? I wasn't aware of such a > > need. > > > > If the drivers/video/fb_defio.c hunk of th

Re: [PATCH 2/3] fbdev: Make deferred I/O work as advertized

2008-03-19 Thread Jaya Kumar
On Thu, Mar 20, 2008 at 6:39 AM, Andrew Morton <[EMAIL PROTECTED]> wrote: > > Well all we have in the changelog is > > Implement support for the E-Ink Metronome controller. It provides an > mmapable interface to the controller using defio support. It was tested > with a gumstix pxa255 with