Re: [PATCH v3 4/4] virtio_net: disable cb aggressively

2023-01-16 Thread Jason Wang
On Mon, Jan 16, 2023 at 9:41 PM Laurent Vivier wrote: > > Hi Michael, > > On 5/26/21 10:24, Michael S. Tsirkin wrote: > > There are currently two cases where we poll TX vq not in response to a > > callback: start xmit and rx napi. We currently do this with callbacks > > enabled which can cause

Re: [PATCH v3 4/4] virtio_net: disable cb aggressively

2023-01-16 Thread Laurent Vivier
Hi Michael, On 5/26/21 10:24, Michael S. Tsirkin wrote: There are currently two cases where we poll TX vq not in response to a callback: start xmit and rx napi. We currently do this with callbacks enabled which can cause extra interrupts from the card. Used not to be a big issue as we run

Re: [PATCH v3 4/4] virtio_net: disable cb aggressively

2021-05-26 Thread Jason Wang
在 2021/5/26 下午4:24, Michael S. Tsirkin 写道: There are currently two cases where we poll TX vq not in response to a callback: start xmit and rx napi. We currently do this with callbacks enabled which can cause extra interrupts from the card. Used not to be a big issue as we run with interrupts

Re: [PATCH v3 4/4] virtio_net: disable cb aggressively

2021-05-26 Thread Willem de Bruijn
On Wed, May 26, 2021 at 11:15 AM Eric Dumazet wrote: > > > > On 5/26/21 10:24 AM, Michael S. Tsirkin wrote: > > There are currently two cases where we poll TX vq not in response to a > > callback: start xmit and rx napi. We currently do this with callbacks > > enabled which can cause extra

Re: [PATCH v3 4/4] virtio_net: disable cb aggressively

2021-05-26 Thread Eric Dumazet
On 5/26/21 10:24 AM, Michael S. Tsirkin wrote: > There are currently two cases where we poll TX vq not in response to a > callback: start xmit and rx napi. We currently do this with callbacks > enabled which can cause extra interrupts from the card. Used not to be > a big issue as we run with

[PATCH v3 4/4] virtio_net: disable cb aggressively

2021-05-26 Thread Michael S. Tsirkin
There are currently two cases where we poll TX vq not in response to a callback: start xmit and rx napi. We currently do this with callbacks enabled which can cause extra interrupts from the card. Used not to be a big issue as we run with interrupts disabled but that is no longer the case, and