Re: [PATCH libinput] CI: Hook up GitLab CI

2018-06-15 Thread Benjamin Tissoires
Hi Peter, On Fri, Jun 15, 2018 at 8:59 AM Peter Hutterer wrote: > > From: Benjamin Tissoires > > The main tasks it does is build on a few different distros as well as build > with the various build options to make sure they work.It doesn't (yet) run the > test suite

Re: [PATCH libinput] evdev: disable ABS_MT_TOOL_PALM on the Lenovo X1 Carbon 6th gen

2018-04-19 Thread Benjamin Tissoires
reasons to do so, let's unassume this for this device by disabling that > axis altogether and relying on the touch pressure only. > > https://bugzilla.redhat.com/show_bug.cgi?id=1565692 > > Signed-off-by: Peter Hutterer > --- LGTM: Reviewed-by: Benjamin Tiss

[PATCH libinput] udev: drop the version field in device groups

2017-10-26 Thread Benjamin Tissoires
The version field is a per device information. We have no guarantees a touchscreen and a tablet device will share the same version of the firmware (especially if both firmwares are from different vendors). Fixes the touch arbitration for the Dell Canvas 27 Signed-off-by: Benjamin Tissoires

Re: [PATCH libinput] timer: flush the timer funcs if our events come in late

2017-09-20 Thread Benjamin Tissoires
. In that case we > can > erroneously trigger or miss out on taps, see wrong palm detection, etc. > > Signed-off-by: Peter Hutterer > Looks good to me: Reviewed-by: Benjamin Tissoires Cheers, Benjamin ___ wayland-devel mailing list wayland-d

Re: [PATCH libinput] tablet: always enable the no-proximity-out quirk on HUION tablets

2017-09-20 Thread Benjamin Tissoires
On Wed, Sep 20, 2017 at 3:40 AM, Peter Hutterer wrote: > And instead disable it when we do get a proximity out. > > Signed-off-by: Peter Hutterer > --- > This looks good to me: Reviewed-by: Benjamin Tissoires Cheers, Benjamin > Follow-up to > https://lists.freedesktop

Re: [PATCH libinput 2/2] tablet: support tablet devices without BTN_TOOL_PEN

2017-09-19 Thread Benjamin Tissoires
only fix is the correct one (IMHO). Yay-by: Benjamin Tissoires Cheers, Benjamin > meson.build | 1 + > src/evdev-tablet.c | 16 +- > test/litest-device-uclogic-tablet.c | 106 ++ > ++ > t

Re: [PATCH libinput 3/3] touchpad: detect and warn about kernel tracking pointer jumps

2016-04-27 Thread Benjamin Tissoires
the docs. > > Signed-off-by: Peter Hutterer > --- The patch looks good to me: Reviewed-by: Benjamin Tissoires (this applies for 2/3 and 1/3 if you expand the commit message of 1/3). Cheers, Benjamin > doc/Makefile.am | 1 + > doc/page-hierarchy.dox

Re: [PATCH libinput 1/3] Make a link to the html docs available as a #define

2016-04-27 Thread Benjamin Tissoires
On Wed, Apr 27, 2016 at 12:36 PM, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer > --- > configure.ac | 4 > src/libinput-private.h | 8 > 2 files changed, 12 insertions(+) > > diff --git a/configure.ac b/configure.ac > index 507b8e0..8c5b257 100644 > --- a/configu

Re: [RFC v3 libinput 1/2] buttonset: Add a "buttonset" interface for button-only devices

2016-01-20 Thread Benjamin Tissoires
Hi Peter, On Tue, Jan 19, 2016 at 5:46 AM, Peter Hutterer wrote: > A generic interface for devices that provide buttons and axes, but don't > control the pointer. This caters for the Pad part of Wacom graphics tablets > but could eventually also deal with remote controls, 3D mice and other > devi

Re: [PATCH libinput] touchpad: disable MT for all semi-mt devices

2016-01-20 Thread Benjamin Tissoires
On Tue, Jan 19, 2016 at 1:01 AM, Peter Hutterer wrote: > Synaptics, Elantech and Alps semi-mt devices all have issues with reporting > correct MT data, even the bounding box which semi-mt devices are supposed to > report is wrong. > > Synaptics devices have massive jumps with two fingers down. Ela

Re: [PATCH libinput] touchpad: disable MT for elantech semi-mt touchpads

2016-01-13 Thread Benjamin Tissoires
Hi Hans, On Jan 13 2016 or thereabouts, Hans de Goede wrote: > Hi, > > On 13-01-16 05:09, Peter Hutterer wrote: > >When three fingers are set down on the touchpad, one finger tends to get a > >0/0 > >coordinate, triggering palm detection in the upper left corner. Handle this > >like the jumping

Re: Weston 1.8.0: touch input using evdev not working

2015-09-25 Thread Benjamin Tissoires
very allows us to remove the heuristics to decide whether a device is a mouse, keyboard, touchscreen, etc... to udev, and allows the user to override it if the heuristic fails. That's why we use udev. In previous weston builds, the heuristic was in weston, and that's why it was working. Cheers,

Re: Weston 1.8.0: touch input using evdev not working

2015-09-25 Thread Benjamin Tissoires
On Fri, Sep 25, 2015 at 2:22 AM, Vikas Patil wrote: > Dear Members, > > I am trying Weston 1.8.0 on i.MX6 with Freescale linux 3.14.28 and seems > that touch input is not working for me. Weston.log show the following > messages. I am not using llibinput backend yet. That's weird. Since Weston 1.7

Re: [PATCH libinput 4/4] touchpad: reset the motion history during/after a slots->nfake crossover

2015-07-21 Thread Benjamin Tissoires
sequent events then hover around the 3464 mark, but that initial jump is > enough to cause a massive cursor jump. > > https://bugs.freedesktop.org/show_bug.cgi?id=91352 > > Signed-off-by: Peter Hutterer > --- The series looks good to me: Hallelujah-expressed-by: Benjamin Tiss

Re: [PATCH v3 weston] Introduce wl_relative_pointer interface

2015-07-16 Thread Benjamin Tissoires
On Thu, Jul 16, 2015 at 3:37 AM, Peter Hutterer wrote: > On Thu, Jul 16, 2015 at 03:23:20PM +0800, Jonas Ã…dahl wrote: >> On Thu, Jul 16, 2015 at 03:37:30PM +0900, x414e54 wrote: >> > On Wed, Jul 15, 2015 at 11:55 AM, Peter Hutterer >> > wrote: >> > > On Wed, Jul 15, 2015 at 08:23:09AM +0900, x414

Re: [PATCH libinput] touchpad: disable 2fg scrolling on semi-mt touchpads

2015-07-15 Thread Benjamin Tissoires
t; For Alps: > https://bugs.freedesktop.org/show_bug.cgi?id=91081 > For Synaptics: > https://bugs.freedesktop.org/show_bug.cgi?id=91135 > > Signed-off-by: Peter Hutterer > --- This patch is Acked-by: Benjamin Tissoires FWIW, here is the list of semi-mt devices the kernel exports (and tha

Re: [PATCH libinput] COYPING: Update boilerplate from MIT X11 to MIT Expat license

2015-06-11 Thread Benjamin Tissoires
icense boilerplate itself. >> >> See this thread on wayland-devel here for a discussion: >> http://lists.freedesktop.org/archives/wayland-devel/2015-May/022301.html >> >> [1] >> http://lists.freedesktop.org/archives/wayland-devel/2015-June/022552.html >> >> Signed-off-b

[PATCH v2 libinput 2/2] evdev: remove direct checks for INPUT_PROP_POINTING_STICK

2015-06-02 Thread Benjamin Tissoires
not set. Signed-off-by: Benjamin Tissoires --- Changes in v2: - moved device->dpi to be sure the device is tagged first - thanks to 1/2, now we are sure to have the device tagged before the 2 uses below. src/evdev.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/

[PATCH v2 libinput 1/2] evdev: remove tag_device from evdev_dispatch_interface

2015-06-02 Thread Benjamin Tissoires
when we call each evdev_tag_*, we can also get rid of the device->seat_caps tests. Signed-off-by: Benjamin Tissoires --- new in v2 src/evdev-mt-touchpad.c | 7 +++ src/evdev.c | 32 +--- src/evdev.h | 8 3 files changed,

Re: [PATCH libinput] evdev: use the udev ID_INPUT_POINTINGSTICK property

2015-06-01 Thread Benjamin Tissoires
On Mon, Jun 1, 2015 at 12:08 AM, Peter Hutterer wrote: > On Sat, May 30, 2015 at 12:10:28PM +0200, Hans de Goede wrote: >> Hi, >> >> On 29-05-15 17:06, Benjamin Tissoires wrote: >> > >> > >> >On 05/29/2015 03:31 AM, Hans de Goede wrote: >> &g

Re: [PATCH libinput] evdev: use the udev ID_INPUT_POINTINGSTICK property

2015-05-29 Thread Benjamin Tissoires
: Reviewed-by: Hans de Goede > Yep, as Hans said, this looks good to me (it's already push, so that does not matter that much). However, for completeness, if we want to be able to override the INPUT_PROP_POINTING_STICK property, we also need the following patch: From 9573bfb574a74e2eea89a

Re: [PATCH libinput 04/11] touchpad: only check keyboards for disable-while-typing

2015-05-26 Thread Benjamin Tissoires
et the disable while typing feature and this was because one of the power button input node was catching the dwt feature before the keyboard. The whole series is Tested-by: Benjamin Tissoires Cheers, Benjamin > src/evdev-mt-touchpad.c | 22 -- > sr

Re: [PATCH libinput 7/7] touchpad: sync the initial touch state

2015-05-20 Thread Benjamin Tissoires
; from 0/y or x/0 to the real coordinates. > > For touchpads with distance support this is a real issue since the default > value for a touch distance is > 0. > > Signed-off-by: Peter Hutterer > --- The series is: Tested-by: Benjamin Tissoires Cheers, Ben

[PATCH v2] touchpad: add support for per-finger hovering information

2015-05-06 Thread Benjamin Tissoires
When the device supports true hovering, it reports this information through ABS_MT_DISTANCE. When this axis is available, we should rely on it to (un)hover the touches as BTN_TOUCH is most of the time unreliable (generated by the mouse emulation in the kernel). Signed-off-by: Benjamin Tissoires

Re: [PATCH libinput 3/3] touchpad: add support for per-finger hovering information

2015-05-06 Thread Benjamin Tissoires
On Wed, May 6, 2015 at 5:33 PM, Peter Hutterer wrote: > On Wed, May 06, 2015 at 10:45:20AM -0400, Benjamin Tissoires wrote: >> On Wed, May 6, 2015 at 1:08 AM, Peter Hutterer >> wrote: >> > On Thu, Apr 30, 2015 at 04:30:25PM -0400, Benjamin Tissoires wrote: >&g

Re: [PATCH libinput 3/3] touchpad: add support for per-finger hovering information

2015-05-06 Thread Benjamin Tissoires
On Wed, May 6, 2015 at 1:08 AM, Peter Hutterer wrote: > On Thu, Apr 30, 2015 at 04:30:25PM -0400, Benjamin Tissoires wrote: >> From: Benjamin Tissoires >> >> When the device supports true hovering, it reports this >> information through ABS_MT_DISTANCE. >> When

[PATCH libinput 1/3] test: bcm5974: down should be marked as static

2015-04-30 Thread Benjamin Tissoires
From: Benjamin Tissoires Signed-off-by: Benjamin Tissoires --- test/litest-bcm5974.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/test/litest-bcm5974.c b/test/litest-bcm5974.c index 035bed2..ddff038 100644 --- a/test/litest-bcm5974.c +++ b/test/litest-bcm5974.c

[PATCH libinput 2/3] test: rename hover tests into semi_mt_hover

2015-04-30 Thread Benjamin Tissoires
From: Benjamin Tissoires The current hover tests are uniquely designed for some Synaptics touchpad. Libinput can handle hovering through ABS_MT_DISTANCE, so we need to reserve the "hover" name for real hovering devices. Signed-off-by: Benjamin Tissoires --- test/touchpa

[PATCH libinput 0/3] Support of true hovering

2015-04-30 Thread Benjamin Tissoires
first hovering finger of the session is seen as a touch (annoying but it disapears as soon as it touches once the sensor). I am sending this series now because the 2 previous points are not mandatory for current users. Cheers, Benjamin Benjamin Tissoires (3): test: bcm5974: down should be mark

[PATCH libinput 3/3] touchpad: add support for per-finger hovering information

2015-04-30 Thread Benjamin Tissoires
From: Benjamin Tissoires When the device supports true hovering, it reports this information through ABS_MT_DISTANCE. When this axis is available, we should rely on it to (un)hover the touches as BTN_TOUCH is most of the time unreliable (generated by the mouse emulation in the kernel). Signed

Re: [PATCH libinput] evdev: add support for LIBINPUT_MODEL_* udev tags

2015-04-23 Thread Benjamin Tissoires
st. The LIBINPUT_MODEL_ prefix is used to determine some type of >> device >> model. Note that this property is a private API and subject to change at >> any time without notice. >> >> Signed-off-by: Peter Hutterer > > > Looks good: > > Reviewed-by: Hans

[PATCH libinput v5] evdev: use a different filter for low resolution touchpad on the Lenovo X230

2015-04-23 Thread Benjamin Tissoires
y a factor to minimize those jumps at low speed, and try keeping the same feeling as regular touchpads at high speed. It still feels slower but it is usable at least Signed-off-by: Benjamin Tissoires --- Hi, So this will hopefully be validated and pulled upstream. This patch needs the one Pe

[PATCH libinput v4 1/2] evdev: use a different filter for low resolution touchpad on the Lenovo X230

2015-04-20 Thread Benjamin Tissoires
e a three segments acceleration profile to sort this out: - slow down a lot when speed is below 0.8 + threshold - use a somewhat half acceleration when speed is in ]0.8 + threshold .. 2.0] - use the same acceleration than regular touchpads if the speed is greater than 2.0 Signed-off-by: Benja

[PATCH libinput v4 0/2] Fix Lenovo X230 series touchpad

2015-04-20 Thread Benjamin Tissoires
solution. Nevertheless, I feel that these settings should be OK. Cheers, Benjamin Benjamin Tissoires (2): evdev: use a different filter for low resolution touchpad on the Lenovo X230 udev: add a custom udev rule for X230 touchpads doc/device-configuration-via-udev.dox |9 +++ src/

[PATCH libinput v4 2/2] udev: add a custom udev rule for X230 touchpads

2015-04-20 Thread Benjamin Tissoires
X230 touchpads should be tagged as LIBINPUT_MODEL_LENOVO_X230 by udev to apply a different acceleration profile. Signed-off-by: Benjamin Tissoires Reviewed-by: Peter Hutterer --- changes in v4: - renamed the file as 90-libinput-model-quirks.rules to give some space for users to add their

Re: [PATCH v3 0/4] Fix Lenovo X230 series touchpad

2015-04-17 Thread Benjamin Tissoires
Hi Vasily, On Fri, Apr 17, 2015 at 2:47 AM, Vasily Khoruzhick wrote: > Hi Benjamin, > > On Thu, Apr 16, 2015 at 9:41 PM, Benjamin Tissoires > wrote: >> So here is a v2 (well v3 to keep things incrementing) of the x230 touchpad >> series. >> >> The touchpad

[PATCH v3 3/4] udev: add a custom udev rule for X230 touchpads

2015-04-16 Thread Benjamin Tissoires
X230 touchpads should be tagged as LIBINPUT_MODEL_LENOVO_X230 by udev to apply a different acceleration profile. Signed-off-by: Benjamin Tissoires --- Changes to v1: - more generic rule (in the file name and the way it is handled) No changes to v2. udev/99-libinput-model-quirks.rules | 14

Re: [PATCH v3 0/4] Fix Lenovo X230 series touchpad

2015-04-16 Thread Benjamin Tissoires
Grmbl... this series is for libinput, sorry for the missing subject prefix Benjamin On Thu, Apr 16, 2015 at 2:41 PM, Benjamin Tissoires wrote: > So here is a v2 (well v3 to keep things incrementing) of the x230 touchpad > series. > > The touchpad seems almost as fast as any other by

[PATCH v3 0/4] Fix Lenovo X230 series touchpad

2015-04-16 Thread Benjamin Tissoires
ut it. Maybe other users would be more picky and prefer to have it. Cheers, Benjamin Benjamin Tissoires (4): filter: break out accel_profile_linear from pointer_accel_profile_linear evdev: use a different filter for low resolution touchpad on the Lenovo X230 udev: add a custom udev rul

[PATCH v3 2/4] evdev: use a different filter for low resolution touchpad on the Lenovo X230

2015-04-16 Thread Benjamin Tissoires
y a factor to minimize those jumps at low speed and try keeping the same feeling as regular touchpads at high speed. It still feels slower but it is usable at least Signed-off-by: Benjamin Tissoires Signed-off-by: Peter Hutterer --- Changes to v1: - a bit more generic than the original, makes add

[PATCH v3 1/4] filter: break out accel_profile_linear from pointer_accel_profile_linear

2015-04-16 Thread Benjamin Tissoires
No functional code. Allows to reuse the linear filtering in other acceleration profiles. Signed-off-by: Benjamin Tissoires --- no changes since v1 src/filter.c | 20 +++- 1 files changed, 15 insertions(+), 5 deletions(-) diff --git a/src/filter.c b/src/filter.c index 962d74d

[PATCH v3 4/4] evdev: Fix reported resolution of Lenovo X230 touchpads

2015-04-16 Thread Benjamin Tissoires
The Lenovo X230 advertise a vertical resolution of 136, which gives a size of 31 mm. The actual size of the touchpad is 40mm, so override the resolution to 100. /!\ This is a temporary fix. The proper fix should go in hwdb. /!\ Signed-off-by: Benjamin Tissoires --- changes to v1: - updated with

Re: [PATCH libinput 3/3] udev: add a custom udev rule for X230 touchpads

2015-04-13 Thread Benjamin Tissoires
On Thu, Apr 9, 2015 at 11:45 PM, Peter Hutterer wrote: > On Thu, Apr 09, 2015 at 01:30:39PM -0400, Benjamin Tissoires wrote: >> X230 touchpads should be tagged as LIBINPUT_MODEL_LENOVO_X230 by udev to >> apply a different acceleration profile. >> >> Signed

Re: [PATCH libinput 0/3] Fix Lenovo X230 series touchpad

2015-04-13 Thread Benjamin Tissoires
hat first. Feel free to send the various parameters you set, and we will see if we can include them (after comparison with other touchpads :-P). Cheers, Benjamin > > -- > Giulio > > 2015-04-09 20:30 GMT+03:00 Benjamin Tissoires : >> Hi, >> >> Here is a series to

Re: libinput and the Thinkpad Compact USB Keyboard

2015-04-13 Thread Benjamin Tissoires
Hi Andreas, On Mon, Mar 30, 2015 at 3:39 PM, Andreas Fleig wrote: > Hi, > > I recently updated my T440s to Fedora 22, and was happy about middle button > scrolling being enabled by default -- for the built-in trackpoint. Since I'm > an avid scroller, I needed to make this work for my "ThinkPad Co

Re: [PATCH libinput 0/3] Fix Lenovo X230 series touchpad

2015-04-09 Thread Benjamin Tissoires
On Thu, Apr 9, 2015 at 2:17 PM, Giulio Camuffo wrote: > 2015-04-09 20:30 GMT+03:00 Benjamin Tissoires : >> Hi, >> >> Here is a series to try making the touchpad found on the Lenovo >> X230 working. This touchpad has a very bad hardware resolution and by >> defau

[PATCH libinput 1/3] filter: break out accel_profile_linear from pointer_accel_profile_linear

2015-04-09 Thread Benjamin Tissoires
No functional change. Allows to reuse the linear filtering in other acceleration profiles. Signed-off-by: Benjamin Tissoires --- src/filter.c | 20 +++- 1 files changed, 15 insertions(+), 5 deletions(-) diff --git a/src/filter.c b/src/filter.c index 033201f..92e6802 100644

[PATCH libinput 3/3] udev: add a custom udev rule for X230 touchpads

2015-04-09 Thread Benjamin Tissoires
X230 touchpads should be tagged as LIBINPUT_MODEL_LENOVO_X230 by udev to apply a different acceleration profile. Signed-off-by: Benjamin Tissoires --- udev/99-x230.rules | 14 ++ udev/Makefile.am |4 +++- 2 files changed, 17 insertions(+), 1 deletions(-) create mode 100644

[PATCH libinput 4/3] evdev: Fix reported resolution of Lenovo X230 touchpads

2015-04-09 Thread Benjamin Tissoires
The Lenovo X230 advertise a vertical resolution of 136, which gives a size of 31 mm. The actual size of the touchpad is 40mm, so override the resolution to 100. /!\ This is a temporary fix. The proper fix should go in hwdb. /!\ Signed-off-by: Benjamin Tissoires --- src/evdev.c | 13

[PATCH libinput 0/3] Fix Lenovo X230 series touchpad

2015-04-09 Thread Benjamin Tissoires
better, but that's maybe just me. It's up to the libinput maintainer to decide to take it or not (thus the 4/3). Final note. I tested it on a X230t (t for tablet). I'd like to get some feedbacks from the non-tablet users too. Cheers, Benjamin Benjamin Tissoires (4): fi

[PATCH libinput 2/3] evdev: use a different filter for low resolution touchpad on the Lenovo X230

2015-04-09 Thread Benjamin Tissoires
y a factor to minimize those jumps at low speed and try keeping the same feeling as regular touchpads at high speed. It still feels slower but it is usable at least Signed-off-by: Benjamin Tissoires --- doc/device-configuration-via-udev.dox |9 + src/evdev-mt-touchpa

Re: [PATCH libinput] evdev: Do not mark tablet touchscreens as tablets

2015-03-30 Thread Benjamin Tissoires
On Fri, Mar 27, 2015 at 6:34 PM, Jason Gerecke wrote: > Devices like the Cintiq 24HDT are marked with both ID_INPUT_TABLET and > ID_INPUT_TOUCHSCREEN in udev. Be sure that we don't try to use such a > device as a tablet. > > Signed-off-by: Jason Gerecke > --- Reviewed

Re: [PATCH libinput 1/2] tablet: rely on libwacom for the list of axis capabilities

2015-03-11 Thread Benjamin Tissoires
case WSTYLUS_PUCK: > - copy_axis_cap(tablet, tool, LIBINPUT_TABLET_AXIS_ROTATION_Z); > - copy_axis_cap(tablet, tool, LIBINPUT_TABLET_AXIS_DISTANCE); > - /* lens cursors don't have a wheel */ > - if (!libwacom_stylus_has_lens(s)) > -

Re: [PATCH libinput 1/2] tablet: copy distance axis for the mouse/lens cursor devices

2015-03-05 Thread Benjamin Tissoires
On Wed, Mar 4, 2015 at 11:25 PM, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer > --- For the series: Reviewed-by: Benjamin Tissoires > src/evdev-tablet.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/evdev-tablet.c b/src/evdev-tablet.c > index 8c

Re: [PATCH v2 libinput] tablet: sync tools already in proximity at startup

2015-03-03 Thread Benjamin Tissoires
On Mon, Mar 2, 2015 at 10:29 PM, Benjamin Tissoires wrote: > On Mon, Mar 2, 2015 at 7:59 PM, Peter Hutterer > wrote: >> If a tool is in proximity when we init, send a proximity event immediately. >> >> This is only partially reliable due to the current kernel behavior

Re: [PATCH v2 libinput] tablet: sync tools already in proximity at startup

2015-03-02 Thread Benjamin Tissoires
On Mon, Mar 2, 2015 at 7:59 PM, Peter Hutterer wrote: > If a tool is in proximity when we init, send a proximity event immediately. > > This is only partially reliable due to the current kernel behavior: > * if the tool comes into proximity when there is no evdev client, the device > won't send

Re: [PATCH libinput 19/26] tablet: support z-rotation for the mouse/lens tool

2015-03-02 Thread Benjamin Tissoires
On Mon, Mar 2, 2015 at 1:53 AM, Peter Hutterer wrote: > On Thu, Feb 26, 2015 at 04:20:49PM -0500, Benjamin Tissoires wrote: >> On Tue, Feb 24, 2015 at 1:21 AM, Peter Hutterer >> wrote: >> > Needs to be calculated from the x/y tilt values, the mouse has a fixed >>

Re: [PATCH libinput] tablet: ignore tools already in proximity at startup

2015-02-26 Thread Benjamin Tissoires
On Thu, Feb 26, 2015 at 12:05 AM, Peter Hutterer wrote: > Require a tool to be moved into proximity before we handle any events from it. > This requires the user to lift the tool for first use but a tool that's > already on the tablet on init is likely to send garbage anyway and interfere. > This

Re: [PATCH libinput 19/26] tablet: support z-rotation for the mouse/lens tool

2015-02-26 Thread Benjamin Tissoires
On Tue, Feb 24, 2015 at 1:21 AM, Peter Hutterer wrote: > Needs to be calculated from the x/y tilt values, the mouse has a fixed offset > of 175 degrees counterclockwise. > > Signed-off-by: Peter Hutterer > --- > src/evdev-tablet.c | 88 > +- >

Re: [PATCH v2 libinput 25/26] tablet: add libinput_tablet_get_axis_delta()

2015-02-26 Thread Benjamin Tissoires
On Wed, Feb 25, 2015 at 11:33 PM, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer > --- > Changes to v2: > - delta was stored in tablet->axes[a], causing a wrong axis_value and a > wrong axis_delta. which the test didn' catch because it didn't trigger. > fixed now, store the wheel value in

Re: [PATCH libinput] evdev: ignore tablet pad devices explicitly

2015-02-26 Thread Benjamin Tissoires
already working. >> >> Signed-off-by: Peter Hutterer > > > Looks good: > > Reviewed-by: Hans de Goede > Yep, Reviewed-and-tested-by: Benjamin Tissoires Cheers, Benjamin ___ wayland-devel mailing list wayland-devel@li

Re: [PATCH v2 libinput 00/26] tablet: support the remaining tools

2015-02-24 Thread Benjamin Tissoires
On Tue, Feb 24, 2015 at 11:16 AM, Benjamin Tissoires wrote: > Hi Peter, > > On Tue, Feb 24, 2015 at 1:21 AM, Peter Hutterer > wrote: >> >> This is a v2 of the patchset here [snipped] > Again, I'll try to review the patches one by one. So, I am starving (lunch tim

Re: [PATCH libinput 23/26] tools: only print the tablet axes we have on the tool

2015-02-24 Thread Benjamin Tissoires
On Tue, Feb 24, 2015 at 1:21 AM, Peter Hutterer wrote: > This doesn't really have an effect, since we don't set the per-tool axes > correctly yet. Actually we do now. :) Cheers, Benjamin > > Signed-off-by: Peter Hutterer > --- > tools/event-debug.c | 106 > +++

Re: [PATCH libinput 18/26] tablet: rely on libwacom to give us the right tablet axes

2015-02-24 Thread Benjamin Tissoires
On Tue, Feb 24, 2015 at 1:21 AM, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer > --- > src/evdev-tablet.c | 50 +- > 1 file changed, 33 insertions(+), 17 deletions(-) > > diff --git a/src/evdev-tablet.c b/src/evdev-tablet.c > index 2b90e08.

Re: [PATCH libinput 16/26] tablet: add support for libinput_tool_has_button

2015-02-24 Thread Benjamin Tissoires
On Tue, Feb 24, 2015 at 1:21 AM, Peter Hutterer wrote: > libwacom can tell us how many buttons we have per stylus, so we map those into > BTN_STYLUS and BTN_STYLUS2. > BTN_TOUCH is set on all styli. > > Signed-off-by: Peter Hutterer > --- > src/evdev-tablet.c | 73 >

Re: [PATCH libinput 15/26] tablet: expand the button mask to allow for BTN_LEFT, RIGHT, MIDDLE

2015-02-24 Thread Benjamin Tissoires
On Tue, Feb 24, 2015 at 1:21 AM, Peter Hutterer wrote: > Expand the mask to fit KEY_CNT buttons, the mouse has LMR buttons and a few > more, trying to squash the range is more error-prone than having the full key > range instead. > > Signed-off-by: Peter Hutterer > --- > src/evdev-tablet.c | 82

Re: [PATCH libinput 11/26] tablet: use libwacom to identify tablets for left-handedness

2015-02-24 Thread Benjamin Tissoires
On Tue, Feb 24, 2015 at 1:21 AM, Peter Hutterer wrote: > A tablet hotplug event is rare and not a time-critical event, so we load the > database on tablet init and throw it away again. > > Signed-off-by: Peter Hutterer > --- > configure.ac | 14 ++ > src/Makefile.am

Re: [PATCH libinput 08/26] tablet: document what the tool type means

2015-02-24 Thread Benjamin Tissoires
On Tue, Feb 24, 2015 at 1:21 AM, Peter Hutterer wrote: > It's a rough guide only, but still precise enough to make some decisions. > > Signed-off-by: Peter Hutterer > --- > src/libinput.h | 32 +++- > 1 file changed, 23 insertions(+), 9 deletions(-) > > diff --git a/s

Re: [PATCH libinput 03/26] test: fix double comparison macros

2015-02-24 Thread Benjamin Tissoires
On Tue, Feb 24, 2015 at 1:21 AM, Peter Hutterer wrote: > args needs to be within () to ensure correct calculation > > Signed-off-by: Peter Hutterer > --- > test/litest.h | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/test/litest.h b/test/litest.h > index 45

Re: [PATCH libinput 00/15] tablet: support the remaining tools

2015-02-18 Thread Benjamin Tissoires
Hi Peter, On Wed, Feb 18, 2015 at 12:45 AM, Peter Hutterer wrote: > > This patchset adds the remaining tools to the tablet branch (at least for > Wacom tools). The notable additions are: > * rotation support for mouse/lens cursor > * rotation support for the artpen > * 'wheel' support for the air

Re: [PATCH libinput] evdev: check the first parent of the event node for ID_INPUT tags

2015-02-17 Thread Benjamin Tissoires
> Signed-off-by: Peter Hutterer > --- Thanks for the patch. Tested-by: Benjamin Tissoires Cheers, Benjamin > src/evdev.c | 19 +-- > 1 file changed, 13 insertions(+), 6 deletions(-) > > diff --git a/src/evdev.c b/src/evdev.c > index 11fa89b..cf21d2e 100

Re: [PATCH v2 libinput 2/3] Add a udev bits to assign LIBINPUT_DEVICE_GROUP

2015-02-12 Thread Benjamin Tissoires
On Tue, Feb 10, 2015 at 8:31 PM, Peter Hutterer wrote: > The easiest way to get a device group is by looking at the phys path of the > input device (which looks like usb-:00:14.0-1/input1) and dropping the > /inputX bit. The rest is the same for devices that belong together. > > Ideally we cou

Re: [PATCH libinput 3/3] Use LIBINPUT_DEVICE_GROUP from udev as group identifier

2015-02-12 Thread Benjamin Tissoires
On Tue, Feb 10, 2015 at 1:50 AM, Peter Hutterer wrote: > From: Benjamin Tissoires > > Store it as identifier in the device group, any two devices that have a > the same non-NULL identifier share the group. > > Signed-off-by: Peter Hutterer > --- This one diverged quit

Re: [PATCH libinput 1/3] tools: print the device group in event-debug

2015-02-12 Thread Benjamin Tissoires
On Tue, Feb 10, 2015 at 1:50 AM, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer > --- Reviewed-by: Benjamin Tissoires > tools/event-debug.c | 15 +-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git a/tools/event-debug.c b/tools/eve

Re: [PATCH libinput] tablet: drop LIBINPUT_TABLET_AXIS_NONE from the API

2015-02-12 Thread Benjamin Tissoires
es adding a MIN (or FIRST/LAST), there is not much we can do. With or without this, the patch is still Reviewed-by: Benjamin Tissoires Cheers, Benjamin > This one is for the tablet-support branch. > > src/evdev-tablet.c | 8 +--- > src/evdev-tablet.h | 8 +-

Re: [PATCH libinput 2/3] Add a rules file to assign LIBINPUT_DEVICE_GROUP

2015-02-10 Thread Benjamin Tissoires
Hi Peter, On Tue, Feb 10, 2015 at 1:50 AM, Peter Hutterer wrote: > Ideally we could just take ATTRS{phys} but we can't select substrings to drop > into ENV so we re-assemble it manually. > > Eventually this will likely end up in a RUN callout, but for now this will do. > > Signed-off-by: Peter Hu

Re: [PATCH libinput 2/2] evdev: switch to using udev's device tagging system

2015-02-06 Thread Benjamin Tissoires
t; Signed-off-by: Peter Hutterer > --- There are tiny differences between how libinput and udev handle the various categories of devices. I think for most of the cases, the result is the same. Anyway, having an external way to assign the type of the device that the users can change is a muc

[PATCH libinput] evdev: retrieve udev tags

2015-02-02 Thread Benjamin Tissoires
instance, the pad part of the Wacom tablets is difficult to discriminate from a joystlick or a pointer. This patch adds a udev_tags field in struct evdev_device and populates it accroding to the current known udev built in tags. Signed-off-by: Benjamin Tissoires --- Hi, I had to rely on the udev tags

Re: [PATCH libinput 0/24] Tablet support

2014-05-22 Thread Benjamin Tissoires
On Thu, May 22, 2014 at 1:17 AM, Chandler Paul wrote: > Hi! Sorry this took so long to write, I've been spending a lot of my > time recently trying to understand the libinput code and all of that > good stuff, and I wanted to make sure I had a decent understanding of it > before I actually wrote u

Re: [PATCH libinput 0/24] Tablet support

2014-04-21 Thread Benjamin Tissoires
Hi Carlos, [Adding a few people to the conversation] I am working a little bit on the wacom.ko kernel driver and I can give you some hints on the oddness around the events. On Mon, Apr 21, 2014 at 1:11 PM, Carlos Garnacho wrote: > Hey there!, > > Here's a few patches to have libinput handle eve

[PATCH libinput] evdev: fix device_transform_ functions

2014-02-17 Thread Benjamin Tissoires
640 which is 7 times bigger than li_fixed_t max. To keep the precision of the sensor, first compute the uniformized coordinate (in range 0 .. 1.0) of the touch point, then multiply it by the screen dimension, and revert it to a li_fixed_t. Signed-off-by: Benjamin Tissoires --- Hi, I have hit t

Re: [PATCH]: mtdev could be disabled at configuration

2013-06-11 Thread Benjamin Tissoires
On Tue, Jun 11, 2013 at 12:40 PM, Pekka Paalanen wrote: > On Tue, 11 Jun 2013 12:10:05 +0200 > Benjamin Tissoires wrote: > >> On Tue, Jun 11, 2013 at 9:41 AM, Pekka Paalanen wrote: >> > On Tue, 11 Jun 2013 09:01:48 +0200 >> > Benjamin Tissoires wrote: >>

Re: [PATCH]: mtdev could be disabled at configuration

2013-06-11 Thread Benjamin Tissoires
On Tue, Jun 11, 2013 at 9:41 AM, Pekka Paalanen wrote: > On Tue, 11 Jun 2013 09:01:48 +0200 > Benjamin Tissoires wrote: > >> On Mon, Jun 10, 2013 at 8:42 AM, Pekka Paalanen wrote: >> > On Fri, 7 Jun 2013 12:11:14 +0200 >> > Marc Chalain wrote: >> > &

Re: [PATCH]: mtdev could be disabled at configuration

2013-06-11 Thread Benjamin Tissoires
On Mon, Jun 10, 2013 at 8:42 AM, Pekka Paalanen wrote: > On Fri, 7 Jun 2013 12:11:14 +0200 > Marc Chalain wrote: > >> mtdev is not necessary on some device (desktop or set-top-box). For >> embedded solution the minimum of dependencies is required. "configure" >> accepts the --disable-mtdev option