[PATCH] clients/nested: fix undefined reference to xzalloc

2016-04-22 Thread U. Artie Eoff
Include shared/xalloc.h in clients/nested.c to fix compilation error: undefined reference to `xzalloc' Signed-off-by: U. Artie Eoff --- clients/nested.c | 1 + 1 file changed, 1 insertion(+) diff --git a/clients/nested.c b/clients/nested.c index e78f08c396f4..72aab151a071 100644 --- a/cl

[PATCH weston] comp-wayland: use safe foreach when destroying outputs

2014-05-21 Thread U. Artie Eoff
wl_list_for_each dereference's output to increment the next iteration of the loop. However, output is free'd inside the loop resulting in a dereference to free'd memory. Use wl_list_for_each_safe instead, which is designed to handle this kind of pattern. Signed-off-by: U. Artie

[PATCH] clients/terminal: check for asprintf error condition instead

2014-05-15 Thread U. Artie Eoff
is > 0, then we miss the 0 condition and leak. asprintf docs don't say much about whether a 0 result can occur when the string passed in is clearly not empty... but better safe than sorry. Signed-off-by: U. Artie Eoff --- clients/terminal.c | 2 +- 1 file changed, 1 insertion(+), 1 dele

[PATCH] text-backend: check calloc results

2014-05-15 Thread U. Artie Eoff
Signed-off-by: U. Artie Eoff --- src/text-backend.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/text-backend.c b/src/text-backend.c index d6a6f3b..362a3fa 100644 --- a/src/text-backend.c +++ b/src/text-backend.c @@ -358,6 +358,8 @@ static void

[PATCH] wcap: clean up resources on mmap or frame alloc failure.

2014-05-14 Thread U. Artie Eoff
these cases introduces a resource leak. Signed-off-by: U. Artie Eoff --- wcap/wcap-decode.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/wcap/wcap-decode.c b/wcap/wcap-decode.c index 76ecc2f..8909982 100644 --- a/wcap/wcap-decode.c +++ b/wcap/wcap-decode.c @@ -128,6 +128,7 @@ wcap_de

[PATCH weston] libinput-seat: literal values for WESTON_LIBINPUT_LOG_PRIORITY

2014-05-09 Thread U. Artie Eoff
Only accept specific literal values from the environment variable WESTON_LIBINPUT_LOG_PRIORITY... "debug", "info", or "error". Signed-off-by: U. Artie Eoff --- src/libinput-seat.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/

[PATCH weston] compositor-wayland: fix leak in create_cursor when theme load fails

2014-05-07 Thread U. Artie Eoff
Free the theme configuration string right after wl_cursor_load_theme since we're done using it. This fixes a leak when the cursor theme could not be loaded. Signed-off-by: U. Artie Eoff --- src/compositor-wayland.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH weston 3/3] compositor-wayland: avoid possible NULL deref in handle_keymap

2014-05-06 Thread U. Artie Eoff
If data is NULL, then we jumped to error which attempts to dereference data. Instead, just close(fd) and return when data is NULL. Signed-off-by: U. Artie Eoff --- src/compositor-wayland.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/compositor-wayland.c b/src

[PATCH weston 2/3] compositor-wayland: assign the correct mode

2014-05-06 Thread U. Artie Eoff
Signed-off-by: U. Artie Eoff --- src/compositor-wayland.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c index 35e99a6..3cd308f 100644 --- a/src/compositor-wayland.c +++ b/src/compositor-wayland.c @@ -1149,7 +1149,7

[PATCH weston 1/3] compositor-wayland: free output before returning

2014-05-06 Thread U. Artie Eoff
Signed-off-by: U. Artie Eoff --- src/compositor-wayland.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c index 67f15be..35e99a6 100644 --- a/src/compositor-wayland.c +++ b/src/compositor-wayland.c @@ -1723,8 +1723,11

[PATCH wayland] server: fix potential memleak and NULL deref

2014-05-05 Thread U. Artie Eoff
ly in the "else if" block (assume it can handle NULL closure, too, which it does right now). Signed-off-by: U. Artie Eoff --- src/wayland-server.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/wayland-server.c b/src/wayland-server.c index f2b1b42..e850d48 10064

[PATCH wayland 2/2] connection-test: check malloc result

2014-05-05 Thread U. Artie Eoff
Signed-off-by: U. Artie Eoff --- tests/connection-test.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/connection-test.c b/tests/connection-test.c index 1213875..659bf68 100644 --- a/tests/connection-test.c +++ b/tests/connection-test.c @@ -516,6 +516,8 @@ TEST

[PATCH wayland 1/2] scanner: check wl_array_add result

2014-05-05 Thread U. Artie Eoff
Signed-off-by: U. Artie Eoff --- src/scanner.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/scanner.c b/src/scanner.c index 622d4d8..dd1c7b6 100644 --- a/src/scanner.c +++ b/src/scanner.c @@ -1039,7 +1039,7 @@ emit_types_forward_declarations(struct protocol *protocol

[PATCH weston] weston-info: fix log message typo

2014-04-18 Thread U. Artie Eoff
Signed-off-by: U. Artie Eoff --- clients/weston-info.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clients/weston-info.c b/clients/weston-info.c index 147dc48..df869e3 100644 --- a/clients/weston-info.c +++ b/clients/weston-info.c @@ -225,7 +225,7 @@ print_output_info

[PATCH weston v2 1/5] libinput-seat: redirect libinput log to weston log

2014-04-17 Thread U. Artie Eoff
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=77578 Signed-off-by: U. Artie Eoff --- src/libinput-seat.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/libinput-seat.c b/src/libinput-seat.c index b6adc76..99612c4 100644 --- a/src/libinput-seat.c +++ b/src/libinput-seat.c

[PATCH weston v2 2/5] libinput-seat: allow setting libinput log priority in weston

2014-04-17 Thread U. Artie Eoff
etected at Weston startup and makes it a little more consistent with Weston's original evdev input setup log messages... and useful for debugging and testing. Signed-off-by: U. Artie Eoff --- src/libinput-seat.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/libinput-seat.c

[PATCH weston v2 0/5] Input bug fixes

2014-04-17 Thread U. Artie Eoff
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=77578 Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=77577 Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=77341 Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=77576 U. Artie Eoff (5): libinput-seat: redirect libinput log to

[PATCH weston v2 5/5] seat: don't break in notify_output_create

2014-04-17 Thread U. Artie Eoff
If more than one input device maps to the new output, then we need to map all devices to that output... not just the first device. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=77576 Signed-off-by: U. Artie Eoff --- src/libinput-seat.c | 1 - src/udev-seat.c | 1 - 2 files changed, 2

[PATCH weston v2 4/5] input: fix input device map to output if it doesn't exist.

2014-04-17 Thread U. Artie Eoff
/show_bug.cgi?id=77341 Signed-off-by: U. Artie Eoff --- src/evdev.c | 5 + src/libinput-device.c | 5 + src/libinput-seat.c | 4 +++- src/udev-seat.c | 4 +++- 4 files changed, 16 insertions(+), 2 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index d9b7d32..bc8e5ef 100644

[PATCH weston v2 3/5] libinput-device: break after LIBINPUT_EVENT_TOUCH_UP

2014-04-17 Thread U. Artie Eoff
We need to break after handling LIBINPUT_EVENT_TOUCH_UP otherwise we fall into the default case and end up logging that the event is unknown and then return the wrong "handled" result. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=77577 Signed-off-by: U. Artie Eoff --- sr

[PATCH weston 1/2] input: fix input device map to output if it doesn't exist.

2014-04-11 Thread U. Artie Eoff
/show_bug.cgi?id=77341 Signed-off-by: U. Artie Eoff --- src/evdev.c | 5 + src/libinput-device.c | 5 + src/libinput-seat.c | 4 +++- src/udev-seat.c | 4 +++- 4 files changed, 16 insertions(+), 2 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index d9b7d32..bc8e5ef 100644

[PATCH weston 2/2] don't break in notify_output_create

2014-04-11 Thread U. Artie Eoff
If more than one input device maps to the new output, then we need to map all devices to that output... not just the first device. Signed-off-by: U. Artie Eoff --- src/libinput-seat.c | 1 - src/udev-seat.c | 1 - 2 files changed, 2 deletions(-) diff --git a/src/libinput-seat.c b/src

[PATCH weston] libinput-device: break after LIBINPUT_EVENT_TOUCH_UP

2014-04-11 Thread U. Artie Eoff
Need to break after handling LIBINPUT_EVENT_TOUCH_UP otherwise we fall into the default case and end up logging that the event is unknown and then return the wrong "handled" value. Signed-off-by: U. Artie Eoff --- src/libinput-device.c | 1 + 1 file changed, 1 insertion(+) diff -

[PATCH libinput] evdev: log configured device info

2014-04-11 Thread U. Artie Eoff
Bring back the device configure logging that was originally part of Weston's evdev. Signed-off-by: U. Artie Eoff --- src/evdev.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index 72e4086..755a3a3 100644 --- a/src/ev

[PATCH] libinput-seat: allow setting libinput log priority in weston

2014-04-11 Thread U. Artie Eoff
Look for WESTON_LIBINPUT_LOG_PRIORITY environment variable. If it exists then use it to set the libinput log priority. Otherwise, don't set the priority and get whatever libinput's default priority is. Signed-off-by: U. Artie Eoff --- src/libinput-seat.c | 7 +++ 1 file

[PATCH weston] libinput-seat: redirect libinput log to weston log

2014-04-11 Thread U. Artie Eoff
Signed-off-by: U. Artie Eoff --- src/libinput-seat.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/libinput-seat.c b/src/libinput-seat.c index b6adc76..99612c4 100644 --- a/src/libinput-seat.c +++ b/src/libinput-seat.c @@ -251,6 +251,13 @@ udev_input_enable(struct udev_input

[PATCH 2/2 v2] tests: add version sanity tests

2014-01-24 Thread U. Artie Eoff
From: "U. Artie Eoff" Test the WESTON_VERSION_AT_LEAST macro with at least 27 permutations of major.minor.micro. That is, all permutations where major, minor, and micro are less-than, more-than, or equal to the current version parts. Signed-off-by: U. Artie Eoff --- tests/M

[PATCH 1/2 v2] version: Fix WESTON_VERSION_AT_LEAST macro

2014-01-24 Thread U. Artie Eoff
From: "U. Artie Eoff" Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=74023 Signed-off-by: U. Artie Eoff --- src/version.h.in | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/version.h.in b/src/version.h.in index 79dba45..e72fea8 100644

[PATCH 2/2] tests: add version sanity tests

2014-01-24 Thread U. Artie Eoff
From: "U. Artie Eoff" Test the WESTON_VERSION_AT_LEAST macro with at least 27 permutations of major.minor.micro. That is, all permutations where major, minor, and micro are less-than, more-than, or equal to the current version parts. Signed-off-by: U. Artie Eoff --- tests/M

[PATCH 1/2] version: Fix WESTON_VERSION_AT_LEAST macro

2014-01-24 Thread U. Artie Eoff
From: "U. Artie Eoff" Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=74023 Signed-off-by: U. Artie Eoff --- src/version.h.in | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/version.h.in b/src/version.h.in index 79dba45..b543963 100644

[PATCH 2/2] udev-seat: break early when output is found and log the mapping

2014-01-10 Thread U. Artie Eoff
When an input device has a WL_OUTPUT udev property specified and that output is found, log it... also break from the loop immediately. Log a warning if the requested output is not found. Signed-off-by: U. Artie Eoff --- src/udev-seat.c | 38 +- 1 file

[PATCH 1/2] drm: prepend stamp space to output mode logging

2014-01-10 Thread U. Artie Eoff
Use the STAMP_SPACE to make the output mode logging a little nicer looking. Signed-off-by: U. Artie Eoff --- src/compositor-drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compositor-drm.c b/src/compositor-drm.c index 136d517..f7d7a8a 100644 --- a/src/compositor

[PATCH] weston-test: schedule repaint after moving surface in test extension

2013-07-09 Thread U. Artie Eoff
From: "U. Artie Eoff" After some discussion with Rob Bradford (robster), we concluded that we need to schedule a compositor repaint in weston-test.c:test_configure_surface(...) to ensure that the moved surface gets a frame callback/repaint. This fixes https://bugs.freedesktop.org/sh

[PATCH] weston-test-runner: die if parent process dies

2013-06-24 Thread U. Artie Eoff
From: "U. Artie Eoff" Weston check client tests are fork-exec'd by the Weston process (via the weston-test.so module). If the Weston process dies, the client test might not quit in all cases. This happened in the subsurface-test described at https://bugs.freedesktop.org/show_b

[PATCH weston] add fullscreen to .gitignore

2013-06-04 Thread U. Artie Eoff
From: "U. Artie Eoff" Signed-off-by: U. Artie Eoff --- clients/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/clients/.gitignore b/clients/.gitignore index f925ce6..94082f8 100644 --- a/clients/.gitignore +++ b/clients/.gitignore @@ -7,6 +7,7 @@ dnd editor eventde

[PATCH wfits] weston-wfits: Allow user to configure the input emulator

2013-06-03 Thread U. Artie Eoff
From: "U. Artie Eoff" The available emulators are "uinput" and "notify". To choose which emulator to use, define the environment variable: WESTON_WFITS_INPUT_EMULATOR equal to the name of the desired emulator before loading the weston-wfits.so module into We

[PATCH weston v2] use _exit instead of exit if client fails to exec

2013-06-03 Thread U. Artie Eoff
From: "U. Artie Eoff" exit() calls atexit() handlers and C++ destructors (e.g. a C++ weston module) which could destroy state that the main process depends on (e.g. ioctl's, tmpfiles, sockets, etc...). If an exec fails, call _exit() instead of exit(). v2: prefer _exit over _Exit

[PATCH weston] use _Exit instead of exit if client fails to exec

2013-06-03 Thread U. Artie Eoff
From: "U. Artie Eoff" exit() calls atexit() handlers and C++ destructors (e.g. a C++ weston module) which could destroy state that the main process depends on (e.g. ioctl's, tmpfiles, sockets, etc...). If an exec fails, call _Exit() instead of exit(). Signed-off-by: U. Artie

[PATCH wayland-fits] gtk+: add fullscreen/unfullscreen test

2013-05-28 Thread U. Artie Eoff
From: "U. Artie Eoff" Signed-off-by: U. Artie Eoff --- src/test/gtk+/Makefile.am| 3 +- src/test/gtk+/test_window_fullscreen.cpp | 184 +++ 2 files changed, 186 insertions(+), 1 deletion(-) create mode 100644 sr

[PATCH weston] fix module_init signature in module tests

2013-05-17 Thread U. Artie Eoff
From: "U. Artie Eoff" surface-global-test and surface-test did not get updated to the new module_init(...) signature when it changed in a50e6e4c500e3080b8df7ec14c7e42741477a423. Thus, they failed to compile. Simply running 'make check' shows the problem. This patch fi

[PATCH weston] tests: add simple installcheck test for the weston sdk

2013-05-13 Thread U. Artie Eoff
From: "U. Artie Eoff" This test should be executed with 'make installcheck' after running 'make install'. It is a simple, basic test that attempts to compile a trivial (and inherently useless) weston sdk module to ensure the exported SDK can be used by consumers.

[PATCH weston] move subsurface-server-protocol.h include out of compositor.h

2013-05-13 Thread U. Artie Eoff
From: "U. Artie Eoff" The subsurface-server-protocol.h header should not be included by any headers that are part of the SDK since it is not exported. Otherwise, SDK consumers will break during compilation. Move this include from compositor.h to compositor.c. Fixes https://bugs.freed

[PATCH web] Add a testing webpage

2013-04-16 Thread U. Artie Eoff
From: "U. Artie Eoff" The testing.html page briefly describes the current Wayland and Weston unit test suites. Other Wayland enabled test suites/methods will be described here, too. Signed-off-by: U. Artie Eoff --- index.html | 3 +- testing.

[PATCH] add notify_motion_absolute for absolute motion devices

2013-03-22 Thread U. Artie Eoff
From: "U. Artie Eoff" Fixes https://bugs.freedesktop.org/show_bug.cgi?id=61997 Signed-off-by: U. Artie Eoff --- src/compositor.c | 29 + src/compositor.h | 7 ++- src/evdev.c | 2 +- 3 files changed, 32 insertions(+), 6 deletions(-) diff -

[PATCH weston-1.0] Move weston-egl-ext.h include to gles2-renderer.c

2013-02-23 Thread U. Artie Eoff
From: "U. Artie Eoff" The weston-egl-ext.h include in compositor.h is not needed. Rather, it is only needed by gles2-renderer.c. This also fixes external module compile error since weston-egl-ext.h is not part of the Weston SDK: weston/compositor.h:39:28: fatal error: weston

[PATCH weston-1.0] sdk: install weston-egl-ext.h included from compositor.h

2013-02-23 Thread U. Artie Eoff
From: "U. Artie Eoff" weston-egl-ext.h is included in compositor.h, therefore needs to be installed with the weston sdk. Signed-off-by: U. Artie Eoff --- src/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Makefile.am b/src/Makefile.am index bea3b5f..d925620 10

[PATCH weston] tests: fix assignment typo, should be comparison

2013-01-29 Thread U. Artie Eoff
From: "U. Artie Eoff" Signed-off-by: U. Artie Eoff --- tests/surface-global-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/surface-global-test.c b/tests/surface-global-test.c index dbb8c8d..5908f60 100644 --- a/tests/surface-global-test.c +++ b/tes

[PATCH wayland-web] efl: update efl build instructions

2012-12-10 Thread U. Artie Eoff
From: "U. Artie Eoff" eet, eina, embryo, evas, and ecore have moved into a single build tree in trunk/efl. Various configure options have changed. Signed-off-by: U. Artie Eoff --- efl.html | 41 ++--- 1 file changed, 6 insertions(+), 35 deletion

[PATCH weston v2 6/6] tests: Convert button-test to new test extension

2012-12-07 Thread U. Artie Eoff
From: "U. Artie Eoff" Fixes https://bugs.freedesktop.org/show_bug.cgi?id=56821 Signed-off-by: U. Artie Eoff --- tests/.gitignore| 1 + tests/Makefile.am | 14 -- tests/button-test.c | 128 +--- 3 files changed, 32 insertio

[PATCH weston v2 5/6] tests: Convert event-test to new test extension

2012-12-07 Thread U. Artie Eoff
From: "U. Artie Eoff" Fixes https://bugs.freedesktop.org/show_bug.cgi?id=56819 Signed-off-by: U. Artie Eoff --- tests/.gitignore | 1 + tests/Makefile.am | 9 +- tests/event-test.c | 527 +++-- 3 files changed, 272 insertio

[PATCH weston v2 4/6] tests: Convert keyboard-test to new test extension

2012-12-07 Thread U. Artie Eoff
From: "U. Artie Eoff" This adds a weston-test-runner for the weston test extension and some weston test client helper methods. Converted keyboard-test to use the new test interface, runner, and helper methods. Fixes https://bugs.freedesktop.org/show_bug.cgi?id=56822 Signed-off-by

[PATCH weston v2 3/6] tests: Allow weston-tests-env to process different test types

2012-12-07 Thread U. Artie Eoff
From: "U. Artie Eoff" The weston-tests-env script needs to be able to handle weston test extension style tests as well as module style tests. Signed-off-by: U. Artie Eoff --- tests/weston-tests-env | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) mode change 100644

[PATCH weston v2 2/6] tests: Rename weston-test to weston-tests-env

2012-12-07 Thread U. Artie Eoff
From: "U. Artie Eoff" Renamed weston-test test environment script to weston-tests-env to avoid ambiguity with weston-test.c (the weston test extension). Signed-off-by: U. Artie Eoff --- tests/Makefile.am | 4 ++-- tests/weston-test | 4 tests/weston-tests-env | 4 +++

[PATCH weston v2 1/6] tests: Define and implement a test protocol extension.

2012-12-07 Thread U. Artie Eoff
From: "U. Artie Eoff" The weston test extension, called weston-test.so, can be loaded from the "modules" configuration option on the command line or in the .ini file. Clients can bind to the "wl_test" interface to interact with the weston test extension.

[PATCH weston v2 0/6] Wayland/Weston Test Extension

2012-12-07 Thread U. Artie Eoff
From: "U. Artie Eoff" Define a relatively generic protocol for a Wayland Test Extension. Provide a Weston implementation and use it in the Weston client tests. Support both module-style and extension-style tests. Addresses bugs: https://bugs.freedesktop.org/show_bug.cgi?id=5

[PATCH weston 9/9] tests: Convert button-test to new test interface

2012-12-04 Thread U. Artie Eoff
From: "U. Artie Eoff" Signed-off-by: U. Artie Eoff --- tests/.gitignore| 1 + tests/Makefile.am | 14 -- tests/button-test.c | 128 +--- 3 files changed, 32 insertions(+), 111 deletions(-) diff --git a/tests/.gitigno

[PATCH weston 7/9] tests: Convert keyboard-test to new test interface

2012-12-04 Thread U. Artie Eoff
From: "U. Artie Eoff" Signed-off-by: U. Artie Eoff --- tests/.gitignore | 1 + tests/Makefile.am | 31 +-- tests/keyboard-test.c | 139 +++--- 3 files changed, 68 insertions(+), 103 deletions(-) diff --git a/tests/.g

[PATCH weston 8/9] tests: Convert event-test to new test interface

2012-12-04 Thread U. Artie Eoff
From: "U. Artie Eoff" Signed-off-by: U. Artie Eoff --- tests/.gitignore | 1 + tests/Makefile.am | 9 +- tests/event-test.c | 527 +++-- 3 files changed, 272 insertions(+), 265 deletions(-) diff --git a/tests/.gitignore b/tests/

[PATCH weston 6/9] tests: Allow weston-tests-env to process different test types

2012-12-04 Thread U. Artie Eoff
From: "U. Artie Eoff" The weston-tests-env script needs to be able to handle weston test extension style tests as well as module style tests. Signed-off-by: U. Artie Eoff --- tests/Makefile.am | 2 +- tests/weston-tests-env | 123 ++

[PATCH weston 5/9] tests: Add weston test client helper methods

2012-12-04 Thread U. Artie Eoff
From: "U. Artie Eoff" Add client boiler plate methods to simplify writing tests that use the weston test extension. Signed-off-by: U. Artie Eoff --- tests/weston-test-client-helper.c | 488 ++ tests/weston-test-client-helper.h | 109

[PATCH weston 3/9] tests: Rename weston-test to weston-tests-env

2012-12-04 Thread U. Artie Eoff
From: "U. Artie Eoff" Renamed weston-test test environment script to weston-tests-env to avoid ambiguity with weston-test.c (the weston test extension). Signed-off-by: U. Artie Eoff --- tests/Makefile.am | 4 ++-- tests/weston-test | 4 tests/weston-tests-env | 4 +++

[PATCH weston 4/9] tests: Add weston-test-runner for weston test extension tests

2012-12-04 Thread U. Artie Eoff
From: "U. Artie Eoff" Wayland's test-runner uses a forking method to run each test in its own address space. This technique works well, thus, do the same technique for Weston test extension tests. Signed-off-by: U. Artie Eoff --- tests/weston-test

[PATCH weston 2/9] tests: Implement test protocol as a weston plugin extension.

2012-12-04 Thread U. Artie Eoff
From: "U. Artie Eoff" The weston test extension, called weston-test.so, can be loaded from the "modules" configuration option on the command line or in the .ini file. Clients can bind to the "wl_test" interface to interact with the weston test extension.

[PATCH weston 1/9] Add test protocol definition

2012-12-04 Thread U. Artie Eoff
From: "U. Artie Eoff" Signed-off-by: U. Artie Eoff --- protocol/Makefile.am | 3 ++- protocol/wayland-test.xml | 55 +++ tests/.gitignore | 3 +++ tests/Makefile.am | 9 4 files changed, 69 insertions(+),

[PATCH] desktop-shell: destroy data before exiting.

2012-10-02 Thread U. Artie Eoff
From: "U. Artie Eoff" desktop-shell never returned from display_run() since it was essentially killed when weston exited. To fix this, it is necessary to watch for EPOLLHUP in window.c so that toytoolkit clients will return from display_run() when weston quits. This allows for client

[PATCH] tests: add keyboard test

2012-10-01 Thread U. Artie Eoff
From: "U. Artie Eoff" Signed-off-by: U. Artie Eoff --- tests/Makefile.am | 3 +- tests/keyboard-test.c | 124 ++ tests/test-client.c | 32 - 3 files changed, 157 insertions(+), 2 deletions(-) create mode 10

[PATCH 3/3] tests: add button test

2012-09-28 Thread U. Artie Eoff
From: "U. Artie Eoff" Signed-off-by: U. Artie Eoff --- tests/Makefile.am | 4 +- tests/button-test.c | 138 tests/test-client.c | 15 ++ 3 files changed, 156 insertions(+), 1 deletion(-) create mode 100644 tests/button-te

[PATCH 2/3] tests: test surface to/from global functions

2012-09-28 Thread U. Artie Eoff
From: "U. Artie Eoff" Signed-off-by: U. Artie Eoff --- tests/Makefile.am | 5 +++- tests/surface-global-test.c | 65 + 2 files changed, 69 insertions(+), 1 deletion(-) create mode 100644 tests/surface-global-test.c diff --g

[PATCH 1/3] event-test: more aggressive event testing

2012-09-28 Thread U. Artie Eoff
From: "U. Artie Eoff" Test surface pointer enter/leave/motion and surface leave/enter events more aggressively. Signed-off-by: U. Artie Eoff --- tests/event-test.c | 302 tests/test-client.c | 71 ++-- tests/test-runn

[PATCH 0/3] tests: more event tests and such...

2012-09-28 Thread U. Artie Eoff
From: "U. Artie Eoff" Add more tests to cover pointer move/enter/leave/button and surface enter/leave events. Add tests to exercise surface to/from global functions. This patch series is a resubmit of the following patches to address coding convention feedback received from Krist

[PATCH] tests: add button test

2012-09-26 Thread U. Artie Eoff
From: "U. Artie Eoff" Signed-off-by: U. Artie Eoff --- tests/Makefile.am | 4 +- tests/button-test.c | 136 tests/test-client.c | 18 ++- 3 files changed, 156 insertions(+), 2 deletions(-) create mode 100644 tests/but

[PATCH] tests: test surface to/from global functions

2012-09-25 Thread U. Artie Eoff
From: "U. Artie Eoff" Signed-off-by: U. Artie Eoff --- tests/Makefile.am | 5 +++- tests/surface-global-test.c | 65 + 2 files changed, 69 insertions(+), 1 deletion(-) create mode 100644 tests/surface-global-test.c diff --g

[PATCH v2] event-test: more aggressive event testing

2012-09-25 Thread U. Artie Eoff
From: "U. Artie Eoff" Test surface pointer enter/leave/motion and surface leave/enter events more aggressively. Signed-off-by: U. Artie Eoff --- tests/event-test.c | 269 tests/test-client.c | 60 ++-- tests/test-runn

[PATCH] event-test: more aggressive event testing

2012-09-24 Thread U. Artie Eoff
From: "U. Artie Eoff" Test surface pointer enter/leave/motion and surface leave/enter events more aggressively. Depends on: http://lists.freedesktop.org/archives/wayland-devel/2012-September/005224.html Signed-off-by: U. Artie Eoff --- tests/event-tes

[PATCH] test-client: initialize input instance.

2012-09-04 Thread U. Artie Eoff
From: "U. Artie Eoff" In seat_handle_capabilities, if input->pointer is not properly initialized, then it will contain an arbitrary value and results in the wl_pointer listener not getting registered if that value is not 0/null. Thus, use calloc to initialize the "input"

[PATCH] test-text-client: fix compile error

2012-09-04 Thread U. Artie Eoff
From: "U. Artie Eoff" Pass surface to text_model_factory_create_text_model. Fixes https://bugs.freedesktop.org/show_bug.cgi?id=54502 Signed-off-by: U. Artie Eoff --- tests/test-text-client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test-text-client

[PATCH 2/2] tests: ensure sanity leak check tests pass when leak checks are disabled.

2012-08-16 Thread U. Artie Eoff
From: "U. Artie Eoff" This finalizes Robert Bradfords patch to allow NO_ASSERT_LEAK_CHECK environment variable to disable leak checks in unit tests. Signed-off-by: U. Artie Eoff --- tests/sanity-test.c | 8 tests/test-runner.c | 6 +- 2 files changed, 13 insertions(+),

[PATCH 1/2] tests: Allow disabling leak checking assertions by env

2012-08-16 Thread U. Artie Eoff
From: Rob Bradford Some code coverage tools trigger these assertions when run against the test suite since they don't free all their memory. --- tests/test-runner.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/test-runner.c b/tests/test-runner.c index 63ce384..

[PATCH wayland] test: remove memory leak checks

2012-08-08 Thread U. Artie Eoff
From: "U. Artie Eoff" Wrapping dynamic memory functions (malloc, realloc, free, calloc) can be problematic, for instance, when instrumenting code with coverage hooks. In general, the community consensus is to avoid writing your own memory leak checking and to use an existing to

[PATCH v2, rebase] wayland: Add --with-tests-environment option to configure

2012-05-14 Thread U. Artie Eoff
From: "U. Artie Eoff" The --with-tests-environment allows one to specify a custom tests environment script. This is useful for customizing and/or normalizing test result output to whatever format necessary (e.g. xml). Signed-off-by: U. Artie Eoff --- configure.ac |7

[PATCH wayland] wayland: Add --with-tests-environment option to configure

2012-05-04 Thread U. Artie Eoff
From: "U. Artie Eoff" The --with-tests-environment allows one to specify a custom tests environment script. This is useful for customizing and/or normalizing test result output to whatever format necessary (e.g. xml). Signed-off-by: U. Artie Eoff --- configure.ac |7

[PATCH weston] Add --with-tests-environment option to configure

2012-05-04 Thread U. Artie Eoff
From: "U. Artie Eoff" The --with-tests-environment allows one to specify a custom tests environment script. This is useful for customizing and/or normalizing test result output to whatever format necessary (e.g. xml). Signed-off-by: U. Artie Eoff --- configure.ac |7

[PATCH v2] Add simple memory leak check to all tests.

2012-03-23 Thread U. Artie Eoff
From: "U. Artie Eoff" Wrap all tests with a memory balance check to detect potential memory leaks. Fixed a few tests that had memory leaks contained in the tests themselves. Signed-off-by: U. Artie Eoff --- tests/Makefile.am |2 +- tests/array-test.c |2 ++ tests/

[PATCH] Add simple memory leak check to all tests.

2012-03-23 Thread U. Artie Eoff
From: "U. Artie Eoff" Wrap all tests with a memory balance check to detect potential memory leaks. Fixed a few tests that had memory leaks contained in the tests themselves. Signed-off-by: U. Artie Eoff --- tests/Makefile.am |2 +- tests/array-test.c |2 ++ tests/

[PATCH] Resubmit - Add simple memory leak check to all tests

2012-03-23 Thread U. Artie Eoff
From: "U. Artie Eoff" Resubmitting patch to fix some coding style issues... U. Artie Eoff (1): Add simple memory leak check to all tests. tests/Makefile.am |2 +- tests/array-test.c |2 ++ tests/map-test.c|2 ++ tests/test-runne

[PATCH] Add simple memory leak check to all tests.

2012-03-22 Thread U. Artie Eoff
From: "U. Artie Eoff" Wrap all test cases with a memory balance check to detect potential memory leaks. Fixed a few tests that had memory leaks contained in the test themselves. Signed-off-by: U. Artie Eoff --- tests/Makefile.am |2 +- tests/array-test.c |1 + tests/

[PATCH 3/3] Add copyright to test files

2012-02-29 Thread U. Artie Eoff
From: "U. Artie Eoff" Signed-off-by: U. Artie Eoff --- tests/check-wayland-util.c | 24 +++- tests/wayland-check.h | 22 ++ 2 files changed, 45 insertions(+), 1 deletions(-) diff --git a/tests/check-wayland-util.c b/tests/check-wayl

[PATCH 2/3] Add initial unit tests and unit test framework.

2012-02-29 Thread U. Artie Eoff
From: "U. Artie Eoff" Add tests directory and makefiles to the toolchain configuration. Created first unit tests for wayland-util. Unit tests can be executed with the command 'make check'. Signed-off-by: U. Artie Eoff --- Makefile.am|

[PATCH 1/3] Add dependency checking for the check module.

2012-02-29 Thread U. Artie Eoff
From: "U. Artie Eoff" Check is a unit testing framework for C (http://check.sourceforge.net/) and will be used for writing wayland unit tests. Signed-off-by: U. Artie Eoff --- configure.ac |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/configure.ac b/co

[PATCH 0/3] Resubmit - Unit test framework for Wayland

2012-02-29 Thread U. Artie Eoff
From: "U. Artie Eoff" Resubmitting since some recent tip commits cause previous patches to not apply properly. The following patches should apply to today's tip. I've included the contents of my original cover-letter for convenience... Unit testing is a very powerful met

[PATCH 3/3] Add copyright to test files

2012-02-29 Thread U. Artie Eoff
From: "U. Artie Eoff" Signed-off-by: U. Artie Eoff --- tests/check-wayland-util.c | 24 +++- tests/wayland-check.h | 22 ++ 2 files changed, 45 insertions(+), 1 deletions(-) diff --git a/tests/check-wayland-util.c b/tests/check-wayl

[PATCH 2/3] Add initial unit tests and unit test framework.

2012-02-29 Thread U. Artie Eoff
From: "U. Artie Eoff" Add tests directory and makefiles to the toolchain configuration. Created first unit tests for wayland-util. Unit tests can be executed with the command 'make check'. Signed-off-by: U. Artie Eoff --- Makefile.am|

[PATCH 1/3] Add dependency checking for the check module.

2012-02-29 Thread U. Artie Eoff
From: "U. Artie Eoff" Check is a unit testing framework for C (http://check.sourceforge.net/) and will be used for writing wayland unit tests. Signed-off-by: U. Artie Eoff --- configure.ac |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/configure.ac b/co

[PATCH 0/3] Unit test framework for Wayland

2012-02-29 Thread U. Artie Eoff
From: "U. Artie Eoff" Unit testing is a very powerful method to find problems early on in the development cycle. It allows us to test individual parts for correctness and logic. It also serves as a form of regression testing. Ideally, we would like to write test cases for all fun