Re: [PATCH/RFC] Scanner for tests

2013-12-03 Thread Marek Ch
On 3 December 2013 11:57, Pekka Paalanen wrote: > On Tue, 3 Dec 2013 11:40:19 +0100 > Marek Ch wrote: > > > Also, the UNIT_TEST define (or it's renamed alternative) have to be > > defined in both > > src/Makefile.am and tests/Makefile.am. Wouldn't it be better to > > handle this define > > via c

Re: [PATCH/RFC] Scanner for tests

2013-12-03 Thread Pekka Paalanen
On Tue, 3 Dec 2013 11:40:19 +0100 Marek Ch wrote: > Also, the UNIT_TEST define (or it's renamed alternative) have to be > defined in both > src/Makefile.am and tests/Makefile.am. Wouldn't it be better to > handle this define > via configure.ac in this case? No, because UNIT_TEST must not be defi

Re: [PATCH/RFC] Scanner for tests

2013-12-03 Thread Marek Ch
I would propose WL_PRIVATE, because it's logical to me to store the declarations into wayland-private.h (it has been already used - or even created - for this purpose). Moreover it states that the function is private (static) in the terms of Wayland. Also, the UNIT_TEST define (or it's renamed alt

Re: [PATCH/RFC] Scanner for tests

2013-12-02 Thread Bryce W. Harrington
On Fri, Nov 29, 2013 at 04:36:56PM +0200, Pekka Paalanen wrote: > On Fri, 29 Nov 2013 14:52:30 +0100 > Marek Ch wrote: > > > > > Hi! > > > > I was looking into wayland's code and I saw static wl_buffer_* > > functions and I thought: These would use a test.. But how to do it > > when they are st

Re: [PATCH/RFC] Scanner for tests

2013-11-29 Thread Marek Ch
Thanks! I'll look at that :) Marek Ch On 29 November 2013 15:36, Pekka Paalanen wrote: > On Fri, 29 Nov 2013 14:52:30 +0100 > Marek Ch wrote: > > > > > Hi! > > > > I was looking into wayland's code and I saw static wl_buffer_* > > functions and I thought: These would use a test.. But how to d

Re: [PATCH/RFC] Scanner for tests

2013-11-29 Thread Pekka Paalanen
On Fri, 29 Nov 2013 14:52:30 +0100 Marek Ch wrote: > > Hi! > > I was looking into wayland's code and I saw static wl_buffer_* > functions and I thought: These would use a test.. But how to do it > when they are static? I can take the code and copy it into test > manually, but that is not good.

[PATCH/RFC] Scanner for tests

2013-11-29 Thread Marek Ch
Hi! I was looking into wayland's code and I saw static wl_buffer_* functions and I thought: These would use a test.. But how to do it when they are static? I can take the code and copy it into test manually, but that is not good. The code can change.. I solved it by writting simple scanner that