Re: [PATCH weston v3] drm: port the drm backend to the new init api

On Tue, 24 Nov 2015 16:31:42 +0200 Giulio Camuffo wrote: > 2015-11-20 11:38 GMT+02:00 Quentin Glidic : > > For now, I will just comment on the part I am not too happy with. > > > > On 31/10/2015 12:08, Giulio Camuffo wrote: > >> > >>

Re: [PATCH weston v3] drm: port the drm backend to the new init api

On Mon, 8 Feb 2016 16:01:13 -0800 Bill Spitzak wrote: > I thought the purpose of this was so that compositors could pass to the > backend DRM configuration data supplied by the clients, therefore the api > that clients use to pass this information seemed pretty important. No,

Re: [PATCH weston v3] drm: port the drm backend to the new init api

On 9 February 2016 at 00:01, Bill Spitzak wrote: > I thought the purpose of this was so that compositors could pass to the > backend DRM configuration data supplied by the clients, therefore the api > that clients use to pass this information seemed pretty important. If you

Re: [PATCH weston v3] drm: port the drm backend to the new init api

I thought the purpose of this was so that compositors could pass to the backend DRM configuration data supplied by the clients, therefore the api that clients use to pass this information seemed pretty important. On Mon, Feb 8, 2016 at 1:53 PM, Daniel Stone wrote: > On

Re: [PATCH weston v3] drm: port the drm backend to the new init api

On Mon, Feb 8, 2016 at 2:02 AM, Pekka Paalanen wrote: > On Fri, 5 Feb 2016 21:03:20 +0100 > Benoit Gschwind wrote: > > > Hello, > > > > I will add my opinion as called for opinions. First I made a quick > > brainstorm following previous proposals about

Re: [PATCH weston v3] drm: port the drm backend to the new init api

On Tue, 9 Feb 2016 01:11:48 +0100 Benoit Gschwind wrote: > Hello, > > while I developing the option 2. I raise few questions because this > option explicit the fact that back-ends does not share the same API (at > less for the configuration). To resolve the issue I found

Re: [PATCH weston v3] drm: port the drm backend to the new init api

Le 09/02/2016 11:38, Pekka Paalanen a écrit : On Tue, 9 Feb 2016 01:11:48 +0100 Benoit Gschwind wrote: Hello, while I developing the option 2. I raise few questions because this option explicit the fact that back-ends does not share the same API (at less for the

Re: [PATCH weston v3] drm: port the drm backend to the new init api

On Fri, 5 Feb 2016 21:03:20 +0100 Benoit Gschwind wrote: > Hello, > > I will add my opinion as called for opinions. First I made a quick > brainstorm following previous proposals about solutions available. I see > 3 mains choice: Hi, thanks for looking into this. > 1.

Re: [PATCH weston v3] drm: port the drm backend to the new init api

On Monday, 8 February 2016, Bill Spitzak wrote: > On Mon, Feb 8, 2016 at 2:02 AM, Pekka Paalanen > wrote: > >> On Fri, 5 Feb 2016 21:03:20 +0100 >> Benoit Gschwind >

Re: [PATCH weston v3] drm: port the drm backend to the new init api

Hello, while I developing the option 2. I raise few questions because this option explicit the fact that back-ends does not share the same API (at less for the configuration). To resolve the issue I found the following options: 1. find a common configuration API (use key/value) 2. have

Re: [PATCH weston v3] drm: port the drm backend to the new init api

Hello, I will add my opinion as called for opinions. First I made a quick brainstorm following previous proposals about solutions available. I see 3 mains choice: 1. a structure that user fill and pass to the back end; 2. an opaque structure that the user fill through helper function; 3. a

Re: [PATCH weston v3] drm: port the drm backend to the new init api

On Fri, 11 Dec 2015 17:49:57 +0200 Giulio Camuffo wrote: > 2015-12-11 17:31 GMT+02:00 Pekka Paalanen : > > On Wed, 9 Dec 2015 19:08:58 +0200 > > Giulio Camuffo wrote: > > > >> 2015-12-09 18:58 GMT+02:00 Daniel Stone

Re: [PATCH weston v3] drm: port the drm backend to the new init api

On Wed, 9 Dec 2015 19:08:58 +0200 Giulio Camuffo wrote: > 2015-12-09 18:58 GMT+02:00 Daniel Stone : > > Hi, > > > > On 9 December 2015 at 16:29, Giulio Camuffo > > wrote: > >> +enum weston_drm_backend_output_mode { > >>

[PATCH weston v3] drm: port the drm backend to the new init api

Reviewed-by: Quentin Glidic --- v3: - move the modeline parsing back in the drm code, so that compositors can rely on that instead of having to duplicate the parsing code. - add documentation in compositor-drm.h Makefile.am | 3 +

Re: [PATCH weston v3] drm: port the drm backend to the new init api

I forgot to mention, this requires a revert of 5ffbfffaf7758c33791978516d0a1100773b85e2. -- Giulio 2015-12-09 18:29 GMT+02:00 Giulio Camuffo : > Reviewed-by: Quentin Glidic > --- > > v3: - move the modeline parsing back in the drm code, so

Re: [PATCH weston v3] drm: port the drm backend to the new init api

2015-12-09 18:58 GMT+02:00 Daniel Stone : > Hi, > > On 9 December 2015 at 16:29, Giulio Camuffo wrote: >> +enum weston_drm_backend_output_mode { >> + /** The output is disabled */ >> + WESTON_DRM_BACKEND_OUTPUT_OFF, >> + /** The

Re: [PATCH weston v3] drm: port the drm backend to the new init api

Hi, On 9 December 2015 at 16:29, Giulio Camuffo wrote: > +enum weston_drm_backend_output_mode { > + /** The output is disabled */ > + WESTON_DRM_BACKEND_OUTPUT_OFF, > + /** The output will use the current active mode */ > +

Re: [PATCH weston v3] drm: port the drm backend to the new init api

2015-11-20 11:38 GMT+02:00 Quentin Glidic : > For now, I will just comment on the part I am not too happy with. > > On 31/10/2015 12:08, Giulio Camuffo wrote: >> >> [snip] >> >> diff --git a/src/main.c b/src/main.c >> index 292f8e0..bde27ee 100644 >> ---

Re: [PATCH weston v3] drm: port the drm backend to the new init api

For now, I will just comment on the part I am not too happy with. On 31/10/2015 12:08, Giulio Camuffo wrote: [snip] diff --git a/src/main.c b/src/main.c index 292f8e0..bde27ee 100644 --- a/src/main.c +++ b/src/main.c @@ -47,6 +47,8 @@ #include "git-version.h" #include "version.h" +#include

[PATCH weston v3] drm: port the drm backend to the new init api

--- v3: fixed warning after rebase Makefile.am | 3 + src/compositor-drm.c | 234 --- src/compositor-drm.h | 87 +++ src/main.c | 129 +++- 4 files changed, 292 insertions(+), 161