Re: [PATCH wayland 1/2] scanner: refactor creating objects and get rid of leaks

2015-07-22 Thread Derek Foreman
On 22/07/15 02:25 AM, Marek Chalupa wrote: Thanks for review, On 07/17/2015 11:02 PM, Derek Foreman wrote: On 16/07/15 06:59 AM, Marek Chalupa wrote: Create functions for structures allocation (instead of inlining it into the code) and free the objects after we don't use them anymore.

Re: [PATCH wayland 1/2] scanner: refactor creating objects and get rid of leaks

2015-07-22 Thread Marek Chalupa
Thanks for review, On 07/17/2015 11:02 PM, Derek Foreman wrote: On 16/07/15 06:59 AM, Marek Chalupa wrote: Create functions for structures allocation (instead of inlining it into the code) and free the objects after we don't use them anymore. Signed-off-by: Marek Chalupa mchqwe...@gmail.com

Re: [PATCH wayland 1/2] scanner: refactor creating objects and get rid of leaks

2015-07-22 Thread Marek Chalupa
On 07/22/2015 07:43 PM, Derek Foreman wrote: On 22/07/15 02:25 AM, Marek Chalupa wrote: Thanks for review, On 07/17/2015 11:02 PM, Derek Foreman wrote: On 16/07/15 06:59 AM, Marek Chalupa wrote: Create functions for structures allocation (instead of inlining it into the code) and free the

Re: [PATCH wayland 1/2] scanner: refactor creating objects and get rid of leaks

2015-07-17 Thread Derek Foreman
On 16/07/15 06:59 AM, Marek Chalupa wrote: Create functions for structures allocation (instead of inlining it into the code) and free the objects after we don't use them anymore. Signed-off-by: Marek Chalupa mchqwe...@gmail.com I think this is quite nice, but I'd like to see the leak fixes