Re: [webkit-dev] policyBaseURL and mainDocumentURL

2009-05-22 Thread Adam Barth
On Thu, May 21, 2009 at 1:39 PM, Adam Barth wrote: > If it's really the same thing, maybe we should call it > firstPartyURLForCookies.  :) For those of you following along at home, the cleanup is happening in https://bugs.webkit.org/show_bug.cgi?id=25955 Adam

Re: [webkit-dev] Review Queue

2009-05-22 Thread Eric Seidel
Update: We're down to 74 patches now. Thanks especially to Maciej for all his reviewing this evening: curl -s "https://bugs.webkit.org/request.cgi"; | grep PDT | wc -l] 74 Still a long way to go. -eric On Fri, May 22, 2009 at 12:27 PM, Eric Seidel wrote: > Our review process seems to be fail

Re: [webkit-dev] Review Queue

2009-05-22 Thread Maciej Stachowiak
On May 22, 2009, at 2:19 AM, Eric Seidel wrote: Update: We're down to 74 patches now. Thanks especially to Maciej for all his reviewing this evening: curl -s "https://bugs.webkit.org/request.cgi"; | grep PDT | wc -l] 74 Still a long way to go. FWIW I prefer this query, which counts by bug

Re: [webkit-dev] Review Queue

2009-05-22 Thread Nikolas Zimmermann
Am 22.05.2009 um 06:41 schrieb Maciej Stachowiak: On May 21, 2009, at 9:18 PM, Ojan Vafai wrote: It makes no sense to me to r- a patch because reviewers don't have time to review it. It put incentive in the wrong place. There are other solutions to this problem that put incentive in the r

Re: [webkit-dev] Review Queue

2009-05-22 Thread Gustavo Noronha
On Thu, 2009-05-21 at 21:41 -0700, Maciej Stachowiak wrote: > I discussed the review backlog with Mark Rowe earlier, and we came up > with another idea that may help. This would be to categorize the > review queues. Perhaps we could get bugzilla to show a separate review > queue per component. So

Re: [webkit-dev] Review Queue

2009-05-22 Thread Eric Seidel
Reviewed more before bed. We're down to: https://bugs.webkit.org/buglist.cgi?field0-0-0=flagtypes.name&type0-0-0=equals&value0-0-0=review%3F 50 and curl -s "https://bugs.webkit.org/request.cgi"; | grep PDT | wc -l 61 respectively. Still awful, but much much better than yesterday. -eric On F

Re: [webkit-dev] Webkit JavaScript question

2009-05-22 Thread Lucius Fox
Thanks. Can you please help me understand why SquirellFish needs to generate squirellFish byte code first before compile it to machine code? For v8, it "compiles JavaScript source code directly into machine code when it is first executed. There are no intermediate byte codes, no interpreter." htt

[webkit-dev] Webkit profiling on MacOS

2009-05-22 Thread Meryl Silverburgh
Hi, Does Webkit have profiling build in on MacOS? e.g. For each page, I would like to know how much time is spent on html parsing, css parsing, javascript executing? And does Webkit work with Valgrind on MacOS? Or it uses other time of profiling tool on MacOS? e.g. for each page, find out the brea

Re: [webkit-dev] Notifications API

2009-05-22 Thread John Gregg
Sure. We have the following plan for how to handle opt-in: - Use of the feature by script, if permission isn't granted to the origin, should throw an exception, not present permissions UI. So your insistent porn site would have no effect on the user. - A dialog box asking for permission should

Re: [webkit-dev] Webkit JavaScript question

2009-05-22 Thread tonikitoo (Antonio Gomes)
> The last step depends on the architecture (supported or not) and C++ > compiler directives. If JIT is enabled (see wtf/Platform.h), it always > generates machine code. Otherwise an interpreter executes the byte code. A > mixed environment (both jit and interpreter) is not yet supported. Are ther

Re: [webkit-dev] Webkit JavaScript question

2009-05-22 Thread Zoltan Herczeg
Hi, Historical reasons. SF byte code had been implemented a year ago than jit. SF byte code (interpreter) will never go away, since not all devices support jit, and it is easier to generate JIT code from SF byte code than from Abstract Syntax Tree. Perhaps the authors can tell you more about this

[webkit-dev] Webkit Rendered Image

2009-05-22 Thread webkitUser
Hi, I have modified the WinLauncher application to dump what it has rendered. Basically I have plugged in the "createBitmapContextFromWebView" method from DumpRenderTree Sample, which is supposed to dump a png out of a WebView. However, I see that the resulting png just has a blank image and no

Re: [webkit-dev] Webkit JavaScript question

2009-05-22 Thread Darin Adler
Some of the rationale is in this blog post too . For example: “We also think we can get a lot more speedups out of the JIT through techniques such as type specialization, better register allocation and liveness analysis. [...] by

Re: [webkit-dev] Webkit JavaScript question

2009-05-22 Thread Zoltan Herczeg
Hi, I don't think so. It is not worth to do it on a desktop pc since interpreter is always slower than JIT. However, the story is different for embedded systems, when they enter low-memory mode. We made some experiments before, and it seems possible to switch between jit and interpreter, but I am

Re: [webkit-dev] SharedWorkers alternate design

2009-05-22 Thread Darin Adler
No substantive comment, but a small style comment. On May 21, 2009, at 4:20 PM, Drew Wilson wrote: // Static factory method for getting the correct repository implementation for a given browser static public SharedWorkerRepository* getRepository(); Generally WebKit does not use the verb

Re: [webkit-dev] SharedWorkers alternate design

2009-05-22 Thread Drew Wilson
Thanks - I hadn't realized that about WebKit style. I've updated the interfaces to use different verbs (like "createWorkerProxy()") or omit the verb entirely where appropriate. -atw On Fri, May 22, 2009 at 12:30 PM, Darin Adler wrote: > No substantive comment, but a small style comment. > > On

Re: [webkit-dev] SharedWorkers alternate design

2009-05-22 Thread Kenneth Christiansen
I believe Qt uses instance() in this situation. > Sadly we have not yet found a good verb for the common "get or create" > idiom. Cheers. Kenneth ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit

[webkit-dev] Browser issue with multiple tabulators

2009-05-22 Thread Sebastian Hennebrueder
Hello, I am not sure if this is the right place to ask but I would like to make Safari developer aware of a problem in most web applications. The web is intended to be stateless but web application naturally require stateful behaviour. The option to append the state (for example a shopping c

Re: [webkit-dev] SharedWorkers alternate design

2009-05-22 Thread Drew Wilson
Following up on this, I had a question about the best way to enable the implementation of SharedWorkerRepository to vary for different platforms. I'd like to provide a default WebKit implementation, but on Chromium we'll want to provide an implementation that proxies shared worker operations to the

Re: [webkit-dev] SharedWorkers alternate design

2009-05-22 Thread Peter Kasting
On Fri, May 22, 2009 at 12:30 PM, Darin Adler wrote: > Sadly we have not yet found a good verb for the common "get or create" > idiom. My own code uses "createObjectIfNeeded()" and similar variants. PK ___ webkit-dev mailing list webkit-dev@lists.web

Re: [webkit-dev] Browser issue with multiple tabulators

2009-05-22 Thread Darin Adler
I believe HTML 5’s sessionStorage is intended to resolve this issue. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] SharedWorkers alternate design

2009-05-22 Thread Jeremy Orlow
On Fri, May 22, 2009 at 2:25 PM, Drew Wilson wrote: > Following up on this, I had a question about the best way to enable the > implementation of SharedWorkerRepository to vary for different platforms. > I'd like to provide a default WebKit implementation, but on Chromium we'll > want to provide

Re: [webkit-dev] Browser issue with multiple tabulators

2009-05-22 Thread Jeremy Orlow
This is _exactly_ the use case SessionStorage was developed for. :-) On Fri, May 22, 2009 at 2:41 PM, Darin Adler wrote: > I believe HTML 5’s sessionStorage is intended to resolve this issue. > >-- Darin > > > ___ > webkit-dev mailing list > webki

Re: [webkit-dev] Review Queue

2009-05-22 Thread Eric Seidel
We're down to 30 bugs: https://bugs.webkit.org/buglist.cgi?field0-0-0=flagtypes.name&type0-0-0=equals&value0-0-0=review%3F With 36 patches total: curl -s "https://bugs.webkit.org/request.cgi"; | grep PDT | wc -l 15 of those are Gtk-only bugs. Need some help from the Gtk reviewers on this one. T