Re: [webkit-dev] Ancient patches in pending-review

On Thu, May 13, 2010 at 9:12 AM, Adam Barth wrote: > Editing (Enrica, Ojan) > * 24943: Command-B and Command-I do not generate keydown events in > contentEditable regions. > * 35632: htmlediting.cpp : isEmptyTableCell() is incomplete > * 32605: Regression: Selection anchor + focus swap when arrow

Re: [webkit-dev] Table hit testing

Ohh I see, I was confused about this line in RenderTable: 1138 if (!hasOverflowClip() || overflowClipRect(tx, ty).contains(xPos, yPos)) { It seems that the default case is to visit all the children as hasOverflowClip() is false. Thanks for the explanation David. I will look into optimizing

Re: [webkit-dev] Table hit testing

On May 18, 2010, at 12:52 PM, Fady Samuel wrote: > Hi all, > > I'm looking at table hit testing, and in all the simple test cases I've > tried, it seems to show that RenderTable never has the flag m_hasOverflowClip > set to true. What this means is that all the table's children are ALWAYS > ch

Re: [webkit-dev] Broken test

Filed https://bugs.webkit.org/show_bug.cgi?id=39285 about that last night. On Tue, May 18, 2010 at 10:15 AM, Adam Barth wrote: > The same test is failing on essentially all the bots: > > fast/files/file-reader.html > > http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r59670

[webkit-dev] Table hit testing

Hi all, I'm looking at table hit testing, and in all the simple test cases I've tried, it seems to show that RenderTable never has the flag m_hasOverflowClip set to true. What this means is that all the table's children are ALWAYS checked on all mouse events. For large tables, or pages with many t

Re: [webkit-dev] Broken test

I am investigating it. It seems that some test cases, like testing non-existent and empty files, are not robust enough. I am disable these test cases in this test file and going to land the fix soon. On Tue, May 18, 2010 at 10:15 AM, Adam Barth wrote: > The same test is failing on essentially al

[webkit-dev] Broken test

The same test is failing on essentially all the bots: fast/files/file-reader.html http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r59670%20(10305)/fast/files/file-reader-pretty-diff.html The blame list computed by the bots is as follows: http://trac.webkit.org/changeset/

Re: [webkit-dev] Cr Linux bot Hosed

I kicked it. :DG< On Mon, May 17, 2010 at 11:27 PM, Eric Seidel wrote: > Could someone with access to the Cr-Linux bot give it a kick? > > http://build.webkit.org/builders/Chromium%20Linux%20Release/builds/6703/steps/svn/logs/stdio > > it's filesystem seems to have turned read-only. > > -eric >

Re: [webkit-dev] webkit build error

The mailing list for questions about how to build WebKit is webkit-help, not webkit-dev. Please see . -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webk

Re: [webkit-dev] Pixel test differences between Leopard and Snow Leopard

On Mon, May 17, 2010 at 3:59 PM, Simon Fraser wrote: > On May 17, 2010, at 3:44 PM, James Robinson wrote: > > After this is done it should be possible to run the full layout test suite > with --tolerance=0 on Snow Leopard and have no failures. Assuming this > happens, I would like to switch the d

[webkit-dev] webkit build error

hello,all: Execus me,I am so sorry. who can help me? when I build the webkit, there are some error occurs in my project! why? The errors as follows: 10>Linking... 10>LINK : warning LNK4044: unrecognized option '/dynamicbase'; ignored 10>msvcprt.lib(MSVCP80.dll) : error LNK2005: "public: sta