Re: [webkit-dev] Apple-Mac-Pro-6 is misconfigured

Can we make the master config run something which aborts the slave if the umask is wrong? This of course still doesn't answer the original problem of the layout tests failing strangely on that machine. :) -eric On Mon, Jan 3, 2011 at 10:54 AM, William Siegrist wrote: > On Jan 1, 2011, at 9:20 P

Re: [webkit-dev] git history and the moving to Source

Adam is correct. To elaborate, there are two rename-related flags of interest: 1) When you git log -- foo/bar.cc, you're saying "only show me logs that apply to the path foo/bar.cc". This excludes renames implicitly. The --follow flag indicates that the filename filter should be broadened to in

Re: [webkit-dev] git history and the moving to Source

There's a git option to follow renames. I think it's --follow, but some git experts might know better. Adam On Mon, Jan 3, 2011 at 5:53 PM, Balazs Kelemen wrote: > I have just realized that git log -- filename does not output the > history before the file had been moved to Source. It seems lik

[webkit-dev] git history and the moving to Source

I have just realized that git log -- filename does not output the history before the file had been moved to Source. It seems like the whole git history will be lost after the move. Did we take this into consideration when we decided to switch to the new directory structure? Can we do something to

Re: [webkit-dev] Handling of feature dependencies

On Jan 3, 2011, at 12:53 PM, Konstantin Tokarev wrote: > I'd like to get WebKit running on device with very limited resources. > Basically, it would be quite enough if resulting "browser" just properly > displayed HTML 4 + CSS 2.1, and it would be highly desired to reduce size of > binaries and

Re: [webkit-dev] Handling of feature dependencies

> Here are my thoughts on this subject matter: > > 1) It's bad for the WebKit project to have too many feature flags. All > those ifdefs make the code both harder to read and harder to test. I think we > already have too many and would like to reduce the number. > > 2) It’s bad for the w

Re: [webkit-dev] Support for CSS3 gradients landed; ports will need minor changes

I've filed https://bugs.webkit.org/show_bug.cgi?id=51841 about making the change for Chromium/Skia. Mihai On Mon, Jan 3, 2011 at 11:45 AM, Simon Fraser wrote: > I just landed support for CSS3 gradients (see > ), via >

[webkit-dev] Support for CSS3 gradients landed; ports will need minor changes

I just landed support for CSS3 gradients (see ), via . The spec now allows elliptical gradients. Since some platforms may be able to render elliptical gradients natively, the code relies on the platfo

Re: [webkit-dev] Handling of feature dependencies

On Dec 30, 2010, at 2:37 AM, Konstantin Tokarev wrote: > What is the right way to handle dependencies between features set in time of > configuration? > > For example, I'd like to shrink some functionality ("feature B") in embedded > browser, and therefore add option --[no]-B flag to build-webk

Re: [webkit-dev] Apple-Mac-Pro-6 is misconfigured

On Jan 1, 2011, at 9:20 PM, Eric Seidel wrote: > http://build.webkit.org/builders/Leopard%20Intel%20Debug%20%28Tests%29/builds/25306 > > It's always failign 3 tests: > http://build.webkit.org/results/Leopard%20Intel%20Debug%20(Tests)/r74852%20(25306)/results.html > > Different tests than other b

Re: [webkit-dev] git and svn out of sync?

The git repo should be in sync within a minute after each commit, though there is no transactional guarantee that they are always in sync. If something crashes during the sync, it won't retry until the next svn commit. -Bill On Jan 2, 2011, at 12:36 PM, Robert Hogan wrote: > Looks like this

Re: [webkit-dev] Fixing Qt and Chromium builds

Looks like http://trac.webkit.org/changeset/74899 will fix things. Mihai On Mon, Jan 3, 2011 at 9:56 AM, Mihai Parparita wrote: > I'm Chromium gardener, and I'll take a look at the Chromium compile errors. > > Mihai > > On Mon, Jan 3, 2011 at 9:46 AM, Darin Adler wrote: >> To fix Qt I need to a

Re: [webkit-dev] Fixing Qt and Chromium builds

I'm Chromium gardener, and I'll take a look at the Chromium compile errors. Mihai On Mon, Jan 3, 2011 at 9:46 AM, Darin Adler wrote: > To fix Qt I need to add includes of ExceptionCode.h to two source files. > > To fox Chromium I have to figure out why my code change to not use > defaultChecked

[webkit-dev] Fixing Qt and Chromium builds

To fix Qt I need to add includes of ExceptionCode.h to two source files. To fox Chromium I have to figure out why my code change to not use defaultChecked seems to have been ineffective. I will be able to deal with these in an hour or so. If someone else can do so sooner that would be great. I