Here are some examples of old and new format:
BUGCR24182 SLOW MAC DEBUG : fast/css/large-list-of-rules-crash.html = PASS
BUGCR24182 SLOW LINUX MAC DEBUG :
fast/dom/Window/window-postmessage-clone-really-deep-array.html = PASS
BUGCR24182 SLOW MAC DEBUG :
Oops, some really bad typos.
On Thu, Jun 14, 2012 at 3:10 AM, Ryosuke Niwa rn...@webkit.org wrote:
Beginning of line (current proposal with expectations):
End of line with expectations (current proposal)
WONTFIX SKIP : media/media-captions.html = TIMEOUT
BUGWK43459 WONTFIX :
On Wed, Jun 13, 2012 at 6:53 PM, Dirk Pranke dpra...@chromium.org wrote:
* We'll probably rename IMAGE+TEXT to IMAGE_AND_TEXT.
Can someone please remind me why IMAGE+TEXT even exists?
Wouldn't it be simpler to just mark a test as follows?
- IMAGE : allow image failure; go red if there is
On Thu, Jun 14, 2012 at 1:39 PM, Elliot Poger epo...@chromium.org wrote:
Can someone please remind me why IMAGE+TEXT even exists?
Wouldn't it be simpler to just mark a test as follows?
- IMAGE : allow image failure; go red if there is a text failure
- TEXT: allow text failure; go red
On Thu, Jun 14, 2012 at 1:44 PM, Peter Kasting pkast...@chromium.orgwrote:
On Thu, Jun 14, 2012 at 1:39 PM, Elliot Poger epo...@chromium.org wrote:
Can someone please remind me why IMAGE+TEXT even exists?
Wouldn't it be simpler to just mark a test as follows?
- IMAGE : allow image
On Thu, Jun 14, 2012 at 4:44 PM, Peter Kasting pkast...@chromium.orgwrote:
On Thu, Jun 14, 2012 at 1:39 PM, Elliot Poger epo...@chromium.org wrote:
Can someone please remind me why IMAGE+TEXT even exists?
Wouldn't it be simpler to just mark a test as follows?
- IMAGE : allow image
On Thu, Jun 14, 2012 at 1:44 PM, Peter Kasting pkast...@chromium.org wrote:
On Thu, Jun 14, 2012 at 1:39 PM, Elliot Poger epo...@chromium.org wrote:
Can someone please remind me why IMAGE+TEXT even exists?
Wouldn't it be simpler to just mark a test as follows?
IMAGE : allow image failure;
On Jun 14, 2012, at 1:47 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Thu, Jun 14, 2012 at 1:44 PM, Peter Kasting pkast...@chromium.org wrote:
On Thu, Jun 14, 2012 at 1:39 PM, Elliot Poger epo...@chromium.org wrote:
Can someone please remind me why IMAGE+TEXT even exists?
Wouldn't it be
On Thu, Jun 14, 2012 at 4:22 PM, Maciej Stachowiak m...@apple.com wrote:
On Jun 14, 2012, at 1:47 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Thu, Jun 14, 2012 at 1:44 PM, Peter Kasting pkast...@chromium.org
wrote:
On Thu, Jun 14, 2012 at 1:39 PM, Elliot Poger epo...@chromium.org wrote:
Can
On Thu, Jun 14, 2012 at 4:34 PM, Adam Barth aba...@webkit.org wrote:
I too would like to see us remove TEXT+IMAGE. It's really confusing
to non-experts, and it doesn't scale as we introduce new kinds of
failures (like Audio). Do we really need TEXT+IMAGE+AUDIO,
TEXT+AUDIO, and IMAGE+AUDIO?
On Thu, Jun 14, 2012 at 4:22 PM, Maciej Stachowiak m...@apple.com wrote:
On Jun 14, 2012, at 1:47 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Thu, Jun 14, 2012 at 1:44 PM, Peter Kasting pkast...@chromium.org
wrote:
On Thu, Jun 14, 2012 at 1:39 PM, Elliot Poger epo...@chromium.org wrote:
On Thu, Jun 14, 2012 at 4:34 PM, Adam Barth aba...@webkit.org wrote:
On Thu, Jun 14, 2012 at 4:22 PM, Maciej Stachowiak m...@apple.com wrote:
On Jun 14, 2012, at 1:47 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Thu, Jun 14, 2012 at 1:44 PM, Peter Kasting pkast...@chromium.org
wrote:
On
Hi all,
Because I have infinite patience for bikeshedding, I thought I would
send out Yet Another note on the proposed changes to the expectation
syntax.
Based on the last thread, I'm planning to change ORWT so that it will
recognize the syntax in the TestExpectations files and treat any
On Wed, Jun 13, 2012 at 3:58 PM, Darin Adler da...@apple.com wrote:
On Jun 13, 2012, at 3:53 PM, Dirk Pranke dpra...@chromium.org wrote:
* we use \ (backslash) as a delimiter instead of : and =
Seems worse to me. When I see a backslash I assume it’s a line
continuation character or a C
On Wed, Jun 13, 2012 at 4:12 PM, Benjamin Poulain benja...@webkit.orgwrote:
On Wed, Jun 13, 2012 at 3:53 PM, Dirk Pranke dpra...@chromium.org wrote:
webkit.org/12345 WIN MAC DEBUG \
animations/stop-animation-on-suspend.html \ CRASH TEXT PASS
My bikeshedding:
-In my opinion, the backslash
On Wed, Jun 13, 2012 at 3:58 PM, Darin Adler da...@apple.com wrote:
On Jun 13, 2012, at 3:53 PM, Dirk Pranke dpra...@chromium.org wrote:
* we use \ (backslash) as a delimiter instead of : and =
Seems worse to me. When I see a backslash I assume it’s a line continuation
character or a C
On Wed, Jun 13, 2012 at 4:26 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Wed, Jun 13, 2012 at 4:12 PM, Benjamin Poulain benja...@webkit.org
wrote:
On Wed, Jun 13, 2012 at 3:53 PM, Dirk Pranke dpra...@chromium.org wrote:
webkit.org/12345 WIN MAC DEBUG \
On Wed, Jun 13, 2012 at 4:32 PM, Dirk Pranke dpra...@chromium.org wrote:
On Wed, Jun 13, 2012 at 4:26 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Wed, Jun 13, 2012 at 4:12 PM, Benjamin Poulain benja...@webkit.org
wrote:
On Wed, Jun 13, 2012 at 3:53 PM, Dirk Pranke dpra...@chromium.org
On Wed, Jun 13, 2012 at 4:38 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Wed, Jun 13, 2012 at 4:32 PM, Dirk Pranke dpra...@chromium.org wrote:
On Wed, Jun 13, 2012 at 4:26 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Wed, Jun 13, 2012 at 4:12 PM, Benjamin Poulain benja...@webkit.org
wrote:
On Wed, Jun 13, 2012 at 4:32 PM, Dirk Pranke dpra...@chromium.org wrote:
So something like
webkit.org/12345 [Win Mac Debug] animations/stop-animation-on-suspend.html
[Crash Text Pass]
? I like that!
This seems quite readable to me as well. As mentioned above, I'd be
inclined to make the
As long as we're considering TitleCase for the keywords, could we use it to
keep all of them as single words?
WontFix, SkipCrash, SkipTimeout
--Tom
On Jun 13, 2012, at 4:46 PM, Dirk Pranke wrote:
There's still a distinction between SKIP (temporary) and WONTFIX
(permanent until some plan
Skip and WontFix have a different purpose than Crash and
timeout; the first two (like slow) tell you what to do with the
test, and the latter tell you what you expect the test to result in.
I don't want to combine them into single tokens because that would
cause an explosion of tokens :).
--
On Wed, Jun 13, 2012 at 4:55 PM, Tom Zakrajsek t...@codeaurora.org wrote:
As long as we're considering TitleCase for the keywords, could we use it
to keep all of them as single words?
WontFix, SkipCrash, SkipTimeout
For skipped tests, it doesn't make sense to have crash, timeout, etc...
On Wed, Jun 13, 2012 at 5:05 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Wed, Jun 13, 2012 at 4:55 PM, Tom Zakrajsek t...@codeaurora.org wrote:
As long as we're considering TitleCase for the keywords, could we use it
to keep all of them as single words?
WontFix, SkipCrash, SkipTimeout
For
On Jun 13, 2012, at 3:58 PM, Darin Adler da...@apple.com wrote:
On Jun 13, 2012, at 3:53 PM, Dirk Pranke dpra...@chromium.org wrote:
* we use \ (backslash) as a delimiter instead of : and =
Seems worse to me. When I see a backslash I assume it’s a line continuation
character or a C
On Wed, Jun 13, 2012 at 5:42 PM, Maciej Stachowiak m...@apple.com wrote:
On Jun 13, 2012, at 3:58 PM, Darin Adler da...@apple.com wrote:
On Jun 13, 2012, at 3:53 PM, Dirk Pranke dpra...@chromium.org wrote:
* we use \ (backslash) as a delimiter instead of : and =
Seems worse to me. When I
On Jun 13, 2012, at 4:26 PM, Ryosuke Niwa rn...@webkit.org wrote:
So something like
webkit.org/12345 [Win Mac Debug] animations/stop-animation-on-suspend.html
[Crash Text Pass]
? I like that!
Yes, looks good to me too.
-- Darin
___
webkit-dev
27 matches
Mail list logo