Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1074353 into lp:widelands

2014-07-15 Thread SirVer
Review: Approve -- https://code.launchpad.net/~widelands-dev/widelands/bug-1074353/+merge/221095 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1074353. ___ Mailing list: https://launchpad.net/~widelands-dev Po

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1074353 into lp:widelands

2014-07-15 Thread SirVer
I found a couple of minor bugs and made the testsuite pass again. Great that you wrote tests for all your methods! It made it really easy to find, understand and fix bugs. I merged this now. This is a great contribution and a big chunk of work! Thanks for your persistence with this :). It great

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1074353 into lp:widelands

2014-07-15 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/bug-1074353 into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1074353/+merge/221095 -- https://code.launchpad.net/~widelands-dev/widelands/bug-10

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1074353 into lp:widelands

2014-07-15 Thread SirVer
I adressed the remaining comments in 6926. One question was how to get a object from c++ to Lua. There is a template function to_lua<> for this. Usage is like this: to_lua(L, new L_WareDescription(tribe.get_ware_descr(ware_amount.first))); This generates a L_WareDescription and pushes it at t

Re: [Widelands-dev] [Merge] lp:~hjd/widelands/freebsd-unlink into lp:widelands

2014-07-15 Thread SirVer
unistd.h is a unix only header. So you have to wrap it in a #ifdef. -- https://code.launchpad.net/~hjd/widelands/freebsd-unlink/+merge/226905 Your team Widelands Developers is requested to review the proposed merge of lp:~hjd/widelands/freebsd-unlink into lp:widelands. __

[Widelands-dev] [Merge] lp:~hjd/widelands/freebsd-unlink into lp:widelands

2014-07-15 Thread Hans Joachim Desserud
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/freebsd-unlink into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~hjd/widelands/freebsd-unlink/+merge/226905 Hello again :) So after a bit back and forth, m

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/map_information into lp:widelands

2014-07-15 Thread SirVer
Anyone? -- https://code.launchpad.net/~widelands-dev/widelands/map_information/+merge/226572 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/map_information. ___ Mailing list: https://launchpad.net/~widelands-dev Post

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1322473 into lp:widelands

2014-07-15 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/bug-1322473 into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1322473/+merge/221235 -- https://code.launchpad.net/~widelands-dev/widelands/bug-13

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1322473 into lp:widelands

2014-07-15 Thread SirVer
Review: Approve I looked over this again and fixed some formatting issues, merged trunk, tested real quick and merged. Thanks for taking care of this. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1322473/+merge/221235 Your team Widelands Developers is subscribed to branch lp:~wid

Re: [Widelands-dev] lua / use error

2014-07-15 Thread Holger Rapp
I know what is going on here. A bandaid for you is using —datadir as command line flag. I filed bug https://bugs.launchpad.net/widelands/+bug/1342228 and suggest taking the discussion there. > so I used strace to watch what files it opens and here is the result :) : > > > open("/usr/share/ga

Re: [Widelands-dev] lua / use error

2014-07-15 Thread Tibor Bamhor
so I used strace to watch what files it opens and here is the result :) : open("/usr/share/games/widelands/tribes/atlanteans/scripting/sc00_headquarters_medium.lua", O_RDONLY) = 11 Game data error reading basic info for tribe "atlanteans": [/var/widelands/tibor-ai5/src/scripting/lua_errors.h:29]

Re: [Widelands-dev] lua / use error

2014-07-15 Thread Tibor Bamhor
I have couple of them, one is from package manger and about 2 are compiled. I have it this way for long time and tibor-ai3 (compiled today) works fine, only fresh branch from the trunk complains. 2014-07-15 14:36 GMT+02:00 Holger Rapp : > Probably your --datadir searches for widelands data in th

Re: [Widelands-dev] lua / use error

2014-07-15 Thread Holger Rapp
Probably your --datadir searches for widelands data in the wrong place. Do you have a installed version of widelands somewhere? > Am 15.07.2014 um 12:33 schrieb Fòram na Gàidhlig : > > Try the following instead of the use: > > include "scripting/infrastructure.lua" > > > > 15/07/2014 08:42,

[Widelands-dev] [Merge] lp:~gunchleoc/widelands/mapobject_cleanup into lp:widelands

2014-07-15 Thread GunChleoc
GunChleoc has proposed merging lp:~gunchleoc/widelands/mapobject_cleanup into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1341082 in widelands: "Building help: clean up name, descname" https://bugs.launchpad.net/widelands/+bug/1341082 For more d

Re: [Widelands-dev] lua / use error

2014-07-15 Thread Fòram na Gàidhlig
Try the following instead of the use: include "scripting/infrastructure.lua" 15/07/2014 08:42, sgrìobh Tibor Bamhor: > Hi, > > quick question > > I compiled a trunk from yesterday and when running the game I am getting > this error: > > Game data error > reading basic info for tribe "atlante

[Widelands-dev] [Merge] lp:~hjd/widelands/assert-becomes into lp:widelands

2014-07-15 Thread Hans Joachim Desserud
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/assert-becomes into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~hjd/widelands/assert-becomes/+merge/226797 Fix remaining becomes() which was hidden in an a

[Widelands-dev] lua / use error

2014-07-15 Thread Tibor Bamhor
Hi, quick question I compiled a trunk from yesterday and when running the game I am getting this error: Game data error reading basic info for tribe "atlanteans": [/var/widelands/tibor-ai5/src/scripting/lua_errors.h:29] [string "tribes/atlanteans/scripting/sc00_headquarters..."]:5: attempt to ca