https://bugzilla.wikimedia.org/show_bug.cgi?id=62762
James Forrester changed:
What|Removed |Added
Blocks||72156
--
You are receiving this mai
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762
James Forrester changed:
What|Removed |Added
Blocks||72156
--
You are receiving this mai
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762
James Forrester changed:
What|Removed |Added
Status|PATCH_TO_REVIEW |RESOLVED
Blocks|72156
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762
--- Comment #20 from Gerrit Notification Bot ---
Change 167055 merged by jenkins-bot:
Replace calls to ve.bind( fn, ... ) with fn.bind( ... )
https://gerrit.wikimedia.org/r/167055
--
You are receiving this mail because:
You are on the CC lis
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762
Gerrit Notification Bot changed:
What|Removed |Added
Status|ASSIGNED|PATCH_TO_REVIEW
--
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762
--- Comment #19 from Gerrit Notification Bot ---
Change 167055 had a related patch set uploaded by Alex Monk:
Replace calls to ve.bind( fn, ... ) with fn.bind( ... )
https://gerrit.wikimedia.org/r/167055
--
You are receiving this mail becaus
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762
James Forrester changed:
What|Removed |Added
Status|PATCH_TO_REVIEW |ASSIGNED
Target Milestone|---
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762
--- Comment #18 from Gerrit Notification Bot ---
Change 166155 merged by jenkins-bot:
Replace calls to OO.ui.bind( fn, ... ) with fn.bind( ... )
https://gerrit.wikimedia.org/r/166155
--
You are receiving this mail because:
You are on the CC
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762
--- Comment #17 from Gerrit Notification Bot ---
Change 166155 had a related patch set uploaded by Alex Monk:
Replace calls to OO.ui.bind( fn, ... ) with fn.bind( ... )
https://gerrit.wikimedia.org/r/166155
--
You are receiving this mail bec
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762
Gerrit Notification Bot changed:
What|Removed |Added
Status|ASSIGNED|PATCH_TO_REVIEW
--
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762
--- Comment #16 from James Forrester ---
(In reply to Alex Monk from comment #15)
> (In reply to Krinkle from comment #14)
> > VisualEditor core, and OOjs UI.
>
> Me and Krinkle spoke about this and think it would be a better idea to defer
> t
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762
Alex Monk changed:
What|Removed |Added
Status|PATCH_TO_REVIEW |ASSIGNED
--- Comment #15 from Alex Monk -
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762
--- Comment #14 from Krinkle ---
(In reply to Alex Monk from comment #13)
> (In reply to Krinkle from comment #7)
> > We now have the polyfill for Function.prototype.bind provided by MediaWiki
> > so this should be easier to do now.
>
> Heh.
>
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762
--- Comment #13 from Alex Monk ---
(In reply to Krinkle from comment #7)
> We now have the polyfill for Function.prototype.bind provided by MediaWiki
> so this should be easier to do now.
Heh.
Anyway, is there anything else to do here?
--
Y
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762
--- Comment #12 from Gerrit Notification Bot ---
Change 144840 merged by jenkins-bot:
Replace ve.bind( fn, ... ) calls with fn.bind( ... )
https://gerrit.wikimedia.org/r/144840
--
You are receiving this mail because:
You are on the CC list f
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762
--- Comment #11 from Krinkle ---
(In reply to Krinkle from comment #10)
> Why? How is this different from the other ES5 methods we've been using
> already? VisualEditor nor OOjs UI support ES3 engines afaik.
>
> MediaWiki itself does, and OOjs
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762
--- Comment #10 from Krinkle ---
Why? How is this different from the other ES5 methods we've been using already?
VisualEditor nor OOjs UI support ES3 engines afaik.
MediaWiki itself does, and OOjs core does (for other consumers of OOjs). But w
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762
Ed Sanders changed:
What|Removed |Added
CC||esand...@wikimedia.org
--- Comment #9 fro
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762
Gerrit Notification Bot changed:
What|Removed |Added
Status|ASSIGNED|PATCH_TO_REVIEW
--
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762
--- Comment #8 from Gerrit Notification Bot ---
Change 144840 had a related patch set uploaded by Alex Monk:
Replace ve.bind( fn, ... ) calls with fn.bind( ... )
https://gerrit.wikimedia.org/r/144840
--
You are receiving this mail because:
Y
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762
James Forrester changed:
What|Removed |Added
Assignee|jforrester+veteambztickets@ |kren...@wikimedia.org
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762
--- Comment #7 from Krinkle ---
We now have the polyfill for Function.prototype.bind provided by MediaWiki so
this should be easier to do now. Simply replace all uses of $.proxy(fn..) and
ve.bind(fn) in the modules/ directory with calls to fn.b
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762
James Forrester changed:
What|Removed |Added
Status|NEW |ASSIGNED
--
You are receiving this
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762
Tony Thomas <01tonytho...@gmail.com> changed:
What|Removed |Added
Status|ASSIGNED|NEW
As
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762
--- Comment #5 from James Forrester ---
Ping on this bug again – do you need any support/advice/help?
--
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l maili
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762
--- Comment #4 from Krinkle ---
> (In reply to James Forrester from comment #1)
> > Tony, are you planning to take on this bug?
>
> I plan to. But is there anything like bind() is only present in modern
> browsers ?
Indeed, Function.prototype
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762
--- Comment #3 from Roan Kattouw ---
We don't use $.proxy() directly in the VE code base, instead we set ve.bind =
$.proxy; and use ve.bind().
Yes, this.keyup.bind() exists in modern browsers. It doesn't exist in older
browsers, but we don't r
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762
--- Comment #2 from Tony Thomas <01tonytho...@gmail.com> ---
(In reply to James Forrester from comment #1)
> Tony, are you planning to take on this bug?
I plan to. But is there anything like bind() is only present in modern browsers
?
will rep
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762
James Forrester changed:
What|Removed |Added
Priority|Unprioritized |Low
Status|NEW
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762
Tony Thomas <01tonytho...@gmail.com> changed:
What|Removed |Added
CC||01tonytho...@gmai
30 matches
Mail list logo