gerritbot added a comment.
Change 398815 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Avoid using EntityDiffChangedAspectsFactory like a static constructor
https://gerrit.wikimedia.org/r/398815TASK DETAILhttps://phabricator.wikimedia.org/T113468EMAIL
gerritbot added a comment.
Change 398815 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Wikibase@master] Avoid using EntityDiffChangedAspectsFactory like a static constructor
https://gerrit.wikimedia.org/r/398815TASK
gerritbot added a comment.
Change 394044 merged by Ladsgroup:
[mediawiki/extensions/Wikibase@master] Avoid using EntityDiffChangedAspectsFactory like a static constructor
https://gerrit.wikimedia.org/r/394044TASK DETAILhttps://phabricator.wikimedia.org/T113468EMAIL
daniel added a comment.
excellent!TASK DETAILhttps://phabricator.wikimedia.org/T113468EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, danielCc: Stashbot, Liuxinyu970226, Lucas_Werkmeister_WMDE, Ladsgroup, Addshore, Lydia_Pintscher, thiemowmde,
Ladsgroup added a comment.
MariaDB [testwikidatawiki_p]> select * from wb_changes order by change_id desc limit 1;
gerritbot added a comment.
Change 392053 abandoned by Ladsgroup:
[very WIP][DNM][I don't know what I'm doing] Use EntityDiffChangedAspects
Reason:
Not needed anymore
https://gerrit.wikimedia.org/r/392053TASK DETAILhttps://phabricator.wikimedia.org/T113468EMAIL
Stashbot added a comment.
Mentioned in SAL (#wikimedia-operations) [2017-12-04T14:50:32Z] deployed backward compatibility of entity compact diff transmit T113468TASK DETAILhttps://phabricator.wikimedia.org/T113468EMAIL
gerritbot added a comment.
Change 394999 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@wmf/1.31.0-wmf.10] All the backward compatibility needed for compact diff representation
https://gerrit.wikimedia.org/r/394999TASK DETAILhttps://phabricator.wikimedia.org/T113468EMAIL
gerritbot added a comment.
Change 394999 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/Wikibase@wmf/1.31.0-wmf.10] All the backward compatibility needed for compact diff representation
https://gerrit.wikimedia.org/r/394999TASK
gerritbot added a comment.
Change 393791 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Transmit compact diff instead of suppressed diff
https://gerrit.wikimedia.org/r/393791TASK DETAILhttps://phabricator.wikimedia.org/T113468EMAIL
gerritbot added a comment.
Change 393780 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] All the backward compatibility needed for compact diff representation
https://gerrit.wikimedia.org/r/393780TASK DETAILhttps://phabricator.wikimedia.org/T113468EMAIL
gerritbot added a comment.
Change 394044 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/Wikibase@master] Avoid using EntityDiffChangedAspectsFactory like a static constructor
https://gerrit.wikimedia.org/r/394044TASK
gerritbot added a comment.
Change 393286 abandoned by Ladsgroup:
Transmit compact diff instead of suppressed diff
Reason:
Split now
https://gerrit.wikimedia.org/r/393286TASK DETAILhttps://phabricator.wikimedia.org/T113468EMAIL
gerritbot added a comment.
Change 393791 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/Wikibase@master] Transmit compact diff instead of suppressed diff
https://gerrit.wikimedia.org/r/393791TASK DETAILhttps://phabricator.wikimedia.org/T113468EMAIL
gerritbot added a comment.
Change 393780 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/Wikibase@master] All the backward compatibility needed for compact diff representation
https://gerrit.wikimedia.org/r/393780TASK
gerritbot added a comment.
Change 393286 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/Wikibase@master] Transmit compact diff instead of suppressed diff
https://gerrit.wikimedia.org/r/393286TASK DETAILhttps://phabricator.wikimedia.org/T113468EMAIL
gerritbot added a comment.
Change 392830 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Make AffectedPagesFinder use EntityDiffChangedAspects
https://gerrit.wikimedia.org/r/392830TASK DETAILhttps://phabricator.wikimedia.org/T113468EMAIL
gerritbot added a comment.
Change 392830 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/Wikibase@master] Make AffectedPagesFinder use EntityDiffChangedAspects
https://gerrit.wikimedia.org/r/392830TASK
gerritbot added a comment.
Change 392053 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/Wikibase@master] [very WIP][DNM][I don't know what I'm doing] Use EntityDiffChangedAspects
https://gerrit.wikimedia.org/r/392053TASK
gerritbot added a comment.
Change 391900 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Change handling of sitelinks in EntityDiffChangedAspects
https://gerrit.wikimedia.org/r/391900TASK DETAILhttps://phabricator.wikimedia.org/T113468EMAIL
gerritbot added a comment.
Change 391900 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/Wikibase@master] Change handling of sitelinks in EntityDiffChangedAspects
https://gerrit.wikimedia.org/r/391900TASK
gerritbot added a comment.
Change 384298 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add EntityDiffChangedAspects Factory
https://gerrit.wikimedia.org/r/384298TASK DETAILhttps://phabricator.wikimedia.org/T113468EMAIL
gerritbot added a comment.
Change 384298 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/Wikibase@master] Add EntityDiffChangedAspects Factory
https://gerrit.wikimedia.org/r/384298TASK DETAILhttps://phabricator.wikimedia.org/T113468EMAIL
hoo added a comment.
In T113468#3643791, @daniel wrote:
The proposed structure looks good to me. Documentation should make clear that the fields in the structure correspond to usage aspects, and are thus independent of Entity structure.
They aren't equivalent to client usage aspects (they can
daniel added a comment.
The proposed structure looks good to me. Documentation should make clear that the fields in the structure correspond to usage aspects, and are thus independent of Entity structure.
Note that we have to make sure that we have enough information on the client side to not
hoo added a comment.
I suggest replacing the Diff in DiffChange with a new EntityDiffChangedAspects object. Initially both should be present, but only one should be in the serialized form (EntityChange::getSerializedInfo).
I would introduce a new boolean feature flag which changes which of the
hoo added a subscriber: hoo.
hoo added a comment.
No patch for this, yet… I've misattributed a change.
TASK DETAIL
https://phabricator.wikimedia.org/T113468
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: hoo
Cc: hoo, gerritbot, aude, Aklapper,
gerritbot added a subscriber: gerritbot.
gerritbot added a comment.
Change 270580 had a related patch set uploaded (by Hoo man):
Don't include Fingerprint diffs in wb_changes
https://gerrit.wikimedia.org/r/270580
TASK DETAIL
https://phabricator.wikimedia.org/T113468
EMAIL PREFERENCES
aude added a subscriber: aude.
aude added a comment.
it's not just the diffs that was an issue but also generating the diff by
serializing two versions of the entity before putting in wb_changes.
just an idea... if all we need to know are what 'aspects' a change entails,
maybe these can be
daniel added a comment.
@aude yes, something like that could work. Only for sitelinks we really need to
know the actual change, so we can track the (un-)linking of pages on each
client.
TASK DETAIL
https://phabricator.wikimedia.org/T113468
EMAIL PREFERENCES
30 matches
Mail list logo
