gerritbot added a comment.
Change 450599 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Prevent empty sense glosses in front-end
https://gerrit.wikimedia.org/r/450599TASK DETAILhttps://phabricator.wikimedia.org/T198035EMAIL
gerritbot added a comment.
Change 450599 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Prevent empty sense glosses in front-end
https://gerrit.wikimedia.org/r/450599TASK
Lydia_Pintscher added a comment.
I'm ok either way. Could you check with UX please?TASK DETAILhttps://phabricator.wikimedia.org/T198035EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: gerritbot, Aklapper, Lucas_Werkmeister_WMDE, Addshore,
gerritbot added a comment.
Change 446285 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Addshore):
[mediawiki/extensions/WikibaseLexeme@master] Add ChangeOps for editing senses
https://gerrit.wikimedia.org/r/446285TASK DETAILhttps://phabricator.wikimedia.org/T198035EMAIL
Lucas_Werkmeister_WMDE added a comment.
@Lydia_Pintscher what about graying out the “remove” button of the last gloss instead of graying out the “save” button when the glosses are empty? I’ve implemented that for form representations as an experiment, and it feels more natural to me this way.
Lucas_Werkmeister_WMDE added a comment.
Should the UI also prevent this (disable the “remove” of the last gloss, or disable the “save” button if all glosses are gone), or should there only be a backend error? (Note that for forms, the UI currently doesn’t delete the last representation, according
Addshore added a comment.
In T198035#4314903, @RazShuty wrote:
Similar to the way removing the last representation of a form is not allowed.
Example of that on forms in the current state would be:
F22675019: image.pngTASK DETAILhttps://phabricator.wikimedia.org/T198035EMAIL
RazShuty added a comment.
Similar to the way removing the last representation of a form is not allowed.TASK DETAILhttps://phabricator.wikimedia.org/T198035EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: RazShutyCc: RazShuty, Lydia_Pintscher, Lahi, Gq86,