gerritbot added a comment.
Change 403448 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Move code displaying EntityId on diff pages
https://gerrit.wikimedia.org/r/403448TASK DETAILhttps://phabricator.wikimedia.org/T181077EMAIL
gerritbot added a comment.
Change 403358 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Show EntityId in diff page too
https://gerrit.wikimedia.org/r/403358TASK DETAILhttps://phabricator.wikimedia.org/T181077EMAIL
gerritbot added a comment.
Change 403448 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Wikibase@master] Move code displaying EntityId on diff pages
https://gerrit.wikimedia.org/r/403448TASK
gerritbot added a comment.
Change 403358 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/Wikibase@master] Show EntityId in diff page too
https://gerrit.wikimedia.org/r/403358TASK DETAILhttps://phabricator.wikimedia.org/T181077EMAIL
Lucas_Werkmeister_WMDE added a comment.
Put tags where the "" are and reintroduce them via CSS::after /::before (so no visual change done. but a better code structure)
The element, which seems semantically appropriate here (“short inline quotation”), is actually styled with quotation marks by
Jan_Dittrich added a comment.
It does not look nice, indeed. On the other hand, I assume it was never designed systematically (in the sense of "If we put IDs in the header, where else do we use this element?"). So I would frame it as a bit of (non-wicked) design debt. Like with technical debt, we
Lucas_Werkmeister_WMDE added a comment.
Yeah, it doesn’t look very nice to add the bracketed entity ID to the title in its usual style, IMHO:
F11770105: Screenshot-2017-12-11 Difference between revisions of diff utility - Wikidata.png
Not even if you move it outside the quotation marks:
F11770109:
thiemowmde added a comment.
As a user:
I expect the title of a diff view to be identical to the title of the actual content page. The later shows the entity ID in brackets, but diff views don't.
I want to be able to identify the entity (by ID) when I look at a diff.
Example:
Charlie_WMDE added a comment.
Hey @matej_suchanek
to make the problem more clear to people new to this issue (like me), and for future understanding, it would be helpful to fill out this template:
User Story: As a user, I want to _ so I can _
Context of use: I assume the user
