Re: [urlmon 1/2] Cast-qual warning fix

2007-02-07 Thread Joris Huizer
--- Paul Vriens [EMAIL PROTECTED] wrote: Hi, Fix a warning and remove the now not needed cast. Changelog Cast-qual warning fix Cheers, Paul. diff --git a/dlls/urlmon/umon.c b/dlls/urlmon/umon.c index 49260ab..d593c81 100644 --- a/dlls/urlmon/umon.c +++

msi: Make MsiInstallProduct conformance test depend on proper UI level processing.

2007-02-07 Thread Misha Koshelev
Hi, just wanted to double-check with msi ppl and other wine developers if it's okay to add my conformance test to the test_MsiInstallProduct function. My reasons for doing this versus a completely separate test function are as follows: 1. The test is already testing a full product install

Re: winegcc: sign-compare fixes

2007-02-07 Thread Joris Huizer
I believe this one causes problems -- please do not commit yet Joris Huizer [EMAIL PROTECTED] wrote: - Need Mail bonding? Go to the Yahoo! Mail QA for great tips from Yahoo! Answers users.From 8686a200bd1f1cbd934d761013c487a9ddc195c9 Mon Sep 17 00:00:00 2001

Re: winegcc: sign-compare fixes

2007-02-07 Thread Joris Huizer
Joris Huizer [EMAIL PROTECTED] wrote: I believe this one causes problems -- please do not commit yet Sorry for the spamming - the patch should be alright - Everyone is raving about the all-new Yahoo! Mail beta.

Re: winedump: sign-compare fixes

2007-02-07 Thread Dmitry Timoshkov
Joris Huizer [EMAIL PROTECTED] wrote: -static const MINIDUMP_DIRECTORY* get_mdmp_dir(const MINIDUMP_HEADER* hdr, int str_idx) +static const MINIDUMP_DIRECTORY* get_mdmp_dir(const MINIDUMP_HEADER* hdr,unsigned long int str_idx) Please keep white space unchanged. -while (ptr - (const

Re: msi: Make MsiInstallProduct conformance test depend on proper UI level processing.

2007-02-07 Thread Misha Koshelev
On Wed, 2007-02-07 at 08:33 -0600, Misha Koshelev wrote: Hi, just wanted to double-check with msi ppl and other wine developers if it's okay to add my conformance test to the test_MsiInstallProduct function. My reasons for doing this versus a completely separate test function are as follows:

Re: advapi32: sign-compare fixes

2007-02-07 Thread Vitaliy Margolen
Joris Huizer wrote: - int len = WideCharToMultiByte(CP_ACP, 0, lpNameW, -1, lpName, + unsigned int len = WideCharToMultiByte(CP_ACP, 0, lpNameW, -1, lpName, This isn't right. WideCharToMultiByte returns INT, which is signed. @@ -1995,11 +1995,11 @@ LookupAccountSidW( if (dm) {

Re: msi: Make MsiInstallProduct conformance test depend on proper UI level processing.

2007-02-07 Thread James Hawkins
On 2/7/07, Misha Koshelev [EMAIL PROTECTED] wrote: Hi, here is my proposed patch to the current msi MsiInstallProduct consistency test that will make it's success depend on proper process of UI flags (as well as everything else it depends on to make a successful install). It seems to me like

Re: advapi32: sign-compare fixes

2007-02-07 Thread Joris Huizer
Vitaliy Margolen [EMAIL PROTECTED] wrote: Joris Huizer wrote: - int len = WideCharToMultiByte(CP_ACP, 0, lpNameW, -1, lpName, + unsigned int len = WideCharToMultiByte(CP_ACP, 0, lpNameW, -1, lpName, This isn't right. WideCharToMultiByte returns INT, which is signed. @@ -1995,11 +1995,11 @@

Re: msi: Make MsiInstallProduct conformance test depend on proper UI level processing.

2007-02-07 Thread Misha Koshelev
On Wed, 2007-02-07 at 12:30 -0600, James Hawkins wrote: On 2/7/07, Misha Koshelev [EMAIL PROTECTED] wrote: Hi, here is my proposed patch to the current msi MsiInstallProduct consistency test that will make it's success depend on proper process of UI flags (as well as everything else it

Re: msi: Make MsiInstallProduct conformance test depend on proper UI level processing.

2007-02-07 Thread James Hawkins
On 2/7/07, Misha Koshelev [EMAIL PROTECTED] wrote: On Wed, 2007-02-07 at 12:30 -0600, James Hawkins wrote: On 2/7/07, Misha Koshelev [EMAIL PROTECTED] wrote: Hi, here is my proposed patch to the current msi MsiInstallProduct consistency test that will make it's success depend on proper

Re: msi: Register the typelib

2007-02-07 Thread Alexandre Julliard
Mike McCormack [EMAIL PROTECTED] writes: +ITypeLib *get_msi_typelib( LPWSTR *path ) +{ +static CRITICAL_SECTION cs = { NULL, -1, 0, 0, 0, 0 }; Please use the standard pattern for static critical sections. Setting the debug info to NULL is reserved for global sections. -- Alexandre

Re: [PATCH 3/6] oleaut32: Comment out dual attribute of IKindaEnumWidget in tmarshal test to cause the interface to be marshaled correctly.

2007-02-07 Thread Alexandre Julliard
Robert Shearman [EMAIL PROTECTED] writes: This fixes a bunch of tmarshal tests. It doesn't seem to make any difference for me: ../../../tools/runtest -q -P wine -M oleaut32.dll -T ../../.. -p oleaut32_test.exe.so tmarshal.c touch tmarshal.ok tmarshal.c:139: Test failed: CoMarshalInterface

Re: [PATCH 3/6] oleaut32: Comment out dual attribute of IKindaEnumWidget in tmarshal test to cause the interface to be marshaled correctly.

2007-02-07 Thread Robert Shearman
Alexandre Julliard wrote: Robert Shearman [EMAIL PROTECTED] writes: This fixes a bunch of tmarshal tests. It doesn't seem to make any difference for me: ../../../tools/runtest -q -P wine -M oleaut32.dll -T ../../.. -p oleaut32_test.exe.so tmarshal.c touch tmarshal.ok

Re: [PATCH 3/6] oleaut32: Comment out dual attribute of IKindaEnumWidget in tmarshal test to cause the interface to be marshaled correctly.

2007-02-07 Thread Alexandre Julliard
Robert Shearman [EMAIL PROTECTED] writes: Did you remove ~/.wine? It only registers the typelib if the typelib hasn't already been registered (perhaps this should be changed.) Ah sorry, I missed that part. Yes, I think that needs to be changed, we can't ask people to rm -rf their .wine dir all

Re: Undoc. comctl32 mem management functions

2007-02-07 Thread Robert Shearman
Felix Nawothnig wrote: Hi. comctl32 exports (undocumented) Alloc() and friends which call LocalAlloc = GlobalAlloc = HeapAlloc since it's doesn't use any fancy LMEM / GMEM flags... so shouldn't Alloc() call HeapAlloc() directly? If Global/Local* behave different than Heap* on Windows -

Re: msi: Make MsiInstallProduct conformance test depend on proper UI level processing.

2007-02-07 Thread James Hawkins
On 2/7/07, Misha Koshelev [EMAIL PROTECTED] wrote: On Wed, 2007-02-07 at 13:23 -0600, James Hawkins wrote: On 2/7/07, Misha Koshelev [EMAIL PROTECTED] wrote: On Wed, 2007-02-07 at 12:30 -0600, James Hawkins wrote: On 2/7/07, Misha Koshelev [EMAIL PROTECTED] wrote: Hi, here is my

Helping a user migrate an odbc app to Wine

2007-02-07 Thread Dan Kegel
Can somebody help this (german-speaking) fellow: http://www.unixboard.de/vb3/showthread.php?t=26943 He says his company's internal application requires you to input a DSN when installing it, and he doesn't know how to come up with a DSN under Wine. Presumably he doesn't want to mess with

Re: winegcc: sign-compare fixes

2007-02-07 Thread [EMAIL PROTECTED]
On 2/7/07, Joris Huizer [EMAIL PROTECTED] wrote: I believe this one causes problems -- please do not commit yet Joris Huizer [EMAIL PROTECTED] wrote: Need Mail bonding? Go to the Yahoo! Mail QA for great tips from Yahoo! Answers users.From

Re: winedump: sign-compare fixes

2007-02-07 Thread [EMAIL PROTECTED]
On 2/7/07, Dmitry Timoshkov [EMAIL PROTECTED] wrote: Joris Huizer [EMAIL PROTECTED] wrote: -static const MINIDUMP_DIRECTORY* get_mdmp_dir(const MINIDUMP_HEADER* hdr, int str_idx) +static const MINIDUMP_DIRECTORY* get_mdmp_dir(const MINIDUMP_HEADER* hdr,unsigned long int str_idx) Please

Re: msi: Make MsiInstallProduct conformance test depend on proper UI level processing.

2007-02-07 Thread Misha Koshelev
On Wed, 2007-02-07 at 16:46 -0600, James Hawkins wrote: On 2/7/07, Misha Koshelev [EMAIL PROTECTED] wrote: On Wed, 2007-02-07 at 13:23 -0600, James Hawkins wrote: On 2/7/07, Misha Koshelev [EMAIL PROTECTED] wrote: On Wed, 2007-02-07 at 12:30 -0600, James Hawkins wrote: On 2/7/07,

Re: msi: Make MsiInstallProduct conformance test depend on proper UI level processing.

2007-02-07 Thread James Hawkins
On 2/7/07, Misha Koshelev [EMAIL PROTECTED] wrote: On Wed, 2007-02-07 at 16:46 -0600, James Hawkins wrote: On 2/7/07, Misha Koshelev [EMAIL PROTECTED] wrote: On Wed, 2007-02-07 at 13:23 -0600, James Hawkins wrote: On 2/7/07, Misha Koshelev [EMAIL PROTECTED] wrote: On Wed, 2007-02-07 at

Re: msi: Make MsiInstallProduct conformance test depend on proper UI level processing.

2007-02-07 Thread Misha Koshelev
Well, by definition, that's not really a conformance test because it doesn't conform to windows. Did you make the property public and add the property to the Property table? http://msdn2.microsoft.com/en-us/library/aa370912.aspx First of all, I added the Property to the Property table,

Re: msi: Make MsiInstallProduct conformance test depend on proper UI level processing.

2007-02-07 Thread Misha Koshelev
Well, by definition, that's not really a conformance test because it doesn't conform to windows. Did you make the property public and add the property to the Property table? http://msdn2.microsoft.com/en-us/library/aa370912.aspx Aha, google search figured it out: * Property name ALL

Re: msi: Make MsiInstallProduct conformance test depend on proper UI level processing.

2007-02-07 Thread Misha Koshelev
On Wed, 2007-02-07 at 23:46 -0600, James Hawkins wrote: On 2/7/07, Misha Koshelev [EMAIL PROTECTED] wrote: Well, by definition, that's not really a conformance test because it doesn't conform to windows. Did you make the property public and add the property to the Property table?

Re: Helping a user migrate an odbc app to Wine

2007-02-07 Thread Kai Blin
On Thursday 08 February 2007 01:42, Dan Kegel wrote: Can somebody help this (german-speaking) fellow: http://www.unixboard.de/vb3/showthread.php?t=26943 He says his company's internal application requires you to input a DSN when installing it, and he doesn't know how to come up with a DSN

Re: ole32: Remove casts

2007-02-07 Thread Robert Shearman
Mike McCormack wrote: --- This is the way ref counting is done everywhere else in Wine. Ref counts can be assumed to be between 0 and MAXLONG, so the fact that LONG is signed isn't important. NO. The DCOM spec says that STDOBJREF::cPublicRefs is unsigned, therefore the ref counts can be