Re: winmm/tests: waveOutGetDevCaps called with invalid size

2008-04-22 Thread Peter Åstrand
> > However, I still think it's VERY strange to expect success from an invalid > > call. You are describing it as an "invalid argument" yourself. Why should we > > expect a call with an "invalid argument" to succeed? And again, the test > > does NOT pass on all Microsoft versions; it fails on Term

Re: wine-announce and wine-users getting hammered

2008-04-22 Thread Marcus Meissner
On Tue, Apr 22, 2008 at 04:15:53PM +, Luke Bratch wrote: > Hi > > I do the moderation for these lists, and wine-accounce and wine-users are > getting absolutely hammered with notification error messages today (in the > order of around 15 per minute all day long). > > I've been clearing thes

Re: gdi32: Make the bitmap test pass under Windows 2000. Take 2

2008-04-22 Thread Paul Vriens
Dmitry Timoshkov wrote: > "Paul Vriens" <[EMAIL PROTECTED]> wrote: > It's that last piece: "assuming there's enough memory left". >>> >>> That's a valid assumption I'd guess, and a lot of tests already rely >>> on this: every thing which indirectly or directly allocates memory, >>> creates wi

Wine t-shirts?

2008-04-22 Thread Maarten Lankhorst
Hi all, Why don't we have wine t-shirts any more? Cheers, Maarten.

Re: Fix "warning: cast from pointer to integer of different size"

2008-04-22 Thread Erik de Castro Lopo
Dmitry Timoshkov wrote: > "Erik de Castro Lopo" <[EMAIL PROTECTED]> wrote: > > > FIELD_OFFSET is defined in include/winnt.h. > > > > Now I could include winnt.h into include/wine/list.h but that doesn't > > seem right. I could also copy it,but having two definitions of the > > same macro is als

Re: Fix "warning: cast from pointer to integer of different size"

2008-04-22 Thread Dmitry Timoshkov
"Erik de Castro Lopo" <[EMAIL PROTECTED]> wrote: >> > /* get pointer to object containing list element */ >> > #define LIST_ENTRY(elem, type, field) \ >> > -((type *)((char *)(elem) - (unsigned int)(&((type *)0)->field))) >> > +((type *)((char *)(elem) - (unsigned long)(&((type *)0)->field

Re: SOC 2008 Projects Announced

2008-04-22 Thread Maarten Lankhorst
Hi Austin, 2008/4/22 Austin English <[EMAIL PROTECTED]>: > For those of you who haven't heard yet, the Google SOC Projects were > announced today: > http://google-opensource.blogspot.com/2008/04/announcing-accepted-student-proposals.html > > 5 Wine projects have been accepted: > http://code.google

Re: gdi32: Make the bitmap test pass under Windows 2000. Take 2

2008-04-22 Thread Dmitry Timoshkov
"Paul Vriens" <[EMAIL PROTECTED]> wrote: >>> It's that last piece: "assuming there's enough memory left". >> >> That's a valid assumption I'd guess, and a lot of tests already rely >> on this: every thing which indirectly or directly allocates memory, >> creates windows, objects, processes, etc.

Re: Removinig CVS/GIT version from bugzilla

2008-04-22 Thread Vitaliy Margolen
Maarten Lankhorst wrote: > Hello Scott, > > 2008/4/22 Scott Ritchie <[EMAIL PROTECTED]>: >> Vitaliy Margolen wrote: >> > 3. After the next release, if the bug is still present, modify version to >> > that release. Of course no modifying of old bugs. >> > >> >> Sounds like a simple addition to

Re: winehq.org redesign

2008-04-22 Thread Chris Morgan
> Regarding the design itself, the colored boxes remind me more of a > children's party than a useful piece of software. If you want to add > color to the page, it seems like there are other ways to do it without > calling garish attention to the Wine logo. > Garish? ;-) I thought the top X e

Re: Removinig CVS/GIT version from bugzilla

2008-04-22 Thread Maarten Lankhorst
Hello Scott, 2008/4/22 Scott Ritchie <[EMAIL PROTECTED]>: > Vitaliy Margolen wrote: > > 3. After the next release, if the bug is still present, modify version to > > that release. Of course no modifying of old bugs. > > > > Sounds like a simple addition to Alexandre's (scripted?) closing of al

Re: Wine64 : initializer element is not computable at load time?

2008-04-22 Thread Ove Kaaven
Erik de Castro Lopo skrev: > Ove Kaaven wrote: > >> Erik de Castro Lopo skrev: >>> Anybody understand why? >> You could look up the definition of RTL_CRITICAL_SECTION_DEBUG in >> include/winnt.h. Then realize that __WINESRC__ is only defined for stuff >> in dlls/, not for stuff in programs/, whi

Re: Alex Villacís Lasso : uxtheme: Speed up UXTHEME_SizedBlt in the ST_T ILE by building an appropriately-sized me mory bitmap out of the tile instead of iterating with UXTHEME_Blt () directly

2008-04-22 Thread Alex Villací­s Lasso
Frank Richter escribio': > On 22.04.2008 13:47, Alexandre Julliard wrote: > >> uxtheme: Speed up UXTHEME_SizedBlt in the ST_TILE by building an >> appropriately-sized memory bitmap out of the tile instead of iterating with >> UXTHEME_Blt() directly. >> > > But does that keep the alpha cha

Re: winehq.org redesign

2008-04-22 Thread L. Rahyen
On Tuesday April 22 2008 09:07:10 Reece Dunn wrote: > 2008/4/21 Evgeny Burzak <[EMAIL PROTECTED]>: > > Hello all, > > some times ago I make design for AppDB > > (http://buzz.ulx.ru/pf/appdb.png). Folks was delighted with this one, > > but managers rejected my idea due to needs redesign everythin

Re: winehq.org redesign

2008-04-22 Thread Alexander Nicolaysen Sørnes
> Hello all, > some times ago I make design for AppDB (http://buzz.ulx.ru/pf/appdb.png). > Folks was delighted with this one, but managers rejected my idea due to > needs redesign everything then. But now it may be more actual then ever > owing to Wine 1.0 release? I think it may gain attention f

Re: winehq.org redesign

2008-04-22 Thread Scott Ritchie
Evgeny Burzak wrote: > Hello all, > some times ago I make design for AppDB (http://buzz.ulx.ru/pf/appdb.png). > Folks was delighted with this one, but managers rejected my idea due to > needs redesign everything then. > But now it may be more actual then ever owing to Wine 1.0 release? I think

SOC 2008 Projects Announced

2008-04-22 Thread Austin English
For those of you who haven't heard yet, the Google SOC Projects were announced today: http://google-opensource.blogspot.com/2008/04/announcing-accepted-student-proposals.html 5 Wine projects have been accepted: http://code.google.com/soc/2008/wine/about.html

Re: Removinig CVS/GIT version from bugzilla

2008-04-22 Thread Scott Ritchie
Vitaliy Margolen wrote: > 3. After the next release, if the bug is still present, modify version to > that release. Of course no modifying of old bugs. > Sounds like a simple addition to Alexandre's (scripted?) closing of all fixed bugs on release day. Thanks, Scott Ritchie

Re: Wine64 : initializer element is not computable at load time?

2008-04-22 Thread Erik de Castro Lopo
Ove Kaaven wrote: > Erik de Castro Lopo skrev: > > Anybody understand why? > > You could look up the definition of RTL_CRITICAL_SECTION_DEBUG in > include/winnt.h. Then realize that __WINESRC__ is only defined for stuff > in dlls/, not for stuff in programs/, which should make the type > misma

Re: Fix "warning: cast from pointer to integer of different size"

2008-04-22 Thread Erik de Castro Lopo
Dmitry Timoshkov wrote: > "Erik de Castro Lopo" <[EMAIL PROTECTED]> wrote: > > > /* get pointer to object containing list element */ > > #define LIST_ENTRY(elem, type, field) \ > > -((type *)((char *)(elem) - (unsigned int)(&((type *)0)->field))) > > +((type *)((char *)(elem) - (unsigned

Re: [PATCH 01/21] [WinHelp]: get rid of the reuse concept for Windows and refactor the code a bit for window creation / deletion

2008-04-22 Thread Eric Pouech
Alexandre Julliard a écrit : > Eric Pouech <[EMAIL PROTECTED]> writes: > > >> programs/winhelp/winhelp.c | 257 >> >> 1 files changed, 116 insertions(+), 141 deletions(-) >> > > This breaks window repaints for me, when switching pages the wind

Re: Alex Villacís Lasso : uxtheme: Speed up UXTHEME_SizedBlt in the ST_TILE by building an appropriately-sized memory bitmap out of the tile instead of iterating with UXTHEME_Bl t () directly

2008-04-22 Thread Frank Richter
On 22.04.2008 13:47, Alexandre Julliard wrote: > uxtheme: Speed up UXTHEME_SizedBlt in the ST_TILE by building an > appropriately-sized memory bitmap out of the tile instead of iterating with > UXTHEME_Blt() directly. But does that keep the alpha channel intact? -f.r.

Re: [PATCH 05/21] [WinHelp]: properly handle the back button (in multiple windows, in empty stack...)

2008-04-22 Thread Juan Lang
+ * WINHELP_DeleteButtons + * + */ +void WINHELP_DeleteBackSet(WINHELP_WINDOW* win) Nit: the comment should match the function. --Juan

wine-announce and wine-users getting hammered

2008-04-22 Thread Luke Bratch
Hi I do the moderation for these lists, and wine-accounce and wine-users are getting absolutely hammered with notification error messages today (in the order of around 15 per minute all day long). I've been clearing these out, but perhaps this is an indication of someone targeting these lists?

Re: Documentation updating / XML?

2008-04-22 Thread Austin English
On Tue, Apr 22, 2008 at 5:25 AM, Alexandre Julliard <[EMAIL PROTECTED]> wrote: > "Austin English" <[EMAIL PROTECTED]> writes: > > > I've been working on some of the documentation, then remembered that > Scott > > requested a move to XML: > > http://bugs.winehq.org/show_bug.cgi?id=12217 > > > > The

Re: gdi32: Make the bitmap test pass under Windows 2000. Take 2

2008-04-22 Thread Paul Vriens
Dmitry Timoshkov wrote: > "Paul Vriens" <[EMAIL PROTECTED]> wrote: > This one will fail at least on my VMware box. Shouldn't the test (and it's confirmed by James and me) include something like: ok(hbmp!=0 || (hbmp == 0 && GetLastError() == ERROR_NOT_ENOUGH_MEMORY),

Re: gdi32: Make the bitmap test pass under Windows 2000. Take 2

2008-04-22 Thread Dmitry Timoshkov
"Paul Vriens" <[EMAIL PROTECTED]> wrote: >>> This one will fail at least on my VMware box. Shouldn't the test (and >>> it's confirmed by James and me) include something like: >>> >>> ok(hbmp!=0 || (hbmp == 0 && GetLastError() == >>> ERROR_NOT_ENOUGH_MEMORY), ) >> >> Why will it fail? Accord

Re: gdi32: Make the bitmap test pass under Windows 2000. Take 2

2008-04-22 Thread Paul Vriens
Dmitry Timoshkov wrote: > "Paul Vriens" <[EMAIL PROTECTED]> wrote: > >>> SetLastError(0xdeadbeef); >>> -hbmp = CreateBitmap(0x7ff, 1, 1, 1, NULL); >>> -ok(hbmp != 0, "CreateBitmap should not fail\n"); >>> +hbmp = CreateBitmap(0x7fff, 0x7fff, 1, 1, NULL); >>> +ok(hbmp != 0,

Re: gdi32: Make the bitmap test pass under Windows 2000. Take 2

2008-04-22 Thread Reece Dunn
2008/4/22 Paul Vriens <[EMAIL PROTECTED]>: > Hi Dmitry, > > This one will fail at least on my VMware box. Shouldn't the test (and it's > confirmed by James and me) include something like: > > ok(hbmp!=0 || (hbmp == 0 && GetLastError() == ERROR_NOT_ENOUGH_MEMORY), ) I would say something mo

Re: winehq.org redesign

2008-04-22 Thread Reece Dunn
2008/4/21 Evgeny Burzak <[EMAIL PROTECTED]>: > Hello all, > some times ago I make design for AppDB (http://buzz.ulx.ru/pf/appdb.png). > Folks was delighted with this one, but managers rejected my idea due to > needs redesign everything then. > But now it may be more actual then ever owing to

Re: Fix "warning: cast from pointer to integer of different size"

2008-04-22 Thread Dmitry Timoshkov
"Erik de Castro Lopo" <[EMAIL PROTECTED]> wrote: > /* get pointer to object containing list element */ > #define LIST_ENTRY(elem, type, field) \ > -((type *)((char *)(elem) - (unsigned int)(&((type *)0)->field))) > +((type *)((char *)(elem) - (unsigned long)(&((type *)0)->field))) It shou

Re: gdi32: Make the bitmap test pass under Windows 2000. Take 2

2008-04-22 Thread Dmitry Timoshkov
"Paul Vriens" <[EMAIL PROTECTED]> wrote: >> SetLastError(0xdeadbeef); >> -hbmp = CreateBitmap(0x7ff, 1, 1, 1, NULL); >> -ok(hbmp != 0, "CreateBitmap should not fail\n"); >> +hbmp = CreateBitmap(0x7fff, 0x7fff, 1, 1, NULL); >> +ok(hbmp != 0, "CreateBitmap error %u\n", GetLa

Re: Wine64 : initializer element is not computable at load time?

2008-04-22 Thread Ove Kaaven
Erik de Castro Lopo skrev: > Anybody understand why? You could look up the definition of RTL_CRITICAL_SECTION_DEBUG in include/winnt.h. Then realize that __WINESRC__ is only defined for stuff in dlls/, not for stuff in programs/, which should make the type mismatch clear.

Removinig CVS/GIT version from bugzilla

2008-04-22 Thread Vitaliy Margolen
I'm copying my response here to continue the conversation. Please don't remove cvs/git version. What should be done is: 1. Leave old bugs alone or modify them case-by-case 2. All bugs with "cvs/git" version from now on can be filed on the development branch between releases only. 3. After the ne

Re: gdi32: Make the bitmap test pass under Windows 2000. Take 2

2008-04-22 Thread Paul Vriens
Dmitry Timoshkov wrote: > Hello, > > here is another version of the patch. > -- > > According to test.winehq.ord data Windows 2000 behaves weird in some tests, > this looks like a bug to me. This patch addresses these failures. > > Changelog: > gdi32: Make the bitmap test pass under Windows

Wine64 : initializer element is not computable at load time?

2008-04-22 Thread Erik de Castro Lopo
Hi all, I'm compiling wine on x86-64 after configuring with --enable-win64 and I get the error: irotp.c:54: error: initializer element is not computable at load time irotp.c:54: error: (near initialization for 'critsect_debug.Spare[0]') on this this code: 51: static CRITICAL_SECTION

Re: Spelling fixes

2008-04-22 Thread H. Verbeet
On 22/04/2008, Austin English <[EMAIL PROTECTED]> wrote: > -/* Declare loop registers aLx */ > +/* Declare loop registers alx */ > for (i = 0; i < reg_maps->loop_depth; i++) { > shader_addline(buffer, "int aL%u;\n", i); > shader_addline(buffer, "int tmpInt%u;\n", i);

Re: winmm/tests: waveOutGetDevCaps called with invalid size

2008-04-22 Thread Robert Reif
Peter Åstrand wrote: > However, I still think it's VERY strange to expect success from an > invalid call. You are describing it as an "invalid argument" yourself. > Why should we expect a call with an "invalid argument" to succeed? And > again, the test does NOT pass on all Microsoft versions; i

Re: Wine countdown?

2008-04-22 Thread Justus Winter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Dan Kegel wrote: > Anybody seen the nifty countdown logo that Ubuntu is using? > http://www.ubuntu.com/getubuntu/countdown > Maybe we should do something similar for Wine. Agreed. > FWIW, here's a snippet that does something similar, but with text: [.

Re: Documentation updating / XML?

2008-04-22 Thread Alexandre Julliard
"Austin English" <[EMAIL PROTECTED]> writes: > I've been working on some of the documentation, then remembered that Scott > requested a move to XML: > http://bugs.winehq.org/show_bug.cgi?id=12217 > > There are quite a few programs to convert SGML to XML, and I've got a bit of > time to kill. Alexa

Re: [PATCH 01/21] [WinHelp]: get rid of the reuse concept for Windows and refactor the code a bit for window creation / deletion

2008-04-22 Thread Alexandre Julliard
Eric Pouech <[EMAIL PROTECTED]> writes: > programs/winhelp/winhelp.c | 257 > > 1 files changed, 116 insertions(+), 141 deletions(-) This breaks window repaints for me, when switching pages the window is not repainted and still shows the old page.

Translating Wine with PO files

2008-04-22 Thread Dwayne Bailey
Hi, I've just completed a tool for converting resource files (.rc) to Gettext PO. http://translate.sourceforge.net/wiki/toolkit/rc2po This should allow many more FOSS translators to add translations to Wine, hopefully before the 1.0 release. In some ways this is a response to some issues raised

winehq.org redesign

2008-04-22 Thread Evgeny Burzak
Hello all, some times ago I make design for AppDB (http://buzz.ulx.ru/pf/appdb.png). Folks was delighted with this one, but managers rejected my idea due to needs redesign everything then. But now it may be more actual then ever owing to Wine 1.0 release? I think it may gain attention from pr

Re: kernel32: Fix a test that fails on all NT platforms

2008-04-22 Thread James Hawkins
On Tue, Apr 22, 2008 at 2:48 AM, Paul Vriens <[EMAIL PROTECTED]> wrote: > > James Hawkins wrote: > > > On Tue, Apr 22, 2008 at 1:33 AM, Paul Vriens <[EMAIL PROTECTED]> > wrote: > > > > > James Hawkins wrote: > > > > > > > > > > Hi, > > > > > > > > Changelog: > > > > * Fix a test that fails on all N

Re: kernel32: Fix a test that fails on all NT platforms

2008-04-22 Thread Paul Vriens
James Hawkins wrote: > On Tue, Apr 22, 2008 at 1:33 AM, Paul Vriens <[EMAIL PROTECTED]> wrote: >> James Hawkins wrote: >> >>> Hi, >>> >>> Changelog: >>> * Fix a test that fails on all NT platforms. >>> >>> dlls/kernel32/tests/toolhelp.c | 12 +--- >>> 1 files changed, 9 insertions(+), 3

Re: winmm/tests: waveOutGetDevCaps called with invalid size

2008-04-22 Thread Peter Åstrand
On Mon, 21 Apr 2008, Robert Reif wrote: > > That's the whole point of the test, to check what happens with an invalid > > argument. > > > > So what do you think *should* happen with an invalid argument? The result is > different on different Windows platforms. The behaviour is not specifie