Re: user32: EnumDisplaySettingsExA: fill in all of lpDevmode->dmDeviceName

2008-06-05 Thread Dmitry Timoshkov
"Dan Kegel" <[EMAIL PROTECTED]> wrote: > 'Cause if we don't, code that expects it to be defined > is mildly surprised to find that bytes after the string's > terminating nul are undefined. > Fixes 16 Valgrind warnings of the form: > > Use of uninitialised value of size 4 > at mbstowcs_sbcs (mbt

Double free error involving dsound and winealsa.drv

2008-06-05 Thread Dan Kegel
Hmm, freeing a buffer that's already been freed is bad, is it showstopper bad? http://bugs.winehq.org/show_bug.cgi?id=13723

Re: kernel32: tests/path.c: Improve test for GetLongPathNameA

2008-06-05 Thread James Hawkins
On Wed, Jun 4, 2008 at 8:38 PM, Zac Brown <[EMAIL PROTECTED]> wrote: > Add test to check for GetLongPathNameA on GetModuleFileNameA's returned > string. > > Found via errors existing in shell32/tests/shelllink.c. Checked against > Windows XP and Windows 2000. > +pGetModuleFileNameA = +

Re: Remove unused variable in dlls/mlang/tests/mlang.c

2008-06-05 Thread James Hawkins
2008/6/5 Gerald Pfeifer <[EMAIL PROTECTED]>: > > ChangeLog: > Remove unused variable in test_EnumScripts(). > > Index: dlls/mlang/tests/mlang.c > === > RCS file: /home/wine/wine/dlls/mlang/tests/mlang.c,v > retrieving revision 1.24 > d

re: [PATCH] oleaut32: Fix valgrind warnings in vatype.c test

2008-06-05 Thread Jon Griffiths
Hi Dan, > The last part of your patch, having to do with SysAllocStringByteLen(), > seems correct to me, offhand. Maybe if you clean up the comment a > bit more, sprinkle sugar on it, and resend, it'll make it in this time. I'll polish it and fire in again next week, there doesn't seem much poin

Re: gdi32/tests: Take into account several Win9x bugs in GetObject(). (take 3)

2008-06-05 Thread Francois Gouget
On Thu, 5 Jun 2008, Paul Vriens wrote: > Francois Gouget wrote: > > --- > > > > This time without the bug that caused tests to fail in Wine and on Windows > > XP. > > > > +SetLastError(0xdeadbeef); > > ret = GetBitmapBits(hbm, 0, NULL); > > -ok(ret == bm.bmWidthBytes * bm.bmHeight,

Re: gdi32/tests: Take into account several Win9x bugs in GetObject(). (take 3)

2008-06-05 Thread Paul Vriens
Francois Gouget wrote: > --- > > This time without the bug that caused tests to fail in Wine and on > Windows XP. > > > +SetLastError(0xdeadbeef); > ret = GetBitmapBits(hbm, 0, NULL); > -ok(ret == bm.bmWidthBytes * bm.bmHeight, "%d != %d\n", ret, > bm.bmWidthBytes * bm.bmHeight);