On 07/16/2010 11:22 AM, Alexandre Julliard wrote:
> Folks,
>
> First I want to thank everybody for your great work of the past two
> years. I'm very happy with what we have achieved with 1.2 (even if we
> didn't manage to get the regression numbers down ;-) You should all go
> out and have a drink
On 17/07/10 10:22, Misha Koshelev wrote:
> Also, if anyone knows how to make git format-patch only output the 10
> _bottom-most_ patches, please let me know.
Partial solution:
use git format-patch without the --stdout, to generate all the patches
as files, then git send-email or imap-send
Misha Koshelev wrote:
Dear All:
Congrats on 1.2!
I have begun sending my patches from my repository:
http://github.com/misha680/wine/commits/master
Specifically, I have sent the first 10 patches (of approx 70 currently).
I look forward to your comments/commits ;)
Also, if anyone knows how to
Misha Koshelev wrote:
Dear All:
Congrats on 1.2!
I have begun sending my patches from my repository:
http://github.com/misha680/wine/commits/master
Misha:
Might I make a tiny suggestion: Send in one set of patches and wait for
AJ's and others feedback. Make appropriate corrections and
On 07/16/2010 04:22 PM, Misha Koshelev wrote:
> Also, if anyone knows how to make git format-patch only output the 10
> _bottom-most_ patches
If you have 70 patches in your tree then:
git format-patch HEAD~70..HEAD~60
Vitaliy.
Michael Stefaniuc wrote:
Austin English wrote:
On Thu, Jul 15, 2010 at 9:30 PM, James McKenzie
wrote:
Rosanne DiMesio wrote:
On Thu, 15 Jul 2010 17:08:30 +0200
Gert van den Berg wrote:
On Thu, Jul 15, 2010 at 16:23, James Mckenzie
wrote:
Rosanne and y
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=3367
Your paranoid android.
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=3362
Your paranoid android.
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=3365
Your paranoid android.
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=3359
Your paranoid android.
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=3364
Your paranoid android.
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=3366
Your paranoid android.
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=3363
Your paranoid android.
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=3357
Your paranoid android.
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=3361
Your paranoid android.
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=3360
Your paranoid android.
On Fri, Jul 16, 2010 at 5:37 PM, Marvin wrote:
> Hi,
>
> While running your changed tests on Windows, I think I found new failures.
> Being a bot and all I'm not very good at pattern recognition, so I might be
> wrong, but could you please double-check?
> Full results can be found at
> http://test
Dear All:
Congrats on 1.2!
I have begun sending my patches from my repository:
http://github.com/misha680/wine/commits/master
Specifically, I have sent the first 10 patches (of approx 70 currently).
I look forward to your comments/commits ;)
Also, if anyone knows how to make git format-patch o
* On Thu, 15 Jul 2010, Michael Stefaniuc wrote:
> Saulius Krasuckas wrote:
> >
> > TRACE_ONCE probably could help in some cases too. There I see another
>
> I fail to see how TRACE_ONCE could make any sense.
> TRACE is used to trace the important parts of the code flow. Just
> printing a TRACE
W dniu 16.07.2010 19:59, Reece Dunn pisze:
Use broken() to denote the administrator case --
ok(hr == S_OK || broken(hr == E_ACCESSDENIED) /* non-Admin user
*/, IGameExplorer_AddGame(...));
This means that E_ACCESSDENIED is a valid case on Windows, but not on Wine.
- Reece
Yes, I know
On 07/16/2010 05:50 PM, André Hentschel wrote:
+Der Quellcode ist jetzthttp://prdownloads.sourceforge.net/wine/wine-1.2-rc7.tar.bz2";>verfügbar.
Hi André,
You've listed the wrong download.
--
Cheers,
Paul.
Folks,
First I want to thank everybody for your great work of the past two
years. I'm very happy with what we have achieved with 1.2 (even if we
didn't manage to get the regression numbers down ;-) You should all go
out and have a drink to celebrate.
Code freeze is of course lifted now, so once y
2010/7/16 Mariusz Pluciński :
> Hi wine-devel
> I have problems with tests I written last time.
> The problem is connected with privileges levels under Windows.
>
> The method I'm testing is IGameExplorer::AddGame,
> which registers given game in Windows Game Explorer.
> One of it's parameters (ins
Hi wine-devel
I have problems with tests I written last time.
The problem is connected with privileges levels under Windows.
The method I'm testing is IGameExplorer::AddGame,
which registers given game in Windows Game Explorer.
One of it's parameters (installScope) defines if game should
be regis
> Very BAD:
> -
> Changelog: This fixes bug #4711
>
> BAD:
>
> Changelog: Change the handling of flags X Y Z because this fixes bug #4711
>
> OK:
> ---
> Changelog: Change a corner case in the handling of flags X Y Z (with tests).
> This resolve the issue from bug #4711.
On 07/16/2010 04:58 PM, André Hentschel wrote:
Am 16.07.2010 11:32, schrieb Michael Stefaniuc:
Hello Paul,
Paul Chitescu wrote:
I would want to implement a change in where the wine prefix is assumed by
default.
The current behavior of only considering WINEPREFIX is cumbersome and risky.
Slip
Am 16.07.2010 11:32, schrieb Michael Stefaniuc:
> Hello Paul,
>
> Paul Chitescu wrote:
>> I would want to implement a change in where the wine prefix is assumed by
>> default.
>>
>> The current behavior of only considering WINEPREFIX is cumbersome and risky.
>> Slip a finger, forget a letter and
On 07/16/2010 03:50 PM, Dan Kegel wrote:
So it boils down to disagreements about two things:
- mentioning a bug number when posting a patch
I think this is a misunderstanding. There are different ways of adding
the bug number when posting a patch:
Very BAD:
-
Changelog: This fixes bug
On 16 July 2010 16:31, Dan Kegel wrote:
> Without actual examples, I can't see what you're objecting to.
There are three specific examples in this thread, two of those were
provided by yourself, one was by me. If you read carefully you can
probably find them. I also explicitly spelled the issue ou
On Fri, Jul 16, 2010 at 7:08 AM, Henri Verbeet wrote:
> No, you're mistaking specific instances for the larger issue there.
> What it boils down to is giving bad advice from a perceived position
> of authority. Please don't make me search through the archives to find
> every single specific instan
Luke Benstead wrote:
>Sent: Jul 16, 2010 7:18 AM
>To: Henri Verbeet
>Cc: wine-devel@winehq.org, Dan Kegel
>Subject: Re: Please remove / block user from bugzilla
>
>> How do frequent wine committers, and especially Alexandre, feel about
>> > these two issues?
>> I'd say Alexandre's opinion is pre
> How do frequent wine committers, and especially Alexandre, feel about
> > these two issues?
> I'd say Alexandre's opinion is pretty clear, as always:
> http://www.winehq.org/pipermail/wine-devel/2010-February/081744.html.
>
>
That's doesn't settle this at all, Alexandre is almost certainly referr
On 16 July 2010 15:50, Dan Kegel wrote:
> So it boils down to disagreements about two things:
>
> - mentioning a bug number when posting a patch
>
> - turning spammy FIXMEs into oneshots
>
No, you're mistaking specific instances for the larger issue there.
What it boils down to is giving bad advic
On Fri, Jul 16, 2010 at 11:35 PM, Hans Leidekker wrote:
> On Fri, 2010-07-16 at 15:12 +0200, Paul Vriens wrote:
>
>> In the past we have seen that on slower machines the number of tests
>> just exceeded the timeout. That has been 'corrected' back than by making
>> some tests interactive. I guess b
> From: Hans Leidekker [mailto:h...@meelstraat.net]
>
> On Fri, 2010-07-16 at 15:12 +0200, Paul Vriens wrote:
>
> > In the past we have seen that on slower machines the number of tests
> > just exceeded the timeout. That has been 'corrected' back than by making
> > some tests interactive. I guess b
So it boils down to disagreements about two things:
- mentioning a bug number when posting a patch
- turning spammy FIXMEs into oneshots
These both seem like things reasonable developers could disagree about.
(Indeed, Roderick recently posted a patch with a bug number in the subject line,
http:/
Hans Leidekker writes:
> On Fri, 2010-07-16 at 04:36 -0700, Greg Geldorp wrote:
>
>> For all the cases I've checked, when these 1574 errors occur the preceding
>> msi:install test timed out (the reverse is not true, I see msi:install
>> timeouts followed by a successful msi:package).
>
> Do y
On Fri, 2010-07-16 at 15:12 +0200, Paul Vriens wrote:
> In the past we have seen that on slower machines the number of tests
> just exceeded the timeout. That has been 'corrected' back than by making
> some tests interactive. I guess because of the multitude of new tests we
> have ended up in t
Paul Vriens wrote:
On 07/16/2010 03:05 PM, Sven Baars wrote:
MessageId=1207
SymbolicName=ERROR_NOT_CONTAINER
Language=NLD
-Not a container
+Geen
.
You are missing something here I guess.
I guess so too. New patch sent
Sven
On 07/16/2010 03:05 PM, Sven Baars wrote:
MessageId=1207
SymbolicName=ERROR_NOT_CONTAINER
Language=NLD
-Not a container
+Geen
.
You are missing something here I guess.
--
Cheers,
Paul.
On 07/16/2010 03:05 PM, Hans Leidekker wrote:
On Fri, 2010-07-16 at 04:36 -0700, Greg Geldorp wrote:
For all the cases I've checked, when these 1574 errors occur the preceding
msi:install test timed out (the reverse is not true, I see msi:install
timeouts followed by a successful msi:pack
On Fri, 2010-07-16 at 04:36 -0700, Greg Geldorp wrote:
> For all the cases I've checked, when these 1574 errors occur the preceding
> msi:install test timed out (the reverse is not true, I see msi:install
> timeouts followed by a successful msi:package).
Do you have any clue why the test time
On 07/16/2010 02:31 PM, Marko Nikolic wrote:
Paul Vriens wrote:
On 07/14/2010 09:40 AM, Damjan Jovanovic wrote:
Changelog:
* wineboot: fix Serbian Latin translation
Damjan Jovanovic
Hi Damjan,
Thanks for looking into this. I guess we need the pragma statement now
as you are introducing UT
On 16 July 2010 14:10, Wolfram Sang wrote:
> I am confused. Following this list only, I so far did not notice someone
> saying "don't tell the bug number" (ok, might be my fault), but a few
> times asking the question "does this patch fix an actual" bug. Also,
> SubmittingPatches says:
>
> ===
>
>
Paul Vriens wrote:
> On 07/14/2010 09:40 AM, Damjan Jovanovic wrote:
>> Changelog:
>> * wineboot: fix Serbian Latin translation
>>
>> Damjan Jovanovic
>>
>
> Hi Damjan,
>
> Thanks for looking into this. I guess we need the pragma statement now
> as you are introducing UTF-8, not?
>
> I did talk
Paul Chitescu wrote:
> On Friday 16 July 2010 12:32:33 pm Michael Stefaniuc wrote:
>> Hello Paul,
>>
>> Paul Chitescu wrote:
>>> I would want to implement a change in where the wine prefix is assumed by
>>> default.
>>>
>>> The current behavior of only considering WINEPREFIX is cumbersome and
> r
> For reference, there are two basic reasons for not referring to
> bugzilla when sending patches, in the commit log or otherwise. The
> first one is that patches should stand on their own. If the bug
> contains important information that's relevant to the patch, that
> should be included directly
On Friday 16 July 2010 12:32:33 pm Michael Stefaniuc wrote:
> Hello Paul,
>
> Paul Chitescu wrote:
> > I would want to implement a change in where the wine prefix is assumed by
> > default.
> >
> > The current behavior of only considering WINEPREFIX is cumbersome and
risky.
> > Slip a finger,
On 16 July 2010 12:26, Luke Benstead wrote:
> Probably not my place to wade in here, but that's not true, he didn't
> mention the commit log:
>
> "Be sure to mention in the post that it fixes
>
> http://bugs.winehq.org/show_bug.cgi?id=21233";
>
> I'm pretty sure he meant in the email when he email
Ideally, tests should be independent on each other. That's not the case right
now. A clear example is msi:package, which often fails (on XP) with 1574
errors, see http://test.winehq.org/data/tests/msi:package.html. For all the
cases I've checked, when these 1574 errors occur the preceding msi:in
On 7/16/10 1:16 PM, Wilbert Ho wrote:
cmd mishandles quote-enclosed command strings because the leading
quote is included in the string when wine searches through the
built-in commands (dir is a builtin, but "dir is not).
$ ./wine cmd.exe /c "dir README"
wine: cannot find L"C:\\windows\\system3
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=3340
Your paranoid android.
> > - Misha; I told him tests were ok to submit during a code freeze; this is
> true,
> > given that Alexandre accepted tests as last as last Friday. I should
> have
> > told him that tests which add stubs probably aren't ok, but he learned
> > that as soon as he submitted.
> > http://www.winehq.o
On 07/16/2010 02:32 AM, Michael Stefaniuc wrote:
> Hello Paul,
>
> Paul Chitescu wrote:
>> I would want to implement a change in where the wine prefix is assumed by
>> default.
>>
>> The current behavior of only considering WINEPREFIX is cumbersome and risky.
>> Slip a finger, forget a letter an
On 15 July 2010 17:45, Dan Kegel wrote:
> I'm listening. Can you give some examples of problems I've caused?
> Candidates include
>
> - the FIXME_ONCE guy; I think you and I are giving him the same advice;
> http://www.winehq.org/pipermail/wine-devel/2010-July/085069.html
> so that seems fine.
>
Hello Paul,
Paul Chitescu wrote:
> I would want to implement a change in where the wine prefix is assumed by
> default.
>
> The current behavior of only considering WINEPREFIX is cumbersome and risky.
> Slip a finger, forget a letter and you end running a potential disastrous
> command in the
Hi!
I would want to implement a change in where the wine prefix is assumed by
default.
The current behavior of only considering WINEPREFIX is cumbersome and risky.
Slip a finger, forget a letter and you end running a potential disastrous
command in the wrong prefix. I ruined my main prefix by
Austin English wrote:
> On Thu, Jul 15, 2010 at 9:30 PM, James McKenzie
> wrote:
>> Rosanne DiMesio wrote:
>>> On Thu, 15 Jul 2010 17:08:30 +0200
>>> Gert van den Berg wrote:
>>>
>>>
On Thu, Jul 15, 2010 at 16:23, James Mckenzie
wrote:
> Rosanne and you have a good point, but
58 matches
Mail list logo