RE: include/msvcrt: Make sure size_t is properly defined for 64-bit.

2006-07-10 Thread Ge van Geldorp
From: Alexandre Julliard [mailto:[EMAIL PROTECTED] We really shouldn't be including string.h here. Does this work for you? diff --git a/dlls/msvcrt/msvcrt.h b/dlls/msvcrt/msvcrt.h index fc330ce..dcba4ae 100644 --- a/dlls/msvcrt/msvcrt.h +++ b/dlls/msvcrt/msvcrt.h @@ -37,8 +37,6 @@

Re: include/msvcrt: Make sure size_t is properly defined for 64-bit.

2006-07-10 Thread Alexandre Julliard
Ge van Geldorp [EMAIL PROTECTED] writes: I'm not sure why the typedef is duplicated so many times. Wouldn't it be better to define it only in stddef.h, #ifdef'ing it on __x86_64__ and then include stddef.h from the other files? Unfortunately that's not how MS does it. Another option might

Re: include/msvcrt: Make sure size_t is properly defined for 64-bit.

2006-07-07 Thread Alexandre Julliard
Ge van Geldorp [EMAIL PROTECTED] writes: In file included from data.c:21: ./../msvcrt.h:625: error: conflicting types for _strnset ../../../include/msvcrt/string.h:62: error: previous declaration of _strnset was here The patch I submitted fixes the problem by moving the include of windef.h

RE: include/msvcrt: Make sure size_t is properly defined for 64-bit.

2006-07-07 Thread Ge van Geldorp
From: Alexandre Julliard We really shouldn't be including string.h here. Does this work for you? diff --git a/dlls/msvcrt/msvcrt.h b/dlls/msvcrt/msvcrt.h index fc330ce..dcba4ae 100644 --- a/dlls/msvcrt/msvcrt.h +++ b/dlls/msvcrt/msvcrt.h @@ -37,8 +37,6 @@ #ifndef __WINE_MSVCRT_H

RE: include/msvcrt: Make sure size_t is properly defined for 64-bit.

2006-07-07 Thread Ge van Geldorp
From: Ge van Geldorp [mailto:[EMAIL PROTECTED] Yes, this works fine, both with and without the change to include/msvcrt/string.h. Sorry, I only tested dlls/msvcrt. When doing a full rebuild I get errors, will investigate and let you know. Ge.

Re: include/msvcrt: Make sure size_t is properly defined for 64-bit.

2006-07-06 Thread Ge van Geldorp
diff --git a/include/msvcrt/string.h b/include/msvcrt/string.h index a821aa2..cc0b25e 100644 --- a/include/msvcrt/string.h +++ b/include/msvcrt/string.h @@ -18,8 +18,18 @@ typedef unsigned short wchar_t; #endif #endif +#ifndef _MSC_VER +# ifndef __int64 +# define __int64 long long

Re: include/msvcrt: Make sure size_t is properly defined for 64-bit.

2006-07-06 Thread Steven Edwards
On 7/6/06, Ge van Geldorp [EMAIL PROTECTED] wrote: +#include windef.h + #include stdarg.h On MSVC or at least older versions stdarg.h had to come before windef.h -- Steven Edwards There is one thing stronger than all the armies in the world, and that is an idea whose time has come. - Victor