Re: [Wireshark-dev] Community ID flow hashes in Wireshark

2020-09-14 Thread Christian Kreibich
On 9/14/20 2:46 PM, Guy Harris wrote: One thing is, as reported in one of the pre-commit build failures: ERROR: Please edit your merge request and make sure the setting Allow commits from members who can merge to the target branch is checked so that maintainers can

Re: [Wireshark-dev] Community ID flow hashes in Wireshark

2020-09-14 Thread Christian Kreibich
On 7/11/19 3:16 PM, Christian Kreibich wrote: On 7/11/19 3:06 PM, Guy Harris wrote: I.e., compute the community ID for the flow to which a packet belongs, and add it to the protocol tree as a calculated field? Yep, exactly. I finally got around to this and just submitted an MR: https

Re: [Wireshark-dev] Community ID flow hashes in Wireshark

2019-07-11 Thread Christian Kreibich
On 7/11/19 3:06 PM, Guy Harris wrote: I.e., compute the community ID for the flow to which a packet belongs, and add it to the protocol tree as a calculated field? Yep, exactly. How about a higher-level pseudo-code description of the algorithm? That way, it 1) doesn't require the

[Wireshark-dev] Community ID flow hashes in Wireshark

2019-07-11 Thread Christian Kreibich
Hi folks, How do people here feel about adding the ability to see Community ID flow hashes in Wireshark? For context, this is a standardized implementation of flow hashing, to simplify linking/pivoting flows across data sets. There's more detail below, including a Python implementation and