Hi Ronnie,
I've corrected AMQP dissector to handle heartbeats corectly. Diff is
attached. Can you check it in, please?
Thanks.
Martin
0a1
>
9,10d9
< * $Id: packet-amqp.c 21254 2007-03-28 22:16:43Z sahlberg $
< *
2089a2089,2094
> case AMQP_FRAME_TYPE_HEARTBEAT:
> if (chec
On Mon, May 21, 2007 at 02:30:59PM +0200, Martin Sustrik wrote:
> Here's the patch for following issues:
>
> - If there are several AMQP frames in single TCP packet, all of them are
> shown in the 'info' column
> - AMQP heartbeat is dissected correctly, it doesn't assert any more
>
> Can you pl
Steve,
The problem is that the code is generated from the protocol
specification. If I was to find out which parameters actually need _U_
and which do note, the code generation would get considerably more
complex (two passes instead of single one).
Martin
From: Stephen Fisher <[EMAIL PROTECTE
You could use _U_ in the template for all those arguments that might
not be used, regardless of whether they're actually used or not. If
_U_ is not necessary there's no problem if it is present.
L
On 6/1/07, Martin Sustrik <[EMAIL PROTECTED]> wrote:
> Steve,
>
> The problem is that the code is ge
Thanks, that's no problem then. I just tried applying your patch, but
it failed on all hunks. Would it be possible to do an svn update and
regenerate the patch? Is any part of this patch included in your patch
that Ronnie committed on March 28th? That was revision 21254. The
filename you a