On Tue, Jul 22, 2014 at 10:10 PM, Jeff Morriss
wrote:
> On 07/11/14 12:42, Bill Meier wrote:
>>
>> I've been working with the current 'pre-commit' and have noticed the
>> following issues:
>
> [...]
>
>> 1. For the above reasons, I propose that pre-commit only do checkAPIs,
>> checkhf and fix-
On 07/11/14 12:42, Bill Meier wrote:
I've been working with the current 'pre-commit' and have noticed the
following issues:
[...]
1. For the above reasons, I propose that pre-commit only do checkAPIs,
checkhf and fix-encoding-args for dissector files (to be determined
in a rather ugly a
Hi Bill,
On Fri, Jul 11, 2014 at 6:42 PM, Bill Meier wrote:
> I've been working with the current 'pre-commit' and have noticed the
> following issues:
at origin, pre-commit script is personnal script to easy launch some
check tools ;-) and there is a lot of issue...
>
> 1. Using the current pr
On 7/11/2014 3:09 PM, Evan Huus wrote:
On Fri, Jul 11, 2014 at 12:42 PM, Bill Meier
I missed that ...
Thanks
___
Sent via:Wireshark-dev mailing list
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscri
On Fri, Jul 11, 2014 at 12:42 PM, Bill Meier wrote:
> I've been working with the current 'pre-commit' and have noticed the
> following issues:
>
> 1. Using the current pre-commit which calls checkAPIs, etc, it
> doesn't seem possible to make changes to
> certain files (e.g., wsgetopt.c)
On Fri, Jul 11, 2014 at 12:42 PM, Bill Meier wrote:
> I've been working with the current 'pre-commit' and have noticed the
> following issues:
>
> 1. Using the current pre-commit which calls checkAPIs, etc, it
> doesn't seem possible to make changes to
> certain files (e.g., wsgetopt.c)
I've been working with the current 'pre-commit' and have noticed the
following issues:
1. Using the current pre-commit which calls checkAPIs, etc, it
doesn't seem possible to make changes to
certain files (e.g., wsgetopt.c) and submit them to Gerrit.
- The files fail checkAPIs.pl a
