Re: [Xen-devel] [PATCHv5 12/14] xen-blkback: safely unmap grants in case they are still in use

2015-03-11 Thread Roger Pau Monné
Hello, El 12/03/15 a les 9.08, Bob Liu ha escrit: > > On 03/09/2015 07:02 PM, David Vrabel wrote: >> On 09/03/15 10:51, Bob Liu wrote: >>> >>> On 03/09/2015 05:30 PM, David Vrabel wrote: On 09/03/15 09:09, Bob Liu wrote: > Hi David, > > Recently I met an issue which is likely rel

Re: [Xen-devel] [PATCHv1 net] xen-netback: notify immediately after pushing Tx response.

2015-03-11 Thread David Miller
From: David Vrabel Date: Wed, 11 Mar 2015 15:27:59 + > This fixes a performance regression introduced by > 7fbb9d8415d4a51cf542e87cf3a717a9f7e6aedc (xen-netback: release pending > index before pushing Tx responses) > > Moving the notify outside of the spin locks means it can be delayed a > l

Re: [Xen-devel] [v2][PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-11 Thread Chen, Tiejun
+ +if (b_info->u.hvm.gfx_passthru_kind == +LIBXL_GFX_PASSTHRU_KIND_DEFAULT) { +if (libxl__is_igd_vga_passthru(gc, guest_config)) +machinearg = GCSPRINTF("%s,igd-passthru=on", machinearg); +} else if (b_info->u.hvm.gfx_passthru_kind == +

[Xen-devel] [PATCH 13/22] x86: %pF is only for function pointers

2015-03-11 Thread Scott Wood
Use %pS for actual addresses, otherwise you'll get bad output on arches like ppc64 where %pF expects a function descriptor. Even on other architectures, refrain from setting a bad example that people copy. Signed-off-by: Scott Wood Cc: x...@kernel.org Cc: xen-de...@lists.xenproject.org --- arch

Re: [Xen-devel] [PATCH] SeaBios/vTPM: Enable Xen stubdom vTPM for HVM virtual machine

2015-03-11 Thread Xu, Quan
> -Original Message- > From: Kevin O'Connor [mailto:ke...@koconnor.net] > Sent: Thursday, March 12, 2015 3:49 AM > To: Xu, Quan; seab...@seabios.org > Cc: stefano.stabell...@eu.citrix.com; stef...@linux.vnet.ibm.com; > qemu-de...@nongnu.org; xen-devel@lists.xen.org > Subject: Re: [PATCH]

Re: [Xen-devel] vTPM implementation

2015-03-11 Thread Xu, Quan
Marcos, you can read docs/misc/vtpm.txt and docs/misc/vtpmmgr.txt. You'd better setup vtpm for Linux guest first, then Try to read ... tpmback_req_any() vtpmmgr_handle_cmd() ... for more information. Quan > -Original Message- > From: xen-devel-boun...@lists.xen.org >

Re: [Xen-devel] stubdom vtpm build failure in staging

2015-03-11 Thread Xu, Quan
> -Original Message- > From: Ian Campbell [mailto:ian.campb...@citrix.com] > Sent: Wednesday, March 11, 2015 6:51 PM > To: Xu, Quan > Cc: Wei Liu; Stefano Stabellini; Daniel De Graaf; Olaf Hering; Andrew Cooper; > xen-devel@lists.xen.org > Subject: Re: [Xen-devel] stubdom vtpm build failu

Re: [Xen-devel] [PATCH v6 07/30] PCI: Pass PCI domain number combined with root bus number

2015-03-11 Thread Bjorn Helgaas
On Mon, Mar 09, 2015 at 10:34:04AM +0800, Yijing Wang wrote: > Now we could pass PCI domain combined with bus number > in u32 argu. Because in arm/arm64, PCI domain number > is assigned by pci_bus_assign_domain_nr(). So we leave > pci_scan_root_bus() and pci_create_root_bus() in arm/arm64 > unchang

Re: [Xen-devel] [PATCHv5 12/14] xen-blkback: safely unmap grants in case they are still in use

2015-03-11 Thread Bob Liu
On 03/09/2015 07:02 PM, David Vrabel wrote: > On 09/03/15 10:51, Bob Liu wrote: >> >> On 03/09/2015 05:30 PM, David Vrabel wrote: >>> On 09/03/15 09:09, Bob Liu wrote: Hi David, Recently I met an issue which is likely related with this patch. It happened when running block benc

[Xen-devel] [linux-next test] 36117: regressions - trouble: blocked/broken/fail/pass

2015-03-11 Thread xen . org
flight 36117 linux-next real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/36117/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl 9 guest-start fail REGR. vs. 35942 test-amd64-i386-qemuu-

Re: [Xen-devel] [PATCH v6 04/30] xen/PCI: Don't use deprecated function pci_scan_bus_parented()

2015-03-11 Thread Bjorn Helgaas
On Mon, Mar 09, 2015 at 10:34:01AM +0800, Yijing Wang wrote: > From: Arnd Bergmann > > Use pci_scan_root_bus() instead of deprecated function > pci_scan_bus_parented(). > > Signed-off-by: Arnd Bergmann > Signed-off-by: Yijing Wang > CC: Konrad Rzeszutek Wilk > CC: xen-de...@lists.xenproject.o

Re: [Xen-devel] [PATCH v4 1/5] Qemu-Xen-vTPM: Support for Xen stubdom vTPM command line options

2015-03-11 Thread Eric Blake
On 03/10/2015 06:14 AM, Quan Xu wrote: > --Changes in v4: > -qapi schema enhancement. > -remove no need code. Patch history belongs... > > Signed-off-by: Quan Xu > --- ...here. It is useful to reviewers to know what changed since your last submission, but not useful for the actual git histo

Re: [Xen-devel] [PATCH v7 21/21] xl: vNUMA support

2015-03-11 Thread Wei Liu
On Wed, Mar 11, 2015 at 03:12:06PM +, Ian Campbell wrote: > On Mon, 2015-03-09 at 12:51 +, Wei Liu wrote: > > > +Each B is a quoted key=value pair. Supported > > +Bs are: > > Which of these are optional and which are mandatory? All mandatory? > Yes, all mandatory for now. > > +if (

Re: [Xen-devel] Failed to launch xen on J6 evm

2015-03-11 Thread M A Young
On Wed, 11 Mar 2015, Korupol, Naveen (EXT) wrote: > Hi Ian/Team > > It finally looks like xen and dom0 are stable, but the cli seems tricky. > > I can switch between xen/dom0 but cannot execute xm cmds... xm was dropped in xen 4.5. Use xl instead. Michael Young ___

Re: [Xen-devel] [PATCH] SeaBios/vTPM: Enable Xen stubdom vTPM for HVM virtual machine

2015-03-11 Thread Kevin O'Connor
On Tue, Mar 10, 2015 at 08:16:03AM -0400, Quan Xu wrote: > This patch series are only the SeaBios part to enable stubdom vTPM for HVM > virtual machine. It will work with Qemu patch series and Xen patch series. > > > *INTRODUCTION* > > The goal

Re: [Xen-devel] [PATCH 2/2] CA-162192: Fix rebooting on some EFI-booted systems

2015-03-11 Thread Konrad Rzeszutek Wilk
On Wed, Mar 11, 2015 at 03:19:28PM +, Jan Beulich wrote: > >>> On 11.03.15 at 15:36, wrote: > > @@ -504,10 +511,9 @@ void machine_restart(unsigned int delay_millisecs) > > tboot_shutdown(TB_SHUTDOWN_REBOOT); > > } > > > > -efi_reset_system(reboot_mode != 0); > > - > >

Re: [Xen-devel] RFC: [PATCH 1/3] Enhance platform support for PCI

2015-03-11 Thread Stefano Stabellini
On Mon, 23 Feb 2015, Jan Beulich wrote: > >>> On 20.02.15 at 18:33, wrote: > > On Fri, 2015-02-20 at 15:15 +, Jan Beulich wrote: > >> > That's the issue we are trying to resolve, with device tree there is no > >> > explicit segment ID, so we have an essentially unindexed set of PCI > >> > buse

Re: [Xen-devel] [Patch 2/2]xen/sched_credit2.c : Runqueue per core

2015-03-11 Thread Uma Sharma
Hi, I have been working on the patches and made them. But when I am trying to install xen again to test them changes are not getting included. What should I do ? I was on the working branch then did make debball and installed using dpkg. I even wrote printk statements to check but not getting inc

[Xen-devel] [PATCH v2] xentop: add support for qdisks

2015-03-11 Thread Charles Arnold
Now that Xen uses qdisks by default and qemu does not write out statistics to sysfs this patch queries the QMP for disk statistics. This patch depends on libyajl for parsing statistics returned from QMP. The runtime requires libyajl 2.0.3 or newer for required bug fixes in yajl_tree_parse(). No i

Re: [Xen-devel] Using kexec-crashdump with recent Xen and Linux HVM

2015-03-11 Thread Vitaly Kuznetsov
Stefan Bader writes: > After being asked about this I started to play around with Xen-4.4.1/4.5 > together with HVM Linux guest running 3.13/3.16/3.19. With mixed success. > Usually rather failing. > > From a bit of research most activity to enable things were back in 2011. There > was a bit of a

Re: [Xen-devel] [PATCHv1 net] xen-netback: notify immediately after pushing Tx response.

2015-03-11 Thread Wei Liu
On Wed, Mar 11, 2015 at 03:27:59PM +, David Vrabel wrote: > This fixes a performance regression introduced by > 7fbb9d8415d4a51cf542e87cf3a717a9f7e6aedc (xen-netback: release pending > index before pushing Tx responses) > > Moving the notify outside of the spin locks means it can be delayed a

[Xen-devel] Using kexec-crashdump with recent Xen and Linux HVM

2015-03-11 Thread Stefan Bader
After being asked about this I started to play around with Xen-4.4.1/4.5 together with HVM Linux guest running 3.13/3.16/3.19. With mixed success. Usually rather failing. From a bit of research most activity to enable things were back in 2011. There was a bit of a throwback around Linux 3.2[1] but

Re: [Xen-devel] [PATCH V6 00/13] xen: Clean-up of mem_event subsystem

2015-03-11 Thread Tamas K Lengyel
On Wed, Mar 11, 2015 at 5:49 PM, Ian Campbell wrote: > On Wed, 2015-02-18 at 01:11 +0100, Tamas K Lengyel wrote: > > I think the tools aspects here are now all Acked-by Wei and/or myself. > Do lets us know if we've missed anything. (and perhaps prod us if v7 > gains anything new which need our att

Re: [Xen-devel] [PATCHv1 net] xen-netback: notify immediately after pushing Tx response.

2015-03-11 Thread Zoltan Kiss
On 11/03/15 15:27, David Vrabel wrote: This fixes a performance regression introduced by 7fbb9d8415d4a51cf542e87cf3a717a9f7e6aedc (xen-netback: release pending index before pushing Tx responses) Moving the notify outside of the spin locks means it can be delayed a long time (if the dealloc thr

Re: [Xen-devel] [PATCH V13 1/7] xen/arm: p2m changes for mem_access support

2015-03-11 Thread Tamas K Lengyel
On Wed, Mar 11, 2015 at 5:07 PM, Stefano Stabellini wrote: > On Fri, 6 Mar 2015, Tamas K Lengyel wrote: >> Add necessary changes for page table construction routines to pass >> the default access information. We store the p2m_access_t info in a >> Radix tree as the PTE lacks enough software progra

Re: [Xen-devel] [PATCH 5/9] libxl: introduce libxl_cpupool_cpu{add, remove}_cpumap()

2015-03-11 Thread Ian Campbell
On Wed, 2015-03-11 at 16:50 +, Dario Faggioli wrote: > On Wed, 2015-03-11 at 16:42 +, Ian Campbell wrote: > > On Mon, 2015-03-09 at 10:39 +, Wei Liu wrote: > > > rc = xc_cpupool_addcpu(ctx->xch, poolid, cpu); > > > > if (rc) { > > > > -LIBXL__LOG_ERRNOVAL(ctx, LIBXL__L

Re: [Xen-devel] [PATCH] tools/firmware: fix OVMF clean and distclean

2015-03-11 Thread Ian Campbell
On Wed, 2015-03-11 at 16:48 +, Wei Liu wrote: > They should have used "-ovmf-dir" suffix instead of "-ovmf", as the > directory in question is ovmf-dir. > > Signed-off-by: Wei Liu > Cc: Anthony Perard > Cc: Ian Campbell > Cc: Ian Jackson Acked + applied, thanks. ___

Re: [Xen-devel] [PATCH 5/9] libxl: introduce libxl_cpupool_cpu{add, remove}_cpumap()

2015-03-11 Thread Dario Faggioli
On Wed, 2015-03-11 at 16:42 +, Ian Campbell wrote: > On Mon, 2015-03-09 at 10:39 +, Wei Liu wrote: > > rc = xc_cpupool_addcpu(ctx->xch, poolid, cpu); > > > if (rc) { > > > -LIBXL__LOG_ERRNOVAL(ctx, LIBXL__LOG_ERROR, rc, > > > -"Error moving cpu to cpupool"); >

Re: [Xen-devel] [PATCH V6 00/13] xen: Clean-up of mem_event subsystem

2015-03-11 Thread Ian Campbell
On Wed, 2015-02-18 at 01:11 +0100, Tamas K Lengyel wrote: I think the tools aspects here are now all Acked-by Wei and/or myself. Do lets us know if we've missed anything. (and perhaps prod us if v7 gains anything new which need our attention since we might have stopped paying attention). Ian. _

[Xen-devel] [PATCH] tools/firmware: fix OVMF clean and distclean

2015-03-11 Thread Wei Liu
They should have used "-ovmf-dir" suffix instead of "-ovmf", as the directory in question is ovmf-dir. Signed-off-by: Wei Liu Cc: Anthony Perard Cc: Ian Campbell Cc: Ian Jackson --- tools/firmware/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/firmware/

Re: [Xen-devel] [PATCH 1/2] tools: OVMF parallel build

2015-03-11 Thread Wei Liu
On Wed, Mar 11, 2015 at 04:41:32PM +, Ian Campbell wrote: > On Mon, 2015-03-02 at 14:18 +, Ian Campbell wrote: > > On Mon, 2015-03-02 at 10:52 +, Wei Liu wrote: > > > Though it doesn't work with make's "-j" option, the build system of OVMF > > > has an option to specify parallel threads

Re: [Xen-devel] [PATCH V6 01/13] xen/mem_event: Cleanup of mem_event structures

2015-03-11 Thread Ian Campbell
On Wed, 2015-02-18 at 01:11 +0100, Tamas K Lengyel wrote: > tools/tests/xen-access/xen-access.c | 43 + > tools/xenpaging/xenpaging.c | 49 ++- These bits: Acked-by: Ian Campbell (I only glanced at them, I assume they are mechanical in nature) __

Re: [Xen-devel] [PATCH 5/9] libxl: introduce libxl_cpupool_cpu{add, remove}_cpumap()

2015-03-11 Thread Ian Campbell
On Mon, 2015-03-09 at 10:39 +, Wei Liu wrote: > rc = xc_cpupool_addcpu(ctx->xch, poolid, cpu); > > if (rc) { > > -LIBXL__LOG_ERRNOVAL(ctx, LIBXL__LOG_ERROR, rc, > > -"Error moving cpu to cpupool"); > > +LOGE(ERROR, "Error moving cpu %d to cpupool", cpu); >

Re: [Xen-devel] [PATCH 1/2] tools: OVMF parallel build

2015-03-11 Thread Ian Campbell
On Mon, 2015-03-02 at 14:18 +, Ian Campbell wrote: > On Mon, 2015-03-02 at 10:52 +, Wei Liu wrote: > > Though it doesn't work with make's "-j" option, the build system of OVMF > > has an option to specify parallel threads used to run the build. > > > > Using 4 threads to build OVMF looks l

Re: [Xen-devel] [PATCH OSSTEST 09/12] ts-debian-hvm-install: stub out libvirt + ovmf / rombios

2015-03-11 Thread Ian Campbell
On Mon, 2015-02-09 at 11:10 +, Wei Liu wrote: > Libvirt's configuration converter doesn't know how to deal with BIOS > selection. The end result is it always use the default one (seabios). > Stub out ovmf and rombios to avoid false positive results. > > This restriction will be removed once li

Re: [Xen-devel] [PATCH OSSTEST 12/12] make-flight, mfi-common: create live migration test for libvirt

2015-03-11 Thread Ian Campbell
On Mon, 2015-02-09 at 11:10 +, Wei Liu wrote: > Signed-off-by: Wei Liu > Cc: Ian Campbell > Cc: Ian Jackson > --- > make-flight | 13 +++-- > mfi-common | 6 +- > 2 files changed, 16 insertions(+), 3 deletions(-) > > diff --git a/make-flight b/make-flight > index 23d51ea..80c

[Xen-devel] osstest going offline for a bit due to database server move

2015-03-11 Thread Ian Jackson
The db server for the production osstest instance needs to be physically moved. This is planned to take place on Friday. I have dropped a `stop' file in which will stop osstest taking on new work. The db server will be moved on Friday morning (and anything still running then will be killed). We

Re: [Xen-devel] [PATCH OSSTEST 11/12] make-flight, mfi-common: rename onetoolstack to pairtoolstack

2015-03-11 Thread Ian Campbell
On Mon, 2015-02-09 at 11:10 +, Wei Liu wrote: > The name "onetoolstack" in confusing. Currently it's in fact referring > to the toolstack used to test pair migration, so rename it to > "pairtoolstack". > > No functional changes introduced. > > Signed-off-by: Wei Liu Acked-by: Ian Campbell

Re: [Xen-devel] [PATCH OSSTEST 06/12] toolstack/libvirt: guest migrate, save and restore support

2015-03-11 Thread Ian Campbell
On Mon, 2015-02-09 at 11:10 +, Wei Liu wrote: > Signed-off-by: Wei Liu Acked-by: Ian Campbell ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH OSSTEST 10/12] make-flight: debian hvm tests with libvirt

2015-03-11 Thread Ian Campbell
On Mon, 2015-02-09 at 11:10 +, Wei Liu wrote: I know you've made ts-debian-hvm-install DTRT but this is going to result in a load of jobs which go through all the effort of regrooving the box and installing Xen etc, only to fail. It seems like a rather profligate use of our limited test bandw

Re: [Xen-devel] [PATCH OSSTEST 05/12] sg-run-job: remove save/restore dependency on local migration support

2015-03-11 Thread Ian Campbell
On Mon, 2015-02-09 at 11:09 +, Wei Liu wrote: > Since we've introduced different checks for save / restore and local > migration, it's possible to run save / restore tests without running > local migration tests. I don't know if it matters or if it was deliberate, but we used to alternate savi

Re: [Xen-devel] [PATCH v3 4/4] libxl: add support for vscsi

2015-03-11 Thread Ian Campbell
On Wed, 2015-03-11 at 17:02 +0100, Olaf Hering wrote: > On Wed, Mar 11, Ian Campbell wrote: > > > On Fri, 2015-03-06 at 10:45 +0100, Olaf Hering wrote: > > > +void libxl_device_vscsi_append_dev(libxl_ctx *ctx, libxl_device_vscsi > > > *hst, > > > + libxl_vscsi_de

Re: [Xen-devel] [PATCH OSSTEST 08/12] ts-libvirt-build: run libvirt test suite

2015-03-11 Thread Ian Campbell
On Mon, 2015-02-09 at 11:10 +, Wei Liu wrote: > We're interested in xlconfigtest. Since we're running test anyway run > the whole suite. This is run at build time? I take it doesn't (and will never) require an active system? > @@ -69,7 +61,10 @@ END > sub build() { > target_cmd_build($h

Re: [Xen-devel] [PATCH] flask/policy: fix static device labeling examples

2015-03-11 Thread Julien Grall
Hi Daniel, On 11/03/2015 14:59, Daniel De Graaf wrote: The definitions of static device labels must be placed at the end of the policy.conf before passing it to checkpolicy; the existing examples (which are commented out) are in the wrong location. Create a new file for device contexts which wi

Re: [Xen-devel] [PATCH OSSTEST 02/12] Introduce ts-saverestore-support-check

2015-03-11 Thread Ian Campbell
On Mon, 2015-02-09 at 11:09 +, Wei Liu wrote: > Signed-off-by: Wei Liu Acked-by: Ian Campbell ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH OSSTEST 07/12] ts-xen-build-prep: install ebtables

2015-03-11 Thread Ian Campbell
On Mon, 2015-02-09 at 11:10 +, Wei Liu wrote: > Libvirt's test suite needs it. > > Signed-off-by: Wei Liu Acked-by: Ian Campbell But I think it will also want it at runtime, no? The libvirt logs whinge about such things (it was suggested this meant ebtables was on the build host,but given

Re: [Xen-devel] [PATCH 8/9] xl: make error reporting of cpupool subcommands consistent

2015-03-11 Thread Dario Faggioli
On Wed, 2015-03-11 at 16:24 +, Wei Liu wrote: > On Wed, Mar 11, 2015 at 04:22:00PM +, Dario Faggioli wrote: > > On Wed, 2015-03-11 at 15:23 +, Wei Liu wrote: > > > I think b) is good. > > > > > Right. It was the only comment you made on this patch... does that means > > I can stick yo

Re: [Xen-devel] [PATCH OSSTEST 03/12] osstest migrate support check catch -> variables

2015-03-11 Thread Ian Campbell
On Mon, 2015-02-09 at 11:09 +, Wei Liu wrote: > From: Ian Jackson I remember the f2f discussion around this, but I cannot remember what this is actually supposed to do. Can you? If so could you write it down please ;-) > > Signed-off-by: Ian Jackson > --- > sg-run-job | 4 +++- > 1 file c

Re: [Xen-devel] [PATCH 8/9] xl: make error reporting of cpupool subcommands consistent

2015-03-11 Thread Wei Liu
On Wed, Mar 11, 2015 at 04:22:00PM +, Dario Faggioli wrote: > On Wed, 2015-03-11 at 15:23 +, Wei Liu wrote: > > On Wed, Mar 11, 2015 at 03:13:33PM +, Dario Faggioli wrote: > > > On Wed, 2015-03-11 at 15:04 +, Wei Liu wrote: > > > > > Since we haven't explicitly defined any return v

Re: [Xen-devel] [PATCH 8/9] xl: make error reporting of cpupool subcommands consistent

2015-03-11 Thread Dario Faggioli
On Wed, 2015-03-11 at 15:23 +, Wei Liu wrote: > On Wed, Mar 11, 2015 at 03:13:33PM +, Dario Faggioli wrote: > > On Wed, 2015-03-11 at 15:04 +, Wei Liu wrote: > > > Since we haven't explicitly defined any return value in xl manpage, I > > > think we should use EXIT_SUCCESS and EXIT_FAIL

Re: [Xen-devel] [OSSTest PATCH v2 1/2] ts-cpupools: new test script

2015-03-11 Thread Ian Campbell
On Wed, 2015-02-04 at 15:27 +, Dario Faggioli wrote: > + my $xlinfo= target_cmd_output_root($ho, "xl info"); > + $xlinfo =~ /nr_cpus\s*:\s([0-9]*)/; I thought Perl needed a modifier to work in multiline mode? > + $nr_cpus= $1; > + logm("Found $nr_cpus pCPUs"); > + die "Too few pCPUs to t

Re: [Xen-devel] [PATCH OSSTEST 04/12] toolstack: distinguish local and remote migration support

2015-03-11 Thread Ian Campbell
On Mon, 2015-02-09 at 11:09 +, Wei Liu wrote: > Libvirt supports migrating a guest to remote host but not local host. Jim, is that right? (Or alternatively, Wei: Do you have a reference for that?) > diff --git a/Osstest/Toolstack/libvirt.pm b/Osstest/Toolstack/libvirt.pm > index acb801c..a80

Re: [Xen-devel] PML (Page Modification Logging) design for Xen

2015-03-11 Thread George Dunlap
On Wed, Mar 11, 2015 at 11:11 AM, Andrew Cooper wrote: > On 11/03/15 10:59, George Dunlap wrote: >> On Tue, Feb 17, 2015 at 10:19 AM, Jan Beulich wrote: >> On 12.02.15 at 03:39, wrote: On 02/11/2015 07:52 PM, Andrew Cooper wrote: > On 11/02/15 08:28, Kai Huang wrote: >> Design >

Re: [Xen-devel] [PATCH V13 1/7] xen/arm: p2m changes for mem_access support

2015-03-11 Thread Stefano Stabellini
On Fri, 6 Mar 2015, Tamas K Lengyel wrote: > Add necessary changes for page table construction routines to pass > the default access information. We store the p2m_access_t info in a > Radix tree as the PTE lacks enough software programmable bits. > > Signed-off-by: Tamas K Lengyel > --- > v13: -

Re: [Xen-devel] [PATCH] xen: postpone updating domains' node affinity when removing a CPU from a cpupool

2015-03-11 Thread Dario Faggioli
On Wed, 2015-03-11 at 15:01 +, George Dunlap wrote: > On 03/09/2015 04:49 PM, Dario Faggioli wrote: > > 93be8285 ("update domU's node-affinity on the cpupool_unassign_cpu() > > path") does the right thing, but does it too early. In fact, it > > is necessary to call domain_update_node_affinity(

Re: [Xen-devel] [OSSTest PATCH v2 2/2] Testing cpupools: recipe for it and job definition

2015-03-11 Thread Ian Campbell
On Wed, 2015-02-04 at 15:28 +, Dario Faggioli wrote: > Signed-off-by: Dario Faggioli Acked-by: Ian Campbell ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH V13 2/7] xen/arm: Implement domain_get_maximum_gpfn

2015-03-11 Thread Stefano Stabellini
On Fri, 6 Mar 2015, Tamas K Lengyel wrote: > From: Julien Grall > > The function domain_get_maximum_gpfn is returning the maximum gpfn ever > mapped in the guest. We can use d->arch.p2m.max_mapped_gfn for this purpose. > > We use this in xenaccess as to avoid the user attempting to set page > pe

Re: [Xen-devel] [PATCHv1] xen/balloon: disable memory hotplug in PV guests

2015-03-11 Thread Boris Ostrovsky
On 03/11/2015 10:42 AM, David Vrabel wrote: On 10/03/15 13:35, Boris Ostrovsky wrote: On 03/10/2015 07:40 AM, David Vrabel wrote: On 09/03/15 14:10, David Vrabel wrote: Memory hotplug doesn't work with PV guests because: a) The p2m cannot be expanded to cover the new sections. Broken by

Re: [Xen-devel] [PATCH v3 4/4] libxl: add support for vscsi

2015-03-11 Thread Ian Campbell
On Fri, 2015-03-06 at 10:45 +0100, Olaf Hering wrote: > diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h > index 6bbc52d..1ad52e3 100644 > --- a/tools/libxl/libxl.h > +++ b/tools/libxl/libxl.h Needs a LIBXL_HAVE define too. > @@ -1224,6 +1224,35 @@ int libxl_device_channel_getinfo(libxl_ctx

[Xen-devel] [ovmf test] 36087: tolerable FAIL - PUSHED

2015-03-11 Thread xen . org
flight 36087 ovmf real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/36087/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-win7-amd64 7 windows-install fail pass in 35971 test-amd64-i386-libvirt 3 host-insta

[Xen-devel] [PATCHv1 net] xen-netback: notify immediately after pushing Tx response.

2015-03-11 Thread David Vrabel
This fixes a performance regression introduced by 7fbb9d8415d4a51cf542e87cf3a717a9f7e6aedc (xen-netback: release pending index before pushing Tx responses) Moving the notify outside of the spin locks means it can be delayed a long time (if the dealloc thread is descheduled or there is an interrupt

Re: [Xen-devel] [PATCH 8/9] xl: make error reporting of cpupool subcommands consistent

2015-03-11 Thread Wei Liu
On Wed, Mar 11, 2015 at 03:13:33PM +, Dario Faggioli wrote: > On Wed, 2015-03-11 at 15:04 +, Wei Liu wrote: > > On Wed, Mar 11, 2015 at 02:52:31PM +, Ian Campbell wrote: > > > > I think having more consistent exist codes from xl would be nice, but I > > > don't think the libxl error co

Re: [Xen-devel] [PATCH v3 3/4] docs: add pvscsi.txt

2015-03-11 Thread Ian Campbell
On Fri, 2015-03-06 at 16:11 +0100, Olaf Hering wrote: > On Fri, Mar 06, Wei Liu wrote: > > > On Fri, Mar 06, 2015 at 10:45:55AM +0100, Olaf Hering wrote: > > > +== TODO === > > > + > > > +How to do live migration? > > > + - pdev will likely be evaluated again on the target host if it came from > >

Re: [Xen-devel] [PATCH 2/2] CA-162192: Fix rebooting on some EFI-booted systems

2015-03-11 Thread Jan Beulich
>>> On 11.03.15 at 15:36, wrote: > @@ -504,10 +511,9 @@ void machine_restart(unsigned int delay_millisecs) > tboot_shutdown(TB_SHUTDOWN_REBOOT); > } > > -efi_reset_system(reboot_mode != 0); > - > /* Rebooting needs to touch the page at absolute address 0. */ > -*((unsi

Re: [Xen-devel] [PATCH v7 18/21] libxlu: record location when parsing values

2015-03-11 Thread Wei Liu
On Wed, Mar 11, 2015 at 03:12:49PM +, Ian Campbell wrote: > On Mon, 2015-03-09 at 12:51 +, Wei Liu wrote: > > Originally only setting has line number recorded. Since we're moving to > > more sophisticated API, record the location for individual value. It is > > useful for error reporting. >

Re: [Xen-devel] [PATCH v7 18/21] libxlu: record location when parsing values

2015-03-11 Thread Ian Campbell
On Mon, 2015-03-09 at 12:51 +, Wei Liu wrote: > Originally only setting has line number recorded. Since we're moving to > more sophisticated API, record the location for individual value. It is > useful for error reporting. > > Signed-off-by: Wei Liu > Cc: Ian Campbell > Cc: Ian Jackson I'

Re: [Xen-devel] [PATCH 8/9] xl: make error reporting of cpupool subcommands consistent

2015-03-11 Thread Dario Faggioli
On Wed, 2015-03-11 at 15:04 +, Wei Liu wrote: > On Wed, Mar 11, 2015 at 02:52:31PM +, Ian Campbell wrote: > > I think having more consistent exist codes from xl would be nice, but I > > don't think the libxl error codes are the ones to use, since they don't > > really map semantically onto

Re: [Xen-devel] [PATCH 2/2] xen-pciback: also support disabling of bus-mastering and memory-write-invalidate

2015-03-11 Thread Jan Beulich
>>> On 11.03.15 at 15:44, wrote: > On 11/03/15 14:42, Konrad Rzeszutek Wilk wrote: >> On Wed, Mar 11, 2015 at 01:52:00PM +, Jan Beulich wrote: >>> It's not clear to me why only the enabling operation got handled so >>> far. >> >> Reviewed-by: Konrad Rzeszutek Wilk > > With no reports that t

Re: [Xen-devel] [PATCH v7 21/21] xl: vNUMA support

2015-03-11 Thread Ian Campbell
On Mon, 2015-03-09 at 12:51 +, Wei Liu wrote: > +Each B is a quoted key=value pair. Supported > +Bs are: Which of these are optional and which are mandatory? All mandatory? > +if (!xlu_cfg_get_long (config, "maxmem", &l, 0)) > +max_memkb1 = l * 1024; I think you should arrange t

Re: [Xen-devel] [PATCH 8/9] xl: make error reporting of cpupool subcommands consistent

2015-03-11 Thread Ian Campbell
On Wed, 2015-03-11 at 15:04 +, Wei Liu wrote: > On Wed, Mar 11, 2015 at 02:52:31PM +, Ian Campbell wrote: > > On Mon, 2015-03-09 at 11:01 +, Wei Liu wrote: > > > On Fri, Mar 06, 2015 at 06:21:59PM +0100, Dario Faggioli wrote: > > > > with the rest of the file, where we return 1 on 0, ra

Re: [Xen-devel] [PATCH 0/9] Some (not only) cpupool related fixes and improvements

2015-03-11 Thread Dario Faggioli
On Wed, 2015-03-11 at 14:56 +, Ian Campbell wrote: > On Fri, 2015-03-06 at 18:20 +0100, Dario Faggioli wrote: > > --- > > Dario Faggioli (9): > > 1/9 docs: RTDS is a valid alternative as a scheduler for a cpupool > > 2/9 docs: fix `xl list' manpage entry > > Acked + applied these two. >

Re: [Xen-devel] [PATCH 0/9] Some (not only) cpupool related fixes and improvements

2015-03-11 Thread Ian Campbell
On Fri, 2015-03-06 at 18:20 +0100, Dario Faggioli wrote: > Hi everyone, > > The main goal of this series is making it possible to specify ranges of pCPUs > when manipulating (creating, adding/removing pCPUs) cpupools. Something like > this: > > xl cpupool-cpu-remove Pool-node0 6-10 > > while, r

Re: [Xen-devel] [PATCH 9/9] xl: use libxl_cpupoolinfo_list_free() in main_cpupoolnumasplit

2015-03-11 Thread Ian Campbell
On Fri, 2015-03-06 at 18:22 +0100, Dario Faggioli wrote: > instead manually free the elements of the list, which is ^of freeing > exactly the purpose of the said function. > > Trade also a couple of 'return'-s with 'goto out'-s, which > is more in line with libxl usage paradigm. >

Re: [Xen-devel] [PATCH v7 02/21] libxc: duplicate snippet to allocate p2m_host array

2015-03-11 Thread Ian Campbell
On Mon, 2015-03-09 at 12:51 +, Wei Liu wrote: > Currently all in tree code doesn't set the superpage flag, I would just > remove superpage support if I can, but Konrad wants it retained for the > moment. > > As I'm going to change the p2m_host array allocation, duplicate the code > snippet to

[Xen-devel] [PATCH] flask/policy: fix static device labeling examples

2015-03-11 Thread Daniel De Graaf
The definitions of static device labels must be placed at the end of the policy.conf before passing it to checkpolicy; the existing examples (which are commented out) are in the wrong location. Create a new file for device contexts which will place them in the proper location. This also removes s

Re: [Xen-devel] [PATCH] xen: postpone updating domains' node affinity when removing a CPU from a cpupool

2015-03-11 Thread George Dunlap
On 03/09/2015 04:49 PM, Dario Faggioli wrote: > 93be8285 ("update domU's node-affinity on the cpupool_unassign_cpu() > path") does the right thing, but does it too early. In fact, it > is necessary to call domain_update_node_affinity() when a pCPU is > removed from a cpupool, but that must happen

Re: [Xen-devel] [PATCH 2/2] xen: arm: more flexible scheme for specifying early printk device

2015-03-11 Thread Ian Campbell
On Wed, 2015-03-11 at 14:47 +, Julien Grall wrote: > Hi Ian, > > On 11/03/2015 14:11, Ian Campbell wrote: > > This allows for early-printk to be specified (for existing UARTS at > > least) without the need to edit Rules.mk. > > > > The existing shortcuts are retained, but in a much more compac

[Xen-devel] [PATCHv7 1/2] xen: unify foreign GFN map/unmap for auto-xlated physmap guests

2015-03-11 Thread David Vrabel
Auto-translated physmap guests (arm, arm64 and x86 PVHVM/PVH) map and unmap foreign GFNs using the same method (updating the physmap). Unify the two arm and x86 implementations into one commont one. Note that on arm and arm64, the correct error code will be returned (instead of always -EFAULT) and

[Xen-devel] [PATCHv7 0/2] xen: improve migration performance

2015-03-11 Thread David Vrabel
This series signficantly improves the performance of migration by speeding up privcmd's MMAPBATCH_V2 ioctl (for PV toolstack domains). Changes in v7: - Drop (broken) arm __get_user() patch and use get_user() instead as a workaround. - Fix MMAPBATCH_V1 error reporting. Changes in v6: - unify PVH

Re: [Xen-devel] [PATCH 8/9] xl: make error reporting of cpupool subcommands consistent

2015-03-11 Thread Ian Campbell
On Mon, 2015-03-09 at 11:01 +, Wei Liu wrote: > On Fri, Mar 06, 2015 at 06:21:59PM +0100, Dario Faggioli wrote: > > with the rest of the file, where we return 1 on 0, rather > > than using libxl error codes. > > > > While being consistent is good I'm not very sure if we should go for 0/1 > ra

[Xen-devel] [PATCHv7 2/2] xen/privcmd: improve performance of MMAPBATCH_V2

2015-03-11 Thread David Vrabel
Make the IOCTL_PRIVCMD_MMAPBATCH_V2 (and older V1 version) map multiple frames at a time rather than one at a time, despite the pages being non-consecutive GFNs. xen_remap_foreign_mfn_array() is added which maps an array of GFNs (instead of a consecutive range of GFNs). Since per-frame errors are

Re: [Xen-devel] [PATCH 2/2] xen-pciback: also support disabling of bus-mastering and memory-write-invalidate

2015-03-11 Thread David Vrabel
On 11/03/15 14:42, Konrad Rzeszutek Wilk wrote: > On Wed, Mar 11, 2015 at 01:52:00PM +, Jan Beulich wrote: >> It's not clear to me why only the enabling operation got handled so >> far. > > Reviewed-by: Konrad Rzeszutek Wilk With no reports that this actually fixes anything, do we want this

Re: [Xen-devel] [PATCH 2/2] xen-pciback: also support disabling of bus-mastering and memory-write-invalidate

2015-03-11 Thread Konrad Rzeszutek Wilk
On Wed, Mar 11, 2015 at 02:44:18PM +, David Vrabel wrote: > On 11/03/15 14:42, Konrad Rzeszutek Wilk wrote: > > On Wed, Mar 11, 2015 at 01:52:00PM +, Jan Beulich wrote: > >> It's not clear to me why only the enabling operation got handled so > >> far. > > > > Reviewed-by: Konrad Rzeszutek

Re: [Xen-devel] [PATCH 2/2] xen-pciback: also support disabling of bus-mastering and memory-write-invalidate

2015-03-11 Thread Konrad Rzeszutek Wilk
On Wed, Mar 11, 2015 at 01:52:00PM +, Jan Beulich wrote: > It's not clear to me why only the enabling operation got handled so > far. Reviewed-by: Konrad Rzeszutek Wilk > > Signed-off-by: Jan Beulich > --- > drivers/xen/xen-pciback/conf_space_header.c | 16 +++- > 1 file chan

Re: [Xen-devel] [PATCHv1] xen/balloon: disable memory hotplug in PV guests

2015-03-11 Thread David Vrabel
On 10/03/15 13:35, Boris Ostrovsky wrote: > On 03/10/2015 07:40 AM, David Vrabel wrote: >> On 09/03/15 14:10, David Vrabel wrote: >>> Memory hotplug doesn't work with PV guests because: >>> >>>a) The p2m cannot be expanded to cover the new sections. >> Broken by 054954eb051f35e74b75a566a96fe756

Re: [Xen-devel] [PATCH 1/2] xen: arm: sort earlyprintk related lists

2015-03-11 Thread Julien Grall
Hi Ian, On 11/03/2015 14:11, Ian Campbell wrote: Also add a bunch of missing entries to the doc Signed-off-by: Ian Campbell I was wondering if we should also order between ARM64 and ARM32. But I guess it doesn't bring much benefit. So: Reviewed-by: Julien Grall Regards, -- Julien Grall

Re: [Xen-devel] [PATCH 2/2] xen: arm: more flexible scheme for specifying early printk device

2015-03-11 Thread Ian Campbell
On Wed, 2015-03-11 at 14:19 +, Andrew Cooper wrote: > On 11/03/15 14:11, Ian Campbell wrote: > > + > > +COMMA := , > > COMMA is available from the root Config.mk as 'comma' I had missed the -i off my grep, thanks! Ian. ___ Xen-devel mailing list

Re: [Xen-devel] [xen-unstable test] 36062: trouble: broken/fail/pass

2015-03-11 Thread Ian Campbell
On Wed, 2015-03-11 at 09:30 +, Ian Campbell wrote: > > Tests which did not succeed and are blocking, > > including tests which could not be run: > > test-amd64-i386-qemut-rhel6hvm-intel 3 host-install(3) broken REGR. vs. > > 35887 > > field-cricket never collected its preseed file. serial l

[Xen-devel] vTPM implementation

2015-03-11 Thread Marcos Simó Picó
Hello all, I am looking for information about the vTPM implementation on Xen. I have checked the wiki and its references and all the official documentation and even asked in the Q & A forum. However, I could not find what I am looking for. In the forum they recommended me to ask it here. I’d l

Re: [Xen-devel] [PATCH 1/2] xen-pciback: limit guest control of command register

2015-03-11 Thread David Vrabel
On 11/03/15 13:51, Jan Beulich wrote: > Otherwise the guest can abuse that control to cause e.g. PCIe > Unsupported Request responses (by disabling memory and/or I/O decoding > and subsequently causing [CPU side] accesses to the respective address > ranges), which (depending on system configuration

Re: [Xen-devel] [PATCH 2/2] xen: arm: more flexible scheme for specifying early printk device

2015-03-11 Thread Andrew Cooper
On 11/03/15 14:11, Ian Campbell wrote: > + > +COMMA := , COMMA is available from the root Config.mk as 'comma' ~Andrew ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [libvirt test] 36071: tolerable all pass - PUSHED

2015-03-11 Thread Jim Fehlig
Ian Campbell wrote: > On Tue, 2015-03-10 at 17:59 +, xen.org wrote: > >> flight 36071 libvirt real [real] >> http://www.chiark.greenend.org.uk/~xensrcts/logs/36071/ >> >> Failures :-/ but no regressions. >> >> Tests which did not succeed, but are not blocking: >> test-armhf-armhf-libvirt

Re: [Xen-devel] [PATCH 2/2] xen: arm: more flexible scheme for specifying early printk device

2015-03-11 Thread Ian Campbell
On Wed, 2015-03-11 at 14:11 +, Ian Campbell wrote: Sorry, I was too lazy to write a cover letter for these changes and forgot that would mean that git send-email wouldn't thread them. > This allows for early-printk to be specified (for existing UARTS at > least) without the need to edit Rules

[Xen-devel] [PATCH 2/2] xen: arm: more flexible scheme for specifying early printk device

2015-03-11 Thread Ian Campbell
This allows for early-printk to be specified (for existing UARTS at least) without the need to edit Rules.mk. The existing shortcuts are retained, but in a much more compact fashion. An unused EARLY_PRINTK_BAUD was removed from the zynqmq settings. Signed-off-by: Ian Campbell --- docs/misc/arm

Re: [Xen-devel] [PATCH v3 20/24] xen/passthrough: Extend XEN_DOMCTL_assign_device to support DT device

2015-03-11 Thread Ian Campbell
On Wed, 2015-03-11 at 13:50 +, Julien Grall wrote: > Hi Ian, > > On 11/03/2015 12:37, Ian Campbell wrote: > > On Tue, 2015-03-10 at 16:33 +, Julien Grall wrote: > >> Hi Ian, > >> > >> On 20/02/15 17:17, Ian Campbell wrote: > +/* TODO: Do we need to check is_dying? Mostly to protec

[Xen-devel] [PATCH 2/2] xen-pciback: also support disabling of bus-mastering and memory-write-invalidate

2015-03-11 Thread Jan Beulich
It's not clear to me why only the enabling operation got handled so far. Signed-off-by: Jan Beulich --- drivers/xen/xen-pciback/conf_space_header.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) --- 4.0-rc3-xen-pciback.orig/drivers/xen/xen-pciback/conf_space_header.c +

[Xen-devel] [PATCH 1/2] xen-pciback: limit guest control of command register

2015-03-11 Thread Jan Beulich
Otherwise the guest can abuse that control to cause e.g. PCIe Unsupported Request responses (by disabling memory and/or I/O decoding and subsequently causing [CPU side] accesses to the respective address ranges), which (depending on system configuration) may be fatal to the host. Note that to alte

Re: [Xen-devel] [PATCH v3 20/24] xen/passthrough: Extend XEN_DOMCTL_assign_device to support DT device

2015-03-11 Thread Julien Grall
Hi Ian, On 11/03/2015 12:37, Ian Campbell wrote: On Tue, 2015-03-10 at 16:33 +, Julien Grall wrote: Hi Ian, On 20/02/15 17:17, Ian Campbell wrote: +/* TODO: Do we need to check is_dying? Mostly to protect against + * hypercall trying to passthrough a device while we are + * dy

Re: [Xen-devel] [PATCH] x86/domctl: Improve XEN_DOMCTL_hypercall_init error handling

2015-03-11 Thread Jan Beulich
>>> On 11.03.15 at 13:56, wrote: > EACCES cannot be distinguished against an incorrect DOMCTL_INTERFACE_VERSION, > and will cause an incorrect "need to rebuild the user-space tool set?" > message > from libxc. EINVAL is a perfectly reasonable alternative. I'm okay with this for the !page case,

Re: [Xen-devel] [Xen-users] Grant reference batch transmission

2015-03-11 Thread Gareth Stockwell
On Wed, Mar 11, 2015 at 10:54:25, Ian Campbell wrote: > > > What sorts of batch sizes are you expecting to see in your use case? > > > > We need to share hundreds of MB, so (assuming a 4kB guest page size) > > the batch size can be thousands of grant references. > > FWIW, the granularity of a gref

  1   2   >